| Conditions | 17 |
| Paths | 256 |
| Total Lines | 155 |
| Code Lines | 85 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 7 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 51 | protected function getFields(array &$taskInfo, $task, $parentObject) |
||
| 52 | { |
||
| 53 | $additionalFields = []; |
||
| 54 | |||
| 55 | |||
| 56 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 57 | if (empty($taskInfo[$this->fieldSenderFrom]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 58 | $taskInfo[$this->fieldSenderFrom] = $task->{$this->fieldSenderFrom} ?? ''; |
||
| 59 | } |
||
| 60 | |||
| 61 | $taskInfo[$this->fieldSenderFrom] = htmlspecialchars($taskInfo[$this->fieldSenderFrom] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 62 | |||
| 63 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 64 | $fieldCode = sprintf($fieldStr, $this->fieldSenderFrom, $taskInfo[$this->fieldSenderFrom]); |
||
| 65 | |||
| 66 | $additionalFields[$this->fieldSenderFrom] = [ |
||
| 67 | 'code' => $fieldCode, |
||
| 68 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.from-name', |
||
| 69 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 70 | 'cshLabel' => $this->fieldSenderFrom |
||
| 71 | ]; |
||
| 72 | |||
| 73 | |||
| 74 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 75 | if (empty($taskInfo[$this->fieldSenderEmail]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 76 | $taskInfo[$this->fieldSenderEmail] = $task->{$this->fieldSenderEmail} ?? ''; |
||
| 77 | } |
||
| 78 | |||
| 79 | $taskInfo[$this->fieldSenderEmail] = htmlspecialchars($taskInfo[$this->fieldSenderEmail] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 80 | |||
| 81 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 82 | $fieldCode = sprintf($fieldStr, $this->fieldSenderEmail, $taskInfo[$this->fieldSenderEmail]); |
||
| 83 | |||
| 84 | $additionalFields[$this->fieldSenderEmail] = [ |
||
| 85 | 'code' => $fieldCode, |
||
| 86 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.from-email', |
||
| 87 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 88 | 'cshLabel' => $this->fieldSenderEmail |
||
| 89 | ]; |
||
| 90 | |||
| 91 | |||
| 92 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 93 | if (empty($taskInfo[$this->fieldReplyEmail]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 94 | $taskInfo[$this->fieldReplyEmail] = $task->{$this->fieldReplyEmail} ?? ''; |
||
| 95 | } |
||
| 96 | |||
| 97 | $taskInfo[$this->fieldReplyEmail] = htmlspecialchars($taskInfo[$this->fieldReplyEmail] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 98 | |||
| 99 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 100 | $fieldCode = sprintf($fieldStr, $this->fieldReplyEmail, $taskInfo[$this->fieldReplyEmail]); |
||
| 101 | |||
| 102 | $additionalFields[$this->fieldReplyEmail] = [ |
||
| 103 | 'code' => $fieldCode, |
||
| 104 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.reply-email', |
||
| 105 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 106 | 'cshLabel' => $this->fieldReplyEmail |
||
| 107 | ]; |
||
| 108 | |||
| 109 | |||
| 110 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 111 | if (empty($taskInfo[$this->fieldPageCatalog]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 112 | $taskInfo[$this->fieldPageCatalog] = $task->{$this->fieldPageCatalog} ?? ''; |
||
| 113 | } |
||
| 114 | |||
| 115 | $taskInfo[$this->fieldPageCatalog] = htmlspecialchars($taskInfo[$this->fieldPageCatalog] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 116 | |||
| 117 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 118 | $fieldCode = sprintf($fieldStr, $this->fieldPageCatalog, $taskInfo[$this->fieldPageCatalog]); |
||
| 119 | |||
| 120 | $additionalFields[$this->fieldPageCatalog] = [ |
||
| 121 | 'code' => $fieldCode, |
||
| 122 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.page-catalog', |
||
| 123 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 124 | 'cshLabel' => $this->fieldPageCatalog |
||
| 125 | ]; |
||
| 126 | |||
| 127 | |||
| 128 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 129 | if (empty($taskInfo[$this->fieldPageDetail]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 130 | $taskInfo[$this->fieldPageDetail] = $task->{$this->fieldPageDetail} ?? ''; |
||
| 131 | } |
||
| 132 | |||
| 133 | $taskInfo[$this->fieldPageDetail] = htmlspecialchars($taskInfo[$this->fieldPageDetail] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 134 | |||
| 135 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 136 | $fieldCode = sprintf($fieldStr, $this->fieldPageDetail, $taskInfo[$this->fieldPageDetail]); |
||
| 137 | |||
| 138 | $additionalFields[$this->fieldPageDetail] = [ |
||
| 139 | 'code' => $fieldCode, |
||
| 140 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.page-detail', |
||
| 141 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 142 | 'cshLabel' => $this->fieldPageDetail |
||
| 143 | ]; |
||
| 144 | |||
| 145 | |||
| 146 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 147 | if (empty($taskInfo[$this->fieldPageDownload]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 148 | $taskInfo[$this->fieldPageDownload] = $task->{$this->fieldPageDownload} ?? ''; |
||
| 149 | } |
||
| 150 | |||
| 151 | $taskInfo[$this->fieldPageDownload] = htmlspecialchars($taskInfo[$this->fieldPageDownload] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 152 | |||
| 153 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 154 | $fieldCode = sprintf($fieldStr, $this->fieldPageDownload, $taskInfo[$this->fieldPageDownload]); |
||
| 155 | |||
| 156 | $additionalFields[$this->fieldPageDownload] = [ |
||
| 157 | 'code' => $fieldCode, |
||
| 158 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.page-download', |
||
| 159 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 160 | 'cshLabel' => $this->fieldPageDownload |
||
| 161 | ]; |
||
| 162 | |||
| 163 | |||
| 164 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 165 | if (empty($taskInfo[$this->fieldPageLogin]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 166 | $taskInfo[$this->fieldPageLogin] = $task->{$this->fieldPageLogin} ?? ''; |
||
| 167 | } |
||
| 168 | |||
| 169 | $taskInfo[$this->fieldPageLogin] = htmlspecialchars($taskInfo[$this->fieldPageLogin] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 170 | |||
| 171 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 172 | $fieldCode = sprintf($fieldStr, $this->fieldPageLogin, $taskInfo[$this->fieldPageLogin]); |
||
| 173 | |||
| 174 | $additionalFields[$this->fieldPageLogin] = [ |
||
| 175 | 'code' => $fieldCode, |
||
| 176 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.page-login', |
||
| 177 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 178 | 'cshLabel' => $this->fieldPageLogin |
||
| 179 | ]; |
||
| 180 | |||
| 181 | |||
| 182 | // In case of editing a task, set to the internal value if data wasn't already submitted |
||
| 183 | if (empty($taskInfo[$this->fieldTemplateBaseurl]) && $parentObject->getCurrentAction()->equals(Action::EDIT)) { |
||
| 184 | $taskInfo[$this->fieldTemplateBaseurl] = $task->{$this->fieldTemplateBaseurl} ?? ''; |
||
| 185 | } |
||
| 186 | |||
| 187 | $taskInfo[$this->fieldTemplateBaseurl] = htmlspecialchars($taskInfo[$this->fieldTemplateBaseurl] ?? '', ENT_QUOTES, 'UTF-8'); |
||
| 188 | |||
| 189 | $path = 'typo3conf/ext/aimeos/Resources/Public/Themes/default'; |
||
| 190 | $path = $taskInfo[$this->fieldTemplateBaseurl] = $taskInfo[$this->fieldTemplateBaseurl] ?? $path; |
||
| 191 | |||
| 192 | $fieldStr = '<input class="form-control" name="tx_scheduler[%1$s]" id="%1$s" value="%2$s">'; |
||
| 193 | $fieldCode = sprintf($fieldStr, $this->fieldTemplateBaseurl, $path); |
||
| 194 | |||
| 195 | $additionalFields[$this->fieldTemplateBaseurl] = [ |
||
| 196 | 'code' => $fieldCode, |
||
| 197 | 'label' => 'LLL:EXT:aimeos/Resources/Private/Language/scheduler.xlf:email.label.template-baseurl', |
||
| 198 | 'cshKey' => 'xMOD_tx_aimeos', |
||
| 199 | 'cshLabel' => $this->fieldTemplateBaseurl |
||
| 200 | ]; |
||
| 201 | |||
| 202 | |||
| 203 | $additionalFields += parent::getFields($taskInfo, $task, $parentObject); |
||
| 204 | |||
| 205 | return $additionalFields; |
||
| 206 | } |
||
| 272 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths