Inspection of "Use redirect() which is compatible to Symfony 2.4" - aimeos/aimeos-symfony - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a2c835...1acc32 )

by Aimeos

created 2016-01-24 17:56 UTC

Status

Doc Comments +1 added lines, -7 removed lines patch added patch discarded remove patch

@@ -28,7 +28,6 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Symfony\Component\HttpFoundation\Request $request Request object
 	 * @param string Resource location, e.g. "product/stock/wareshouse"
-	 * @param string $sitecode Unique site code
 	 * @param integer|null $id Unique resource ID
 	 * @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
 	 */
@@ -49,7 +48,6 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Symfony\Component\HttpFoundation\Request $request Request object
 	 * @param string Resource location, e.g. "product/stock/wareshouse"
-	 * @param string $sitecode Unique site code
 	 * @param integer|null $id Unique resource ID
 	 * @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
 	 */
@@ -70,7 +68,6 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Symfony\Component\HttpFoundation\Request $request Request object
 	 * @param string Resource location, e.g. "product/stock/wareshouse"
-	 * @param string $sitecode Unique site code
 	 * @param integer|null $id Unique resource ID
 	 * @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
 	 */
@@ -91,7 +88,6 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Symfony\Component\HttpFoundation\Request $request Request object
 	 * @param string Resource location, e.g. "product/stock/wareshouse"
-	 * @param string $sitecode Unique site code
 	 * @param integer $id Unique ID of the resource
 	 * @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
 	 */
@@ -112,7 +108,6 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Symfony\Component\HttpFoundation\Request $request Request object
 	 * @param string Resource location, e.g. "product/stock/wareshouse"
-	 * @param string $sitecode Unique site code
 	 * @param integer|null $id Unique resource ID
 	 * @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
 	 */
@@ -133,7 +128,6 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Symfony\Component\HttpFoundation\Request $request Request object
 	 * @param string Resource location, e.g. "product/stock/wareshouse"
-	 * @param string $sitecode Unique site code
 	 * @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
 	 */
 	public function optionsAction( Request $request, $resource = '', $site = 'default' )
@@ -177,7 +171,7 @@  discard block
 block discarded – undo
 	 * @param string $content Body of the HTTP response
 	 * @param integer $status HTTP status
 	 * @param array $header List of HTTP headers
-	 * @return \Illuminate\Http\Response HTTP response object
+	 * @return Response HTTP response object
 	 */
 	protected function createResponse( $content, $status, array $header )
 	{

Please login to merge, or discard this patch.

DependencyInjection/Configuration.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,5 +45,5 @@
 block discarded – undo
 		;
 
 		return $treeBuilder;
-    }
+	}
 }

Please login to merge, or discard this patch.

Controller/ExtadmController.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -88,7 +88,7 @@  discard block
 block discarded – undo
 	/**
 	 * Single entry point for all JSON admin requests.
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @return \Symfony\Component\HttpFoundation\Response 2.0 RPC message response
 	 */
 	public function doAction( Request $request )
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
 	 * Creates a list of all available translations.
 	 *
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
-	 * @return array List of language IDs with labels
+	 * @return string List of language IDs with labels
 	 */
 	protected function getJsonLanguages( \Aimeos\MShop\Context\Item\Iface $context )
 	{

Please login to merge, or discard this patch.

Controller/JqadmController.php 1 patch

Doc Comments +16 added lines, -21 removed lines patch added patch discarded remove patch

@@ -26,11 +26,10 @@  discard block
 block discarded – undo
 	/**
 	 * Returns the HTML code for a copy of a resource object
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @param string $resource Resource location, e.g. "product"
 	 * @param integer $id Unique resource ID
-	 * @param string $sitecode Unique site code
-	 * @return string Generated output
+	 * @return Response Generated output
 	 */
 	public function copyAction( Request $request, $resource, $id, $site = 'default' )
 	{
@@ -42,10 +41,9 @@  discard block
 block discarded – undo
 	/**
 	 * Returns the HTML code for a new resource object
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @param string $resource Resource location, e.g. "product"
-	 * @param string $sitecode Unique site code
-	 * @return string Generated output
+	 * @return Response Generated output
 	 */
 	public function createAction( Request $request, $resource, $site = 'default' )
 	{
@@ -57,11 +55,10 @@  discard block
 block discarded – undo
 	/**
 	 * Deletes the resource object or a list of resource objects
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @param string $resource Resource location, e.g. "product"
 	 * @param integer $id Unique resource ID
-	 * @param string $sitecode Unique site code
-	 * @return string Generated output
+	 * @return Response Generated output
 	 */
 	public function deleteAction( Request $request, $resource, $id, $site = 'default' )
 	{
@@ -73,11 +70,10 @@  discard block
 block discarded – undo
 	/**
 	 * Returns the HTML code for the requested resource object
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @param string $resource Resource location, e.g. "product"
 	 * @param integer $id Unique resource ID
-	 * @param string $sitecode Unique site code
-	 * @return string Generated output
+	 * @return Response Generated output
 	 */
 	public function getAction( Request $request, $resource, $id, $site = 'default' )
 	{
@@ -89,10 +85,9 @@  discard block
 block discarded – undo
 	/**
 	 * Saves a new resource object
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @param string $resource Resource location, e.g. "product"
-	 * @param string $sitecode Unique site code
-	 * @return string Generated output
+	 * @return Response Generated output
 	 */
 	public function saveAction( Request $request, $resource, $site = 'default' )
 	{
@@ -104,10 +99,9 @@  discard block
 block discarded – undo
 	/**
 	 * Returns the HTML code for a list of resource objects
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @param string $resource Resource location, e.g. "product"
-	 * @param string $sitecode Unique site code
-	 * @return string Generated output
+	 * @return Response Generated output
 	 */
 	public function searchAction( Request $request, $resource, $site = 'default' )
 	{
@@ -119,10 +113,11 @@  discard block
 block discarded – undo
 	/**
 	 * Returns the resource controller
 	 *
-	 * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
+	 * @param Request $request Symfony request object
 	 * @param string $sitecode Unique site code
 	 * @param string Resource location, e.g. "product"
-	 * @return \Aimeos\MShop\Context\Item\Iface Context item
+	 * @param string $resource
+	 * @return \Aimeos\Admin\JQAdm\Iface Context item
 	 */
 	protected function createClient( Request $request, $sitecode, $resource )
 	{
@@ -146,7 +141,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param string $site Unique site code
 	 * @param string $content Content from admin client
-	 * @return \Illuminate\Contracts\View\View View for rendering the output
+	 * @return Response View for rendering the output
 	 */
 	protected function getHtml( $site, $content )
 	{

Please login to merge, or discard this patch.

		@@ -28,7 +28,6 @@ discard block
		block discarded – undo
28	28	*
29	29	* @param \Symfony\Component\HttpFoundation\Request $request Request object
30	30	* @param string Resource location, e.g. "product/stock/wareshouse"
31		- * @param string $sitecode Unique site code
32	31	* @param integer\|null $id Unique resource ID
33	32	* @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
34	33	*/
		@@ -49,7 +48,6 @@ discard block
		block discarded – undo
49	48	*
50	49	* @param \Symfony\Component\HttpFoundation\Request $request Request object
51	50	* @param string Resource location, e.g. "product/stock/wareshouse"
52		- * @param string $sitecode Unique site code
53	51	* @param integer\|null $id Unique resource ID
54	52	* @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
55	53	*/
		@@ -70,7 +68,6 @@ discard block
		block discarded – undo
70	68	*
71	69	* @param \Symfony\Component\HttpFoundation\Request $request Request object
72	70	* @param string Resource location, e.g. "product/stock/wareshouse"
73		- * @param string $sitecode Unique site code
74	71	* @param integer\|null $id Unique resource ID
75	72	* @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
76	73	*/
		@@ -91,7 +88,6 @@ discard block
		block discarded – undo
91	88	*
92	89	* @param \Symfony\Component\HttpFoundation\Request $request Request object
93	90	* @param string Resource location, e.g. "product/stock/wareshouse"
94		- * @param string $sitecode Unique site code
95	91	* @param integer $id Unique ID of the resource
96	92	* @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
97	93	*/
		@@ -112,7 +108,6 @@ discard block
		block discarded – undo
112	108	*
113	109	* @param \Symfony\Component\HttpFoundation\Request $request Request object
114	110	* @param string Resource location, e.g. "product/stock/wareshouse"
115		- * @param string $sitecode Unique site code
116	111	* @param integer\|null $id Unique resource ID
117	112	* @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
118	113	*/
		@@ -133,7 +128,6 @@ discard block
		block discarded – undo
133	128	*
134	129	* @param \Symfony\Component\HttpFoundation\Request $request Request object
135	130	* @param string Resource location, e.g. "product/stock/wareshouse"
136		- * @param string $sitecode Unique site code
137	131	* @return \Symfony\Component\HttpFoundation\Response Response object containing the generated output
138	132	*/
139	133	public function optionsAction( Request $request, $resource = '', $site = 'default' )
		@@ -177,7 +171,7 @@ discard block
		block discarded – undo
177	171	* @param string $content Body of the HTTP response
178	172	* @param integer $status HTTP status
179	173	* @param array $header List of HTTP headers
180		- * @return \Illuminate\Http\Response HTTP response object
	174	+ * @return Response HTTP response object
181	175	*/
182	176	protected function createResponse( $content, $status, array $header )
183	177	{

		@@ -45,5 +45,5 @@
		block discarded – undo
45	45	;
46	46
47	47	return $treeBuilder;
48		- }
	48	+ }
49	49	}

		@@ -88,7 +88,7 @@ discard block
		block discarded – undo
88	88	/**
89	89	* Single entry point for all JSON admin requests.
90	90	*
91		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	91	+ * @param Request $request Symfony request object
92	92	* @return \Symfony\Component\HttpFoundation\Response 2.0 RPC message response
93	93	*/
94	94	public function doAction( Request $request )
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	* Creates a list of all available translations.
150	150	*
151	151	* @param \Aimeos\MShop\Context\Item\Iface $context Context object
152		- * @return array List of language IDs with labels
	152	+ * @return string List of language IDs with labels
153	153	*/
154	154	protected function getJsonLanguages( \Aimeos\MShop\Context\Item\Iface $context )
155	155	{

		@@ -26,11 +26,10 @@ discard block
		block discarded – undo
26	26	/**
27	27	* Returns the HTML code for a copy of a resource object
28	28	*
29		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	29	+ * @param Request $request Symfony request object
30	30	* @param string $resource Resource location, e.g. "product"
31	31	* @param integer $id Unique resource ID
32		- * @param string $sitecode Unique site code
33		- * @return string Generated output
	32	+ * @return Response Generated output
34	33	*/
35	34	public function copyAction( Request $request, $resource, $id, $site = 'default' )
36	35	{
		@@ -42,10 +41,9 @@ discard block
		block discarded – undo
42	41	/**
43	42	* Returns the HTML code for a new resource object
44	43	*
45		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	44	+ * @param Request $request Symfony request object
46	45	* @param string $resource Resource location, e.g. "product"
47		- * @param string $sitecode Unique site code
48		- * @return string Generated output
	46	+ * @return Response Generated output
49	47	*/
50	48	public function createAction( Request $request, $resource, $site = 'default' )
51	49	{
		@@ -57,11 +55,10 @@ discard block
		block discarded – undo
57	55	/**
58	56	* Deletes the resource object or a list of resource objects
59	57	*
60		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	58	+ * @param Request $request Symfony request object
61	59	* @param string $resource Resource location, e.g. "product"
62	60	* @param integer $id Unique resource ID
63		- * @param string $sitecode Unique site code
64		- * @return string Generated output
	61	+ * @return Response Generated output
65	62	*/
66	63	public function deleteAction( Request $request, $resource, $id, $site = 'default' )
67	64	{
		@@ -73,11 +70,10 @@ discard block
		block discarded – undo
73	70	/**
74	71	* Returns the HTML code for the requested resource object
75	72	*
76		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	73	+ * @param Request $request Symfony request object
77	74	* @param string $resource Resource location, e.g. "product"
78	75	* @param integer $id Unique resource ID
79		- * @param string $sitecode Unique site code
80		- * @return string Generated output
	76	+ * @return Response Generated output
81	77	*/
82	78	public function getAction( Request $request, $resource, $id, $site = 'default' )
83	79	{
		@@ -89,10 +85,9 @@ discard block
		block discarded – undo
89	85	/**
90	86	* Saves a new resource object
91	87	*
92		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	88	+ * @param Request $request Symfony request object
93	89	* @param string $resource Resource location, e.g. "product"
94		- * @param string $sitecode Unique site code
95		- * @return string Generated output
	90	+ * @return Response Generated output
96	91	*/
97	92	public function saveAction( Request $request, $resource, $site = 'default' )
98	93	{
		@@ -104,10 +99,9 @@ discard block
		block discarded – undo
104	99	/**
105	100	* Returns the HTML code for a list of resource objects
106	101	*
107		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	102	+ * @param Request $request Symfony request object
108	103	* @param string $resource Resource location, e.g. "product"
109		- * @param string $sitecode Unique site code
110		- * @return string Generated output
	104	+ * @return Response Generated output
111	105	*/
112	106	public function searchAction( Request $request, $resource, $site = 'default' )
113	107	{
		@@ -119,10 +113,11 @@ discard block
		block discarded – undo
119	113	/**
120	114	* Returns the resource controller
121	115	*
122		- * @param Symfony\Component\HttpFoundation\Request $request Symfony request object
	116	+ * @param Request $request Symfony request object
123	117	* @param string $sitecode Unique site code
124	118	* @param string Resource location, e.g. "product"
125		- * @return \Aimeos\MShop\Context\Item\Iface Context item
	119	+ * @param string $resource
	120	+ * @return \Aimeos\Admin\JQAdm\Iface Context item
126	121	*/
127	122	protected function createClient( Request $request, $sitecode, $resource )
128	123	{
		@@ -146,7 +141,7 @@ discard block
		block discarded – undo
146	141	*
147	142	* @param string $site Unique site code
148	143	* @param string $content Content from admin client
149		- * @return \Illuminate\Contracts\View\View View for rendering the output
	144	+ * @return Response View for rendering the output
150	145	*/
151	146	protected function getHtml( $site, $content )
152	147	{

aimeos / aimeos-symfony

Push — master ( a2c835...1acc32 )

Status

Category

Doc Comments +1 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +16 added lines, -21 removed lines patch added patch discarded remove patch