Issues in CatalogController.php - New Issues - Inspection of "Use shorter service names" - aimeos/aimeos-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8d14cd...aab142 )

by Aimeos

created 2019-01-03 11:39 UTC

src/Aimeos/Shop/Controller/CatalogController.php (12 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @license MIT, http://opensource.org/licenses/MIT
 * @copyright Aimeos (aimeos.org), 2015-2016
 * @package laravel
 * @subpackage Controller
 */


namespace Aimeos\Shop\Controller;

use Aimeos\Shop\Facades\Shop;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Response;


/**
 * Aimeos controller for catalog related functionality.
 *
 * @package laravel
 * @subpackage Controller
 */
class CatalogController extends Controller
{
	/**
	 * Returns the view for the XHR response with the counts for the facetted search.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function countAction()
	{
		foreach( app( 'config' )->get( 'shop.page.catalog-count', ['catalog/count'] ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();
		}

		return Response::view('shop::catalog.count', $params)
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			->header('Content-Type', 'application/javascript');
	}


	/**
	 * Returns the html for the catalog detail page.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function detailAction()
	{
		$default = ['basket/mini','catalog/stage','catalog/detail','catalog/session'];

		foreach( app( 'config' )->get( 'shop.page.catalog-detail', $default ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();
		}

		return Response::view('shop::catalog.detail', $params);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
	}


	/**
	 * Returns the html for the catalog list page.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function listAction()
	{
		$default = ['basket/mini','catalog/filter','catalog/lists'];

		foreach( app( 'config' )->get( 'shop.page.catalog-list', $default ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();
		}

		return Response::view('shop::catalog.list', $params);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
	}


	/**
	 * Returns the html body part for the catalog stock page.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function stockAction()
	{
		foreach( app( 'config' )->get( 'shop.page.catalog-stock', ['catalog/stock'] ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();
		}

		return Response::view('shop::catalog.stock', $params)
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			->header('Content-Type', 'application/javascript');
	}


	/**
	 * Returns the view for the XHR response with the product information for the search suggestion.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function suggestAction()
	{
		foreach( app( 'config' )->get( 'shop.page.catalog-suggest', ['catalog/suggest'] ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();
		}

		return Response::view('shop::catalog.suggest', $params)
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			->header('Content-Type', 'application/json');
	}


	/**
	 * Returns the html for the catalog tree page.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function treeAction()
	{
		$default = ['basket/mini','catalog/filter','catalog/stage','catalog/lists'];

		foreach( app( 'config' )->get( 'shop.page.catalog-tree', $default ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();
		}

		return Response::view('shop::catalog.tree', $params);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
	}
}

1		<?php
2
3		/**
4		* @license MIT, http://opensource.org/licenses/MIT
5		* @copyright Aimeos (aimeos.org), 2015-2016
6		* @package laravel
7		* @subpackage Controller
8		*/
9
10
11		namespace Aimeos\Shop\Controller;
12
13		use Aimeos\Shop\Facades\Shop;
14		use Illuminate\Routing\Controller;
15		use Illuminate\Support\Facades\Response;
16
17
18		/**
19		* Aimeos controller for catalog related functionality.
20		*
21		* @package laravel
22		* @subpackage Controller
23		*/
24		class CatalogController extends Controller
25		{
26		/**
27		* Returns the view for the XHR response with the counts for the facetted search.
28		*
29		* @return \Illuminate\Http\Response Response object with output and headers
30		*/
31	View Code Duplication	public function countAction()
32		{
33		foreach( app( 'config' )->get( 'shop.page.catalog-count', ['catalog/count'] ) as $name )
34		{
35		$params['aiheader'][$name] = Shop::get( $name )->getHeader();
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
36		$params['aibody'][$name] = Shop::get( $name )->getBody();
37		}
38
39		return Response::view('shop::catalog.count', $params)
		0 ignored issues – show Bug introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
40		->header('Content-Type', 'application/javascript');
41		}
42
43
44		/**
45		* Returns the html for the catalog detail page.
46		*
47		* @return \Illuminate\Http\Response Response object with output and headers
48		*/
49	View Code Duplication	public function detailAction()
50		{
51		$default = ['basket/mini','catalog/stage','catalog/detail','catalog/session'];
52
53		foreach( app( 'config' )->get( 'shop.page.catalog-detail', $default ) as $name )
54		{
55		$params['aiheader'][$name] = Shop::get( $name )->getHeader();
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
56		$params['aibody'][$name] = Shop::get( $name )->getBody();
57		}
58
59		return Response::view('shop::catalog.detail', $params);
		0 ignored issues – show Bug introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
60		}
61
62
63		/**
64		* Returns the html for the catalog list page.
65		*
66		* @return \Illuminate\Http\Response Response object with output and headers
67		*/
68	View Code Duplication	public function listAction()
69		{
70		$default = ['basket/mini','catalog/filter','catalog/lists'];
71
72		foreach( app( 'config' )->get( 'shop.page.catalog-list', $default ) as $name )
73		{
74		$params['aiheader'][$name] = Shop::get( $name )->getHeader();
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
75		$params['aibody'][$name] = Shop::get( $name )->getBody();
76		}
77
78		return Response::view('shop::catalog.list', $params);
		0 ignored issues – show Bug introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
79		}
80
81
82		/**
83		* Returns the html body part for the catalog stock page.
84		*
85		* @return \Illuminate\Http\Response Response object with output and headers
86		*/
87	View Code Duplication	public function stockAction()
88		{
89		foreach( app( 'config' )->get( 'shop.page.catalog-stock', ['catalog/stock'] ) as $name )
90		{
91		$params['aiheader'][$name] = Shop::get( $name )->getHeader();
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
92		$params['aibody'][$name] = Shop::get( $name )->getBody();
93		}
94
95		return Response::view('shop::catalog.stock', $params)
		0 ignored issues – show Bug introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
96		->header('Content-Type', 'application/javascript');
97		}
98
99
100		/**
101		* Returns the view for the XHR response with the product information for the search suggestion.
102		*
103		* @return \Illuminate\Http\Response Response object with output and headers
104		*/
105	View Code Duplication	public function suggestAction()
106		{
107		foreach( app( 'config' )->get( 'shop.page.catalog-suggest', ['catalog/suggest'] ) as $name )
108		{
109		$params['aiheader'][$name] = Shop::get( $name )->getHeader();
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
110		$params['aibody'][$name] = Shop::get( $name )->getBody();
111		}
112
113		return Response::view('shop::catalog.suggest', $params)
		0 ignored issues – show Bug introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
114		->header('Content-Type', 'application/json');
115		}
116
117
118		/**
119		* Returns the html for the catalog tree page.
120		*
121		* @return \Illuminate\Http\Response Response object with output and headers
122		*/
123	View Code Duplication	public function treeAction()
124		{
125		$default = ['basket/mini','catalog/filter','catalog/stage','catalog/lists'];
126
127		foreach( app( 'config' )->get( 'shop.page.catalog-tree', $default ) as $name )
128		{
129		$params['aiheader'][$name] = Shop::get( $name )->getHeader();
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
130		$params['aibody'][$name] = Shop::get( $name )->getBody();
131		}
132
133		return Response::view('shop::catalog.tree', $params);
		0 ignored issues – show Bug introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
134		}
135		}

aimeos / aimeos-laravel

Push — master ( 8d14cd...aab142 )

src/Aimeos/Shop/Controller/CatalogController.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like