Issues in BasketController.php - New Issues - Inspection of "Use shorter service names" - aimeos/aimeos-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8d14cd...aab142 )

by Aimeos

created 2019-01-03 11:39 UTC

src/Aimeos/Shop/Controller/BasketController.php (1 issue)

Labels

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @license MIT, http://opensource.org/licenses/MIT
 * @copyright Aimeos (aimeos.org), 2015-2016
 * @package laravel
 * @subpackage Controller
 */


namespace Aimeos\Shop\Controller;

use Aimeos\Shop\Facades\Shop;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Response;


/**
 * Aimeos controller for basket related functionality.
 *
 * @package laravel
 * @subpackage Controller
 */
class BasketController extends Controller
{
	/**
	 * Returns the html for the standard basket page.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function indexAction()
	{
		$default = ['basket/standard','basket/related'];

		foreach( app( 'config' )->get( 'shop.page.basket-index', $default ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();
		}

		return Response::view('shop::basket.index', $params)->header('Cache-Control', 'no-store');
	}
}

1		<?php
2
3		/**
4		* @license MIT, http://opensource.org/licenses/MIT
5		* @copyright Aimeos (aimeos.org), 2015-2016
6		* @package laravel
7		* @subpackage Controller
8		*/
9
10
11		namespace Aimeos\Shop\Controller;
12
13		use Aimeos\Shop\Facades\Shop;
14		use Illuminate\Routing\Controller;
15		use Illuminate\Support\Facades\Response;
16
17
18		/**
19		* Aimeos controller for basket related functionality.
20		*
21		* @package laravel
22		* @subpackage Controller
23		*/
24		class BasketController extends Controller
25		{
26		/**
27		* Returns the html for the standard basket page.
28		*
29		* @return \Illuminate\Http\Response Response object with output and headers
30		*/
31	View Code Duplication	public function indexAction()
32		{
33		$default = ['basket/standard','basket/related'];
34
35		foreach( app( 'config' )->get( 'shop.page.basket-index', $default ) as $name )
36		{
37		$params['aiheader'][$name] = Shop::get( $name )->getHeader();
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
38		$params['aibody'][$name] = Shop::get( $name )->getBody();
39		}
40
41		return Response::view('shop::basket.index', $params)->header('Cache-Control', 'no-store');
42		}
43		}

aimeos / aimeos-laravel

Push — master ( 8d14cd...aab142 )

src/Aimeos/Shop/Controller/BasketController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like