Issues in AccountController.php - New Issues - Inspection of "Use shorter service names" - aimeos/aimeos-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8d14cd...aab142 )

by Aimeos

created 2019-01-03 11:39 UTC

src/Aimeos/Shop/Controller/AccountController.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @license MIT, http://opensource.org/licenses/MIT
 * @copyright Aimeos (aimeos.org), 2015-2016
 * @package laravel
 * @subpackage Controller
 */


namespace Aimeos\Shop\Controller;

use Aimeos\Shop\Facades\Shop;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Response;


/**
 * Aimeos controller for account related functionality.
 *
 * @package laravel
 * @subpackage Controller
 */
class AccountController extends Controller
{
	/**
	 * Returns the html for the "My account" page.
	 *
	 * @return \Illuminate\Http\Response Response object with output and headers
	 */
	public function indexAction()
	{
		$default = ['account/profile','account/subscription','account/history','account/favorite','account/watch','basket/mini','catalog/session'];

		foreach( app( 'config' )->get( 'shop.page.account-index', $default ) as $name )
		{
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$params['aibody'][$name] = Shop::get( $name )->getBody();

		}

		return Response::view('shop::account.index', $params);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
	}


	/**
	 * Returns the html for the "My account" download page.
	 *
	 * @return \Illuminate\Contracts\View\View View for rendering the output
	 */
	public function downloadAction()
	{
		$response = Shop::get( 'account/download' )->getView()->response();

		return Response::make( (string) $response->getBody(), $response->getStatusCode(), $response->getHeaders() );
	}
}

Push — master ( 8d14cd...aab142 )

src/Aimeos/Shop/Controller/AccountController.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3			/**
4			* @license MIT, http://opensource.org/licenses/MIT
5			* @copyright Aimeos (aimeos.org), 2015-2016
6			* @package laravel
7			* @subpackage Controller
8			*/
9
10
11			namespace Aimeos\Shop\Controller;
12
13			use Aimeos\Shop\Facades\Shop;
14			use Illuminate\Routing\Controller;
15			use Illuminate\Support\Facades\Response;
16
17
18			/**
19			* Aimeos controller for account related functionality.
20			*
21			* @package laravel
22			* @subpackage Controller
23			*/
24			class AccountController extends Controller
25			{
26			/**
27			* Returns the html for the "My account" page.
28			*
29			* @return \Illuminate\Http\Response Response object with output and headers
30			*/
31			public function indexAction()
32			{
33			$default = ['account/profile','account/subscription','account/history','account/favorite','account/watch','basket/mini','catalog/session'];
34
35			foreach( app( 'config' )->get( 'shop.page.account-index', $default ) as $name )
36			{
37			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
			0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history... Unused Code introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Shop::get()` has too many arguments starting with `$name`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
38			$params['aibody'][$name] = Shop::get( $name )->getBody();
			0 ignored issues – show Unused Code introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Shop::get()` has too many arguments starting with `$name`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
39			}
40
41			return Response::view('shop::account.index', $params);
			0 ignored issues – show Bug introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
42			}
43
44
45			/**
46			* Returns the html for the "My account" download page.
47			*
48			* @return \Illuminate\Contracts\View\View View for rendering the output
49			*/
50			public function downloadAction()
51			{
52			$response = Shop::get( 'account/download' )->getView()->response();
			0 ignored issues – show Unused Code introduced 2019-01-03 11:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Shop::get()` has too many arguments starting with `'account/download'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
53			return Response::make( (string) $response->getBody(), $response->getStatusCode(), $response->getHeaders() );
54			}
55			}

aimeos / aimeos-laravel

Push — master ( 8d14cd...aab142 )

src/Aimeos/Shop/Controller/AccountController.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like