Issues in AccountCommand.php - New Issues - Inspection of "Simplified code for creating administrator account..." - aimeos/aimeos-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cec86c...859d6d )

by Aimeos

created 2019-09-12 17:17 UTC

src/Aimeos/Shop/Command/AccountCommand.php (2 issues)

Labels

Bug 2

Severity

Major 2

<?php

/**
 * @license MIT, http://opensource.org/licenses/MIT
 * @copyright Aimeos (aimeos.org), 2015-2016
 * @package laravel
 * @subpackage Command
 */


namespace Aimeos\Shop\Command;

use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputArgument;


/**
 * Creates new accounts or resets their passwords
 * @package laravel
 * @subpackage Command
 */
class AccountCommand extends AbstractCommand
{
	/**
	 * The name and signature of the console command.
	 *
	 * @var string
	 */
	protected $signature = 'aimeos:account
		{email? : E-Mail adress of the (admin) user (will ask for if not given)}
		{site=default : Site to create account for}
		{--password= : Secret password for the account (will ask for if not given)}
		{--super : If account should have super user privileges for all sites}
		{--admin : If account should have site administrator privileges}
		{--editor : If account should have limited editor privileges}
		{--api : If account should be able to access the APIs}
	';

	/**
	 * The console command description.
	 *
	 * @var string
	 */
	protected $description = 'Creates new (admin) accounts';


	/**
	 * Execute the console command.
	 *
	 * @return mixed
	 */
	public function handle()
	{
		if( ( $email = $this->argument( 'email' ) ) === null ) {
			$email = $this->ask( 'E-Mail' );
		}

		if( ( $password = $this->option( 'password' ) ) === null ) {
			$password = $this->secret( 'Password' );
		}

		$context = $this->getLaravel()->make( 'Aimeos\Shop\Base\Context' )->get( false, 'command' );
		$context->setEditor( 'aimeos:account' );

		$localeManager = \Aimeos\MShop::create( $context, 'locale' );
		$localeItem = $localeManager->bootstrap( $this->argument( 'site' ), '', '', false );
		$context->setLocale( $localeItem );

		$manager = \Aimeos\MShop::create( $context, 'customer' );

		try {
			$item = $manager->findItem( $email );
		} catch( \Aimeos\MShop\Exception $e ) {
			$item = $manager->createItem();
		}

		$item = $item->setCode( $email )->setLabel( $email )->setPassword( $password )->setStatus( 1 );
		$item->getPaymentAddress()->setEmail( $email );

		$item = $manager->saveItem( $this->addGroups( $context, $item ) );

		\Illuminate\Foundation\Auth\User::findOrFail( $item->getId() )
			->forceFill( ['superuser' => ( $this->option( 'super' ) ? 1 : 0 )] )
			->save();
	}


	/**
	 * Adds the group to the given user
	 *
	 * @param \Aimeos\MShop\Context\Item\Iface $context Aimeos context object
	 * @param \Aimeos\MShop\Customer\Item\Iface $user Aimeos customer object
	 */
	protected function addGroups( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Customer\Item\Iface $user )
	{
		if( $this->option( 'admin' ) ) {
			$user = $this->addGroup( $context, $user, 'admin' );
		}

		if( $this->option( 'editor' ) ) {
			$user = $this->addGroup( $context, $user, 'editor' );
		}

		if( $this->option( 'api' ) ) {
			$user = $this->addGroup( $context, $user, 'api' );
		}

		return $user;
	}


	/**
	 * Adds the group to the given user
	 *
	 * @param \Aimeos\MShop\Context\Item\Iface $context Aimeos context object
	 * @param \Aimeos\MShop\Customer\Item\Iface $user Aimeos customer object
	 * @param string $group Unique customer group code
	 */
	protected function addGroup( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Customer\Item\Iface $user, $group )
	{
		$msg = 'Add "%1$s" group to user "%2$s" for site "%3$s"';
		$this->info( sprintf( $msg, $group, $user->getCode(), $this->argument( 'site' ) ) );

		$groupId = $this->getGroupItem( $context, $group )->getId();
		return $user->setGroups( array_merge( $user->getGroups(), [$groupId] ) );
	}


	/**
	 * Returns the customer group item for the given code
	 *
	 * @param \Aimeos\MShop\Context\Item\Iface $context Aimeos context object
	 * @param string $code Unique customer group code
	 * @return \Aimeos\MShop\Customer\Item\Group\Iface Aimeos customer group item object
	 */
	protected function getGroupItem( \Aimeos\MShop\Context\Item\Iface $context, $code )
	{
		$manager = \Aimeos\MShop::create( $context, 'customer/group' );

		try
		{
			$item = $manager->findItem( $code );
		}
		catch( \Aimeos\MShop\Exception $e )
		{
			$item = $manager->createItem();
			$item->setLabel( $code );
          setLabel( $code );
			$item->setCode( $code );
          setCode( $code );

			$manager->saveItem( $item );
		}

		return $item;
	}
}


aimeos / aimeos-laravel

Push — master ( cec86c...859d6d )

src/Aimeos/Shop/Command/AccountCommand.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like