Standard - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/aimeos..." - aimeos/aimeos-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 24a86a...771b97 )

by Aimeos

created 2018-06-24 08:06 UTC

Standard A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	333
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	333
rs	9.0399
c	0
b	0
f	0
wmc	42
lcom	1
cbo	2

19 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	getAttributeId()	8	2
A	setAttributeId()	10	2
A	getParentId()	6	2
A	setParentId()	10	2
A	getType()	8	2
A	setType()	10	2
A	getCode()	8	2
A	setCode()	10	2
A	getName()	8	2
A	setName()	10	2
A	getValue()	8	2
A	setValue()	10	2
A	getQuantity()	8	2
A	setQuantity()	10	2
A	getResourceType()	4	1
A	copyFrom()	11	1
B	fromArray()	22	9
A	toArray()	17	2

How to fix Complexity

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Metaways Infosystems GmbH, 2011
 * @copyright Aimeos (aimeos.org), 2015-2017
 * @package MShop
 * @subpackage Order
 */


namespace Aimeos\MShop\Order\Item\Base\Service\Attribute;


/**
 * Default order item base service attribute.
 *
 * @package MShop
 * @subpackage Order
 */
class Standard
	extends \Aimeos\MShop\Common\Item\Base

	implements \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface
{
	private $values;


	/**
	 * Initializes the order item base service attribute item.
	 *
	 * @param array $values Associative array of key/value pairs.
	 */
	public function __construct( array $values = [] )
	{
		parent::__construct( 'order.base.service.attribute.', $values );

		$this->values = $values;
	}


	/**
	 * Returns the original attribute ID of the service attribute item.
	 *
	 * @return string Attribute ID of the service attribute item
	 */
	public function getAttributeId()
	{
		if( isset( $this->values['order.base.service.attribute.attributeid'] ) ) {
			return (string) $this->values['order.base.service.attribute.attributeid'];
		}

		return '';
	}


	/**
	 * Sets the original attribute ID of the service attribute item.
	 *
	 * @param string $id Attribute ID of the service attribute item
	 * @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
	 */
	public function setAttributeId( $id )
	{
		if( (string) $id !== $this->getAttributeId() )
		{
			$this->values['order.base.service.attribute.attributeid'] = (string) $id;
			$this->setModified();
		}

		return $this;
	}


	/**
	 * Returns the ID of the ordered service item as parent
	 *
	 * @return string|null ID of the ordered service item
	 */
	public function getParentId()
	{
		if( isset( $this->values['order.base.service.attribute.parentid'] ) ) {
			return (string) $this->values['order.base.service.attribute.parentid'];
		}
	}


	/**
	 * Sets the ID of the ordered service item as parent
	 *
	 * @param string $id ID of the ordered service item
	 * @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
	 */
	public function setParentId( $id )
	{
		if( (string) $id !== $this->getParentId() )
		{
			$this->values['order.base.service.attribute.parentid'] = (string) $id;
			$this->setModified();
		}

		return $this;
	}


	/**
	 * Returns the type of the service attribute item.
	 *
	 * @return string Type of the service attribute item
	 */
	public function getType()
	{
		if( isset( $this->values['order.base.service.attribute.type'] ) ) {
			return (string) $this->values['order.base.service.attribute.type'];
		}

		return '';
	}


	/**
	 * Sets a new type for the service attribute item.
	 *
	 * @param string $type Type of the service attribute
	 * @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
	 */
	public function setType( $type )
	{
		if( (string) $type !== $this->getType() )
		{
			$this->values['order.base.service.attribute.type'] = (string) $type;
			$this->setModified();
		}

		return $this;
	}


	/**
	 * Returns the code of the service attribute item.
	 *
	 * @return string Code of the service attribute item
	 */
	public function getCode()
	{
		if( isset( $this->values['order.base.service.attribute.code'] ) ) {
			return (string) $this->values['order.base.service.attribute.code'];
		}

		return '';
	}


	/**
	 * Sets a new code for the service attribute item.
	 *
	 * @param string $code Code as defined by the service provider
	 * @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
	 */
	public function setCode( $code )
	{
		if( (string) $code !== $this->getCode() )
		{
			$this->values['order.base.service.attribute.code'] = (string) $this->checkCode( $code );
			$this->setModified();
		}

		return $this;
	}


	/**
	 * Returns the name of the service attribute item.
	 *
	 * @return string Name of the service attribute item
	 */
	public function getName()
	{
		if( isset( $this->values['order.base.service.attribute.name'] ) ) {
			return (string) $this->values['order.base.service.attribute.name'];
		}

		return '';
	}


	/**
	 * Sets a new name for the service attribute item.
	 *
	 * @param string $name Name as defined by the service provider
	 * @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
	 */
	public function setName( $name )
	{
		if( (string) $name !== $this->getName() )
		{
			$this->values['order.base.service.attribute.name'] = (string) $name;
			$this->setModified();
		}

		return $this;
	}


	/**
	 * Returns the value of the service attribute item.
	 *
	 * @return string|array Service attribute item value
	 */
	public function getValue()
	{
		if( isset( $this->values['order.base.service.attribute.value'] ) ) {
			return $this->values['order.base.service.attribute.value'];
		}

		return '';
	}


	/**
	 * Sets a new value for the service item.
	 *
	 * @param string|array $value service attribute item value
	 * @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
	 */
	public function setValue( $value )
	{
		if( $value !== $this->getValue() )
		{
			$this->values['order.base.service.attribute.value'] = $value;
			$this->setModified();
		}

		return $this;
	}


	/**
	 * Returns the quantity of the service attribute.
	 *
	 * @return integer Quantity of the service attribute
	 */
	public function getQuantity()
	{
		if( isset( $this->values['order.base.service.attribute.quantity'] ) ) {
			return (int) $this->values['order.base.service.attribute.quantity'];
		}

		return 1;
	}


	/**
	 * Sets the quantity of the service attribute.
	 *
	 * @param integer $value Quantity of the service attribute
	 * @return \Aimeos\MShop\Order\Item\Base\Product\Attribute\Iface Order base service attribute item for chaining method calls

	 */
	public function setQuantity( $value )
	{
		if( (int) $value !== $this->getQuantity() )
		{
			$this->values['order.base.service.attribute.quantity'] = (int) $value;
			$this->setModified();
		}

		return $this;
	}


	/**
	 * Returns the item type
	 *
	 * @return string Item type, subtypes are separated by slashes
	 */
	public function getResourceType()
	{
		return 'order/base/service/attribute';
	}


	/**
	 * Copys all data from a given attribute item.
	 *
	 * @param \Aimeos\MShop\Attribute\Item\Iface $item Attribute item to copy from
	 * @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
	 */
	public function copyFrom( \Aimeos\MShop\Attribute\Item\Iface $item )
	{
		$this->setAttributeId( $item->getId() );
		$this->setName( $item->getName() );
		$this->setCode( $item->getType() );
		$this->setValue( $item->getCode() );

		$this->setModified();

		return $this;
	}


	/**
	 * Sets the item values from the given array.
	 *
	 * @param array $list Associative list of item keys and their values
	 * @return array Associative list of keys and their values that are unknown
	 */
	public function fromArray( array $list )
	{
		$unknown = [];
		$list = parent::fromArray( $list );

		foreach( $list as $key => $value )
		{
			switch( $key )
			{
				case 'order.base.service.attribute.attrid': $this->setAttributeId( $value ); break;
				case 'order.base.service.attribute.parentid': $this->setParentId( $value ); break;
				case 'order.base.service.attribute.type': $this->setType( $value ); break;
				case 'order.base.service.attribute.name': $this->setName( $value ); break;
				case 'order.base.service.attribute.code': $this->setCode( $value ); break;
				case 'order.base.service.attribute.value': $this->setValue( $value ); break;
				case 'order.base.service.attribute.quantity': $this->setQuantity( $value ); break;
				default: $unknown[$key] = $value;
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}
			}
		}

		return $unknown;
	}


	/**
	 * Returns the item values as array.
	 *
	 * @param boolean True to return private properties, false for public only
	 * @return array Associative list of item properties and their values
	 */
	public function toArray( $private = false )
	{
		$list = parent::toArray( $private );

		$list['order.base.service.attribute.attrid'] = $this->getAttributeId();
		$list['order.base.service.attribute.type'] = $this->getType();
		$list['order.base.service.attribute.name'] = $this->getName();
		$list['order.base.service.attribute.code'] = $this->getCode();
		$list['order.base.service.attribute.value'] = $this->getValue();
		$list['order.base.service.attribute.quantity'] = $this->getQuantity();

		if( $private === true ) {
			$list['order.base.service.attribute.parentid'] = $this->getParentId();
		}

		return $list;
	}
}

1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Metaways Infosystems GmbH, 2011
6			* @copyright Aimeos (aimeos.org), 2015-2017
7			* @package MShop
8			* @subpackage Order
9			*/
10
11
12			namespace Aimeos\MShop\Order\Item\Base\Service\Attribute;
13
14
15			/**
16			* Default order item base service attribute.
17			*
18			* @package MShop
19			* @subpackage Order
20			*/
21			class Standard
22			extends \Aimeos\MShop\Common\Item\Base
			0 ignored issues – show Coding Style introduced 2016-02-05 10:43 UTC by Report Bug Copy Issue Report Expected 0 spaces between "Base" and comma; 1 found Loading history...
23			implements \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface
24			{
25			private $values;
26
27
28			/**
29			* Initializes the order item base service attribute item.
30			*
31			* @param array $values Associative array of key/value pairs.
32			*/
33			public function __construct( array $values = [] )
34			{
35			parent::__construct( 'order.base.service.attribute.', $values );
36
37			$this->values = $values;
38			}
39
40
41			/**
42			* Returns the original attribute ID of the service attribute item.
43			*
44			* @return string Attribute ID of the service attribute item
45			*/
46			public function getAttributeId()
47			{
48			if( isset( $this->values['order.base.service.attribute.attributeid'] ) ) {
49			return (string) $this->values['order.base.service.attribute.attributeid'];
50			}
51
52			return '';
53			}
54
55
56			/**
57			* Sets the original attribute ID of the service attribute item.
58			*
59			* @param string $id Attribute ID of the service attribute item
60			* @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
61			*/
62			public function setAttributeId( $id )
63			{
64			if( (string) $id !== $this->getAttributeId() )
65			{
66			$this->values['order.base.service.attribute.attributeid'] = (string) $id;
67			$this->setModified();
68			}
69
70			return $this;
71			}
72
73
74			/**
75			* Returns the ID of the ordered service item as parent
76			*
77			* @return string\|null ID of the ordered service item
78			*/
79			public function getParentId()
80			{
81			if( isset( $this->values['order.base.service.attribute.parentid'] ) ) {
82			return (string) $this->values['order.base.service.attribute.parentid'];
83			}
84			}
85
86
87			/**
88			* Sets the ID of the ordered service item as parent
89			*
90			* @param string $id ID of the ordered service item
91			* @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
92			*/
93			public function setParentId( $id )
94			{
95			if( (string) $id !== $this->getParentId() )
96			{
97			$this->values['order.base.service.attribute.parentid'] = (string) $id;
98			$this->setModified();
99			}
100
101			return $this;
102			}
103
104
105			/**
106			* Returns the type of the service attribute item.
107			*
108			* @return string Type of the service attribute item
109			*/
110			public function getType()
111			{
112			if( isset( $this->values['order.base.service.attribute.type'] ) ) {
113			return (string) $this->values['order.base.service.attribute.type'];
114			}
115
116			return '';
117			}
118
119
120			/**
121			* Sets a new type for the service attribute item.
122			*
123			* @param string $type Type of the service attribute
124			* @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
125			*/
126			public function setType( $type )
127			{
128			if( (string) $type !== $this->getType() )
129			{
130			$this->values['order.base.service.attribute.type'] = (string) $type;
131			$this->setModified();
132			}
133
134			return $this;
135			}
136
137
138			/**
139			* Returns the code of the service attribute item.
140			*
141			* @return string Code of the service attribute item
142			*/
143			public function getCode()
144			{
145			if( isset( $this->values['order.base.service.attribute.code'] ) ) {
146			return (string) $this->values['order.base.service.attribute.code'];
147			}
148
149			return '';
150			}
151
152
153			/**
154			* Sets a new code for the service attribute item.
155			*
156			* @param string $code Code as defined by the service provider
157			* @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
158			*/
159			public function setCode( $code )
160			{
161			if( (string) $code !== $this->getCode() )
162			{
163			$this->values['order.base.service.attribute.code'] = (string) $this->checkCode( $code );
164			$this->setModified();
165			}
166
167			return $this;
168			}
169
170
171			/**
172			* Returns the name of the service attribute item.
173			*
174			* @return string Name of the service attribute item
175			*/
176			public function getName()
177			{
178			if( isset( $this->values['order.base.service.attribute.name'] ) ) {
179			return (string) $this->values['order.base.service.attribute.name'];
180			}
181
182			return '';
183			}
184
185
186			/**
187			* Sets a new name for the service attribute item.
188			*
189			* @param string $name Name as defined by the service provider
190			* @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
191			*/
192			public function setName( $name )
193			{
194			if( (string) $name !== $this->getName() )
195			{
196			$this->values['order.base.service.attribute.name'] = (string) $name;
197			$this->setModified();
198			}
199
200			return $this;
201			}
202
203
204			/**
205			* Returns the value of the service attribute item.
206			*
207			* @return string\|array Service attribute item value
208			*/
209			public function getValue()
210			{
211			if( isset( $this->values['order.base.service.attribute.value'] ) ) {
212			return $this->values['order.base.service.attribute.value'];
213			}
214
215			return '';
216			}
217
218
219			/**
220			* Sets a new value for the service item.
221			*
222			* @param string\|array $value service attribute item value
223			* @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
224			*/
225			public function setValue( $value )
226			{
227			if( $value !== $this->getValue() )
228			{
229			$this->values['order.base.service.attribute.value'] = $value;
230			$this->setModified();
231			}
232
233			return $this;
234			}
235
236
237			/**
238			* Returns the quantity of the service attribute.
239			*
240			* @return integer Quantity of the service attribute
241			*/
242			public function getQuantity()
243			{
244			if( isset( $this->values['order.base.service.attribute.quantity'] ) ) {
245			return (int) $this->values['order.base.service.attribute.quantity'];
246			}
247
248			return 1;
249			}
250
251
252			/**
253			* Sets the quantity of the service attribute.
254			*
255			* @param integer $value Quantity of the service attribute
256			* @return \Aimeos\MShop\Order\Item\Base\Product\Attribute\Iface Order base service attribute item for chaining method calls
			0 ignored issues – show Documentation introduced 2017-10-12 12:55 UTC by Report Bug Copy Issue Report Should the return type not be `Standard`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
257			*/
258			public function setQuantity( $value )
259			{
260			if( (int) $value !== $this->getQuantity() )
261			{
262			$this->values['order.base.service.attribute.quantity'] = (int) $value;
263			$this->setModified();
264			}
265
266			return $this;
267			}
268
269
270			/**
271			* Returns the item type
272			*
273			* @return string Item type, subtypes are separated by slashes
274			*/
275			public function getResourceType()
276			{
277			return 'order/base/service/attribute';
278			}
279
280
281			/**
282			* Copys all data from a given attribute item.
283			*
284			* @param \Aimeos\MShop\Attribute\Item\Iface $item Attribute item to copy from
285			* @return \Aimeos\MShop\Order\Item\Base\Service\Attribute\Iface Order base service attribute item for chaining method calls
286			*/
287			public function copyFrom( \Aimeos\MShop\Attribute\Item\Iface $item )
288			{
289			$this->setAttributeId( $item->getId() );
290			$this->setName( $item->getName() );
291			$this->setCode( $item->getType() );
292			$this->setValue( $item->getCode() );
293
294			$this->setModified();
295
296			return $this;
297			}
298
299
300			/**
301			* Sets the item values from the given array.
302			*
303			* @param array $list Associative list of item keys and their values
304			* @return array Associative list of keys and their values that are unknown
305			*/
306			public function fromArray( array $list )
307			{
308			$unknown = [];
309			$list = parent::fromArray( $list );
310
311			foreach( $list as $key => $value )
312			{
313			switch( $key )
314			{
315			case 'order.base.service.attribute.attrid': $this->setAttributeId( $value ); break;
316			case 'order.base.service.attribute.parentid': $this->setParentId( $value ); break;
317			case 'order.base.service.attribute.type': $this->setType( $value ); break;
318			case 'order.base.service.attribute.name': $this->setName( $value ); break;
319			case 'order.base.service.attribute.code': $this->setCode( $value ); break;
320			case 'order.base.service.attribute.value': $this->setValue( $value ); break;
321			case 'order.base.service.attribute.quantity': $this->setQuantity( $value ); break;
322			default: $unknown[$key] = $value;
			0 ignored issues – show Coding Style introduced 2016-02-26 18:19 UTC by Report Bug Copy Issue Report The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
323			}
324			}
325
326			return $unknown;
327			}
328
329
330			/**
331			* Returns the item values as array.
332			*
333			* @param boolean True to return private properties, false for public only
334			* @return array Associative list of item properties and their values
335			*/
336			public function toArray( $private = false )
337			{
338			$list = parent::toArray( $private );
339
340			$list['order.base.service.attribute.attrid'] = $this->getAttributeId();
341			$list['order.base.service.attribute.type'] = $this->getType();
342			$list['order.base.service.attribute.name'] = $this->getName();
343			$list['order.base.service.attribute.code'] = $this->getCode();
344			$list['order.base.service.attribute.value'] = $this->getValue();
345			$list['order.base.service.attribute.quantity'] = $this->getQuantity();
346
347			if( $private === true ) {
348			$list['order.base.service.attribute.parentid'] = $this->getParentId();
349			}
350
351			return $list;
352			}
353			}

aimeos / aimeos-core

Push — master ( 24a86a...771b97 )

Standard A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like