aimeos / aimeos-core

lib/mshoplib/tests/MShop/Service/Provider/Decorator/QuantityTest.php

Doc Comments +1 added lines

@@ -137,6 +137,7 @@
 
 
 	/**
+	 * @param string $paydate
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface
 	 */
 	protected function getOrderBaseItem( $paydate )

lib/mshoplib/src/MShop/Service/Provider/Decorator/Quantity.php

Braces +1 added lines, -2 removed lines

@@ -98,8 +98,7 @@
 				foreach( $products as $prodItem ) { // calculate bundled products
 					$sum += $qty * $prodItem->getQuantity();
 				}
-			}
-			else
+			} else
 			{
 				$sum += $qty;
 			}

lib/mshoplib/tests/MShop/Media/Manager/Property/StandardTest.php

Spacing +13 added lines, -13 removed lines

@@ -54,11 +54,11 @@ 
 		$search->setConditions( $search->compare( '==', 'media.property.editor', $this->editor ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No property item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setLanguageId( 'en' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -109,13 +109,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '~=', 'media.property.value', '1024'),
+			$search->compare( '~=', 'media.property.value', '1024' ),
 			$search->compare( '==', 'media.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results)) === false ) {
+		if( ( $expected = reset( $results ) ) === false ) {
 			throw new \RuntimeException( sprintf( 'No media property item found for value "%1$s".', '1024' ) );
 		}
 
@@ -166,7 +166,7 @@ 
 		$expr[] = $search->compare( '>=', 'media.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'media.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
@@ -177,13 +177,13 @@ 
 			$search->compare( '==', 'media.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
-		$search->setSlice(0, 1);
+		$search->setSlice( 0, 1 );
 		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 3, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -191,17 +191,17 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type') );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type', 'Standard') );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type' ) );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type', 'Standard' ) );
 
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 
 
 	public function testGetSubManagerInvalidName()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('type', 'unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'type', 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Media/Manager/Property/Type/StandardTest.php

Spacing +13 added lines, -13 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Media\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'media.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -156,7 +156,7 @@ 
 		$expr[] = $search->compare( '>=', 'media.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'media.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
@@ -166,14 +166,14 @@ 
 			$search->compare( '=~', 'media.property.type.code', '' ),
 			$search->compare( '==', 'media.property.type.editor', $this->editor )
 		);
-		$search->setConditions( $search->combine('&&', $conditions ) );
-		$search->setSlice(0, 1);
-		$items = $this->object->searchItems( $search, [], $total);
+		$search->setConditions( $search->combine( '&&', $conditions ) );
+		$search->setSlice( 0, 1 );
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 3, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -181,7 +181,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/src/MShop/Media/Manager/Property/Standard.php

Spacing +1 added lines, -1 removed lines

@@ -288,7 +288,7 @@
 		 * @see mshop/media/manager/property/decorators/global
 		 */
 
-		return $this->getSubManagerBase( 'media', 'property/' . $manager, $name );
+		return $this->getSubManagerBase( 'media', 'property/'.$manager, $name );
 	}
 
 

lib/mshoplib/src/MShop/Media/Manager/Property/Type/Standard.php

Spacing +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 		 * @see mshop/media/manager/property/type/decorators/global
 		 */
 
-		return $this->getSubManagerBase( 'media', 'property/type/' . $manager, $name );
+		return $this->getSubManagerBase( 'media', 'property/type/'.$manager, $name );
 	}
 
 

lib/mshoplib/setup/unittest/MediaAddPropertyTestData.php

Spacing +6 added lines, -6 removed lines

@@ -51,7 +51,7 @@ 
 		$this->additional->setEditor( 'core:unittest' );
 
 		$ds = DIRECTORY_SEPARATOR;
-		$path = __DIR__ . $ds . 'data' . $ds . 'media-property.php';
+		$path = __DIR__.$ds.'data'.$ds.'media-property.php';
 
 		if( ( $testdata = include( $path ) ) == false ) {
 			throw new \Aimeos\MShop\Exception( sprintf( 'No file "%1$s" found for media domain', $path ) );
@@ -89,19 +89,19 @@ 
 			$type->setStatus( $dataset['status'] );
 
 			$mediaPropertyTypeManager->saveItem( $type );
-			$typeIds[ $key ] = $type->getId();
+			$typeIds[$key] = $type->getId();
 		}
 
 		$prodProperty = $mediaPropertyManager->createItem();
 		foreach( $testdata['media/property'] as $key => $dataset )
 		{
-			if( !isset( $typeIds[ $dataset['typeid'] ] ) ) {
+			if( !isset( $typeIds[$dataset['typeid']] ) ) {
 				throw new \Aimeos\MW\Setup\Exception( sprintf( 'No media property type ID found for "%1$s"', $dataset['typeid'] ) );
 			}
 
 			$prodProperty->setId( null );
-			$prodProperty->setParentId( $prodIds[ $dataset['parentid'] ] );
-			$prodProperty->setTypeId( $typeIds[ $dataset['typeid'] ] );
+			$prodProperty->setParentId( $prodIds[$dataset['parentid']] );
+			$prodProperty->setTypeId( $typeIds[$dataset['typeid']] );
 			$prodProperty->setLanguageId( $dataset['langid'] );
 			$prodProperty->setValue( $dataset['value'] );
 
@@ -124,7 +124,7 @@ 
 		$search = $mediaManager->createSearch();
 
 		foreach( $mediaManager->searchItems( $search ) as $id => $item ) {
-			$entry[ 'media/' . $item->getUrl() ] = $id;
+			$entry['media/'.$item->getUrl()] = $id;
 		}
 
 		return $entry;

lib/mshoplib/setup/unittest/data/media-property.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * @copyright Aimeos (aimeos.org), 2017
  */
 
-return array (
+return array(
 	'media/property/type' => array(
 		'media/property/type/size' => array( 'domain' => 'media', 'code' => 'size', 'label' => 'Size', 'status' => 1 ),
 		'media/property/type/mtime' => array( 'domain' => 'media', 'code' => 'mtime', 'label' => 'Modification time', 'status' => 1 ),

lib/mshoplib/setup/default/schema/media.php

Spacing +7 added lines, -7 removed lines

@@ -8,7 +8,7 @@ 
 
 return array(
 	'table' => array(
-		'mshop_media_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_type' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_media_type' );
 
@@ -31,7 +31,7 @@ 
 			return $schema;
 		},
 
-		'mshop_media' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_media' );
 
@@ -47,7 +47,7 @@ 
 			$table->addColumn( 'status', 'smallint', [] );
 			$table->addColumn( 'mtime', 'datetime', [] );
 			$table->addColumn( 'ctime', 'datetime', [] );
-			$table->addColumn( 'editor', 'string', array('length' => 255 ) );
+			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );
 
 			$table->setPrimaryKey( array( 'id' ), 'pk_msmed_id' );
 			$table->addIndex( array( 'siteid', 'domain', 'langid' ), 'idx_msmed_sid_dom_langid' );
@@ -62,7 +62,7 @@ 
 			return $schema;
 		},
 
-		'mshop_media_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_list_type' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_media_list_type' );
 
@@ -85,7 +85,7 @@ 
 			return $schema;
 		},
 
-		'mshop_media_list' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_list' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_media_list' );
 
@@ -123,7 +123,7 @@ 
 			return $schema;
 		},
 
-		'mshop_media_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_property_type' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_media_property_type' );
 
@@ -146,7 +146,7 @@ 
 			return $schema;
 		},
 
-		'mshop_media_property' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_property' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_media_property' );
 

Braces +12 added lines, -6 removed lines

@@ -8,7 +8,8 @@ 
 
 return array(
 	'table' => array(
-		'mshop_media_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_type' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_media_type' );
 
@@ -31,7 +32,8 @@ 
 			return $schema;
 		},
 
-		'mshop_media' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_media' );
 
@@ -62,7 +64,8 @@ 
 			return $schema;
 		},
 
-		'mshop_media_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_media_list_type' );
 
@@ -85,7 +88,8 @@ 
 			return $schema;
 		},
 
-		'mshop_media_list' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_list' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_media_list' );
 
@@ -123,7 +127,8 @@ 
 			return $schema;
 		},
 
-		'mshop_media_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_media_property_type' );
 
@@ -146,7 +151,8 @@ 
 			return $schema;
 		},
 
-		'mshop_media_property' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_media_property' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_media_property' );