aimeos / aimeos-core

lib/mshoplib/tests/MShop/Attribute/Manager/Property/Type/StandardTest.php

Spacing +13 added lines, -13 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Attribute\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'attribute.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -156,7 +156,7 @@ 
 		$expr[] = $search->compare( '>=', 'attribute.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'attribute.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
@@ -166,14 +166,14 @@ 
 			$search->compare( '=~', 'attribute.property.type.code', '' ),
 			$search->compare( '==', 'attribute.property.type.editor', $this->editor )
 		);
-		$search->setConditions( $search->combine('&&', $conditions ) );
-		$search->setSlice(0, 1);
-		$items = $this->object->searchItems( $search, [], $total);
+		$search->setConditions( $search->combine( '&&', $conditions ) );
+		$search->setSlice( 0, 1 );
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 3, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -181,7 +181,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Attribute/Manager/Property/StandardTest.php

Spacing +13 added lines, -13 removed lines

@@ -54,11 +54,11 @@ 
 		$search->setConditions( $search->compare( '==', 'attribute.property.editor', $this->editor ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No property item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setLanguageId( 'en' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -109,13 +109,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '~=', 'attribute.property.value', '1024'),
+			$search->compare( '~=', 'attribute.property.value', '1024' ),
 			$search->compare( '==', 'attribute.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results)) === false ) {
+		if( ( $expected = reset( $results ) ) === false ) {
 			throw new \RuntimeException( sprintf( 'No attribute property item found for value "%1$s".', '1024' ) );
 		}
 
@@ -166,7 +166,7 @@ 
 		$expr[] = $search->compare( '>=', 'attribute.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'attribute.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
@@ -177,13 +177,13 @@ 
 			$search->compare( '==', 'attribute.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
-		$search->setSlice(0, 1);
+		$search->setSlice( 0, 1 );
 		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 3, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -191,17 +191,17 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type') );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type', 'Standard') );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type' ) );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type', 'Standard' ) );
 
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 
 
 	public function testGetSubManagerInvalidName()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('type', 'unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'type', 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Plugin/Provider/Order/ProductFreeOptionsTest.php

Doc Comments +3 added lines

@@ -132,6 +132,9 @@
 	}
 
 
+	/**
+	 * @param string $name
+	 */
 	protected function access( $name )
 	{
 		$class = new \ReflectionClass( '\Aimeos\MShop\Plugin\Provider\Order\ProductFreeOptions' );

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
 		$attribute->setQuantity( 2 );
 		$attribute->setCode( 'size' );
 		$attribute->setType( 'config' );
-		$attribute->setAttributeId( $attrManager->findItem( 'xs', [], 'product', 'size')->getId() );
+		$attribute->setAttributeId( $attrManager->findItem( 'xs', [], 'product', 'size' )->getId() );
 
 		$product->setAttributeItem( $attribute );
 		$product->setProductId( $prodManager->findItem( 'CNE' )->getId() );

lib/mshoplib/src/MShop/Plugin/Provider/Order/ProductFreeOptions.php

Braces +1 added lines, -2 removed lines

@@ -78,8 +78,7 @@
 			{
 				$list = $this->sortByPrice( $list, $attrQtys );
 				$priceItem = $this->addPrices( $priceItem, $list, $attrQtys, (int) $prodConf[$type] );
-			}
-			else
+			} else
 			{
 				$priceItem = $this->addPrices( $priceItem, $list, $attrQtys, 0 );
 			}

controller/common/src/Controller/Common/Media/Standard.php

Braces +7 added lines, -4 removed lines

@@ -61,8 +61,7 @@ 
 			$filepath = $this->getFilePath( $file->getClientFilename(), 'preview', $mimeprev );
 			$this->storeFile( $media->save( null, $mimetype ), $fsname, $filepath, $item->getPreview() );
 			$item->setPreview( $filepath );
-		}
-		else
+		} else
 		{
 			$mimetype = $media->getMimeType();
 			$item->setPreview( $this->getMimeIcon( $mimetype ) );
@@ -103,7 +102,9 @@ 
 				$fs->rm( $path );
 			}
 		}
-		catch( \Exception $e ) { ; } // Can be a mime icon with relative path
+		catch( \Exception $e )
+		{
+; } // Can be a mime icon with relative path
 
 		$item->setPreview( '' );
 	}
@@ -486,7 +487,9 @@ 
 				$fs->rm( $oldpath );
 			}
 		}
-		catch( \Aimeos\MW\Filesystem\Exception $e ) {} // continue if removing file fails
+		catch( \Aimeos\MW\Filesystem\Exception $e )
+		{
+} // continue if removing file fails
 
 		$fs->write( $filepath, $content );
 	}

Spacing +7 added lines, -7 removed lines

@@ -103,7 +103,7 @@ 
 				$fs->rm( $path );
 			}
 		}
-		catch( \Exception $e ) { ; } // Can be a mime icon with relative path
+		catch( \Exception $e ) {; } // Can be a mime icon with relative path
 
 		$item->setPreview( '' );
 	}
@@ -225,10 +225,10 @@ 
 		$list = $this->context->getConfig()->get( 'controller/common/media/standard/extensions', [] );
 
 		if( isset( $list[$mimetype] ) ) {
-			$ext = '.' . $list[$mimetype];
+			$ext = '.'.$list[$mimetype];
 		}
 
-		$filename = md5( $filename . getmypid() . microtime( true ) );
+		$filename = md5( $filename.getmypid().microtime( true ) );
 
 		return "${type}/${filename[0]}/${filename[1]}/${filename}${ext}";
 	}
@@ -317,7 +317,7 @@ 
 		 */
 		$ext = $config->get( 'controller/common/media/standard/mimeicon/extension', '.png' );
 
-		return $mimedir . DIRECTORY_SEPARATOR . $mimetype . $ext;
+		return $mimedir.DIRECTORY_SEPARATOR.$mimetype.$ext;
 	}
 
 
@@ -361,7 +361,7 @@ 
 		 * @category User
 		 */
 		$default = array( 'image/jpeg', 'image/png', 'image/gif' );
-		$allowed = $config->get( 'controller/common/media/standard/' . $type . '/allowedtypes', $default );
+		$allowed = $config->get( 'controller/common/media/standard/'.$type.'/allowedtypes', $default );
 
 		if( in_array( $mimetype, $allowed ) === false )
 		{
@@ -422,7 +422,7 @@ 
 		 * @category Developer
 		 * @category User
 		 */
-		$maxwidth = $config->get( 'controller/common/media/standard/' . $type . '/maxwidth', null );
+		$maxwidth = $config->get( 'controller/common/media/standard/'.$type.'/maxwidth', null );
 
 		/** controller/common/media/standard/files/maxheight
 		 * Maximum height of the uploaded images
@@ -459,7 +459,7 @@ 
 		 * @category Developer
 		 * @category User
 		 */
-		$maxheight = $config->get( 'controller/common/media/standard/' . $type . '/maxheight', null );
+		$maxheight = $config->get( 'controller/common/media/standard/'.$type.'/maxheight', null );
 
 		return $media->scale( $maxwidth, $maxheight );
 	}

lib/mwlib/tests/MW/Process/PcntlTest.php

Braces +6 added lines, -2 removed lines

@@ -23,7 +23,9 @@ 
 	public function testRun()
 	{
 		$object = new \Aimeos\MW\Process\Pcntl();
-		$fcn = function() { sleep( 1 ); };
+		$fcn = function()
+		{
+sleep( 1 ); };
 
 		$start = microtime( true );
 		$return = $object->start( $fcn, [] )->start( $fcn, [] )->wait();
@@ -37,7 +39,9 @@ 
 
 	public function testRunException()
 	{
-		$fcn = function() { throw new \Exception(); };
+		$fcn = function()
+		{
+throw new \Exception(); };
 
 		try
 		{

lib/mshoplib/src/MShop/Service/Provider/Decorator/Base.php

Doc Comments +2 added lines, -2 removed lines

@@ -180,7 +180,7 @@ 
 	 * Processes the order
 	 *
 	 * @param \Aimeos\MShop\Order\Item\Iface $order Order invoice object to process
-	 * @param array $params Request parameter if available
+	 * @param string[] $params Request parameter if available
 	 * @return \Aimeos\MShop\Common\Item\Helper\Form\Standard|null Form object or null
 	 */
 	public function process( \Aimeos\MShop\Order\Item\Iface $order, array $params = [] )
@@ -265,7 +265,7 @@ 
 	/**
 	 * Updates the orders for whose status updates have been received by the confirmation page
 	 *
-	 * @param ServerRequestInterface $request Request object with parameters and request body
+	 * @param \Psr\Http\Message\ServerRequestInterface $request Request object with parameters and request body
 	 * @param \Aimeos\MShop\Order\Item\Iface $orderItem Order item that should be updated
 	 * @return \Aimeos\MShop\Order\Item\Iface Updated order item
 	 * @throws \Aimeos\MShop\Service\Exception If updating the orders failed

lib/mshoplib/src/MShop/Service/Provider/Iface.php

Doc Comments +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
 	/**
 	 * Updates the orders for whose status updates have been received by the confirmation page
 	 *
-	 * @param ServerRequestInterface $request Request object with parameters and request body
+	 * @param \Psr\Http\Message\ServerRequestInterface $request Request object with parameters and request body
 	 * @param \Aimeos\MShop\Order\Item\Iface $orderItem Order item that should be updated
 	 * @return \Aimeos\MShop\Order\Item\Iface Updated order item
 	 * @throws \Aimeos\MShop\Service\Exception If updating the orders failed

lib/mshoplib/src/MShop/Plugin/Manager/Iface.php

Doc Comments +1 added lines

@@ -33,6 +33,7 @@
 	 *
 	 * @param \Aimeos\MW\Observer\Publisher\Iface $publisher Publisher object
 	 * @param string $type Plugin type code
+	 * @return void
 	 */
 	public function register( \Aimeos\MW\Observer\Publisher\Iface $publisher, $type );
 }