aimeos / aimeos-core

lib/mwlib/src/MW/Common/Base.php

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public static function checkClass( $name, $object )
 	{
-		if( ($object instanceof $name) === false ) {
+		if( ( $object instanceof $name ) === false ) {
 			throw new \Aimeos\MW\Common\Exception( sprintf( 'Object doesn\'t implement "%1$s"', $name ) );
 		}
 	}
@@ -45,7 +45,7 @@ 
 	public static function checkClassList( $name, array $list )
 	{
 		foreach( $list as $object ) {
-			if( ($object instanceof $name) === false ) {
+			if( ( $object instanceof $name ) === false ) {
 				throw new \Aimeos\MW\Common\Exception( sprintf( 'Object doesn\'t implement "%1$s"', $name ) );
 			}
 		}

lib/mwlib/src/MW/Common/Manager/Base.php

Spacing +4 added lines, -4 removed lines

@@ -98,9 +98,9 @@ 
 		foreach( $attributes as $key => $item )
 		{
 			if( $item instanceof $iface ) {
-				$translations[ $item->getCode() ] = $item->getInternalCode();
+				$translations[$item->getCode()] = $item->getInternalCode();
 			} else if( isset( $item['code'] ) ) {
-				$translations[ $item['code'] ] = $item['internalcode'];
+				$translations[$item['code']] = $item['internalcode'];
 			} else {
 				throw new \Aimeos\MW\Common\Exception( sprintf( 'Invalid attribute at position "%1$d"', $key ) );
 			}
@@ -126,9 +126,9 @@ 
 		foreach( $attributes as $key => $item )
 		{
 			if( $item instanceof $iface ) {
-				$types[ $item->getCode() ] = $item->getInternalType();
+				$types[$item->getCode()] = $item->getInternalType();
 			} else if( isset( $item['code'] ) ) {
-				$types[ $item['code'] ] = $item['internaltype'];
+				$types[$item['code']] = $item['internaltype'];
 			} else {
 				throw new \Aimeos\MW\Common\Exception( sprintf( 'Invalid attribute at position "%1$d"', $key ) );
 			}

lib/mshoplib/tests/MShop/Service/Provider/BaseTest.php

Doc Comments +3 added lines

@@ -311,6 +311,9 @@
 
 class TestBase extends \Aimeos\MShop\Service\Provider\Base
 {
+	/**
+	 * @param integer $ts
+	 */
 	public function calcDateLimitPublic( $ts, $days = 0, $bd = false, $hd = '' )
 	{
 		return $this->calcDateLimit( $ts, $days, $bd, $hd );

controller/common/tests/Controller/Common/Media/StandardTest.php

Doc Comments +3 added lines

@@ -335,6 +335,9 @@
 	}
 
 
+	/**
+	 * @param string $name
+	 */
 	protected function access( $name )
 	{
 		$class = new \ReflectionClass( '\Aimeos\Controller\Common\Media\Standard' );

Spacing +15 added lines, -15 removed lines

@@ -40,7 +40,7 @@ 
 
 		$file = $this->getMockBuilder( '\Psr\Http\Message\UploadedFileInterface' )->getMock();
 		$file->expects( $this->once() )->method( 'getStream' )
-			->will( $this->returnValue( file_get_contents( __DIR__ . '/testfiles/test.gif' ) ) );
+			->will( $this->returnValue( file_get_contents( __DIR__.'/testfiles/test.gif' ) ) );
 
 		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'media' )->createItem();
 
@@ -60,7 +60,7 @@ 
 
 		$file = $this->getMockBuilder( '\Psr\Http\Message\UploadedFileInterface' )->getMock();
 		$file->expects( $this->once() )->method( 'getStream' )
-			->will( $this->returnValue( file_get_contents( __DIR__ . '/testfiles/test.pdf' ) ) );
+			->will( $this->returnValue( file_get_contents( __DIR__.'/testfiles/test.pdf' ) ) );
 
 		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'media' )->createItem();
 
@@ -108,7 +108,7 @@ 
 			->getMock();
 
 		$object->expects( $this->once() )->method( 'getFileContent' )
-			->will( $this->returnValue( file_get_contents( __DIR__ . '/testfiles/test.png' ) ) );
+			->will( $this->returnValue( file_get_contents( __DIR__.'/testfiles/test.png' ) ) );
 
 		$object->expects( $this->exactly( 2 ) )->method( 'storeFile' );
 
@@ -204,9 +204,9 @@ 
 
 	public function testGetFileContent()
 	{
-		$dest = dirname( dirname( dirname( __DIR__ ) ) ) . '/tmp/';
+		$dest = dirname( dirname( dirname( __DIR__ ) ) ).'/tmp/';
 		if( !is_dir( $dest ) ) { mkdir( $dest, 0755, true ); }
-		copy( __DIR__ . '/testfiles/test.gif', $dest . 'test.gif' );
+		copy( __DIR__.'/testfiles/test.gif', $dest.'test.gif' );
 
 		$result = $this->access( 'getFileContent' )->invokeArgs( $this->object, array( 'test.gif', 'fs-media' ) );
 
@@ -296,7 +296,7 @@ 
 
 	public function testGetMimeType()
 	{
-		$file = \Aimeos\MW\Media\Factory::get( __DIR__ . '/testfiles/test.png' );
+		$file = \Aimeos\MW\Media\Factory::get( __DIR__.'/testfiles/test.png' );
 
 		$result = $this->access( 'getMimeType' )->invokeArgs( $this->object, array( $file, 'files' ) );
 		$this->assertEquals( 'image/png', $result );
@@ -305,7 +305,7 @@ 
 
 	public function testGetMimeTypeNotAllowed()
 	{
-		$file = \Aimeos\MW\Media\Factory::get( __DIR__ . '/testfiles/test.gif' );
+		$file = \Aimeos\MW\Media\Factory::get( __DIR__.'/testfiles/test.gif' );
 		$this->context->getConfig()->set( 'controller/common/media/standard/files/allowedtypes', array( 'image/jpeg' ) );
 
 		$result = $this->access( 'getMimeType' )->invokeArgs( $this->object, array( $file, 'files' ) );
@@ -315,7 +315,7 @@ 
 
 	public function testGetMimeTypeNoTypes()
 	{
-		$file = \Aimeos\MW\Media\Factory::get( __DIR__ . '/testfiles/test.gif' );
+		$file = \Aimeos\MW\Media\Factory::get( __DIR__.'/testfiles/test.gif' );
 		$this->context->getConfig()->set( 'controller/common/media/standard/files/allowedtypes', [] );
 
 		$this->setExpectedException( '\Aimeos\Controller\Common\Exception' );
@@ -325,7 +325,7 @@ 
 
 	public function testScaleImage()
 	{
-		$file = \Aimeos\MW\Media\Factory::get( __DIR__ . '/testfiles/test.gif' );
+		$file = \Aimeos\MW\Media\Factory::get( __DIR__.'/testfiles/test.gif' );
 
 		$this->access( 'scaleImage' )->invokeArgs( $this->object, array( $file, 'files' ) );
 	}
@@ -333,18 +333,18 @@ 
 
 	public function testStoreFile()
 	{
-		$content = file_get_contents( __DIR__ . '/testfiles/test.gif' );
+		$content = file_get_contents( __DIR__.'/testfiles/test.gif' );
 
-		$dest = dirname( dirname( dirname( __DIR__ ) ) ) . '/tmp/';
+		$dest = dirname( dirname( dirname( __DIR__ ) ) ).'/tmp/';
 		if( !is_dir( $dest ) ) { mkdir( $dest, 0755, true ); }
-		copy( __DIR__ . '/testfiles/test.gif', $dest . 'test2.gif' );
+		copy( __DIR__.'/testfiles/test.gif', $dest.'test2.gif' );
 
 		$this->access( 'storeFile' )->invokeArgs( $this->object, array( $content, 'fs-media', 'test.gif', 'test2.gif' ) );
 
-		$this->assertFalse( file_exists( $dest . 'test2.gif' ) );
-		$this->assertTrue( file_exists( $dest . 'test.gif' ) );
+		$this->assertFalse( file_exists( $dest.'test2.gif' ) );
+		$this->assertTrue( file_exists( $dest.'test.gif' ) );
 
-		unlink( $dest . 'test.gif' );
+		unlink( $dest.'test.gif' );
 	}
 
 

lib/mshoplib/src/MShop/Plugin/Provider/Order/Autofill.php

Doc Comments +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Basket of the customer
 	 * @param string $type Service type constant from \Aimeos\MShop\Order\Item\Base\Service\Base
 	 * @param string|null $code Service item code
-	 * @return \Aimeos\MShop\Order\Item\Base\Service\Iface|null Order service item if available or null otherwise
+	 * @return \Aimeos\MShop\Common\Item\Iface|null Order service item if available or null otherwise
 	 */
 	protected function getServiceItem( \Aimeos\MShop\Order\Item\Base\Iface $order, $type, $code = null )
 	{

lib/mshoplib/src/MShop/Locale/Manager/Currency/Standard.php

Doc Comments +2 added lines, -2 removed lines

@@ -605,7 +605,7 @@ 
 	 * Returns the search results for the given SQL statement.
 	 *
 	 * @param \Aimeos\MW\DB\Connection\Iface $conn Database connection
-	 * @param $sql SQL statement
+	 * @param string $sql SQL statement
 	 * @return \Aimeos\MW\DB\Result\Iface Search result object
 	 */
 	protected function getSearchResults( \Aimeos\MW\DB\Connection\Iface $conn, $sql )
@@ -635,7 +635,7 @@ 
 	 * Returns the total number of items found for the conditions
 	 *
 	 * @param \Aimeos\MW\DB\Connection\Iface $conn Database connection
-	 * @param array $find List of markers that should be replaced in the SQL statement
+	 * @param string[] $find List of markers that should be replaced in the SQL statement
 	 * @param array $replace List of replacements for the markers in the SQL statement
 	 * @throws \Aimeos\MShop\Locale\Exception If no total value was found
 	 * @return integer Total number of found items

Spacing +3 added lines, -3 removed lines

@@ -369,7 +369,7 @@ 
 			$replace = array(
 				$search->getConditionString( $types, $translations ),
 				$search->getSortationString( $types, $translations ),
-				( $columns ? ', ' . $columns : '' ),
+				( $columns ? ', '.$columns : '' ),
 				$search->getSliceStart(),
 				$search->getSliceSize(),
 			);
@@ -581,7 +581,7 @@ 
 		 * @see mshop/locale/manager/currency/decorators/global
 		 */
 
-		return $this->getSubManagerBase( 'locale', 'currency/' . $manager, $name );
+		return $this->getSubManagerBase( 'locale', 'currency/'.$manager, $name );
 	}
 
 
@@ -611,7 +611,7 @@ 
 	protected function getSearchResults( \Aimeos\MW\DB\Connection\Iface $conn, $sql )
 	{
 		$statement = $conn->create( $sql );
-		$this->getContext()->getLogger()->log( __METHOD__ . ': SQL statement: ' . $statement, \Aimeos\MW\Logger\Base::DEBUG );
+		$this->getContext()->getLogger()->log( __METHOD__.': SQL statement: '.$statement, \Aimeos\MW\Logger\Base::DEBUG );
 
 		$results = $statement->execute();
 

Braces +6 added lines, -4 removed lines

@@ -105,9 +105,12 @@ 
 	 */
 	public function createItem()
 	{
-		try {
+		try
+		{
 			$values = array( 'locale.currency.siteid' => $this->getContext()->getLocale()->getSiteId() );
-		} catch( \Exception $ex ) {
+		}
+		catch( \Exception $ex )
+		{
 			$values = array( 'locale.currency.siteid' => null );
 		}
 
@@ -177,8 +180,7 @@ 
 				 * @see mshop/locale/manager/currency/standard/count/ansi
 				 */
 				$path = 'mshop/locale/manager/currency/standard/insert';
-			}
-			else
+			} else
 			{
 				/** mshop/locale/manager/currency/standard/update/mysql
 				 * Updates an existing currency record in the database

lib/mshoplib/src/MShop/Plugin/Provider/Order/Shipping.php

Braces +6 added lines, -4 removed lines

@@ -55,9 +55,12 @@ 
 		$config = $this->getItemBase()->getConfig();
 		if( !isset( $config['threshold'] ) ) { return true; }
 
-		try {
+		try
+		{
 			$delivery = $order->getService( 'delivery' );
-		} catch( \Aimeos\MShop\Order\Exception $oe ) {
+		}
+		catch( \Aimeos\MShop\Order\Exception $oe )
+		{
 			// no delivery item available yet
 			return true;
 		}
@@ -94,8 +97,7 @@ 
 		{
 			$price->setRebate( $price->getCosts() );
 			$price->setCosts( '0.00' );
-		}
-		else if( $sum->getValue() + $sum->getRebate() < $threshold[$currency] && $price->getRebate() > '0.00' )
+		} else if( $sum->getValue() + $sum->getRebate() < $threshold[$currency] && $price->getRebate() > '0.00' )
 		{
 			$price->setCosts( $price->getRebate() );
 			$price->setRebate( '0.00' );

lib/mshoplib/src/MShop/Index/Manager/Price/Standard.php

Spacing +2 added lines, -2 removed lines

@@ -402,7 +402,7 @@ 
 		 * @see mshop/index/manager/price/decorators/global
 		 */
 
-		return $this->getSubManagerBase( 'index', 'price/' . $manager, $name );
+		return $this->getSubManagerBase( 'index', 'price/'.$manager, $name );
 	}
 
 
@@ -733,7 +733,7 @@ 
 
 				try {
 					$stmt->execute()->finish();
-				} catch( \Aimeos\MW\DB\Exception $e ) { ; } // Ignore duplicates
+				} catch( \Aimeos\MW\DB\Exception $e ) {; } // Ignore duplicates
 			}
 		}
 	}

Braces +6 added lines, -2 removed lines

@@ -731,9 +731,13 @@
 				$stmt->bind( 13, $editor );
 				$stmt->bind( 14, $date ); //ctime
 
-				try {
+				try
+				{
 					$stmt->execute()->finish();
-				} catch( \Aimeos\MW\DB\Exception $e ) { ; } // Ignore duplicates
+				}
+				catch( \Aimeos\MW\DB\Exception $e )
+				{
+; } // Ignore duplicates
 			}
 		}
 	}

lib/mshoplib/src/MShop/Index/Manager/Attribute/Standard.php

Spacing +2 added lines, -2 removed lines

@@ -358,7 +358,7 @@ 
 		 * @see mshop/index/manager/attribute/decorators/global
 		 */
 
-		return $this->getSubManagerBase( 'index', 'attribute/' . $manager, $name );
+		return $this->getSubManagerBase( 'index', 'attribute/'.$manager, $name );
 	}
 
 
@@ -683,7 +683,7 @@ 
 
 				try {
 					$stmt->execute()->finish();
-				} catch( \Aimeos\MW\DB\Exception $e ) { ; } // Ignore duplicates
+				} catch( \Aimeos\MW\DB\Exception $e ) {; } // Ignore duplicates
 			}
 		}
 	}

Braces +6 added lines, -2 removed lines

@@ -681,9 +681,13 @@
 				$stmt->bind( 8, $editor );
 				$stmt->bind( 9, $date ); // ctime
 
-				try {
+				try
+				{
 					$stmt->execute()->finish();
-				} catch( \Aimeos\MW\DB\Exception $e ) { ; } // Ignore duplicates
+				}
+				catch( \Aimeos\MW\DB\Exception $e )
+				{
+; } // Ignore duplicates
 			}
 		}
 	}