Simple::exec() - Code Metrics - Inspection of "Reconnect to database if an error occurs" - aimeos/aimeos-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 212c5f...8d6a89 )

by Aimeos

created 2017-05-25 18:39 UTC

Simple::exec() A

↳ Parent: Simple

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Metaways Infosystems GmbH, 2011
 * @copyright Aimeos (aimeos.org), 2015-2016
 * @package MW
 * @subpackage DB
 */


namespace Aimeos\MW\DB\Statement\PDO;


/**
 * Database statement class for simple PDO statements
 *
 * @package MW
 * @subpackage DB
 */
class Simple extends \Aimeos\MW\DB\Statement\Base implements \Aimeos\MW\DB\Statement\Iface
{
	private $binds = [];
	private $parts;
	private $sql;


	/**
	 * Initializes the statement object
	 *
	 * @param \Aimeos\MW\DB\Connection\PDO $conn Database connection object
	 * @param string $sql SQL statement
	 */
	public function __construct( \Aimeos\MW\DB\Connection\PDO $conn, $sql )
	{
		parent::__construct( $conn );

		$this->parts = $this->getSqlParts( $sql );
	}


	/**
	 * Binds a value to a parameter in the statement.
	 *
	 * @param integer $position Position index of the placeholder
	 * @param mixed $value Value which should be bound to the placeholder
	 * @param integer $type Type of given value defined in \Aimeos\MW\DB\Statement\Base as constant
	 */
	public function bind( $position, $value, $type = \Aimeos\MW\DB\Statement\Base::PARAM_STR )
	{
		if( is_null( $value ) ) {
			$this->binds[$position] = 'NULL'; return;
		}

		switch( $type )
		{
			case \Aimeos\MW\DB\Statement\Base::PARAM_NULL:
				$this->binds[$position] = 'NULL'; break;
			case \Aimeos\MW\DB\Statement\Base::PARAM_BOOL:
				$this->binds[$position] = (int) (bool) $value; break;
			case \Aimeos\MW\DB\Statement\Base::PARAM_INT:
				$this->binds[$position] = (int) $value; break;
			case \Aimeos\MW\DB\Statement\Base::PARAM_FLOAT:
				$this->binds[$position] = (float) $value; break;
			case \Aimeos\MW\DB\Statement\Base::PARAM_STR:
				$this->binds[$position] = $this->getConnection()->getRawObject()->quote( $value ); break;
			default:
				throw new \Aimeos\MW\DB\Exception( sprintf( 'Invalid parameter type "%1$s"', $type ) );
		}

		$this->sql = null;
	}


	/**
	 * Executes the statement.
	 *
	 * @return \Aimeos\MW\DB\Result\Iface Result object
	 * @throws \Aimeos\MW\DB\Exception If an error occured in the unterlying driver or if the number of binds doesn't match
	 */
	public function execute()
	{
		if( count( $this->binds ) !== count( $this->parts ) - 1 )
		{
			$msg = 'Number of binds (%1$d) doesn\'t match the number of markers in "%2$s"';
			throw new \Aimeos\MW\DB\Exception( sprintf( $msg, count( $this->binds ), implode( '?', $this->parts ) ) );
		}

		try
		{
			$result = $this->exec();
		}
		catch( \PDOException $e )
		{
			try {
				$result = $this->reconnect( $e )->exec();
			} catch( \PDOException $e ) {
				throw new \Aimeos\MW\DB\Exception( $e->getMessage(), $e->getCode() );
			}
		}

		return new \Aimeos\MW\DB\Result\PDO( $result );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}


	/**
	 * Returns the SQL string as sent to the database (magic PHP method)
	 *
	 * @return string SQL statement

	 */
	public function __toString()
	{
		if( $this->sql === null ) {
			$this->sql = $this->buildSQL( $this->parts, $this->binds );
		}

		return $this->sql;
	}


	/**
	 * Binds the parameters and executes the SQL statment
	 *
	 * @return \Doctrine\DBAL\Driver\Statement Executed DBAL statement
	 */
	protected function exec()
	{
		if( $this->sql === null ) {
			$this->sql = $this->buildSQL( $this->parts, $this->binds );
		}

		return $this->getConnection()->getRawObject()->query( $this->sql );
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Metaways Infosystems GmbH, 2011
6			* @copyright Aimeos (aimeos.org), 2015-2016
7			* @package MW
8			* @subpackage DB
9			*/
10
11
12			namespace Aimeos\MW\DB\Statement\PDO;
13
14
15			/**
16			* Database statement class for simple PDO statements
17			*
18			* @package MW
19			* @subpackage DB
20			*/
21			class Simple extends \Aimeos\MW\DB\Statement\Base implements \Aimeos\MW\DB\Statement\Iface
22			{
23			private $binds = [];
24			private $parts;
25			private $sql;
26
27
28			/**
29			* Initializes the statement object
30			*
31			* @param \Aimeos\MW\DB\Connection\PDO $conn Database connection object
32			* @param string $sql SQL statement
33			*/
34			public function __construct( \Aimeos\MW\DB\Connection\PDO $conn, $sql )
35			{
36			parent::__construct( $conn );
37
38			$this->parts = $this->getSqlParts( $sql );
39			}
40
41
42			/**
43			* Binds a value to a parameter in the statement.
44			*
45			* @param integer $position Position index of the placeholder
46			* @param mixed $value Value which should be bound to the placeholder
47			* @param integer $type Type of given value defined in \Aimeos\MW\DB\Statement\Base as constant
48			*/
49			public function bind( $position, $value, $type = \Aimeos\MW\DB\Statement\Base::PARAM_STR )
50			{
51			if( is_null( $value ) ) {
52			$this->binds[$position] = 'NULL'; return;
53			}
54
55			switch( $type )
56			{
57			case \Aimeos\MW\DB\Statement\Base::PARAM_NULL:
58			$this->binds[$position] = 'NULL'; break;
59			case \Aimeos\MW\DB\Statement\Base::PARAM_BOOL:
60			$this->binds[$position] = (int) (bool) $value; break;
61			case \Aimeos\MW\DB\Statement\Base::PARAM_INT:
62			$this->binds[$position] = (int) $value; break;
63			case \Aimeos\MW\DB\Statement\Base::PARAM_FLOAT:
64			$this->binds[$position] = (float) $value; break;
65			case \Aimeos\MW\DB\Statement\Base::PARAM_STR:
66			$this->binds[$position] = $this->getConnection()->getRawObject()->quote( $value ); break;
67			default:
68			throw new \Aimeos\MW\DB\Exception( sprintf( 'Invalid parameter type "%1$s"', $type ) );
69			}
70
71			$this->sql = null;
72			}
73
74
75			/**
76			* Executes the statement.
77			*
78			* @return \Aimeos\MW\DB\Result\Iface Result object
79			* @throws \Aimeos\MW\DB\Exception If an error occured in the unterlying driver or if the number of binds doesn't match
80			*/
81			public function execute()
82			{
83			if( count( $this->binds ) !== count( $this->parts ) - 1 )
84			{
85			$msg = 'Number of binds (%1$d) doesn\'t match the number of markers in "%2$s"';
86			throw new \Aimeos\MW\DB\Exception( sprintf( $msg, count( $this->binds ), implode( '?', $this->parts ) ) );
87			}
88
89			try
90			{
91			$result = $this->exec();
92			}
93			catch( \PDOException $e )
94			{
95			try {
96			$result = $this->reconnect( $e )->exec();
97			} catch( \PDOException $e ) {
98			throw new \Aimeos\MW\DB\Exception( $e->getMessage(), $e->getCode() );
99			}
100			}
101
102			return new \Aimeos\MW\DB\Result\PDO( $result );
			0 ignored issues – show Documentation introduced 2017-05-25 18:48 UTC by Report Bug Copy Issue Report `$result` is of type `object<Doctrine\DBAL\Driver\Statement>`, but the function expects a `object<PDOStatement>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
103			}
104
105
106			/**
107			* Returns the SQL string as sent to the database (magic PHP method)
108			*
109			* @return string SQL statement
			0 ignored issues – show Documentation introduced 2017-05-25 18:48 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
110			*/
111			public function __toString()
112			{
113			if( $this->sql === null ) {
114			$this->sql = $this->buildSQL( $this->parts, $this->binds );
115			}
116
117			return $this->sql;
118			}
119
120
121			/**
122			* Binds the parameters and executes the SQL statment
123			*
124			* @return \Doctrine\DBAL\Driver\Statement Executed DBAL statement
125			*/
126			protected function exec()
127			{
128			if( $this->sql === null ) {
129			$this->sql = $this->buildSQL( $this->parts, $this->binds );
130			}
131
132			return $this->getConnection()->getRawObject()->query( $this->sql );
133			}
134			}
135

aimeos / aimeos-core

Push — master ( 212c5f...8d6a89 )

Simple::exec() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like