ServicesUpdate::update() - Code Metrics - Inspection of "Moved plugin singleton check to own decorator" - aimeos/aimeos-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dc433d...4234c3 )

by Aimeos

created 2017-05-04 21:37 UTC

ServicesUpdate::update() B

↳ Parent: ServicesUpdate

Complexity

Conditions	8
Paths	11

Size

Total Lines	60
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
eloc	30
c	1
b	0
f	0
nc	11
nop	3
dl	0
loc	60
rs	7.0677

How to fix Long Method

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Metaways Infosystems GmbH, 2014
 * @copyright Aimeos (aimeos.org), 2015-2016
 * @package MShop
 * @subpackage Plugin
 */


namespace Aimeos\MShop\Plugin\Provider\Order;


/**
 * Updates service items on basket change.
 *
 * @package MShop
 * @subpackage Plugin
 */
class ServicesUpdate
	extends \Aimeos\MShop\Plugin\Provider\Factory\Base

	implements \Aimeos\MShop\Plugin\Provider\Factory\Iface
{
	/**
	 * Subscribes itself to a publisher
	 *
	 * @param \Aimeos\MW\Observer\Publisher\Iface $p Object implementing publisher interface
	 */
	public function register( \Aimeos\MW\Observer\Publisher\Iface $p )
	{
		$p->addListener( $this->getObject(), 'setAddress.after' );
		$p->addListener( $this->getObject(), 'deleteAddress.after' );
		$p->addListener( $this->getObject(), 'addProduct.after' );
		$p->addListener( $this->getObject(), 'deleteProduct.after' );
		$p->addListener( $this->getObject(), 'addCoupon.after' );
		$p->addListener( $this->getObject(), 'deleteCoupon.after' );
	}


	/**
	 * Receives a notification from a publisher object
	 *
	 * @param \Aimeos\MW\Observer\Publisher\Iface $order Shop basket instance implementing publisher interface
	 * @param string $action Name of the action to listen for
	 * @param mixed $value Object or value changed in publisher
	 * @throws \Aimeos\MShop\Plugin\Provider\Exception if checks fail
	 * @return bool true if checks succeed
	 */
	public function update( \Aimeos\MW\Observer\Publisher\Iface $order, $action, $value = null )
	{
		if( !( $order instanceof \Aimeos\MShop\Order\Item\Base\Iface ) )
		{
			$msg = $this->getContext()->getI18n()->dt( 'mshop', 'Object is not of required type "%1$s"' );
			throw new \Aimeos\MShop\Plugin\Exception( sprintf( $msg, '\Aimeos\MShop\Order\Item\Base\Iface' ) );
		}

		$ids = [];
		$context = $this->getContext();
		$services = $order->getServices();


		if( count( $order->getProducts() ) === 0 )
		{
			$priceManager = \Aimeos\MShop\Factory::createManager( $context, 'price' );

			foreach( $services as $type => $service ) {
				$service->setPrice( $priceManager->createItem() );
			}

			return true;
		}


		foreach( $services as $type => $service ) {
			$ids[$type] = $service->getServiceId();
		}

		$serviceManager = \Aimeos\MShop\Factory::createManager( $context, 'service' );

		$search = $serviceManager->createSearch( true );
		$expr = array(
			$search->compare( '==', 'service.id', $ids ),
			$search->getConditions(),
		);
		$search->setConditions( $search->combine( '&&', $expr ) );

		$result = $serviceManager->searchItems( $search, array( 'price' ) );


		foreach( $services as $type => $service )
		{
			if( isset( $result[$service->getServiceId()] ) )
			{
				$provider = $serviceManager->getProvider( $result[$service->getServiceId()] );

				if( $provider->isAvailable( $order ) )
				{
					$service->setPrice( $provider->calcPrice( $order ) );
					$order->setService( $service, $type );
					continue;
				}
			}

			$order->deleteService( $type );
		}

		return true;
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Metaways Infosystems GmbH, 2014
6			* @copyright Aimeos (aimeos.org), 2015-2016
7			* @package MShop
8			* @subpackage Plugin
9			*/
10
11
12			namespace Aimeos\MShop\Plugin\Provider\Order;
13
14
15			/**
16			* Updates service items on basket change.
17			*
18			* @package MShop
19			* @subpackage Plugin
20			*/
21			class ServicesUpdate
22			extends \Aimeos\MShop\Plugin\Provider\Factory\Base
			0 ignored issues – show Coding Style introduced 2016-02-05 10:43 UTC by Report Bug Copy Issue Report Expected 0 spaces between "Base" and comma; 1 found Loading history...
23			implements \Aimeos\MShop\Plugin\Provider\Factory\Iface
24			{
25			/**
26			* Subscribes itself to a publisher
27			*
28			* @param \Aimeos\MW\Observer\Publisher\Iface $p Object implementing publisher interface
29			*/
30			public function register( \Aimeos\MW\Observer\Publisher\Iface $p )
31			{
32			$p->addListener( $this->getObject(), 'setAddress.after' );
33			$p->addListener( $this->getObject(), 'deleteAddress.after' );
34			$p->addListener( $this->getObject(), 'addProduct.after' );
35			$p->addListener( $this->getObject(), 'deleteProduct.after' );
36			$p->addListener( $this->getObject(), 'addCoupon.after' );
37			$p->addListener( $this->getObject(), 'deleteCoupon.after' );
38			}
39
40
41			/**
42			* Receives a notification from a publisher object
43			*
44			* @param \Aimeos\MW\Observer\Publisher\Iface $order Shop basket instance implementing publisher interface
45			* @param string $action Name of the action to listen for
46			* @param mixed $value Object or value changed in publisher
47			* @throws \Aimeos\MShop\Plugin\Provider\Exception if checks fail
48			* @return bool true if checks succeed
49			*/
50			public function update( \Aimeos\MW\Observer\Publisher\Iface $order, $action, $value = null )
51			{
52			if( !( $order instanceof \Aimeos\MShop\Order\Item\Base\Iface ) )
53			{
54			$msg = $this->getContext()->getI18n()->dt( 'mshop', 'Object is not of required type "%1$s"' );
55			throw new \Aimeos\MShop\Plugin\Exception( sprintf( $msg, '\Aimeos\MShop\Order\Item\Base\Iface' ) );
56			}
57
58			$ids = [];
59			$context = $this->getContext();
60			$services = $order->getServices();
61
62
63			if( count( $order->getProducts() ) === 0 )
64			{
65			$priceManager = \Aimeos\MShop\Factory::createManager( $context, 'price' );
66
67			foreach( $services as $type => $service ) {
68			$service->setPrice( $priceManager->createItem() );
69			}
70
71			return true;
72			}
73
74
75			foreach( $services as $type => $service ) {
76			$ids[$type] = $service->getServiceId();
77			}
78
79			$serviceManager = \Aimeos\MShop\Factory::createManager( $context, 'service' );
80
81			$search = $serviceManager->createSearch( true );
82			$expr = array(
83			$search->compare( '==', 'service.id', $ids ),
84			$search->getConditions(),
85			);
86			$search->setConditions( $search->combine( '&&', $expr ) );
87
88			$result = $serviceManager->searchItems( $search, array( 'price' ) );
89
90
91			foreach( $services as $type => $service )
92			{
93			if( isset( $result[$service->getServiceId()] ) )
94			{
95			$provider = $serviceManager->getProvider( $result[$service->getServiceId()] );
96
97			if( $provider->isAvailable( $order ) )
98			{
99			$service->setPrice( $provider->calcPrice( $order ) );
100			$order->setService( $service, $type );
101			continue;
102			}
103			}
104
105			$order->deleteService( $type );
106			}
107
108			return true;
109			}
110			}
111

aimeos / aimeos-core

Push — master ( dc433d...4234c3 )

ServicesUpdate::update() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like