Inspection of "Handle bool values in search criteria for PostgreS..." - aimeos/aimeos-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f21277...f08cc9 )

by Aimeos

created 2018-11-24 15:57 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -35,25 +35,25 @@
 block discarded – undo
 	 */
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
 	public function testGet()
 	{
-		$this->assertEquals(null, $this->object->get('test'));
+		$this->assertEquals( null, $this->object->get( 'test' ) );
 
-		$this->object->set('test', '123456789');
-		$this->assertEquals('123456789', $this->object->get('test'));
+		$this->object->set( 'test', '123456789' );
+		$this->assertEquals( '123456789', $this->object->get( 'test' ) );
 	}
 
 
 	public function testSet()
 	{
-		$this->object->set('test', null);
+		$this->object->set( 'test', null );
 		$this->assertEquals( null, $this->object->get( 'test' ) );
 
-		$this->object->set('test', '234');
+		$this->object->set( 'test', '234' );
 		$this->assertEquals( '234', $this->object->get( 'test' ) );
 	}
 }

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Session/PHPTest.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -23,25 +23,25 @@
 block discarded – undo
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
 	public function testGet()
 	{
-		$this->assertEquals(null, $this->object->get('test'));
+		$this->assertEquals( null, $this->object->get( 'test' ) );
 
-		$this->object->set('test', '123456789');
-		$this->assertEquals('123456789', $this->object->get('test'));
+		$this->object->set( 'test', '123456789' );
+		$this->assertEquals( '123456789', $this->object->get( 'test' ) );
 	}
 
 
 	public function testSet()
 	{
-		$this->object->set('test', null);
+		$this->object->set( 'test', null );
 		$this->assertEquals( null, $this->object->get( 'test' ) );
 
-		$this->object->set('test', '234');
+		$this->object->set( 'test', '234' );
 		$this->assertEquals( '234', $this->object->get( 'test' ) );
 	}
 }

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Container/FactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
 
 	public function testFactoryFail()
 	{
-		$this->setExpectedException('\\Aimeos\\MW\\Container\\Exception');
+		$this->setExpectedException( '\\Aimeos\\MW\\Container\\Exception' );
 		\Aimeos\MW\Container\Factory::getContainer( 'tempfile', 'notDefined', 'invalid' );
 	}
 }

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Template/SQLTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@
 block discarded – undo
 
 	public function testToString()
 	{
-		$template = $this->object->get('FROM');
+		$template = $this->object->get( 'FROM' );
 		$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
 
 		$this->assertEquals( 'table', $template->str() );

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Template/T3Test.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -42,7 +42,7 @@
 block discarded – undo
 
 	public function testToString()
 	{
-		$template = $this->object->get('NAME');
+		$template = $this->object->get( 'NAME' );
 		$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
 
 		$this->assertEquals( 'Name', $template->str() );

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Template/BaseTest.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -55,28 +55,28 @@  discard block
 block discarded – undo
 
 	public function testDisable()
 	{
-		$this->assertEquals('
+		$this->assertEquals( '
 <div> text</div>
 ',
-		$this->object->get('ITEM')->disable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
+		$this->object->get( 'ITEM' )->disable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
 	}
 
 
 	public function testEnable()
 	{
-		$this->assertEquals('
+		$this->assertEquals( '
 <div>1 text</div>
 ',
-		$this->object->get('ITEM')->enable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
+		$this->object->get( 'ITEM' )->enable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
 	}
 
 
 	public function testGet()
 	{
-		$template = $this->object->get('TEMPLATE');
+		$template = $this->object->get( 'TEMPLATE' );
 		$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
 
-		$this->assertEquals('
+		$this->assertEquals( '
 test template
 <!--###LIST-->
 <!--###ITEM-->
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
 
 	public function testGetBeginIsNotDefined()
 	{
-		$this->setExpectedException('\\Aimeos\\MW\\Template\\Exception');
-		$this->object->get('NOTDEFINED');
+		$this->setExpectedException( '\\Aimeos\\MW\\Template\\Exception' );
+		$this->object->get( 'NOTDEFINED' );
 	}
 
 	public function testGetEndIsNotDefined()
@@ -113,24 +113,24 @@  discard block
 block discarded – undo
 
 		$object = new \Aimeos\MW\Template\Base( $template, '<!--###$-->', '<!--$###-->' );
 
-		$this->setExpectedException('\\Aimeos\\MW\\Template\\Exception');
-		$object->get('ITEM');
+		$this->setExpectedException( '\\Aimeos\\MW\\Template\\Exception' );
+		$object->get( 'ITEM' );
 	}
 
 
 
 	public function testGetMarkerNames()
 	{
-		$this->assertEquals( array('TEMPLATE', 'LIST', 'ITEM', 'NUM', 'TEXT'), $this->object->getMarkerNames() );
+		$this->assertEquals( array( 'TEMPLATE', 'LIST', 'ITEM', 'NUM', 'TEXT' ), $this->object->getMarkerNames() );
 	}
 
 
 	public function testReplace()
 	{
-		$this->assertEquals('
+		$this->assertEquals( '
 <div><!--###NUM-->1<!--NUM###--> <!--###TEXT-->example test<!--TEXT###--></div>
 ',
-		$this->object->get('ITEM')->replace( 'text', 'test' )->str( false ) );
+		$this->object->get( 'ITEM' )->replace( 'text', 'test' )->str( false ) );
 	}
 
 
@@ -141,10 +141,10 @@  discard block
 block discarded – undo
 			'TEXT' => 'test'
 		);
 
-		$this->assertEquals('
+		$this->assertEquals( '
 <div>123 test</div>
 ',
-			$this->object->get('ITEM')->substitute( $marker )->str()
+			$this->object->get( 'ITEM' )->substitute( $marker )->str()
 		);
 	}
 
@@ -168,16 +168,16 @@  discard block
 block discarded – undo
 
 		$object = new \Aimeos\MW\Template\Base( $template, '<!--###$-->', '<!--$###-->' );
 
-		$this->setExpectedException('\\Aimeos\\MW\\Template\\Exception');
-		$object->substitute( array('ITEM'=>'Title' ) );
+		$this->setExpectedException( '\\Aimeos\\MW\\Template\\Exception' );
+		$object->substitute( array( 'ITEM'=>'Title' ) );
 	}
 
 	public function testStr()
 	{
-		$template = $this->object->get('TEMPLATE');
+		$template = $this->object->get( 'TEMPLATE' );
 		$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
 
-		$this->assertEquals('
+		$this->assertEquals( '
 test template
 
 ',

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Config/testowrite/config.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 
 return array(
-	'manager' => array (
+	'manager' => array(
 		'default' => array(
 			'select' => 'select11',
 		),

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Config/testowrite/subconfig/default.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 
 return array(
-	'subitem' => array (
+	'subitem' => array(
 		'a' => array(
 			'aa' => '111',
 		),

Please login to merge, or discard this patch.

lib/mwlib/tests/MW/Config/testfiles/config.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 
 return array(
-	'manager' => array (
+	'manager' => array(
 		'default' => array(
 			'select' => 'select1',
 		),
 	),
 	'provider' => array(
-		'delivery' => array (
+		'delivery' => array(
 			'sh' => array(
 				'select' => 'select2',
 			),

Please login to merge, or discard this patch.

		@@ -35,25 +35,25 @@
		block discarded – undo
35	35	*/
36	36	protected function tearDown()
37	37	{
38		- unset($this->object);
	38	+ unset( $this->object );
39	39	}
40	40
41	41
42	42	public function testGet()
43	43	{
44		- $this->assertEquals(null, $this->object->get('test'));
	44	+ $this->assertEquals( null, $this->object->get( 'test' ) );
45	45
46		- $this->object->set('test', '123456789');
47		- $this->assertEquals('123456789', $this->object->get('test'));
	46	+ $this->object->set( 'test', '123456789' );
	47	+ $this->assertEquals( '123456789', $this->object->get( 'test' ) );
48	48	}
49	49
50	50
51	51	public function testSet()
52	52	{
53		- $this->object->set('test', null);
	53	+ $this->object->set( 'test', null );
54	54	$this->assertEquals( null, $this->object->get( 'test' ) );
55	55
56		- $this->object->set('test', '234');
	56	+ $this->object->set( 'test', '234' );
57	57	$this->assertEquals( '234', $this->object->get( 'test' ) );
58	58	}
59	59	}

		@@ -55,28 +55,28 @@ discard block
		block discarded – undo
55	55
56	56	public function testDisable()
57	57	{
58		- $this->assertEquals('
	58	+ $this->assertEquals( '
59	59	<div> text</div>
60	60	',
61		- $this->object->get('ITEM')->disable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
	61	+ $this->object->get( 'ITEM' )->disable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
62	62	}
63	63
64	64
65	65	public function testEnable()
66	66	{
67		- $this->assertEquals('
	67	+ $this->assertEquals( '
68	68	<div>1 text</div>
69	69	',
70		- $this->object->get('ITEM')->enable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
	70	+ $this->object->get( 'ITEM' )->enable( 'NUM' )->substitute( array( 'TEXT' => 'text' ) )->str() );
71	71	}
72	72
73	73
74	74	public function testGet()
75	75	{
76		- $template = $this->object->get('TEMPLATE');
	76	+ $template = $this->object->get( 'TEMPLATE' );
77	77	$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
78	78
79		- $this->assertEquals('
	79	+ $this->assertEquals( '
80	80	test template
81	81	<!--###LIST-->
82	82	<!--###ITEM-->
		@@ -89,8 +89,8 @@ discard block
		block discarded – undo
89	89
90	90	public function testGetBeginIsNotDefined()
91	91	{
92		- $this->setExpectedException('\\Aimeos\\MW\\Template\\Exception');
93		- $this->object->get('NOTDEFINED');
	92	+ $this->setExpectedException( '\\Aimeos\\MW\\Template\\Exception' );
	93	+ $this->object->get( 'NOTDEFINED' );
94	94	}
95	95
96	96	public function testGetEndIsNotDefined()
		@@ -113,24 +113,24 @@ discard block
		block discarded – undo
113	113
114	114	$object = new \Aimeos\MW\Template\Base( $template, '<!--###$-->', '<!--$###-->' );
115	115
116		- $this->setExpectedException('\\Aimeos\\MW\\Template\\Exception');
117		- $object->get('ITEM');
	116	+ $this->setExpectedException( '\\Aimeos\\MW\\Template\\Exception' );
	117	+ $object->get( 'ITEM' );
118	118	}
119	119
120	120
121	121
122	122	public function testGetMarkerNames()
123	123	{
124		- $this->assertEquals( array('TEMPLATE', 'LIST', 'ITEM', 'NUM', 'TEXT'), $this->object->getMarkerNames() );
	124	+ $this->assertEquals( array( 'TEMPLATE', 'LIST', 'ITEM', 'NUM', 'TEXT' ), $this->object->getMarkerNames() );
125	125	}
126	126
127	127
128	128	public function testReplace()
129	129	{
130		- $this->assertEquals('
	130	+ $this->assertEquals( '
131	131	<div><!--###NUM-->1<!--NUM###--> <!--###TEXT-->example test<!--TEXT###--></div>
132	132	',
133		- $this->object->get('ITEM')->replace( 'text', 'test' )->str( false ) );
	133	+ $this->object->get( 'ITEM' )->replace( 'text', 'test' )->str( false ) );
134	134	}
135	135
136	136
		@@ -141,10 +141,10 @@ discard block
		block discarded – undo
141	141	'TEXT' => 'test'
142	142	);
143	143
144		- $this->assertEquals('
	144	+ $this->assertEquals( '
145	145	<div>123 test</div>
146	146	',
147		- $this->object->get('ITEM')->substitute( $marker )->str()
	147	+ $this->object->get( 'ITEM' )->substitute( $marker )->str()
148	148	);
149	149	}
150	150
		@@ -168,16 +168,16 @@ discard block
		block discarded – undo
168	168
169	169	$object = new \Aimeos\MW\Template\Base( $template, '<!--###$-->', '<!--$###-->' );
170	170
171		- $this->setExpectedException('\\Aimeos\\MW\\Template\\Exception');
172		- $object->substitute( array('ITEM'=>'Title' ) );
	171	+ $this->setExpectedException( '\\Aimeos\\MW\\Template\\Exception' );
	172	+ $object->substitute( array( 'ITEM'=>'Title' ) );
173	173	}
174	174
175	175	public function testStr()
176	176	{
177		- $template = $this->object->get('TEMPLATE');
	177	+ $template = $this->object->get( 'TEMPLATE' );
178	178	$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
179	179
180		- $this->assertEquals('
	180	+ $this->assertEquals( '
181	181	test template
182	182
183	183	',

		@@ -23,25 +23,25 @@
		block discarded – undo
23	23
24	24	protected function tearDown()
25	25	{
26		- unset($this->object);
	26	+ unset( $this->object );
27	27	}
28	28
29	29
30	30	public function testGet()
31	31	{
32		- $this->assertEquals(null, $this->object->get('test'));
	32	+ $this->assertEquals( null, $this->object->get( 'test' ) );
33	33
34		- $this->object->set('test', '123456789');
35		- $this->assertEquals('123456789', $this->object->get('test'));
	34	+ $this->object->set( 'test', '123456789' );
	35	+ $this->assertEquals( '123456789', $this->object->get( 'test' ) );
36	36	}
37	37
38	38
39	39	public function testSet()
40	40	{
41		- $this->object->set('test', null);
	41	+ $this->object->set( 'test', null );
42	42	$this->assertEquals( null, $this->object->get( 'test' ) );
43	43
44		- $this->object->set('test', '234');
	44	+ $this->object->set( 'test', '234' );
45	45	$this->assertEquals( '234', $this->object->get( 'test' ) );
46	46	}
47	47	}

		@@ -20,7 +20,7 @@
		block discarded – undo
20	20
21	21	public function testFactoryFail()
22	22	{
23		- $this->setExpectedException('\\Aimeos\\MW\\Container\\Exception');
	23	+ $this->setExpectedException( '\\Aimeos\\MW\\Container\\Exception' );
24	24	\Aimeos\MW\Container\Factory::getContainer( 'tempfile', 'notDefined', 'invalid' );
25	25	}
26	26	}

		@@ -35,7 +35,7 @@
		block discarded – undo
35	35
36	36	public function testToString()
37	37	{
38		- $template = $this->object->get('FROM');
	38	+ $template = $this->object->get( 'FROM' );
39	39	$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
40	40
41	41	$this->assertEquals( 'table', $template->str() );

		@@ -42,7 +42,7 @@
		block discarded – undo
42	42
43	43	public function testToString()
44	44	{
45		- $template = $this->object->get('NAME');
	45	+ $template = $this->object->get( 'NAME' );
46	46	$this->assertInstanceOf( '\\Aimeos\\MW\\Template\\Iface', $template );
47	47
48	48	$this->assertEquals( 'Name', $template->str() );

		@@ -1,7 +1,7 @@
		block discarded – undo
1	1	<?php
2	2
3	3	return array(
4		- 'manager' => array (
	4	+ 'manager' => array(
5	5	'default' => array(
6	6	'select' => 'select11',
7	7	),

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2
3	3	return array(
4		- 'manager' => array (
	4	+ 'manager' => array(
5	5	'default' => array(
6	6	'select' => 'select1',
7	7	),
8	8	),
9	9	'provider' => array(
10		- 'delivery' => array (
	10	+ 'delivery' => array(
11	11	'sh' => array(
12	12	'select' => 'select2',
13	13	),

aimeos / aimeos-core

Push — master ( f21277...f08cc9 )

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch