PgSQL - Code Metrics - Inspection of "Moved escape() to criteria expression trait and al..." - aimeos/aimeos-base - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6a58b9...6d010e )

by Aimeos

created 2023-08-27 10:43 UTC

PgSQL A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	5
eloc	8
c	1
b	0
f	0
dl	0
loc	23
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	escape()	0	13	5

<?php

/**
 * @license LGPLv3, https://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2018-2023
 * @package Base
 * @subpackage Common
 */


namespace Aimeos\Base\Criteria\Expression\Compare;


/**
 * PostgreSQL implementation for comparing objects
 *
 * @package Base
 * @subpackage Common
 */
class PgSQL extends SQL
{
	/**
	 * Escapes the value so it can be inserted into a SQL statement
	 *
	 * @param string $operator Operator used for the expression
	 * @param string $type Type constant
	 * @param mixed $value Value that the variable or column should be compared to
	 * @return double|string|integer Escaped value
	 */
	protected function escape( string $operator, string $type, $value )
	{
		$value = $this->translateValue( $this->getName(), $value, $type );

		switch( $type )
		{
			case 'bool':
			case 'boolean':
			case \Aimeos\Base\DB\Statement\Base::PARAM_BOOL:
				return ( $value ? "'t'" : "'f'" ); break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
		}

		return parent::escape( $operator, $type, $value );
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, https://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2018-2023
6			* @package Base
7			* @subpackage Common
8			*/
9
10
11			namespace Aimeos\Base\Criteria\Expression\Compare;
12
13
14			/**
15			* PostgreSQL implementation for comparing objects
16			*
17			* @package Base
18			* @subpackage Common
19			*/
20			class PgSQL extends SQL
21			{
22			/**
23			* Escapes the value so it can be inserted into a SQL statement
24			*
25			* @param string $operator Operator used for the expression
26			* @param string $type Type constant
27			* @param mixed $value Value that the variable or column should be compared to
28			* @return double\|string\|integer Escaped value
29			*/
30			protected function escape( string $operator, string $type, $value )
31			{
32			$value = $this->translateValue( $this->getName(), $value, $type );
33
34			switch( $type )
35			{
36			case 'bool':
37			case 'boolean':
38			case \Aimeos\Base\DB\Statement\Base::PARAM_BOOL:
39			return ( $value ? "'t'" : "'f'" ); break;
			0 ignored issues – show Unused Code introduced 2023-08-27 10:45 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
40			}
41
42			return parent::escape( $operator, $type, $value );
43			}
44			}
45

aimeos / aimeos-base

Push — master ( 6a58b9...6d010e )

PgSQL A

Complexity

Size/Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like