| Conditions | 135 |
| Paths | 685 |
| Total Lines | 115 |
| Code Lines | 98 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 120 | protected function index( int $number, string $locale ) : int |
||
| 121 | { |
||
| 122 | switch( $locale ) |
||
| 123 | { |
||
| 124 | case 'af': |
||
| 125 | case 'az': |
||
| 126 | case 'bn': |
||
| 127 | case 'bg': |
||
| 128 | case 'ca': |
||
| 129 | case 'da': |
||
| 130 | case 'de': |
||
| 131 | case 'el': |
||
| 132 | case 'en': |
||
| 133 | case 'eo': |
||
| 134 | case 'es': |
||
| 135 | case 'et': |
||
| 136 | case 'eu': |
||
| 137 | case 'fa': |
||
| 138 | case 'fi': |
||
| 139 | case 'fo': |
||
| 140 | case 'fur': |
||
| 141 | case 'fy': |
||
| 142 | case 'gl': |
||
| 143 | case 'gu': |
||
| 144 | case 'ha': |
||
| 145 | case 'he': |
||
| 146 | case 'hu': |
||
| 147 | case 'is': |
||
| 148 | case 'it': |
||
| 149 | case 'ku': |
||
| 150 | case 'lb': |
||
| 151 | case 'ml': |
||
| 152 | case 'mn': |
||
| 153 | case 'mr': |
||
| 154 | case 'nah': |
||
| 155 | case 'nb': |
||
| 156 | case 'ne': |
||
| 157 | case 'nl': |
||
| 158 | case 'nn': |
||
| 159 | case 'no': |
||
| 160 | case 'om': |
||
| 161 | case 'or': |
||
| 162 | case 'pa': |
||
| 163 | case 'pap': |
||
| 164 | case 'ps': |
||
| 165 | case 'pt': |
||
| 166 | case 'so': |
||
| 167 | case 'sq': |
||
| 168 | case 'sv': |
||
| 169 | case 'sw': |
||
| 170 | case 'ta': |
||
| 171 | case 'te': |
||
| 172 | case 'tk': |
||
| 173 | case 'ur': |
||
| 174 | case 'zu': |
||
| 175 | return ( $number == 1 ) ? 0 : 1; |
||
| 176 | |||
| 177 | case 'am': |
||
| 178 | case 'bh': |
||
| 179 | case 'fil': |
||
| 180 | case 'fr': |
||
| 181 | case 'gun': |
||
| 182 | case 'hi': |
||
| 183 | case 'ln': |
||
| 184 | case 'mg': |
||
| 185 | case 'nso': |
||
| 186 | case 'xbr': |
||
| 187 | case 'ti': |
||
| 188 | case 'wa': |
||
| 189 | return ( ( $number == 0 ) || ( $number == 1 ) ) ? 0 : 1; |
||
| 190 | |||
| 191 | case 'be': |
||
| 192 | case 'bs': |
||
| 193 | case 'hr': |
||
| 194 | case 'ru': |
||
| 195 | case 'sr': |
||
| 196 | case 'uk': |
||
| 197 | return ( ( $number % 10 == 1 ) && ( $number % 100 != 11 ) ) ? 0 : ( ( ( $number % 10 >= 2 ) && ( $number % 10 <= 4 ) && ( ( $number % 100 < 10 ) || ( $number % 100 >= 20 ) ) ) ? 1 : 2 ); |
||
| 198 | |||
| 199 | case 'cs': |
||
| 200 | case 'sk': |
||
| 201 | return ( $number == 1 ) ? 0 : ( ( ( $number >= 2 ) && ( $number <= 4 ) ) ? 1 : 2 ); |
||
| 202 | |||
| 203 | case 'ar': |
||
| 204 | return ( $number == 0 ) ? 0 : ( ( $number == 1 ) ? 1 : ( ( $number == 2 ) ? 2 : ( ( ( $number >= 3 ) && ( $number <= 10 ) ) ? 3 : ( ( ( $number >= 11 ) && ( $number <= 99 ) ) ? 4 : 5 ) ) ) ); |
||
| 205 | |||
| 206 | case 'cy': |
||
| 207 | return ( $number == 1 ) ? 0 : ( ( $number == 2 ) ? 1 : ( ( ( $number == 8 ) || ( $number == 11 ) ) ? 2 : 3 ) ); |
||
| 208 | |||
| 209 | case 'ga': |
||
| 210 | return ( $number == 1 ) ? 0 : ( ( $number == 2 ) ? 1 : 2 ); |
||
| 211 | |||
| 212 | case 'lt': |
||
| 213 | return ( ( $number % 10 == 1 ) && ( $number % 100 != 11 ) ) ? 0 : ( ( ( $number % 10 >= 2 ) && ( ( $number % 100 < 10 ) || ( $number % 100 >= 20 ) ) ) ? 1 : 2 ); |
||
| 214 | |||
| 215 | case 'lv': |
||
| 216 | return ( $number == 0 ) ? 0 : ( ( ( $number % 10 == 1 ) && ( $number % 100 != 11 ) ) ? 1 : 2 ); |
||
| 217 | |||
| 218 | case 'mk': |
||
| 219 | return ( $number % 10 == 1 ) ? 0 : 1; |
||
| 220 | |||
| 221 | case 'mt': |
||
| 222 | return ( $number == 1 ) ? 0 : ( ( ( $number == 0 ) || ( ( $number % 100 > 1 ) && ( $number % 100 < 11 ) ) ) ? 1 : ( ( ( $number % 100 > 10 ) && ( $number % 100 < 20 ) ) ? 2 : 3 ) ); |
||
| 223 | |||
| 224 | case 'pl': |
||
| 225 | return ( $number == 1 ) ? 0 : ( ( ( $number % 10 >= 2 ) && ( $number % 10 <= 4 ) && ( ( $number % 100 < 12 ) || ( $number % 100 > 14 ) ) ) ? 1 : 2 ); |
||
| 226 | |||
| 227 | case 'ro': |
||
| 228 | return ( $number == 1 ) ? 0 : ( ( ( $number == 0 ) || ( ( $number % 100 > 0 ) && ( $number % 100 < 20 ) ) ) ? 1 : 2 ); |
||
| 229 | |||
| 230 | case 'sl': |
||
| 231 | return ( $number % 100 == 1 ) ? 0 : ( ( $number % 100 == 2 ) ? 1 : ( ( ( $number % 100 == 3 ) || ( $number % 100 == 4 ) ) ? 2 : 3 ) ); |
||
| 232 | |||
| 233 | default: |
||
| 234 | return 0; |
||
| 235 | } |
||
| 239 |