| Conditions | 2 |
| Paths | 2 |
| Total Lines | 89 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 89 | public function testSaveUpdateDeleteItem() |
||
| 90 | { |
||
| 91 | $search = $this->object->createSearch(); |
||
| 92 | $search->setConditions( $search->compare( '==', 'customer.address.email', '[email protected]' ) ); |
||
| 93 | $results = $this->object->searchItems( $search ); |
||
| 94 | |||
| 95 | if( ( $item = reset( $results ) ) === false ) { |
||
| 96 | throw new \RuntimeException( 'No customer address found' ); |
||
| 97 | } |
||
| 98 | |||
| 99 | $item->setId( null ); |
||
| 100 | $resultSaved = $this->object->saveItem( $item ); |
||
|
|
|||
| 101 | $itemSaved = $this->object->getItem( $item->getId() ); |
||
| 102 | |||
| 103 | $itemExp = clone $itemSaved; |
||
| 104 | $itemExp->setCompany( 'unitTest' ); |
||
| 105 | $resultUpd = $this->object->saveItem( $itemExp ); |
||
| 106 | $itemUpd = $this->object->getItem( $itemExp->getId() ); |
||
| 107 | |||
| 108 | $this->object->deleteItem( $item->getId() ); |
||
| 109 | |||
| 110 | |||
| 111 | $this->assertTrue( $item->getId() !== null ); |
||
| 112 | $this->assertEquals( $item->getId(), $itemSaved->getId() ); |
||
| 113 | $this->assertEquals( $item->getSiteId(), $itemSaved->getSiteId() ); |
||
| 114 | $this->assertEquals( $item->getParentId(), $itemSaved->getParentId() ); |
||
| 115 | $this->assertEquals( $item->getSalutation(), $itemSaved->getSalutation() ); |
||
| 116 | $this->assertEquals( $item->getCompany(), $itemSaved->getCompany() ); |
||
| 117 | $this->assertEquals( $item->getVatID(), $itemSaved->getVatID() ); |
||
| 118 | $this->assertEquals( $item->getTitle(), $itemSaved->getTitle() ); |
||
| 119 | $this->assertEquals( $item->getFirstname(), $itemSaved->getFirstname() ); |
||
| 120 | $this->assertEquals( $item->getLastname(), $itemSaved->getLastname() ); |
||
| 121 | $this->assertEquals( $item->getAddress1(), $itemSaved->getAddress1() ); |
||
| 122 | $this->assertEquals( $item->getAddress2(), $itemSaved->getAddress2() ); |
||
| 123 | $this->assertEquals( $item->getAddress3(), $itemSaved->getAddress3() ); |
||
| 124 | $this->assertEquals( $item->getPostal(), $itemSaved->getPostal() ); |
||
| 125 | $this->assertEquals( $item->getCity(), $itemSaved->getCity() ); |
||
| 126 | $this->assertEquals( $item->getState(), $itemSaved->getState() ); |
||
| 127 | $this->assertEquals( $item->getLanguageId(), $itemSaved->getLanguageId() ); |
||
| 128 | $this->assertEquals( $item->getCountryId(), $itemSaved->getCountryId() ); |
||
| 129 | $this->assertEquals( $item->getTelephone(), $itemSaved->getTelephone() ); |
||
| 130 | $this->assertEquals( $item->getEMail(), $itemSaved->getEMail() ); |
||
| 131 | $this->assertEquals( $item->getTelefax(), $itemSaved->getTelefax() ); |
||
| 132 | $this->assertEquals( $item->getWebsite(), $itemSaved->getWebsite() ); |
||
| 133 | $this->assertEquals( $item->getLongitude(), $itemSaved->getLongitude() ); |
||
| 134 | $this->assertEquals( $item->getLatitude(), $itemSaved->getLatitude() ); |
||
| 135 | $this->assertEquals( $item->getFlag(), $itemSaved->getFlag() ); |
||
| 136 | $this->assertEquals( $item->getPosition(), $itemSaved->getPosition() ); |
||
| 137 | $this->assertEquals( $item->getEditor(), $itemSaved->getEditor() ); |
||
| 138 | |||
| 139 | $this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeCreated() ); |
||
| 140 | $this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified() ); |
||
| 141 | |||
| 142 | $this->assertEquals( $itemExp->getId(), $itemUpd->getId() ); |
||
| 143 | $this->assertEquals( $itemExp->getSiteId(), $itemUpd->getSiteId() ); |
||
| 144 | $this->assertEquals( $itemExp->getParentId(), $itemUpd->getParentId() ); |
||
| 145 | $this->assertEquals( $itemExp->getSalutation(), $itemUpd->getSalutation() ); |
||
| 146 | $this->assertEquals( $itemExp->getCompany(), $itemUpd->getCompany() ); |
||
| 147 | $this->assertEquals( $itemExp->getVatID(), $itemUpd->getVatID() ); |
||
| 148 | $this->assertEquals( $itemExp->getTitle(), $itemUpd->getTitle() ); |
||
| 149 | $this->assertEquals( $itemExp->getFirstname(), $itemUpd->getFirstname() ); |
||
| 150 | $this->assertEquals( $itemExp->getLastname(), $itemUpd->getLastname() ); |
||
| 151 | $this->assertEquals( $itemExp->getAddress1(), $itemUpd->getAddress1() ); |
||
| 152 | $this->assertEquals( $itemExp->getAddress2(), $itemUpd->getAddress2() ); |
||
| 153 | $this->assertEquals( $itemExp->getAddress3(), $itemUpd->getAddress3() ); |
||
| 154 | $this->assertEquals( $itemExp->getPostal(), $itemUpd->getPostal() ); |
||
| 155 | $this->assertEquals( $itemExp->getCity(), $itemUpd->getCity() ); |
||
| 156 | $this->assertEquals( $itemExp->getState(), $itemUpd->getState() ); |
||
| 157 | $this->assertEquals( $itemExp->getLanguageId(), $itemUpd->getLanguageId() ); |
||
| 158 | $this->assertEquals( $itemExp->getCountryId(), $itemUpd->getCountryId() ); |
||
| 159 | $this->assertEquals( $itemExp->getTelephone(), $itemUpd->getTelephone() ); |
||
| 160 | $this->assertEquals( $itemExp->getEMail(), $itemUpd->getEMail() ); |
||
| 161 | $this->assertEquals( $itemExp->getTelefax(), $itemUpd->getTelefax() ); |
||
| 162 | $this->assertEquals( $itemExp->getWebsite(), $itemUpd->getWebsite() ); |
||
| 163 | $this->assertEquals( $itemExp->getLongitude(), $itemUpd->getLongitude() ); |
||
| 164 | $this->assertEquals( $itemExp->getLatitude(), $itemUpd->getLatitude() ); |
||
| 165 | $this->assertEquals( $itemExp->getFlag(), $itemUpd->getFlag() ); |
||
| 166 | $this->assertEquals( $itemExp->getPosition(), $itemUpd->getPosition() ); |
||
| 167 | $this->assertEquals( $itemExp->getEditor(), $itemUpd->getEditor() ); |
||
| 168 | |||
| 169 | $this->assertEquals( $itemExp->getTimeCreated(), $itemUpd->getTimeCreated() ); |
||
| 170 | $this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemUpd->getTimeModified() ); |
||
| 171 | |||
| 172 | $this->assertInstanceOf( '\Aimeos\MShop\Common\Item\Iface', $resultSaved ); |
||
| 173 | $this->assertInstanceOf( '\Aimeos\MShop\Common\Item\Iface', $resultUpd ); |
||
| 174 | |||
| 175 | $this->setExpectedException( '\\Aimeos\\MShop\\Exception' ); |
||
| 176 | $this->object->getItem( $item->getId() ); |
||
| 177 | } |
||
| 178 | |||
| 261 |
This check looks for function or method calls that always return null and whose return value is assigned to a variable.
The method
getObject()can return nothing but null, so it makes no sense to assign that value to a variable.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.