Passed
Push — 2019.10 ( 315de5...898197 )
by Aimeos
01:54
created
lib/custom/tests/MW/Common/Criteria/Plugin/T3StatusTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 	 */
33 33
 	protected function tearDown()
34 34
 	{
35
-		unset($this->object);
35
+		unset( $this->object );
36 36
 	}
37 37
 
38 38
 
Please login to merge, or discard this patch.
lib/custom/tests/MW/View/Helper/Url/Typo3Test.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	public function testTransform()
34 34
 	{
35 35
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
36
-			->setMethods( array( 'buildFrontendUri') )->getMock();
36
+			->setMethods( array( 'buildFrontendUri' ) )->getMock();
37 37
 
38 38
 		$mock->expects( $this->once() )->method( 'buildFrontendUri' );
39 39
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	public function testTransformAbsolute()
48 48
 	{
49 49
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
50
-			->setMethods( array( 'setCreateAbsoluteUri') )->getMock();
50
+			->setMethods( array( 'setCreateAbsoluteUri' ) )->getMock();
51 51
 
52 52
 		$mock->expects( $this->once() )->method( 'setCreateAbsoluteUri' )
53 53
 			->with( $this->equalTo( true ) )->will( $this->returnValue( $mock ) );
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	public function testTransformNocache()
63 63
 	{
64 64
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
65
-			->setMethods( array( 'setNoCache') )->getMock();
65
+			->setMethods( array( 'setNoCache' ) )->getMock();
66 66
 
67 67
 		$mock->expects( $this->once() )->method( 'setNoCache' )
68 68
 			->with( $this->equalTo( true ) )->will( $this->returnValue( $mock ) );
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	public function testTransformChash()
78 78
 	{
79 79
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
80
-			->setMethods( array( 'setUseCacheHash') )->getMock();
80
+			->setMethods( array( 'setUseCacheHash' ) )->getMock();
81 81
 
82 82
 		$mock->expects( $this->once() )->method( 'setUseCacheHash' )
83 83
 			->with( $this->equalTo( true ) )->will( $this->returnValue( $mock ) );
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	public function testTransformType()
93 93
 	{
94 94
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
95
-			->setMethods( array( 'setTargetPageType') )->getMock();
95
+			->setMethods( array( 'setTargetPageType' ) )->getMock();
96 96
 
97 97
 		$mock->expects( $this->once() )->method( 'setTargetPageType' )
98 98
 			->with( $this->equalTo( 123 ) )->will( $this->returnValue( $mock ) );
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	public function testTransformFormat()
108 108
 	{
109 109
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
110
-			->setMethods( array( 'setFormat') )->getMock();
110
+			->setMethods( array( 'setFormat' ) )->getMock();
111 111
 
112 112
 		$mock->expects( $this->once() )->method( 'setFormat' )
113 113
 			->with( $this->equalTo( 'xml' ) )->will( $this->returnValue( $mock ) );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	public function testTransformEID()
123 123
 	{
124 124
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
125
-			->setMethods( array( 'setArguments') )->getMock();
125
+			->setMethods( array( 'setArguments' ) )->getMock();
126 126
 
127 127
 		$param = array( 'eID' => 123, 'ai' => array( 'controller' => '', 'action' => null ) );
128 128
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	public function testTransformLocale()
140 140
 	{
141 141
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
142
-			->setMethods( array( 'setArguments') )->getMock();
142
+			->setMethods( array( 'setArguments' ) )->getMock();
143 143
 
144 144
 		$param = array( 'L' => 'de', 'ai' => ['controller' => '', 'action' => null, 'locale' => 'de'] );
145 145
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 	public function testTransformBackend()
157 157
 	{
158 158
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
159
-		->setMethods( array( 'buildBackendUri') )->getMock();
159
+		->setMethods( array( 'buildBackendUri' ) )->getMock();
160 160
 
161 161
 		$mock->expects( $this->once() )->method( 'buildBackendUri' );
162 162
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 	public function testTransformParams()
171 171
 	{
172 172
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
173
-			->setMethods( array( 'buildFrontendUri') )->getMock();
173
+			->setMethods( array( 'buildFrontendUri' ) )->getMock();
174 174
 
175 175
 		$mock->expects( $this->once() )->method( 'buildFrontendUri' );
176 176
 
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 	public function testTransformUnchangedOriginalUriBuilder()
201 201
 	{
202 202
 		$mock = $this->getMockBuilder( 'TYPO3\\CMS\\Extbase\\Mvc\\Web\\Routing\\UriBuilder' )
203
-			->setMethods( array( 'reset') )->getMock();
203
+			->setMethods( array( 'reset' ) )->getMock();
204 204
 
205 205
 		$mock->expects( $this->once() )->method( 'reset' )->will( $this->returnValue( $mock ) );
206 206
 
Please login to merge, or discard this patch.
lib/custom/setup/unittest/data/customer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 				'customer.address.telefax' => '055544332212', 'customer.address.website' => 'www.example.com',
80 80
 				'customer.address.longitude' => '10.5', 'customer.address.latitude' => '51.0',
81 81
 				'customer.address.position' => '0',
82
-			],[
82
+			], [
83 83
 				'customer.address.company' => 'Example company LLC', 'customer.address.vatid' => 'DE999999999',
84 84
 				'customer.address.salutation' => 'mr', 'customer.address.title' => 'Dr.',
85 85
 				'customer.address.firstname' => 'Good', 'customer.address.lastname' => 'Unittest',
Please login to merge, or discard this patch.
lib/custom/setup/default/schema/customer.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
 return array(
10 10
 	'table' => array(
11 11
 
12
-		'fe_users_address' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
12
+		'fe_users_address' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
13 13
 
14 14
 			$table = $schema->createTable( 'fe_users_address' );
15 15
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 			$table->addColumn( 'latitude', 'float', array( 'notnull' => false ) );
40 40
 			$table->addColumn( 'mtime', 'datetime', [] );
41 41
 			$table->addColumn( 'ctime', 'datetime', [] );
42
-			$table->addColumn( 'editor', 'string', array('length' => 255 ) );
42
+			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );
43 43
 
44 44
 			$table->setPrimaryKey( array( 'id' ), 'pk_t3feuad_id' );
45 45
 			$table->addIndex( array( 'lastname', 'firstname' ), 'idx_t3feuad_last_first' );
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 			return $schema;
57 57
 		},
58 58
 
59
-		'fe_users_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
59
+		'fe_users_list_type' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
60 60
 
61 61
 			$table = $schema->createTable( 'fe_users_list_type' );
62 62
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 			return $schema;
81 81
 		},
82 82
 
83
-		'fe_users_list' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
83
+		'fe_users_list' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
84 84
 
85 85
 			$table = $schema->createTable( 'fe_users_list' );
86 86
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 			return $schema;
110 110
 		},
111 111
 
112
-		'fe_users_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
112
+		'fe_users_property_type' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
113 113
 
114 114
 			$table = $schema->createTable( 'fe_users_property_type' );
115 115
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 			return $schema;
134 134
 		},
135 135
 
136
-		'fe_users_property' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
136
+		'fe_users_property' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
137 137
 
138 138
 			$table = $schema->createTable( 'fe_users_property' );
139 139
 
Please login to merge, or discard this patch.
lib/custom/tests/MShop/Customer/Manager/Lists/Type/Typo3Test.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -42,10 +42,10 @@  discard block
 block discarded – undo
42 42
 	public function testGetItem()
43 43
 	{
44 44
 		$search = $this->object->createSearch();
45
-		$search->setSlice(0, 1);
46
-		$results = $this->object->searchItems($search);
45
+		$search->setSlice( 0, 1 );
46
+		$results = $this->object->searchItems( $search );
47 47
 
48
-		if( ( $expected = reset($results) ) === false ) {
48
+		if( ( $expected = reset( $results ) ) === false ) {
49 49
 			throw new \RuntimeException( 'No list type item found' );
50 50
 		}
51 51
 
@@ -56,14 +56,14 @@  discard block
 block discarded – undo
56 56
 	public function testSaveUpdateDeleteItem()
57 57
 	{
58 58
 		$search = $this->object->createSearch();
59
-		$search->setSlice(0, 1);
60
-		$results = $this->object->searchItems($search);
59
+		$search->setSlice( 0, 1 );
60
+		$results = $this->object->searchItems( $search );
61 61
 
62
-		if( ( $item = reset($results) ) === false ) {
62
+		if( ( $item = reset( $results ) ) === false ) {
63 63
 			throw new \RuntimeException( 'No type item found' );
64 64
 		}
65 65
 
66
-		$item->setId(null);
66
+		$item->setId( null );
67 67
 		$item->setCode( 'unitTestInit' );
68 68
 		$resultSaved = $this->object->saveItem( $item );
69 69
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultSaved );
103 103
 		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultUpd );
104 104
 
105
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
105
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
106 106
 		$this->object->getItem( $itemSaved->getId() );
107 107
 	}
108 108
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$expr[] = $search->compare( '==', 'customer.lists.type.editor', $this->editor );
126 126
 
127 127
 		$search->setConditions( $search->combine( '&&', $expr ) );
128
-		$search->setSlice(0, 1);
128
+		$search->setSlice( 0, 1 );
129 129
 
130 130
 		$results = $this->object->searchItems( $search, [], $total );
131 131
 		$this->assertEquals( 1, count( $results ) );
Please login to merge, or discard this patch.
lib/custom/tests/MShop/Customer/Manager/Property/Type/Typo3Test.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 
28 28
 	protected function tearDown()
29 29
 	{
30
-		unset($this->object);
30
+		unset( $this->object );
31 31
 	}
32 32
 
33 33
 
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 		$results = $this->object->searchItems( $search );
72 72
 
73
-		if( ($expected = reset($results) ) === false )
73
+		if( ( $expected = reset( $results ) ) === false )
74 74
 		{
75 75
 			throw new \RuntimeException( 'No property type item found.' );
76 76
 		}
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
92 92
 	{
93 93
 		$search = $this->object->createSearch();
94 94
 		$search->setConditions( $search->compare( '==', 'customer.property.type.editor', $this->editor ) );
95
-		$results = $this->object->searchItems($search);
95
+		$results = $this->object->searchItems( $search );
96 96
 
97
-		if( ( $item = reset($results) ) === false ) {
97
+		if( ( $item = reset( $results ) ) === false ) {
98 98
 			throw new \RuntimeException( 'No type item found' );
99 99
 		}
100 100
 
101
-		$item->setId(null);
101
+		$item->setId( null );
102 102
 		$item->setCode( 'unitTestSave' );
103 103
 		$resultSaved = $this->object->saveItem( $item );
104 104
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -159,19 +159,19 @@  discard block
 block discarded – undo
159 159
 		$expr[] = $search->compare( '>=', 'customer.property.type.ctime', '1970-01-01 00:00:00' );
160 160
 		$expr[] = $search->compare( '==', 'customer.property.type.editor', $this->editor );
161 161
 
162
-		$search->setConditions( $search->combine('&&', $expr) );
162
+		$search->setConditions( $search->combine( '&&', $expr ) );
163 163
 		$results = $this->object->searchItems( $search, [], $total );
164 164
 		$this->assertEquals( 1, count( $results ) );
165 165
 
166 166
 
167 167
 		$search = $this->object->createSearch();
168 168
 		$conditions = array(
169
-			$search->compare( '=~', 'customer.property.type.code', 'newsletter'),
169
+			$search->compare( '=~', 'customer.property.type.code', 'newsletter' ),
170 170
 			$search->compare( '==', 'customer.property.type.editor', $this->editor )
171 171
 		);
172
-		$search->setConditions( $search->combine('&&', $conditions ) );
173
-		$search->setSlice(0, 1);
174
-		$items = $this->object->searchItems( $search, [], $total);
172
+		$search->setConditions( $search->combine( '&&', $conditions ) );
173
+		$search->setSlice( 0, 1 );
174
+		$items = $this->object->searchItems( $search, [], $total );
175 175
 
176 176
 		$this->assertEquals( 1, count( $items ) );
177 177
 		$this->assertEquals( 1, $total );
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 
185 185
 	public function testGetSubManager()
186 186
 	{
187
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
188
-		$this->object->getSubManager('unknown');
187
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
188
+		$this->object->getSubManager( 'unknown' );
189 189
 	}
190 190
 }
Please login to merge, or discard this patch.
lib/custom/tests/MShop/Customer/Manager/Lists/Typo3Test.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	public function testGetItem()
54 54
 	{
55 55
 		$search = $this->object->createSearch();
56
-		$search->setSlice(0, 1);
56
+		$search->setSlice( 0, 1 );
57 57
 		$results = $this->object->searchItems( $search );
58 58
 
59 59
 		if( ( $item = reset( $results ) ) === false ) {
@@ -67,14 +67,14 @@  discard block
 block discarded – undo
67 67
 	public function testSaveUpdateDeleteItem()
68 68
 	{
69 69
 		$search = $this->object->createSearch();
70
-		$search->setSlice(0, 1);
70
+		$search->setSlice( 0, 1 );
71 71
 		$items = $this->object->searchItems( $search );
72 72
 
73 73
 		if( ( $item = reset( $items ) ) === false ) {
74 74
 			throw new \RuntimeException( 'No item found' );
75 75
 		}
76 76
 
77
-		$item->setId(null);
77
+		$item->setId( null );
78 78
 		$item->setDomain( 'unittest' );
79 79
 		$resultSaved = $this->object->saveItem( $item );
80 80
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -98,12 +98,12 @@  discard block
 block discarded – undo
98 98
 		$this->assertEquals( $item->getDateEnd(), $itemSaved->getDateEnd() );
99 99
 		$this->assertEquals( $item->getPosition(), $itemSaved->getPosition() );
100 100
 		$this->assertEquals( $this->editor, $itemSaved->getEditor() );
101
-		$this->assertStringStartsWith(date('Y-m-d', time()), $itemSaved->getTimeCreated());
102
-		$this->assertStringStartsWith(date('Y-m-d', time()), $itemSaved->getTimeModified());
101
+		$this->assertStringStartsWith( date( 'Y-m-d', time() ), $itemSaved->getTimeCreated() );
102
+		$this->assertStringStartsWith( date( 'Y-m-d', time() ), $itemSaved->getTimeModified() );
103 103
 
104 104
 		$this->assertEquals( $this->editor, $itemSaved->getEditor() );
105 105
 		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeCreated() );
106
-		$this->assertRegExp('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified() );
106
+		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified() );
107 107
 
108 108
 		$this->assertEquals( $itemExp->getId(), $itemUpd->getId() );
109 109
 		$this->assertEquals( $itemExp->getSiteId(), $itemUpd->getSiteId() );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultSaved );
123 123
 		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultUpd );
124 124
 
125
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
125
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
126 126
 		$this->object->getItem( $itemSaved->getId() );
127 127
 	}
128 128
 
@@ -192,10 +192,10 @@  discard block
 block discarded – undo
192 192
 
193 193
 	public function testGetSubManager()
194 194
 	{
195
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type') );
196
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type', 'Typo3') );
195
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type' ) );
196
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type', 'Typo3' ) );
197 197
 
198
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
199
-		$this->object->getSubManager('unknown');
198
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
199
+		$this->object->getSubManager( 'unknown' );
200 200
 	}
201 201
 }
Please login to merge, or discard this patch.
lib/custom/src/MShop/Customer/Manager/Typo3.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -630,7 +630,7 @@
 block discarded – undo
630 630
 		}
631 631
 		catch( \Exception $e )
632 632
 		{
633
-			$dbm->release( $conn, $dbname  );
633
+			$dbm->release( $conn, $dbname );
634 634
 			throw $e;
635 635
 		}
636 636
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -470,8 +470,7 @@
 block discarded – undo
470 470
 				 */
471 471
 				$path = 'mshop/customer/manager/typo3/insert';
472 472
 				$sql = $this->addSqlColumns( array_keys( $columns ), $this->getSqlConfig( $path ) );
473
-			}
474
-			else
473
+			} else
475 474
 			{
476 475
 				/** mshop/customer/manager/typo3/update
477 476
 				 * Updates an existing customer record in the database
Please login to merge, or discard this patch.
lib/custom/src/MShop/Customer/Manager/Group/Typo3.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -237,8 +237,7 @@
 block discarded – undo
237 237
 				 */
238 238
 				$path = 'mshop/customer/manager/group/typo3/insert';
239 239
 				$sql = $this->addSqlColumns( array_keys( $columns ), $this->getSqlConfig( $path ) );
240
-			}
241
-			else
240
+			} else
242 241
 			{
243 242
 				/** mshop/customer/manager/group/typo3/update/mysql
244 243
 				 * Updates an existing customer group record in the database
Please login to merge, or discard this patch.