Aimeos\Slim\Router::relativePathFor()

Complexity

Conditions	8
Paths	27

Size

Total Lines	51
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
	public function relativePathFor( $name, array $data = [], array $queryParams = [] )
	{
		$route = $this->getNamedRoute($name);
		$pattern = $route->getPattern();

		$routeDatas = $this->routeParser->parse($pattern);
		// $routeDatas is an array of all possible routes that can be made. There is
		// one routedata for each optional parameter plus one for no optional parameters.
		//
		// The most specific is last, so we look for that first.
		$routeDatas = array_reverse($routeDatas);

		$segments = $segmentKeys = [];
		foreach ( $routeDatas as $routeData ) {
			foreach ( $routeData as $item ) {
				if ( is_string($item) ) {
					// this segment is a static string
					$segments[] = $item;
					continue;
				}

				// This segment has a parameter: first element is the name
				if ( !array_key_exists($item[0], $data) ) {
					// we don't have a data element for this segment: cancel
					// testing this routeData item, so that we can try a less
					// specific routeData item.
					$segments = [];
					$segmentName = $item[0];
					break;
				}
				$segments[] = $data[$item[0]];
				$segmentKeys[$item[0]] = true;
			}
			if ( !empty($segments) ) {
				// we found all the parameters for this route data, no need to check
				// less specific ones
				break;
			}
		}

		if ( empty($segments) ) {
			throw new InvalidArgumentException('Missing data for URL segment: ' . $segmentName);

The variable $segmentName does not seem to be defined for all execution paths leading up to this point.

		}
		$url = implode('', $segments);

		$params = array_merge(array_diff_key($data, $segmentKeys), $queryParams);
		if ( $params ) {

The expression $params of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			$url .= '?' . http_build_query($params);
		}

		return $url;
	}