Issues in customer.php - All Issues - Inspection of "Adapt to new create() factory method" - aimeos/ai-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c1f25f...b3d94f )

by Aimeos

created 2018-12-28 12:04 UTC

lib/custom/setup/default/schema/customer.php (35 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2016-2018
 */


return array(
	'table' => array(
		'users' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {

			$table = $schema->createTable( 'users' );

			$table->addColumn( 'id', 'integer', array( 'autoincrement' => true ) );
			$table->addColumn( 'superuser', 'smallint', array( 'default' => 0 ) );
			$table->addColumn( 'siteid', 'integer', array( 'notnull' => false ) );
			$table->addColumn( 'label', 'string', array( 'length' => 255, 'default' => '' ) );
			$table->addColumn( 'name', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'remember_token', 'string', array( 'length' => 100, 'notnull' => false ) );
			$table->addColumn( 'salutation', 'string', array( 'length' => 8, 'default' => '' ) );
			$table->addColumn( 'company', 'string', array( 'length' => 100, 'default' => '' ) );
			$table->addColumn( 'vatid', 'string', array( 'length' => 32, 'default' => '' ) );
			$table->addColumn( 'title', 'string', array( 'length' => 64, 'default' => '' ) );
			$table->addColumn( 'firstname', 'string', array( 'length' => 64, 'default' => '' ) );
			$table->addColumn( 'lastname', 'string', array( 'length' => 64, 'default' => '' ) );
			$table->addColumn( 'address1', 'string', array( 'length' => 200, 'default' => '' ) );
			$table->addColumn( 'address2', 'string', array( 'length' => 200, 'default' => '' ) );
			$table->addColumn( 'address3', 'string', array( 'length' => 200, 'default' => '' ) );
			$table->addColumn( 'postal', 'string', array( 'length' => 16, 'default' => '' ) );
			$table->addColumn( 'city', 'string', array( 'length' => 200, 'default' => '' ) );
			$table->addColumn( 'state', 'string', array( 'length' => 200, 'default' => '' ) );
			$table->addColumn( 'langid', 'string', array( 'length' => 5, 'notnull' => false ) );
			$table->addColumn( 'countryid', 'string', array( 'length' => 2, 'notnull' => false, 'fixed' => true ) );
			$table->addColumn( 'telephone', 'string', array( 'length' => 32, 'default' => '' ) );
			$table->addColumn( 'telefax', 'string', array( 'length' => 32, 'default' => '' ) );
			$table->addColumn( 'website', 'string', array( 'length' => 255, 'default' => '' ) );
			$table->addColumn( 'email', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'password', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'longitude', 'float', array( 'notnull' => false ) );
			$table->addColumn( 'latitude', 'float', array( 'notnull' => false ) );
			$table->addColumn( 'birthday', 'date', array( 'notnull' => false ) );
			$table->addColumn( 'vdate', 'date', array( 'notnull' => false ) );
			$table->addColumn( 'status', 'smallint', array( 'default' => 1 ) );
			$table->addColumn( 'updated_at', 'datetime', [] );
			$table->addColumn( 'created_at', 'datetime', [] );
			$table->addColumn( 'editor', 'string', array('length' => 255, 'default' => '' ) );

			$table->setPrimaryKey( array( 'id' ), 'pk_lvusr_id' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addUniqueIndex( array( 'email' ), 'unq_lvusr_email' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'langid' ), 'idx_lvusr_langid' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'lastname', 'firstname' ), 'idx_lvusr_last_first' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'postal', 'address1' ), 'idx_lvusr_post_addr1' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'postal', 'city' ), 'idx_lvusr_post_city' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'lastname' ), 'idx_lvusr_lastname' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'address1' ), 'idx_lvusr_address1' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'city' ), 'idx_lvusr_city' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

			return $schema;
		},

		'users_address' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {

			$table = $schema->createTable( 'users_address' );

			$table->addColumn( 'id', 'integer', array( 'autoincrement' => true ) );
			$table->addColumn( 'siteid', 'integer', [] );
			$table->addColumn( 'parentid', 'integer', [] );
			$table->addColumn( 'pos', 'smallint', [] );
			$table->addColumn( 'company', 'string', array( 'length' => 100 ) );
			$table->addColumn( 'vatid', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'salutation', 'string', array( 'length' => 8 ) );
			$table->addColumn( 'title', 'string', array( 'length' => 64 ) );
			$table->addColumn( 'firstname', 'string', array( 'length' => 64 ) );
			$table->addColumn( 'lastname', 'string', array( 'length' => 64 ) );
			$table->addColumn( 'address1', 'string', array( 'length' => 200 ) );
			$table->addColumn( 'address2', 'string', array( 'length' => 200 ) );
			$table->addColumn( 'address3', 'string', array( 'length' => 200 ) );
			$table->addColumn( 'postal', 'string', array( 'length' => 16 ) );
			$table->addColumn( 'city', 'string', array( 'length' => 200 ) );
			$table->addColumn( 'state', 'string', array( 'length' => 200 ) );
			$table->addColumn( 'langid', 'string', array( 'length' => 5, 'notnull' => false ) );
			$table->addColumn( 'countryid', 'string', array( 'length' => 2, 'notnull' => false, 'fixed' => true ) );
			$table->addColumn( 'telephone', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'email', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'telefax', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'website', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'longitude', 'float', array( 'notnull' => false ) );
			$table->addColumn( 'latitude', 'float', array( 'notnull' => false ) );
			$table->addColumn( 'mtime', 'datetime', [] );
			$table->addColumn( 'ctime', 'datetime', [] );
			$table->addColumn( 'editor', 'string', array('length' => 255 ) );

			$table->setPrimaryKey( array( 'id' ), 'pk_lvuad_id' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'parentid' ), 'idx_lvuad_pid' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'lastname', 'firstname' ), 'idx_lvuad_last_first' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'postal', 'address1' ), 'idx_lvuad_post_addr1' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'postal', 'city' ), 'idx_lvuad_post_city' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'address1' ), 'idx_lvuad_address1' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'city' ), 'idx_lvuad_city' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'email' ), 'idx_lvuad_email' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

			$table->addForeignKeyConstraint( 'users', array( 'parentid' ), array( 'id' ),
				array( 'onUpdate' => 'CASCADE', 'onDelete' => 'CASCADE' ), 'fk_lvuad_pid' );

			return $schema;
		},

		'users_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {


			$table = $schema->createTable( 'users_list_type' );

			$table->addColumn( 'id', 'integer', array( 'autoincrement' => true ) );
			$table->addColumn( 'siteid', 'integer', [] );
			$table->addColumn( 'domain', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'code', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'label', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'pos', 'integer', ['default' => 0] );
			$table->addColumn( 'status', 'smallint', [] );
			$table->addColumn( 'mtime', 'datetime', [] );
			$table->addColumn( 'ctime', 'datetime', [] );
			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );

			$table->setPrimaryKey( array( 'id' ), 'pk_lvulity_id' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addUniqueIndex( array( 'siteid', 'domain', 'code' ), 'unq_lvulity_sid_dom_code' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'siteid', 'status', 'pos' ), 'idx_lvulity_sid_status_pos' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'siteid', 'label' ), 'idx_lvulity_sid_label' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'siteid', 'code' ), 'idx_lvulity_sid_code' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

			return $schema;
		},

		'users_list' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {

			$table = $schema->createTable( 'users_list' );

			$table->addColumn( 'id', 'integer', array( 'autoincrement' => true ) );
			$table->addColumn( 'parentid', 'integer', [] );
			$table->addColumn( 'siteid', 'integer', [] );
			$table->addColumn( 'type', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'domain', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'refid', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'start', 'datetime', array( 'notnull' => false ) );
			$table->addColumn( 'end', 'datetime', array( 'notnull' => false ) );
			$table->addColumn( 'config', 'text', array( 'length' => 0xffff ) );
			$table->addColumn( 'pos', 'integer', [] );
			$table->addColumn( 'status', 'smallint', [] );
			$table->addColumn( 'mtime', 'datetime', [] );
			$table->addColumn( 'ctime', 'datetime', [] );
			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );

			$table->setPrimaryKey( array( 'id' ), 'pk_lvuli_id' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addUniqueIndex( array( 'parentid', 'siteid', 'domain', 'type', 'refid' ), 'unq_lvuli_pid_sid_dm_ty_rid' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'parentid' ), 'fk_lvuli_pid' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

			$table->addForeignKeyConstraint( 'users', array( 'parentid' ), array( 'id' ),
				array( 'onUpdate' => 'CASCADE', 'onDelete' => 'CASCADE' ), 'fk_lvuli_pid' );

			return $schema;
		},

		'users_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {


			$table = $schema->createTable( 'users_property_type' );

			$table->addColumn( 'id', 'integer', array( 'autoincrement' => true ) );
			$table->addColumn( 'siteid', 'integer', [] );
			$table->addColumn( 'domain', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'code', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'label', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'pos', 'integer', ['default' => 0] );
			$table->addColumn( 'status', 'smallint', [] );
			$table->addColumn( 'mtime', 'datetime', [] );
			$table->addColumn( 'ctime', 'datetime', [] );
			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );

			$table->setPrimaryKey( array( 'id' ), 'pk_lvuprty_id' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addUniqueIndex( array( 'siteid', 'domain', 'code' ), 'unq_lvuprty_sid_dom_code' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'siteid', 'status', 'pos' ), 'idx_lvuprty_sid_status_pos' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'siteid', 'label' ), 'idx_lvuprty_sid_label' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'siteid', 'code' ), 'idx_lvuprty_sid_code' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

			return $schema;
		},

		'users_property' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {

			$table = $schema->createTable( 'users_property' );

			$table->addColumn( 'id', 'integer', array( 'autoincrement' => true ) );
			$table->addColumn( 'siteid', 'integer', [] );
			$table->addColumn( 'parentid', 'integer', [] );
			$table->addColumn( 'type', 'string', array( 'length' => 32 ) );
			$table->addColumn( 'langid', 'string', array( 'length' => 5, 'notnull' => false ) );
			$table->addColumn( 'value', 'string', array( 'length' => 255 ) );
			$table->addColumn( 'mtime', 'datetime', [] );
			$table->addColumn( 'ctime', 'datetime', [] );
			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );

			$table->setPrimaryKey( array( 'id' ), 'pk_lvupr_id' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addUniqueIndex( array( 'parentid', 'siteid', 'type', 'langid', 'value' ), 'unq_lvupr_sid_ty_lid_value' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$table->addIndex( array( 'parentid' ), 'fk_lvupr_pid' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

			$table->addForeignKeyConstraint( 'users', array( 'parentid' ), array( 'id' ),
				array( 'onUpdate' => 'CASCADE', 'onDelete' => 'CASCADE' ), 'fk_lvupr_pid' );

			return $schema;
		},
	),
);


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2016-2018
6			*/
7
8
9			return array(
10			'table' => array(
11			'users' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
12
13			$table = $schema->createTable( 'users' );
14
15			$table->addColumn( 'id', 'integer', array( 'autoincrement' => true ) );
16			$table->addColumn( 'superuser', 'smallint', array( 'default' => 0 ) );
17			$table->addColumn( 'siteid', 'integer', array( 'notnull' => false ) );
18			$table->addColumn( 'label', 'string', array( 'length' => 255, 'default' => '' ) );
19			$table->addColumn( 'name', 'string', array( 'length' => 255 ) );
20			$table->addColumn( 'remember_token', 'string', array( 'length' => 100, 'notnull' => false ) );
21			$table->addColumn( 'salutation', 'string', array( 'length' => 8, 'default' => '' ) );
22			$table->addColumn( 'company', 'string', array( 'length' => 100, 'default' => '' ) );
23			$table->addColumn( 'vatid', 'string', array( 'length' => 32, 'default' => '' ) );
24			$table->addColumn( 'title', 'string', array( 'length' => 64, 'default' => '' ) );
25			$table->addColumn( 'firstname', 'string', array( 'length' => 64, 'default' => '' ) );
26			$table->addColumn( 'lastname', 'string', array( 'length' => 64, 'default' => '' ) );
27			$table->addColumn( 'address1', 'string', array( 'length' => 200, 'default' => '' ) );
28			$table->addColumn( 'address2', 'string', array( 'length' => 200, 'default' => '' ) );
29			$table->addColumn( 'address3', 'string', array( 'length' => 200, 'default' => '' ) );
30			$table->addColumn( 'postal', 'string', array( 'length' => 16, 'default' => '' ) );
31			$table->addColumn( 'city', 'string', array( 'length' => 200, 'default' => '' ) );
32			$table->addColumn( 'state', 'string', array( 'length' => 200, 'default' => '' ) );
33			$table->addColumn( 'langid', 'string', array( 'length' => 5, 'notnull' => false ) );
34			$table->addColumn( 'countryid', 'string', array( 'length' => 2, 'notnull' => false, 'fixed' => true ) );
35			$table->addColumn( 'telephone', 'string', array( 'length' => 32, 'default' => '' ) );
36			$table->addColumn( 'telefax', 'string', array( 'length' => 32, 'default' => '' ) );
37			$table->addColumn( 'website', 'string', array( 'length' => 255, 'default' => '' ) );
38			$table->addColumn( 'email', 'string', array( 'length' => 255 ) );
39			$table->addColumn( 'password', 'string', array( 'length' => 255 ) );
40			$table->addColumn( 'longitude', 'float', array( 'notnull' => false ) );

aimeos / ai-laravel

Push — master ( c1f25f...b3d94f )

lib/custom/setup/default/schema/customer.php (35 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like