Conditions | 6 |
Paths | 18 |
Total Lines | 53 |
Code Lines | 27 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
42 | public function migrate() |
||
43 | { |
||
44 | $schema = $this->getSchema( 'db-customer' ); |
||
45 | $sql = 'SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = \'users\' AND COLUMN_NAME = \'id\''; |
||
46 | |||
47 | try { |
||
48 | $type = $this->getValue( $sql, 'COLUMN_TYPE', 'db-customer' ); |
||
49 | } catch( \Aimeos\MW\Setup\Exception $e ) { |
||
50 | $type = null; |
||
51 | } |
||
52 | |||
53 | if( in_array( $type, ['int(10)', 'int(11)'] ) ) |
||
54 | { |
||
55 | $this->msg( sprintf( 'Remove signed constraints in users related tables' ), 0 ); |
||
56 | $this->status( '' ); |
||
57 | |||
58 | |||
59 | $this->msg( 'Checking constraint in "users_address"', 1 ); |
||
60 | |||
61 | if( $schema->constraintExists( 'users_address', 'fk_lvuad_pid' ) ) |
||
62 | { |
||
63 | $this->execute( 'ALTER TABLE "users_address" DROP FOREIGN KEY "fk_lvuad_pid"', 'db-customer' ); |
||
64 | $this->status( 'done' ); |
||
65 | } |
||
66 | else |
||
67 | { |
||
68 | $this->status( 'OK' ); |
||
69 | } |
||
70 | |||
71 | |||
72 | $this->msg( 'Checking constraint in "users_list"', 1 ); |
||
73 | |||
74 | if( $schema->constraintExists( 'users_list', 'fk_lvuli_pid' ) ) |
||
75 | { |
||
76 | $this->execute( 'ALTER TABLE "users_list" DROP FOREIGN KEY "fk_lvuli_pid"', 'db-customer' ); |
||
77 | $this->status( 'done' ); |
||
78 | } |
||
79 | else |
||
80 | { |
||
81 | $this->status( 'OK' ); |
||
82 | } |
||
83 | |||
84 | |||
85 | $this->msg( 'Checking constraint in "users_property"', 1 ); |
||
86 | |||
87 | if( $schema->constraintExists( 'users_property', 'fk_lvupr_pid' ) ) |
||
88 | { |
||
89 | $this->execute( 'ALTER TABLE "users_property" DROP FOREIGN KEY "fk_lvupr_pid"', 'db-customer' ); |
||
90 | $this->status( 'done' ); |
||
91 | } |
||
92 | else |
||
93 | { |
||
94 | $this->status( 'OK' ); |
||
95 | } |
||
98 | } |