LaravelTest::testSaveInvalid() - Code Metrics - Inspection of "Migrate from type IDs to type codes" - aimeos/ai-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c23c8...3a0c6f )

by Aimeos

created 2018-12-18 17:59 UTC

LaravelTest::testSaveInvalid() A

↳ Parent: LaravelTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2018
 */


namespace Aimeos\MShop\Customer\Manager\Property;


class LaravelTest extends \PHPUnit\Framework\TestCase
{
	private $object;
	private $editor = '';


	protected function setUp()

	{
		$context = \TestHelper::getContext();
		$this->editor = $context->getEditor();

		$manager = \Aimeos\MShop\Customer\Manager\Factory::createManager( $context, 'Laravel' );
		$this->object = $manager->getSubManager( 'property', 'Laravel' );
	}


	protected function tearDown()
	{
		unset( $this->object );
	}


	public function testCleanup()
	{
		$this->object->cleanup( array( -1 ) );
	}


	public function testCreateItem()
	{
		$item = $this->object->createItem();
		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Property\\Iface', $item );
	}


	public function testSaveInvalid()
	{
		$this->setExpectedException( \Aimeos\MW\Common\Exception::class );
		$this->object->saveItem( new \Aimeos\MShop\Locale\Item\Standard() );
	}


	public function testSaveUpdateDeleteItem()
	{
		$search = $this->object->createSearch();
		$search->setConditions( $search->compare( '==', 'customer.property.editor', $this->editor ) );
		$results = $this->object->searchItems( $search );

		if( ( $item = reset($results) ) === false ) {
			throw new \RuntimeException( 'No property item found' );
		}

		$item->setId(null);
		$item->setLanguageId( 'en' );
		$resultSaved = $this->object->saveItem( $item );
		$itemSaved = $this->object->getItem( $item->getId() );

		$itemExp = clone $itemSaved;
		$itemExp->setValue( 'unittest' );
		$resultUpd = $this->object->saveItem( $itemExp );
		$itemUpd = $this->object->getItem( $itemExp->getId() );

		$this->object->deleteItem( $itemSaved->getId() );

		$context = \TestHelper::getContext();

		$this->assertTrue( $item->getId() !== null );
		$this->assertEquals( $item->getId(), $itemSaved->getId() );
		$this->assertEquals( $item->getParentId(), $itemSaved->getParentId() );
		$this->assertEquals( $item->getSiteId(), $itemSaved->getSiteId() );
		$this->assertEquals( $item->getType(), $itemSaved->getType() );
		$this->assertEquals( $item->getLanguageId(), $itemSaved->getLanguageId() );
		$this->assertEquals( $item->getValue(), $itemSaved->getValue() );

		$this->assertEquals( $context->getEditor(), $itemSaved->getEditor() );
		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeCreated() );
		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified() );

		$this->assertEquals( $itemExp->getId(), $itemUpd->getId() );
		$this->assertEquals( $itemExp->getParentId(), $itemUpd->getParentId() );
		$this->assertEquals( $itemExp->getSiteId(), $itemUpd->getSiteId() );
		$this->assertEquals( $itemExp->getType(), $itemUpd->getType() );
		$this->assertEquals( $itemExp->getLanguageId(), $itemUpd->getLanguageId() );
		$this->assertEquals( $itemExp->getValue(), $itemUpd->getValue() );

		$this->assertEquals( $context->getEditor(), $itemUpd->getEditor() );
		$this->assertEquals( $itemExp->getTimeCreated(), $itemUpd->getTimeCreated() );
		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemUpd->getTimeModified() );

		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultSaved );
		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultUpd );

		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
		$this->object->getItem( $itemSaved->getId() );
	}


	public function testGetItem()

	{
		$search = $this->object->createSearch();
		$conditions = array(
			$search->compare( '~=', 'customer.property.value', '1'),
			$search->compare( '==', 'customer.property.editor', $this->editor )
		);
		$search->setConditions( $search->combine( '&&', $conditions ) );
		$results = $this->object->searchItems( $search );

		if( ($expected = reset($results)) === false ) {
			throw new \RuntimeException( sprintf( 'No customer property item found for value "%1$s".', '1' ) );
		}

		$actual = $this->object->getItem( $expected->getId() );
		$this->assertEquals( $expected, $actual );
	}


	public function testGetResourceType()
	{
		$result = $this->object->getResourceType();

		$this->assertContains( 'customer/property', $result );
	}


	public function testGetSearchAttributes()
	{
		foreach( $this->object->getSearchAttributes() as $attribute ) {
			$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Attribute\\Iface', $attribute );
		}
	}


	public function testSearchItems()
	{
		$total = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$search = $this->object->createSearch();

		$expr = [];
		$expr[] = $search->compare( '!=', 'customer.property.id', null );
		$expr[] = $search->compare( '!=', 'customer.property.parentid', null );
		$expr[] = $search->compare( '!=', 'customer.property.siteid', null );
		$expr[] = $search->compare( '==', 'customer.property.type', 'newsletter' );
		$expr[] = $search->compare( '==', 'customer.property.languageid', null );
		$expr[] = $search->compare( '==', 'customer.property.value', '1' );
		$expr[] = $search->compare( '==', 'customer.property.editor', $this->editor );
	}


	public function testGetSubManager()

	{
		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type') );
		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type', 'Standard') );

		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
		$this->object->getSubManager('unknown');
	}


	public function testGetSubManagerInvalidName()
	{
		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
		$this->object->getSubManager('type', 'unknown');
	}
}


1		<?php
2
3		/**
4		* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5		* @copyright Aimeos (aimeos.org), 2018
6		*/
7
8
9		namespace Aimeos\MShop\Customer\Manager\Property;
10
11
12		class LaravelTest extends \PHPUnit\Framework\TestCase
13		{
14		private $object;
15		private $editor = '';
16
17
18	View Code Duplication	protected function setUp()
		0 ignored issues – show Duplication introduced 2018-06-10 17:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$context = \TestHelper::getContext();
21		$this->editor = $context->getEditor();
22
23		$manager = \Aimeos\MShop\Customer\Manager\Factory::createManager( $context, 'Laravel' );
24		$this->object = $manager->getSubManager( 'property', 'Laravel' );
25		}
26
27
28		protected function tearDown()
29		{
30		unset( $this->object );
31		}
32
33
34		public function testCleanup()
35		{
36		$this->object->cleanup( array( -1 ) );
37		}
38
39
40		public function testCreateItem()
41		{
42		$item = $this->object->createItem();
43		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Property\\Iface', $item );
44		}
45
46
47		public function testSaveInvalid()
48		{
49		$this->setExpectedException( \Aimeos\MW\Common\Exception::class );
50		$this->object->saveItem( new \Aimeos\MShop\Locale\Item\Standard() );
51		}
52
53
54		public function testSaveUpdateDeleteItem()
55		{
56		$search = $this->object->createSearch();
57		$search->setConditions( $search->compare( '==', 'customer.property.editor', $this->editor ) );
58		$results = $this->object->searchItems( $search );
59
60		if( ( $item = reset($results) ) === false ) {
61		throw new \RuntimeException( 'No property item found' );
62		}
63
64		$item->setId(null);
65		$item->setLanguageId( 'en' );
66		$resultSaved = $this->object->saveItem( $item );
67		$itemSaved = $this->object->getItem( $item->getId() );
68
69		$itemExp = clone $itemSaved;
70		$itemExp->setValue( 'unittest' );
71		$resultUpd = $this->object->saveItem( $itemExp );
72		$itemUpd = $this->object->getItem( $itemExp->getId() );
73
74		$this->object->deleteItem( $itemSaved->getId() );
75
76		$context = \TestHelper::getContext();
77
78		$this->assertTrue( $item->getId() !== null );
79		$this->assertEquals( $item->getId(), $itemSaved->getId() );
80		$this->assertEquals( $item->getParentId(), $itemSaved->getParentId() );
81		$this->assertEquals( $item->getSiteId(), $itemSaved->getSiteId() );
82		$this->assertEquals( $item->getType(), $itemSaved->getType() );
83		$this->assertEquals( $item->getLanguageId(), $itemSaved->getLanguageId() );
84		$this->assertEquals( $item->getValue(), $itemSaved->getValue() );
85
86		$this->assertEquals( $context->getEditor(), $itemSaved->getEditor() );
87		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeCreated() );
88		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified() );
89
90		$this->assertEquals( $itemExp->getId(), $itemUpd->getId() );
91		$this->assertEquals( $itemExp->getParentId(), $itemUpd->getParentId() );
92		$this->assertEquals( $itemExp->getSiteId(), $itemUpd->getSiteId() );
93		$this->assertEquals( $itemExp->getType(), $itemUpd->getType() );
94		$this->assertEquals( $itemExp->getLanguageId(), $itemUpd->getLanguageId() );
95		$this->assertEquals( $itemExp->getValue(), $itemUpd->getValue() );
96
97		$this->assertEquals( $context->getEditor(), $itemUpd->getEditor() );
98		$this->assertEquals( $itemExp->getTimeCreated(), $itemUpd->getTimeCreated() );
99		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemUpd->getTimeModified() );
100
101		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultSaved );
102		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultUpd );
103
104		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
105		$this->object->getItem( $itemSaved->getId() );
106		}
107
108
109	View Code Duplication	public function testGetItem()
		0 ignored issues – show Duplication introduced 2018-12-18 18:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111		$search = $this->object->createSearch();
112		$conditions = array(
113		$search->compare( '~=', 'customer.property.value', '1'),
114		$search->compare( '==', 'customer.property.editor', $this->editor )
115		);
116		$search->setConditions( $search->combine( '&&', $conditions ) );
117		$results = $this->object->searchItems( $search );
118
119		if( ($expected = reset($results)) === false ) {
120		throw new \RuntimeException( sprintf( 'No customer property item found for value "%1$s".', '1' ) );
121		}
122
123		$actual = $this->object->getItem( $expected->getId() );
124		$this->assertEquals( $expected, $actual );
125		}
126
127
128		public function testGetResourceType()
129		{
130		$result = $this->object->getResourceType();
131
132		$this->assertContains( 'customer/property', $result );
133		}
134
135
136		public function testGetSearchAttributes()
137		{
138		foreach( $this->object->getSearchAttributes() as $attribute ) {
139		$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Attribute\\Iface', $attribute );
140		}
141		}
142
143
144		public function testSearchItems()
145		{
146		$total = 0;
		0 ignored issues – show Unused Code introduced 2018-12-18 18:01 UTC by Report Bug Copy Issue Report `$total` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
147		$search = $this->object->createSearch();
148
149		$expr = [];
150		$expr[] = $search->compare( '!=', 'customer.property.id', null );
151		$expr[] = $search->compare( '!=', 'customer.property.parentid', null );
152		$expr[] = $search->compare( '!=', 'customer.property.siteid', null );
153		$expr[] = $search->compare( '==', 'customer.property.type', 'newsletter' );
154		$expr[] = $search->compare( '==', 'customer.property.languageid', null );
155		$expr[] = $search->compare( '==', 'customer.property.value', '1' );
156		$expr[] = $search->compare( '==', 'customer.property.editor', $this->editor );
157		}
158
159
160	View Code Duplication	public function testGetSubManager()
		0 ignored issues – show Duplication introduced 2018-06-10 17:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
161		{
162		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type') );
163		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type', 'Standard') );
164
165		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
166		$this->object->getSubManager('unknown');
167		}
168
169
170		public function testGetSubManagerInvalidName()
171		{
172		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
173		$this->object->getSubManager('type', 'unknown');
174		}
175		}
176

aimeos / ai-laravel

Push — master ( 8c23c8...3a0c6f )

LaravelTest::testSaveInvalid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like