Conditions | 1 |
Paths | 1 |
Total Lines | 81 |
Code Lines | 70 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
111 | public function testSaveUpdateDeleteItem() |
||
112 | { |
||
113 | $item = new \Aimeos\MShop\Common\Item\Address\Standard( 'customer.address.', $this->fixture ); |
||
114 | $item->setId( null ); |
||
115 | $resultSaved = $this->object->saveItem( $item ); |
||
116 | $itemSaved = $this->object->getItem( $item->getId() ); |
||
117 | |||
118 | $itemExp = clone $itemSaved; |
||
119 | $itemExp->setPosition( 1 ); |
||
120 | $itemExp->setCity( 'Berlin' ); |
||
121 | $itemExp->setState( 'Berlin' ); |
||
122 | $resultUpd = $this->object->saveItem( $itemExp ); |
||
123 | $itemUpd = $this->object->getItem( $itemExp->getId() ); |
||
124 | |||
125 | $this->object->deleteItem( $itemSaved->getId() ); |
||
126 | |||
127 | |||
128 | $this->assertTrue( $item->getId() !== null ); |
||
129 | $this->assertEquals( $item->getId(), $itemSaved->getId() ); |
||
130 | $this->assertEquals( $item->getParentId(), $itemSaved->getParentId() ); |
||
131 | $this->assertEquals( $item->getPosition(), $itemSaved->getPosition() ); |
||
132 | $this->assertEquals( $item->getCompany(), $itemSaved->getCompany() ); |
||
133 | $this->assertEquals( $item->getVatID(), $itemSaved->getVatID() ); |
||
134 | $this->assertEquals( $item->getSalutation(), $itemSaved->getSalutation() ); |
||
135 | $this->assertEquals( $item->getTitle(), $itemSaved->getTitle() ); |
||
136 | $this->assertEquals( $item->getFirstname(), $itemSaved->getFirstname() ); |
||
137 | $this->assertEquals( $item->getLastname(), $itemSaved->getLastname() ); |
||
138 | $this->assertEquals( $item->getAddress1(), $itemSaved->getAddress1() ); |
||
139 | $this->assertEquals( $item->getAddress2(), $itemSaved->getAddress2() ); |
||
140 | $this->assertEquals( $item->getAddress3(), $itemSaved->getAddress3() ); |
||
141 | $this->assertEquals( $item->getPostal(), $itemSaved->getPostal() ); |
||
142 | $this->assertEquals( $item->getCity(), $itemSaved->getCity() ); |
||
143 | $this->assertEquals( $item->getState(), $itemSaved->getState() ); |
||
144 | $this->assertEquals( $item->getCountryId(), $itemSaved->getCountryId() ); |
||
145 | $this->assertEquals( $item->getLanguageId(), $itemSaved->getLanguageId() ); |
||
146 | $this->assertEquals( $item->getTelephone(), $itemSaved->getTelephone() ); |
||
147 | $this->assertEquals( $item->getEmail(), $itemSaved->getEmail() ); |
||
148 | $this->assertEquals( $item->getTelefax(), $itemSaved->getTelefax() ); |
||
149 | $this->assertEquals( $item->getWebsite(), $itemSaved->getWebsite() ); |
||
150 | $this->assertEquals( $item->getLongitude(), $itemSaved->getLongitude() ); |
||
151 | $this->assertEquals( $item->getLatitude(), $itemSaved->getLatitude() ); |
||
152 | $this->assertEquals( $item->getBirthday(), $itemSaved->getBirthday() ); |
||
153 | |||
154 | $this->assertEquals( $this->editor, $itemSaved->getEditor() ); |
||
155 | $this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeCreated() ); |
||
156 | $this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified() ); |
||
157 | |||
158 | $this->assertEquals( $itemExp->getId(), $itemUpd->getId() ); |
||
159 | $this->assertEquals( $itemExp->getParentId(), $itemUpd->getParentId() ); |
||
160 | $this->assertEquals( $itemExp->getPosition(), $itemUpd->getPosition() ); |
||
161 | $this->assertEquals( $itemExp->getCompany(), $itemUpd->getCompany() ); |
||
162 | $this->assertEquals( $itemExp->getVatID(), $itemUpd->getVatID() ); |
||
163 | $this->assertEquals( $itemExp->getSalutation(), $itemUpd->getSalutation() ); |
||
164 | $this->assertEquals( $itemExp->getTitle(), $itemUpd->getTitle() ); |
||
165 | $this->assertEquals( $itemExp->getFirstname(), $itemUpd->getFirstname() ); |
||
166 | $this->assertEquals( $itemExp->getLastname(), $itemUpd->getLastname() ); |
||
167 | $this->assertEquals( $itemExp->getAddress1(), $itemUpd->getAddress1() ); |
||
168 | $this->assertEquals( $itemExp->getAddress2(), $itemUpd->getAddress2() ); |
||
169 | $this->assertEquals( $itemExp->getAddress3(), $itemUpd->getAddress3() ); |
||
170 | $this->assertEquals( $itemExp->getPostal(), $itemUpd->getPostal() ); |
||
171 | $this->assertEquals( $itemExp->getCity(), $itemUpd->getCity() ); |
||
172 | $this->assertEquals( $itemExp->getState(), $itemUpd->getState() ); |
||
173 | $this->assertEquals( $itemExp->getCountryId(), $itemUpd->getCountryId() ); |
||
174 | $this->assertEquals( $itemExp->getLanguageId(), $itemUpd->getLanguageId() ); |
||
175 | $this->assertEquals( $itemExp->getTelephone(), $itemUpd->getTelephone() ); |
||
176 | $this->assertEquals( $itemExp->getEmail(), $itemUpd->getEmail() ); |
||
177 | $this->assertEquals( $itemExp->getTelefax(), $itemUpd->getTelefax() ); |
||
178 | $this->assertEquals( $itemExp->getWebsite(), $itemUpd->getWebsite() ); |
||
179 | $this->assertEquals( $itemExp->getLongitude(), $itemUpd->getLongitude() ); |
||
180 | $this->assertEquals( $itemExp->getLatitude(), $itemUpd->getLatitude() ); |
||
181 | $this->assertEquals( $itemExp->getBirthday(), $itemUpd->getBirthday() ); |
||
182 | |||
183 | $this->assertEquals( $this->editor, $itemUpd->getEditor() ); |
||
184 | $this->assertEquals( $itemExp->getTimeCreated(), $itemUpd->getTimeCreated() ); |
||
185 | $this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemUpd->getTimeModified() ); |
||
186 | |||
187 | $this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultSaved ); |
||
188 | $this->assertInstanceOf( \Aimeos\MShop\Common\Item\Iface::class, $resultUpd ); |
||
189 | |||
190 | $this->expectException( '\\Aimeos\\MShop\\Exception' ); |
||
191 | $this->object->getItem( $itemSaved->getId() ); |
||
192 | } |
||
261 |