Inspection of "Merge branch 'master' of https://github.com/aimeos..." - aimeos/ai-filesystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ec1d8c...21580b )

by Aimeos

created 2016-03-31 14:13 UTC

Status

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -7,32 +7,32 @@
 block discarded – undo
 {
 	protected function setUp()
 	{
-		if( !interface_exists( '\\League\\Flysystem\\FilesystemInterface' ) ) {
-			$this->markTestSkipped( 'Install Flysystem first' );
+		if (!interface_exists('\\League\\Flysystem\\FilesystemInterface')) {
+			$this->markTestSkipped('Install Flysystem first');
 		}
 	}
 
 
 	public function testGetProvider()
 	{
-		if( !class_exists( '\League\Flysystem\AwsS3v3\AwsS3Adapter' ) ) {
-			$this->markTestSkipped( 'Install Flysystem AwsS3v3 adapter' );
+		if (!class_exists('\League\Flysystem\AwsS3v3\AwsS3Adapter')) {
+			$this->markTestSkipped('Install Flysystem AwsS3v3 adapter');
 		}
 
-		$object = new FlyAwsS3( array( 'bucket' => 'test' ) );
-		$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
+		$object = new FlyAwsS3(array('bucket' => 'test'));
+		$this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
 
-		$this->setExpectedException( 'InvalidArgumentException' );
-		$object->has( 'test' );
+		$this->setExpectedException('InvalidArgumentException');
+		$object->has('test');
 	}
 
 
 	public function testGetProviderNoBucket()
 	{
-		$object = new FlyAwsS3( array() );
-		$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
+		$object = new FlyAwsS3(array());
+		$this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
 
-		$this->setExpectedException( '\Aimeos\MW\Filesystem\Exception' );
-		$object->has( 'test' );
+		$this->setExpectedException('\Aimeos\MW\Filesystem\Exception');
+		$object->has('test');
 	}
 }

Please login to merge, or discard this patch.

lib/custom/tests/MW/Filesystem/FlyReplicateTest.php 1 patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -7,27 +7,27 @@  discard block
 block discarded – undo
 {
 	protected function setUp()
 	{
-		if( !interface_exists( '\\League\\Flysystem\\FilesystemInterface' ) ) {
-			$this->markTestSkipped( 'Install Flysystem first' );
+		if (!interface_exists('\\League\\Flysystem\\FilesystemInterface')) {
+			$this->markTestSkipped('Install Flysystem first');
 		}
 	}
 
 
 	public function testGetProvider()
 	{
-		if( !class_exists( '\League\Flysystem\Replicate\ReplicateAdapter' ) ) {
-			$this->markTestSkipped( 'Install Flysystem Replicate adapter' );
+		if (!class_exists('\League\Flysystem\Replicate\ReplicateAdapter')) {
+			$this->markTestSkipped('Install Flysystem Replicate adapter');
 		}
 
 		$config = array(
 			'adapter' => 'Replicate',
-			'source' => array( 'adapter' => 'FlyMemory' ),
-			'replica' => array( 'adapter' => 'FlyMemory' ),
+			'source' => array('adapter' => 'FlyMemory'),
+			'replica' => array('adapter' => 'FlyMemory'),
 		);
-		$object = new FlyReplicate( $config );
-		$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
+		$object = new FlyReplicate($config);
+		$this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
 
-		$object->has( 'test' );
+		$object->has('test');
 	}
 
 
@@ -36,11 +36,11 @@  discard block
 block discarded – undo
 		$config = array(
 			'adapter' => 'Replicate',
 		);
-		$object = new FlyReplicate( $config );
-		$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
+		$object = new FlyReplicate($config);
+		$this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
 
-		$this->setExpectedException( 'Aimeos\MW\Filesystem\Exception' );
-		$object->has( 'test' );
+		$this->setExpectedException('Aimeos\MW\Filesystem\Exception');
+		$object->has('test');
 	}
 
 
@@ -48,12 +48,12 @@  discard block
 block discarded – undo
 	{
 		$config = array(
 			'adapter' => 'Replicate',
-			'source' => array( 'adapter' => 'FlyMemory' ),
+			'source' => array('adapter' => 'FlyMemory'),
 		);
-		$object = new FlyReplicate( $config );
-		$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
+		$object = new FlyReplicate($config);
+		$this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
 
-		$this->setExpectedException( 'Aimeos\MW\Filesystem\Exception' );
-		$object->has( 'test' );
+		$this->setExpectedException('Aimeos\MW\Filesystem\Exception');
+		$object->has('test');
 	}
 }

Please login to merge, or discard this patch.

lib/custom/tests/MW/Filesystem/FlyWebdavTest.php 2 patches

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -7,42 +7,42 @@
 block discarded – undo
 {
 	protected function setUp()
 	{
-		if( !interface_exists( '\\League\\Flysystem\\FilesystemInterface' ) ) {
-			$this->markTestSkipped( 'Install Flysystem first' );
+		if (!interface_exists('\\League\\Flysystem\\FilesystemInterface')) {
+			$this->markTestSkipped('Install Flysystem first');
 		}
 	}
 
 
 	public function testGetProvider()
 	{
-		if( !class_exists( '\League\Flysystem\WebDAV\WebDAVAdapter' ) ) {
-			$this->markTestSkipped( 'Install Flysystem WebDAV adapter' );
+		if (!class_exists('\League\Flysystem\WebDAV\WebDAVAdapter')) {
+			$this->markTestSkipped('Install Flysystem WebDAV adapter');
 		}
 
 		try
 		{
-			$object = new FlyWebdav( array( 'baseUri' => 'http://test.webdav.org/dav/' ) );
-			$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
+			$object = new FlyWebdav(array('baseUri' => 'http://test.webdav.org/dav/'));
+			$this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
 
-			$object->has( 'test' );
+			$object->has('test');
 		}
-		catch( \Sabre\HTTP\ClientException $e )
+		catch (\Sabre\HTTP\ClientException $e)
 		{
-			$this->markTestSkipped( $e->getMessage() );
+			$this->markTestSkipped($e->getMessage());
 		}
 	}
 
 
 	public function testGetProviderNoBaseuri()
 	{
-		if( !class_exists( '\League\Flysystem\WebDAV\WebDAVAdapter' ) ) {
-			$this->markTestSkipped( 'Install Flysystem WebDAV adapter' );
+		if (!class_exists('\League\Flysystem\WebDAV\WebDAVAdapter')) {
+			$this->markTestSkipped('Install Flysystem WebDAV adapter');
 		}
 
-		$object = new FlyWebdav( array() );
-		$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
+		$object = new FlyWebdav(array());
+		$this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
 
-		$this->setExpectedException( '\InvalidArgumentException' );
-		$object->has( 'test' );
+		$this->setExpectedException('\InvalidArgumentException');
+		$object->has('test');
 	}
 }

Please login to merge, or discard this patch.

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -25,8 +25,7 @@
 block discarded – undo
 			$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
 
 			$object->has( 'test' );
-		}
-		catch( \Sabre\HTTP\ClientException $e )
+		} catch( \Sabre\HTTP\ClientException $e )
 		{
 			$this->markTestSkipped( $e->getMessage() );
 		}

Please login to merge, or discard this patch.

		@@ -7,32 +7,32 @@
		block discarded – undo
7	7	{
8	8	protected function setUp()
9	9	{
10		- if( !interface_exists( '\\League\\Flysystem\\FilesystemInterface' ) ) {
11		- $this->markTestSkipped( 'Install Flysystem first' );
	10	+ if (!interface_exists('\\League\\Flysystem\\FilesystemInterface')) {
	11	+ $this->markTestSkipped('Install Flysystem first');
12	12	}
13	13	}
14	14
15	15
16	16	public function testGetProvider()
17	17	{
18		- if( !class_exists( '\League\Flysystem\AwsS3v3\AwsS3Adapter' ) ) {
19		- $this->markTestSkipped( 'Install Flysystem AwsS3v3 adapter' );
	18	+ if (!class_exists('\League\Flysystem\AwsS3v3\AwsS3Adapter')) {
	19	+ $this->markTestSkipped('Install Flysystem AwsS3v3 adapter');
20	20	}
21	21
22		- $object = new FlyAwsS3( array( 'bucket' => 'test' ) );
23		- $this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
	22	+ $object = new FlyAwsS3(array('bucket' => 'test'));
	23	+ $this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
24	24
25		- $this->setExpectedException( 'InvalidArgumentException' );
26		- $object->has( 'test' );
	25	+ $this->setExpectedException('InvalidArgumentException');
	26	+ $object->has('test');
27	27	}
28	28
29	29
30	30	public function testGetProviderNoBucket()
31	31	{
32		- $object = new FlyAwsS3( array() );
33		- $this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
	32	+ $object = new FlyAwsS3(array());
	33	+ $this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
34	34
35		- $this->setExpectedException( '\Aimeos\MW\Filesystem\Exception' );
36		- $object->has( 'test' );
	35	+ $this->setExpectedException('\Aimeos\MW\Filesystem\Exception');
	36	+ $object->has('test');
37	37	}
38	38	}

		@@ -7,27 +7,27 @@ discard block
		block discarded – undo
7	7	{
8	8	protected function setUp()
9	9	{
10		- if( !interface_exists( '\\League\\Flysystem\\FilesystemInterface' ) ) {
11		- $this->markTestSkipped( 'Install Flysystem first' );
	10	+ if (!interface_exists('\\League\\Flysystem\\FilesystemInterface')) {
	11	+ $this->markTestSkipped('Install Flysystem first');
12	12	}
13	13	}
14	14
15	15
16	16	public function testGetProvider()
17	17	{
18		- if( !class_exists( '\League\Flysystem\Replicate\ReplicateAdapter' ) ) {
19		- $this->markTestSkipped( 'Install Flysystem Replicate adapter' );
	18	+ if (!class_exists('\League\Flysystem\Replicate\ReplicateAdapter')) {
	19	+ $this->markTestSkipped('Install Flysystem Replicate adapter');
20	20	}
21	21
22	22	$config = array(
23	23	'adapter' => 'Replicate',
24		- 'source' => array( 'adapter' => 'FlyMemory' ),
25		- 'replica' => array( 'adapter' => 'FlyMemory' ),
	24	+ 'source' => array('adapter' => 'FlyMemory'),
	25	+ 'replica' => array('adapter' => 'FlyMemory'),
26	26	);
27		- $object = new FlyReplicate( $config );
28		- $this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
	27	+ $object = new FlyReplicate($config);
	28	+ $this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
29	29
30		- $object->has( 'test' );
	30	+ $object->has('test');
31	31	}
32	32
33	33
		@@ -36,11 +36,11 @@ discard block
		block discarded – undo
36	36	$config = array(
37	37	'adapter' => 'Replicate',
38	38	);
39		- $object = new FlyReplicate( $config );
40		- $this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
	39	+ $object = new FlyReplicate($config);
	40	+ $this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
41	41
42		- $this->setExpectedException( 'Aimeos\MW\Filesystem\Exception' );
43		- $object->has( 'test' );
	42	+ $this->setExpectedException('Aimeos\MW\Filesystem\Exception');
	43	+ $object->has('test');
44	44	}
45	45
46	46
		@@ -48,12 +48,12 @@ discard block
		block discarded – undo
48	48	{
49	49	$config = array(
50	50	'adapter' => 'Replicate',
51		- 'source' => array( 'adapter' => 'FlyMemory' ),
	51	+ 'source' => array('adapter' => 'FlyMemory'),
52	52	);
53		- $object = new FlyReplicate( $config );
54		- $this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
	53	+ $object = new FlyReplicate($config);
	54	+ $this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
55	55
56		- $this->setExpectedException( 'Aimeos\MW\Filesystem\Exception' );
57		- $object->has( 'test' );
	56	+ $this->setExpectedException('Aimeos\MW\Filesystem\Exception');
	57	+ $object->has('test');
58	58	}
59	59	}

		@@ -7,42 +7,42 @@
		block discarded – undo
7	7	{
8	8	protected function setUp()
9	9	{
10		- if( !interface_exists( '\\League\\Flysystem\\FilesystemInterface' ) ) {
11		- $this->markTestSkipped( 'Install Flysystem first' );
	10	+ if (!interface_exists('\\League\\Flysystem\\FilesystemInterface')) {
	11	+ $this->markTestSkipped('Install Flysystem first');
12	12	}
13	13	}
14	14
15	15
16	16	public function testGetProvider()
17	17	{
18		- if( !class_exists( '\League\Flysystem\WebDAV\WebDAVAdapter' ) ) {
19		- $this->markTestSkipped( 'Install Flysystem WebDAV adapter' );
	18	+ if (!class_exists('\League\Flysystem\WebDAV\WebDAVAdapter')) {
	19	+ $this->markTestSkipped('Install Flysystem WebDAV adapter');
20	20	}
21	21
22	22	try
23	23	{
24		- $object = new FlyWebdav( array( 'baseUri' => 'http://test.webdav.org/dav/' ) );
25		- $this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
	24	+ $object = new FlyWebdav(array('baseUri' => 'http://test.webdav.org/dav/'));
	25	+ $this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
26	26
27		- $object->has( 'test' );
	27	+ $object->has('test');
28	28	}
29		- catch( \Sabre\HTTP\ClientException $e )
	29	+ catch (\Sabre\HTTP\ClientException $e)
30	30	{
31		- $this->markTestSkipped( $e->getMessage() );
	31	+ $this->markTestSkipped($e->getMessage());
32	32	}
33	33	}
34	34
35	35
36	36	public function testGetProviderNoBaseuri()
37	37	{
38		- if( !class_exists( '\League\Flysystem\WebDAV\WebDAVAdapter' ) ) {
39		- $this->markTestSkipped( 'Install Flysystem WebDAV adapter' );
	38	+ if (!class_exists('\League\Flysystem\WebDAV\WebDAVAdapter')) {
	39	+ $this->markTestSkipped('Install Flysystem WebDAV adapter');
40	40	}
41	41
42		- $object = new FlyWebdav( array() );
43		- $this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
	42	+ $object = new FlyWebdav(array());
	43	+ $this->assertInstanceof('\Aimeos\MW\Filesystem\Iface', $object);
44	44
45		- $this->setExpectedException( '\InvalidArgumentException' );
46		- $object->has( 'test' );
	45	+ $this->setExpectedException('\InvalidArgumentException');
	46	+ $object->has('test');
47	47	}
48	48	}

		@@ -25,8 +25,7 @@
		block discarded – undo
25	25	$this->assertInstanceof( '\Aimeos\MW\Filesystem\Iface', $object );
26	26
27	27	$object->has( 'test' );
28		- }
29		- catch( \Sabre\HTTP\ClientException $e )
	28	+ } catch( \Sabre\HTTP\ClientException $e )
30	29	{
31	30	$this->markTestSkipped( $e->getMessage() );
32	31	}

aimeos / ai-filesystem

Push — master ( ec1d8c...21580b )

Status

Category

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch