EzpublishTest::testSaveUpdateDeleteItem() - Code Metrics - Inspection of "Improved code coverage" - aimeos/ai-ezpublish - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 752129...3cf842 )

by Aimeos

created 2016-06-23 23:46 UTC

EzpublishTest::testSaveUpdateDeleteItem() A

↳ Parent: EzpublishTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	75
Code Lines	65

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	75
rs	9
cc	1
eloc	65
nc	1
nop	0

How to fix Long Method

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2016
 */


namespace Aimeos\MShop\Customer\Manager\Address;


class EzpublishTest extends \PHPUnit_Framework_TestCase
{
	private $fixture = null;
	private $object = null;
	private $editor = '';


	protected function setUp()
	{
		$context = \TestHelper::getContext();
		$this->editor = $context->getEditor();
		$customer = new \Aimeos\MShop\Customer\Manager\Ezpublish( $context );

		$search = $customer->createSearch();
		$conditions = array(
			$search->compare( '==', 'customer.code', 'UTC001' ),
			$search->compare( '==', 'customer.editor', $this->editor )
		);
		$search->setConditions( $search->combine( '&&', $conditions ) );
		$result = $customer->searchItems( $search );

		if( ( $customerItem = reset( $result ) ) === false ) {
			throw new \Exception( sprintf( 'No customer item found for code "%1$s"', 'UTC001' ) );
		}

		$this->fixture = array(
			'customer.address.parentid' => $customerItem->getId(),
			'customer.address.company' => 'ABC GmbH',
			'customer.address.vatid' => 'DE999999999',
			'customer.address.salutation' => \Aimeos\MShop\Common\Item\Address\Base::SALUTATION_MR,
			'customer.address.title' => 'Herr',
			'customer.address.firstname' => 'firstunit',
			'customer.address.lastname' => 'lastunit',
			'customer.address.address1' => 'unit str.',
			'customer.address.address2' => ' 166',
			'customer.address.address3' => '4.OG',
			'customer.address.postal' => '22769',
			'customer.address.city' => 'Hamburg',
			'customer.address.state' => 'Hamburg',
			'customer.address.countryid' => 'de',
			'customer.address.languageid' => 'de',
			'customer.address.telephone' => '05554433221',
			'customer.address.email' => '[email protected]',
			'customer.address.telefax' => '05554433222',
			'customer.address.website' => 'unittest.aimeos.org',
			'customer.address.position' => 1,
			'customer.address.siteid' => $context->getLocale()->getSiteId(),
		);

		$this->object = $customer->getSubManager( 'address', 'Ezpublish' );
	}


	protected function tearDown()
	{
		unset( $this->object, $this->fixture );
	}


	public function testCleanup()
	{
		$this->object->cleanup( array( -1 ) );
	}

	public function testGetSearchAttributes()
	{
		foreach( $this->object->getSearchAttributes() as $attribute ) {
			$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Attribute\\Iface', $attribute );
		}
	}

	public function testGetSubManager()
	{
		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
		$this->object->getSubManager( 'unknown' );
	}

	public function testCreateItem()
	{
		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Address\\Iface', $this->object->createItem() );
	}

	public function testGetItem()
	{
		$search = $this->object->createSearch();
		$search->setConditions( $search->compare( '~=', 'customer.address.company', 'ABC GmbH' ) );

		$items = $this->object->searchItems( $search );

		if( ( $item = reset( $items ) ) === false ) {
			throw new \Exception( 'No address item with company "ABC" found' );
		}

		$this->assertEquals( $item, $this->object->getItem( $item->getId() ) );
	}

	public function testSaveUpdateDeleteItem()
	{
		$item = new \Aimeos\MShop\Common\Item\Address\Standard( 'customer.address.', $this->fixture );
		$item->setId( null );
		$this->object->saveItem( $item );
		$itemSaved = $this->object->getItem( $item->getId() );

		$itemExp = clone $itemSaved;
		$itemExp->setPosition( 1 );
		$itemExp->setCity( 'Berlin' );
		$itemExp->setState( 'Berlin' );
		$this->object->saveItem( $itemExp );
		$itemUpd = $this->object->getItem( $itemExp->getId() );

		$this->object->deleteItem( $itemSaved->getId() );


		$this->assertTrue( $item->getId() !== null );
		$this->assertEquals( $item->getId(), $itemSaved->getId() );
		$this->assertEquals( $item->getParentId(), $itemSaved->getParentId());
		$this->assertEquals( $item->getPosition(), $itemSaved->getPosition());
		$this->assertEquals( $item->getCompany(), $itemSaved->getCompany());
		$this->assertEquals( $item->getVatID(), $itemSaved->getVatID());
		$this->assertEquals( $item->getSalutation(), $itemSaved->getSalutation());
		$this->assertEquals( $item->getTitle(), $itemSaved->getTitle());
		$this->assertEquals( $item->getFirstname(), $itemSaved->getFirstname());
		$this->assertEquals( $item->getLastname(), $itemSaved->getLastname());
		$this->assertEquals( $item->getAddress1(), $itemSaved->getAddress1());
		$this->assertEquals( $item->getAddress2(), $itemSaved->getAddress2());
		$this->assertEquals( $item->getAddress3(), $itemSaved->getAddress3());
		$this->assertEquals( $item->getPostal(), $itemSaved->getPostal());
		$this->assertEquals( $item->getCity(), $itemSaved->getCity());
		$this->assertEquals( $item->getState(), $itemSaved->getState());
		$this->assertEquals( $item->getCountryId(), $itemSaved->getCountryId());
		$this->assertEquals( $item->getLanguageId(), $itemSaved->getLanguageId());
		$this->assertEquals( $item->getTelephone(), $itemSaved->getTelephone());
		$this->assertEquals( $item->getEmail(), $itemSaved->getEmail());
		$this->assertEquals( $item->getTelefax(), $itemSaved->getTelefax());
		$this->assertEquals( $item->getWebsite(), $itemSaved->getWebsite());
		$this->assertEquals( $item->getFlag(), $itemSaved->getFlag());

		$this->assertEquals( $this->editor, $itemSaved->getEditor() );
		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeCreated() );
		$this->assertRegExp('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified());

		$this->assertEquals( $itemExp->getId(), $itemUpd->getId() );
		$this->assertEquals( $itemExp->getParentId(), $itemUpd->getParentId());
		$this->assertEquals( $itemExp->getPosition(), $itemUpd->getPosition());
		$this->assertEquals( $itemExp->getCompany(), $itemUpd->getCompany());
		$this->assertEquals( $itemExp->getVatID(), $itemUpd->getVatID());
		$this->assertEquals( $itemExp->getSalutation(), $itemUpd->getSalutation());
		$this->assertEquals( $itemExp->getTitle(), $itemUpd->getTitle());
		$this->assertEquals( $itemExp->getFirstname(), $itemUpd->getFirstname());
		$this->assertEquals( $itemExp->getLastname(), $itemUpd->getLastname());
		$this->assertEquals( $itemExp->getAddress1(), $itemUpd->getAddress1());
		$this->assertEquals( $itemExp->getAddress2(), $itemUpd->getAddress2());
		$this->assertEquals( $itemExp->getAddress3(), $itemUpd->getAddress3());
		$this->assertEquals( $itemExp->getPostal(), $itemUpd->getPostal());
		$this->assertEquals( $itemExp->getCity(), $itemUpd->getCity());
		$this->assertEquals( $itemExp->getState(), $itemUpd->getState());
		$this->assertEquals( $itemExp->getCountryId(), $itemUpd->getCountryId());
		$this->assertEquals( $itemExp->getLanguageId(), $itemUpd->getLanguageId());
		$this->assertEquals( $itemExp->getTelephone(), $itemUpd->getTelephone());
		$this->assertEquals( $itemExp->getEmail(), $itemUpd->getEmail());
		$this->assertEquals( $itemExp->getTelefax(), $itemUpd->getTelefax());
		$this->assertEquals( $itemExp->getWebsite(), $itemUpd->getWebsite());
		$this->assertEquals( $itemExp->getFlag(), $itemUpd->getFlag());

		$this->assertEquals( $this->editor, $itemUpd->getEditor() );
		$this->assertEquals( $itemExp->getTimeCreated(), $itemUpd->getTimeCreated() );
		$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemUpd->getTimeModified() );

		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
		$this->object->getItem( $itemSaved->getId() );
	}

	public function testCreateSearch()
	{
		$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Iface', $this->object->createSearch() );
	}


	public function testSearchItem()
	{
		$search = $this->object->createSearch();

		$conditions = array(
			$search->compare( '==', 'customer.address.company', 'ABC' ),
			$search->compare( '==', 'customer.address.editor', $this->editor )
		);
		$search->setConditions( $search->combine( '&&', $conditions ) );
		$this->assertEquals( 1, count( $this->object->searchItems( $search ) ) );
	}


	public function testSearchItemTotal()
	{
		$total = 0;
		$search = $this->object->createSearch();

		$conditions = array(
			$search->compare( '~=', 'customer.address.company', 'ABC GmbH' ),
			$search->compare( '==', 'customer.address.editor', $this->editor )
		);

		$search->setConditions( $search->combine( '&&', $conditions ) );
		$search->setSlice( 0, 1 );

		$results = $this->object->searchItems( $search, array(), $total );

		$this->assertEquals( 1, count( $results ) );
		$this->assertEquals( 2, $total );

		foreach( $results as $id => $item ) {
			$this->assertEquals( $id, $item->getId() );
		}
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2016
6			*/
7
8
9			namespace Aimeos\MShop\Customer\Manager\Address;
10
11
12			class EzpublishTest extends \PHPUnit_Framework_TestCase
13			{
14			private $fixture = null;
15			private $object = null;
16			private $editor = '';
17
18
19			protected function setUp()
20			{
21			$context = \TestHelper::getContext();
22			$this->editor = $context->getEditor();
23			$customer = new \Aimeos\MShop\Customer\Manager\Ezpublish( $context );
24
25			$search = $customer->createSearch();
26			$conditions = array(
27			$search->compare( '==', 'customer.code', 'UTC001' ),
28			$search->compare( '==', 'customer.editor', $this->editor )
29			);
30			$search->setConditions( $search->combine( '&&', $conditions ) );
31			$result = $customer->searchItems( $search );
32
33			if( ( $customerItem = reset( $result ) ) === false ) {
34			throw new \Exception( sprintf( 'No customer item found for code "%1$s"', 'UTC001' ) );
35			}
36
37			$this->fixture = array(
38			'customer.address.parentid' => $customerItem->getId(),
39			'customer.address.company' => 'ABC GmbH',
40			'customer.address.vatid' => 'DE999999999',
41			'customer.address.salutation' => \Aimeos\MShop\Common\Item\Address\Base::SALUTATION_MR,
42			'customer.address.title' => 'Herr',
43			'customer.address.firstname' => 'firstunit',
44			'customer.address.lastname' => 'lastunit',
45			'customer.address.address1' => 'unit str.',
46			'customer.address.address2' => ' 166',
47			'customer.address.address3' => '4.OG',
48			'customer.address.postal' => '22769',
49			'customer.address.city' => 'Hamburg',
50			'customer.address.state' => 'Hamburg',
51			'customer.address.countryid' => 'de',
52			'customer.address.languageid' => 'de',
53			'customer.address.telephone' => '05554433221',
54			'customer.address.email' => '[email protected]',
55			'customer.address.telefax' => '05554433222',
56			'customer.address.website' => 'unittest.aimeos.org',
57			'customer.address.position' => 1,
58			'customer.address.siteid' => $context->getLocale()->getSiteId(),
59			);
60
61			$this->object = $customer->getSubManager( 'address', 'Ezpublish' );
62			}
63
64
65			protected function tearDown()
66			{
67			unset( $this->object, $this->fixture );
68			}
69
70
71			public function testCleanup()
72			{
73			$this->object->cleanup( array( -1 ) );
74			}
75
76			public function testGetSearchAttributes()
77			{
78			foreach( $this->object->getSearchAttributes() as $attribute ) {
79			$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Attribute\\Iface', $attribute );
80			}
81			}
82
83			public function testGetSubManager()
84			{
85			$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
86			$this->object->getSubManager( 'unknown' );
87			}
88
89			public function testCreateItem()
90			{
91			$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Address\\Iface', $this->object->createItem() );
92			}
93
94			public function testGetItem()
95			{
96			$search = $this->object->createSearch();
97			$search->setConditions( $search->compare( '~=', 'customer.address.company', 'ABC GmbH' ) );
98
99			$items = $this->object->searchItems( $search );
100
101			if( ( $item = reset( $items ) ) === false ) {
102			throw new \Exception( 'No address item with company "ABC" found' );
103			}
104
105			$this->assertEquals( $item, $this->object->getItem( $item->getId() ) );
106			}
107
108			public function testSaveUpdateDeleteItem()
109			{
110			$item = new \Aimeos\MShop\Common\Item\Address\Standard( 'customer.address.', $this->fixture );
111			$item->setId( null );
112			$this->object->saveItem( $item );
113			$itemSaved = $this->object->getItem( $item->getId() );
114
115			$itemExp = clone $itemSaved;
116			$itemExp->setPosition( 1 );
117			$itemExp->setCity( 'Berlin' );
118			$itemExp->setState( 'Berlin' );
119			$this->object->saveItem( $itemExp );
120			$itemUpd = $this->object->getItem( $itemExp->getId() );
121
122			$this->object->deleteItem( $itemSaved->getId() );
123
124
125			$this->assertTrue( $item->getId() !== null );
126			$this->assertEquals( $item->getId(), $itemSaved->getId() );
127			$this->assertEquals( $item->getParentId(), $itemSaved->getParentId());
128			$this->assertEquals( $item->getPosition(), $itemSaved->getPosition());
129			$this->assertEquals( $item->getCompany(), $itemSaved->getCompany());
130			$this->assertEquals( $item->getVatID(), $itemSaved->getVatID());
131			$this->assertEquals( $item->getSalutation(), $itemSaved->getSalutation());
132			$this->assertEquals( $item->getTitle(), $itemSaved->getTitle());
133			$this->assertEquals( $item->getFirstname(), $itemSaved->getFirstname());
134			$this->assertEquals( $item->getLastname(), $itemSaved->getLastname());
135			$this->assertEquals( $item->getAddress1(), $itemSaved->getAddress1());
136			$this->assertEquals( $item->getAddress2(), $itemSaved->getAddress2());
137			$this->assertEquals( $item->getAddress3(), $itemSaved->getAddress3());
138			$this->assertEquals( $item->getPostal(), $itemSaved->getPostal());
139			$this->assertEquals( $item->getCity(), $itemSaved->getCity());
140			$this->assertEquals( $item->getState(), $itemSaved->getState());
141			$this->assertEquals( $item->getCountryId(), $itemSaved->getCountryId());
142			$this->assertEquals( $item->getLanguageId(), $itemSaved->getLanguageId());
143			$this->assertEquals( $item->getTelephone(), $itemSaved->getTelephone());
144			$this->assertEquals( $item->getEmail(), $itemSaved->getEmail());
145			$this->assertEquals( $item->getTelefax(), $itemSaved->getTelefax());
146			$this->assertEquals( $item->getWebsite(), $itemSaved->getWebsite());
147			$this->assertEquals( $item->getFlag(), $itemSaved->getFlag());
148
149			$this->assertEquals( $this->editor, $itemSaved->getEditor() );
150			$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeCreated() );
151			$this->assertRegExp('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemSaved->getTimeModified());
152
153			$this->assertEquals( $itemExp->getId(), $itemUpd->getId() );
154			$this->assertEquals( $itemExp->getParentId(), $itemUpd->getParentId());
155			$this->assertEquals( $itemExp->getPosition(), $itemUpd->getPosition());
156			$this->assertEquals( $itemExp->getCompany(), $itemUpd->getCompany());
157			$this->assertEquals( $itemExp->getVatID(), $itemUpd->getVatID());
158			$this->assertEquals( $itemExp->getSalutation(), $itemUpd->getSalutation());
159			$this->assertEquals( $itemExp->getTitle(), $itemUpd->getTitle());
160			$this->assertEquals( $itemExp->getFirstname(), $itemUpd->getFirstname());
161			$this->assertEquals( $itemExp->getLastname(), $itemUpd->getLastname());
162			$this->assertEquals( $itemExp->getAddress1(), $itemUpd->getAddress1());
163			$this->assertEquals( $itemExp->getAddress2(), $itemUpd->getAddress2());
164			$this->assertEquals( $itemExp->getAddress3(), $itemUpd->getAddress3());
165			$this->assertEquals( $itemExp->getPostal(), $itemUpd->getPostal());
166			$this->assertEquals( $itemExp->getCity(), $itemUpd->getCity());
167			$this->assertEquals( $itemExp->getState(), $itemUpd->getState());
168			$this->assertEquals( $itemExp->getCountryId(), $itemUpd->getCountryId());
169			$this->assertEquals( $itemExp->getLanguageId(), $itemUpd->getLanguageId());
170			$this->assertEquals( $itemExp->getTelephone(), $itemUpd->getTelephone());
171			$this->assertEquals( $itemExp->getEmail(), $itemUpd->getEmail());
172			$this->assertEquals( $itemExp->getTelefax(), $itemUpd->getTelefax());
173			$this->assertEquals( $itemExp->getWebsite(), $itemUpd->getWebsite());
174			$this->assertEquals( $itemExp->getFlag(), $itemUpd->getFlag());
175
176			$this->assertEquals( $this->editor, $itemUpd->getEditor() );
177			$this->assertEquals( $itemExp->getTimeCreated(), $itemUpd->getTimeCreated() );
178			$this->assertRegExp( '/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $itemUpd->getTimeModified() );
179
180			$this->setExpectedException('\\Aimeos\\MShop\\Exception');
181			$this->object->getItem( $itemSaved->getId() );
182			}
183
184			public function testCreateSearch()
185			{
186			$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Iface', $this->object->createSearch() );
187			}
188
189
190			public function testSearchItem()
191			{
192			$search = $this->object->createSearch();
193
194			$conditions = array(
195			$search->compare( '==', 'customer.address.company', 'ABC' ),
196			$search->compare( '==', 'customer.address.editor', $this->editor )
197			);
198			$search->setConditions( $search->combine( '&&', $conditions ) );
199			$this->assertEquals( 1, count( $this->object->searchItems( $search ) ) );
200			}
201
202
203			public function testSearchItemTotal()
204			{
205			$total = 0;
206			$search = $this->object->createSearch();
207
208			$conditions = array(
209			$search->compare( '~=', 'customer.address.company', 'ABC GmbH' ),
210			$search->compare( '==', 'customer.address.editor', $this->editor )
211			);
212
213			$search->setConditions( $search->combine( '&&', $conditions ) );
214			$search->setSlice( 0, 1 );
215
216			$results = $this->object->searchItems( $search, array(), $total );
217
218			$this->assertEquals( 1, count( $results ) );
219			$this->assertEquals( 2, $total );
220
221			foreach( $results as $id => $item ) {
222			$this->assertEquals( $id, $item->getId() );
223			}
224			}
225			}
226

aimeos / ai-ezpublish

Push — master ( 752129...3cf842 )

EzpublishTest::testSaveUpdateDeleteItem() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like