aimeos / ai-controller-jobs

controller/jobs/src/Controller/Jobs/Media/Scale/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -29,7 +29,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/media/scale/name
 		 * Class name of the used media scale job controller implementation
@@ -64,20 +64,20 @@ 
 		 * @since 2017.01
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/media/scale/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/media/scale/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Media\\Scale\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Media\\Scale\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Media\\Scale\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/media/scale/decorators/excludes
 		 * Excludes decorators added by the "common" option from the media scale controllers
@@ -153,6 +153,6 @@ 
 		 * @see controller/jobs/media/scale/decorators/excludes
 		 * @see controller/jobs/media/scale/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'media/scale' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'media/scale');
 	}
 }
\ No newline at end of file

controller/jobs/tests/Controller/Jobs/Media/Scale/FactoryTest.php

Spacing +8 added lines, -8 removed lines

@@ -16,8 +16,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

controller/jobs/src/Controller/Jobs/Media/Scale/Standard.php

Spacing +15 added lines, -15 removed lines

@@ -28,7 +28,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Rescale product images' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Rescale product images');
 	}
 
 
@@ -39,7 +39,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Rescales product images to the new sizes' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Rescales product images to the new sizes');
 	}
 
 
@@ -50,33 +50,33 @@ 
 	 */
 	public function run()
 	{
-		$cntl = \Aimeos\Controller\Common\Media\Factory::createController( $this->getContext() );
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'media' );
+		$cntl = \Aimeos\Controller\Common\Media\Factory::createController($this->getContext());
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'media');
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'media.domain', 'product' ),
-			$search->compare( '=~', 'media.mimetype', 'image/' ),
+			$search->compare('==', 'media.domain', 'product'),
+			$search->compare('=~', 'media.mimetype', 'image/'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'media.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'media.id')));
 
 		$start = 0;
 
 		do
 		{
-			$search->setSlice( $start );
-			$items = $manager->searchItems( $search );
+			$search->setSlice($start);
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $item )
+			foreach ($items as $item)
 			{
-				$cntl->scale( $item, 'fs-media' );
-				$manager->saveItem( $item );
+				$cntl->scale($item, 'fs-media');
+				$manager->saveItem($item);
 			}
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
 		}
-		while( $count === $search->getSliceSize() );
+		while ($count === $search->getSliceSize());
 	}
 }

controller/jobs/tests/Controller/Jobs/Media/Scale/StandardTest.php

Spacing +16 added lines, -16 removed lines

@@ -19,7 +19,7 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Media\Scale\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Media\Scale\Standard($context, $aimeos);
 	}
 
 
@@ -31,14 +31,14 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Rescale product images', $this->object->getName() );
+		$this->assertEquals('Rescale product images', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Rescales product images to the new sizes';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -49,31 +49,31 @@ 
 
 
 		$name = 'ControllerJobsMediaScaleStandardRun';
-		$context->getConfig()->set( 'mshop/media/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/media/name', $name );
+		$context->getConfig()->set('mshop/media/manager/name', $name);
+		$context->getConfig()->set('controller/common/media/name', $name);
 
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Media\\Manager\\Standard' )
-			->setMethods( array( 'saveItem' ) )
-			->setConstructorArgs( array( $context ) )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Media\\Manager\\Standard')
+			->setMethods(array('saveItem'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Media\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Media\\Manager\\' . $name, $managerStub );
+		\Aimeos\MShop\Media\Manager\Factory::injectManager('\\Aimeos\\MShop\\Media\\Manager\\' . $name, $managerStub);
 
-		$managerStub->expects( $this->atLeast( 1 ) )->method( 'saveItem' );
+		$managerStub->expects($this->atLeast(1))->method('saveItem');
 
 
-		$cntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Media\\Standard' )
-			->setMethods( array( 'scale' ) )
-			->setConstructorArgs( array( $context ) )
+		$cntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Media\\Standard')
+			->setMethods(array('scale'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\Controller\Common\Media\Factory::injectController( '\\Aimeos\\Controller\\Common\\Media\\' . $name, $cntlStub );
+		\Aimeos\Controller\Common\Media\Factory::injectController('\\Aimeos\\Controller\\Common\\Media\\' . $name, $cntlStub);
 
-		$cntlStub->expects( $this->atLeast( 1 ) )->method( 'scale' );
+		$cntlStub->expects($this->atLeast(1))->method('scale');
 
 
-		$object = new \Aimeos\Controller\Jobs\Media\Scale\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Media\Scale\Standard($context, $aimeos);
 		$object->run();
 	}
 }

controller/common/src/Controller/Common/Product/Import/Csv/Processor/Base.php

Spacing +9 added lines, -9 removed lines

@@ -32,8 +32,8 @@ 
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 * @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
-		\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping,
+		\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null)
 	{
 		$this->context = $context;
 		$this->mapping = $mapping;
@@ -48,13 +48,13 @@ 
 	 * @param integer $pos Computed position of the list item in the associated list of items
 	 * @return array Given associative list enriched by default values if they were not already set
 	 */
-	protected function addListItemDefaults( array $list, $pos )
+	protected function addListItemDefaults(array $list, $pos)
 	{
-		if( !isset( $list['product.lists.position'] ) ) {
+		if (!isset($list['product.lists.position'])) {
 			$list['product.lists.position'] = $pos;
 		}
 
-		if( !isset( $list['product.lists.status'] ) ) {
+		if (!isset($list['product.lists.status'])) {
 			$list['product.lists.status'] = 1;
 		}
 
@@ -92,8 +92,8 @@ 
 	 */
 	protected function getObject()
 	{
-		if( $this->object === null ) {
-			throw new \Aimeos\Controller\Jobs\Exception( 'No processor object available' );
+		if ($this->object === null) {
+			throw new \Aimeos\Controller\Jobs\Exception('No processor object available');
 		}
 
 		return $this->object;
@@ -108,8 +108,8 @@ 
 	 * @param mixed $default Default value if key isn't found
 	 * @param mixed Value for the key in the list of the default value
 	 */
-	protected function getValue( array $list, $key, $default )
+	protected function getValue(array $list, $key, $default)
 	{
-		return ( isset( $list[$key] ) ? $list[$key] : $default );
+		return (isset($list[$key]) ? $list[$key] : $default);
 	}
 }

controller/jobs/tests/Perf/Product/Import/Csv/StandardTest.php

Spacing +76 added lines, -76 removed lines

@@ -17,31 +17,31 @@ 
 		$this->context = \TestHelperJobs::getContext('unitperf');
 
 		$config = $this->context->getConfig();
-		$config->set( 'controller/jobs/product/import/csv/location', 'tmp/product-import.zip' );
-		$config->set( 'controller/jobs/product/import/csv/container/type', 'Zip' );
-		$config->set( 'controller/jobs/product/import/csv/container/content', 'CSV' );
-		$config->set( 'controller/jobs/product/import/csv/mapping', $this->getMapping() );
+		$config->set('controller/jobs/product/import/csv/location', 'tmp/product-import.zip');
+		$config->set('controller/jobs/product/import/csv/container/type', 'Zip');
+		$config->set('controller/jobs/product/import/csv/container/content', 'CSV');
+		$config->set('controller/jobs/product/import/csv/mapping', $this->getMapping());
 
-		$container = \Aimeos\MW\Container\Factory::getContainer( 'tmp/product-import.zip', 'Zip', 'CSV', [] );
+		$container = \Aimeos\MW\Container\Factory::getContainer('tmp/product-import.zip', 'Zip', 'CSV', []);
 
-		$content = $container->create( 'product.csv' );
+		$content = $container->create('product.csv');
 
-		for( $i = 0; $i < 1000; $i++ )
+		for ($i = 0; $i < 1000; $i++)
 		{
 			$data = [];
 
-			$data = $this->addProduct( $data, $i );
-			$data = $this->addText( $data, $i );
-			$data = $this->addMedia( $data, $i );
-			$data = $this->addPrice( $data, $i );
-			$data = $this->addAttribute( $data, $i );
-			$data = $this->addProductRef( $data, $i );
-			$data = $this->addProperty( $data, $i );
+			$data = $this->addProduct($data, $i);
+			$data = $this->addText($data, $i);
+			$data = $this->addMedia($data, $i);
+			$data = $this->addPrice($data, $i);
+			$data = $this->addAttribute($data, $i);
+			$data = $this->addProductRef($data, $i);
+			$data = $this->addProperty($data, $i);
 
-			$content->add( $data );
+			$content->add($data);
 		}
 
-		$container->add( $content );
+		$container->add($content);
 
 		$container->close();
 	}
@@ -55,25 +55,25 @@ 
 		$this->cleanupPrice();
 		$this->cleanupProduct();
 
-		unlink( 'tmp/product-import.zip' );
+		unlink('tmp/product-import.zip');
 	}
 
 
 	public function testImport()
 	{
 		$aimeos = \TestHelperJobs::getAimeos();
-		$cntl = \Aimeos\Controller\Jobs\Product\Import\Csv\Factory::createController( $this->context, $aimeos, 'Standard' );
+		$cntl = \Aimeos\Controller\Jobs\Product\Import\Csv\Factory::createController($this->context, $aimeos, 'Standard');
 
-		$start = microtime( true );
+		$start = microtime(true);
 
 		$cntl->run();
 
-		$stop = microtime( true );
-		echo "\n    product import CSV: " . ( ( $stop - $start ) ) . " sec\n";
+		$stop = microtime(true);
+		echo "\n    product import CSV: " . (($stop - $start)) . " sec\n";
 	}
 
 
-	protected function addAttribute( array $data, $cnt )
+	protected function addAttribute(array $data, $cnt)
 	{
 		$data[] = 'length'; // type
 		$data[] = 'import-' . ($cnt % 30); // code
@@ -86,7 +86,7 @@ 
 	}
 
 
-	protected function addMedia( array $data, $cnt )
+	protected function addMedia(array $data, $cnt)
 	{
 		$data[] = "/path/to/image-$cnt.jpg"; // url
 
@@ -94,7 +94,7 @@ 
 	}
 
 
-	protected function addPrice( array $data, $cnt )
+	protected function addPrice(array $data, $cnt)
 	{
 		$data[] = 1; // quantity
 		$data[] = 'import-' . $cnt; // label
@@ -105,7 +105,7 @@ 
 	}
 
 
-	protected function addProduct( array $data, $cnt )
+	protected function addProduct(array $data, $cnt)
 	{
 		$data[] = 'import-' . $cnt; // code
 		$data[] = 'import-' . $cnt; // label
@@ -116,7 +116,7 @@ 
 	}
 
 
-	protected function addProductRef( array $data, $cnt )
+	protected function addProductRef(array $data, $cnt)
 	{
 		$data[] = 'import-' . ($cnt % 100); // code
 		$data[] = 'suggestion'; // type
@@ -125,7 +125,7 @@ 
 	}
 
 
-	protected function addProperty( array $data, $cnt )
+	protected function addProperty(array $data, $cnt)
 	{
 		$data[] = 'package-weight'; // type
 		$data[] = '0.5'; // value
@@ -134,7 +134,7 @@ 
 	}
 
 
-	protected function addText( array $data, $cnt )
+	protected function addText(array $data, $cnt)
 	{
 		$data[] = 'name'; // type
 		$data[] = 'import-name-' . $cnt; //content
@@ -149,132 +149,132 @@ 
 
 	protected function cleanupAttribute()
 	{
-		$manager = \Aimeos\MShop\Attribute\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Attribute\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'attribute.domain', 'product' ),
-			$search->compare( '==', 'attribute.label', 'import-%' ),
+			$search->compare('==', 'attribute.domain', 'product'),
+			$search->compare('==', 'attribute.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'attribute.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'attribute.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupMedia()
 	{
-		$manager = \Aimeos\MShop\Media\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Media\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'media.domain', 'product' ),
-			$search->compare( '==', 'media.label', 'import-%' ),
+			$search->compare('==', 'media.domain', 'product'),
+			$search->compare('==', 'media.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'media.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'media.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupPrice()
 	{
-		$manager = \Aimeos\MShop\Price\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Price\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-				$search->compare( '==', 'price.domain', 'product' ),
-				$search->compare( '==', 'price.label', 'import-%' ),
+				$search->compare('==', 'price.domain', 'product'),
+				$search->compare('==', 'price.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'price.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'price.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupProduct()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'product.code', 'import-%' ) );
-		$search->setSortations( array( $search->sort( '+', 'product.id' ) ) );
+		$search->setConditions($search->compare('==', 'product.code', 'import-%'));
+		$search->setSortations(array($search->sort('+', 'product.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupText()
 	{
-		$manager = \Aimeos\MShop\Text\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Text\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'text.domain', 'product' ),
-			$search->compare( '==', 'text.label', 'import-%' ),
+			$search->compare('==', 'text.domain', 'product'),
+			$search->compare('==', 'text.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'text.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'text.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 

controller/jobs/tests/Controller/Jobs/Admin/Log/StandardTest.php

Spacing +20 added lines, -20 removed lines

@@ -25,7 +25,7 @@ 
 		$this->context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard( $this->context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard($this->context, $aimeos);
 	}
 
 
@@ -44,14 +44,14 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Log cleanup', $this->object->getName() );
+		$this->assertEquals('Log cleanup', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Removes the old log entries from the database and archives them (optional)';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -59,38 +59,38 @@ 
 	{
 		$config = $this->context->getConfig();
 
-		$mock = $this->getMockBuilder( '\\Aimeos\\MAdmin\\Log\\Manager\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $this->context ) )
+		$mock = $this->getMockBuilder('\\Aimeos\\MAdmin\\Log\\Manager\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($this->context))
 			->getMock();
 
-		$mock->expects( $this->atLeastOnce() )->method( 'deleteItems' );
+		$mock->expects($this->atLeastOnce())->method('deleteItems');
 
-		$tmppath = dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) . DIRECTORY_SEPARATOR . 'tmp';
+		$tmppath = dirname(dirname(dirname(dirname(__DIR__)))) . DIRECTORY_SEPARATOR . 'tmp';
 		$name = 'ControllerJobsAdminLogDefaultRun';
-		$config->set( 'madmin/log/manager/name', $name );
-		$config->set( 'controller/jobs/admin/log/standard/limit-days', 0 );
-		$config->set( 'controller/jobs/admin/log/standard/path', $tmppath );
+		$config->set('madmin/log/manager/name', $name);
+		$config->set('controller/jobs/admin/log/standard/limit-days', 0);
+		$config->set('controller/jobs/admin/log/standard/path', $tmppath);
 
-		\Aimeos\MAdmin\Log\Manager\Factory::injectManager( '\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock );
+		\Aimeos\MAdmin\Log\Manager\Factory::injectManager('\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock);
 
-		if( !is_dir( $tmppath ) && mkdir( $tmppath ) === false ) {
-			throw new \RuntimeException( sprintf( 'Unable to create temporary path "%1$s"', $tmppath ) );
+		if (!is_dir($tmppath) && mkdir($tmppath) === false) {
+			throw new \RuntimeException(sprintf('Unable to create temporary path "%1$s"', $tmppath));
 		}
 
 		$this->object->run();
 
-		foreach( new \DirectoryIterator( $tmppath ) as $file )
+		foreach (new \DirectoryIterator($tmppath) as $file)
 		{
-			if( $file->isFile() && $file->getExtension() === 'zip' )
+			if ($file->isFile() && $file->getExtension() === 'zip')
 			{
-				$container = \Aimeos\MW\Container\Factory::getContainer( $file->getPathName(), 'Zip', 'CSV', [] );
-				$container->get( 'unittest facility.csv' );
-				unlink( $file->getPathName() );
+				$container = \Aimeos\MW\Container\Factory::getContainer($file->getPathName(), 'Zip', 'CSV', []);
+				$container->get('unittest facility.csv');
+				unlink($file->getPathName());
 				return;
 			}
 		}
 
-		$this->fail( 'Log archive file not found' );
+		$this->fail('Log archive file not found');
 	}
 }

controller/jobs/tests/Controller/Jobs/Order/Service/Payment/StandardTest.php

Spacing +67 added lines, -67 removed lines

@@ -24,7 +24,7 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Capture authorized payments', $this->object->getName() );
+		$this->assertEquals('Capture authorized payments', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Authorized payments of orders will be captured after dispatching or after a configurable amount of time';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -60,49 +60,49 @@ 
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 		$orderItem = $orderManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
-			->setMethods( array( 'isImplemented', 'capture' ) )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
+			->setMethods(array('isImplemented', 'capture'))
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), []));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
-			->will( $this->returnValue( true ) );
+		$serviceProviderStub->expects($this->once())->method('isImplemented')
+			->will($this->returnValue(true));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'capture' );
+		$serviceProviderStub->expects($this->once())->method('capture');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -114,52 +114,52 @@ 
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 		$orderItem = $orderManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
-			->setMethods( array( 'isImplemented', 'capture' ) )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
+			->setMethods(array('isImplemented', 'capture'))
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), []));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
-			->will( $this->returnValue( true ) );
+		$serviceProviderStub->expects($this->once())->method('isImplemented')
+			->will($this->returnValue(true));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'capture' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test oder service payment: capture' ) ) );
+		$serviceProviderStub->expects($this->once())->method('capture')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception('test oder service payment: capture')));
 
-		$orderManagerStub->expects( $this->never() )->method( 'saveItem' );
+		$orderManagerStub->expects($this->never())->method('saveItem');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -171,36 +171,36 @@ 
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test service delivery process: getProvider' ) ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception('test service delivery process: getProvider')));
 
-		$orderManagerStub->expects( $this->never() )->method( 'searchItems' );
+		$orderManagerStub->expects($this->never())->method('searchItems');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 }

controller/jobs/tests/Controller/Jobs/Order/Service/Async/StandardTest.php

Spacing +26 added lines, -26 removed lines

@@ -24,7 +24,7 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Batch update of payment/delivery status', $this->object->getName() );
+		$this->assertEquals('Batch update of payment/delivery status', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Executes payment or delivery service providers that uses batch updates';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -60,34 +60,34 @@ 
 
 
 		$name = 'ControllerJobsServiceAsyncProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
 
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Manual' )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Manual')
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'updateAsync' );
+		$serviceProviderStub->expects($this->once())->method('updateAsync');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -99,27 +99,27 @@ 
 
 
 		$name = 'ControllerJobsServiceAsyncProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
 
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception() ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception()));
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
 		$object->run();
 	}
 }