StandardTest::setUp() - Code Metrics - Inspection of "Implemented coupon code import" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0010c2...5cb668 )

by Aimeos

created 2017-08-09 15:26 UTC

StandardTest::setUp() A

↳ Parent: StandardTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2017
 */


namespace Aimeos\Controller\Jobs\Coupon\Import\Csv\Code;


class StandardTest extends \PHPUnit\Framework\TestCase
{
	private $object;
	private $context;
	private $aimeos;


	protected function setUp()
	{
		\Aimeos\MShop\Factory::setCache( true );

		$this->context = \TestHelperJobs::getContext();
		$this->aimeos = \TestHelperJobs::getAimeos();
		$config = $this->context->getConfig();

		$config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );

		$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
	}


	protected function tearDown()
	{
		\Aimeos\MShop\Factory::setCache( false );
		\Aimeos\MShop\Factory::clear();

		unset( $this->object );
	}


	public function testGetName()
	{
		$this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
	}


	public function testGetDescription()
	{
		$text = 'Imports new and updates existing coupon code from CSV files';
		$this->assertEquals( $text, $this->object->getDescription() );
	}


	public function testRun()
	{
		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
		$coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

		$dir = 'tmp/import/couponcode/unittest';
		$filepath = $dir . '/' . $coupon->getId() . '.csv';


		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
		}

		$content = 'code,count,start,end
jobccimport1,3,2000-01-01 00:00:00,
jobccimport2,5,,';

		if( file_put_contents( $filepath, $content ) === false ) {
			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
		}

		$this->object->run();


		unlink( $filepath );

		$codeManager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon/code' );
		$code1 = $codeManager->findItem( 'jobccimport1' );
		$code2 = $codeManager->findItem( 'jobccimport2' );

		$manager->deleteItem( $coupon->getId() );


		$this->assertEquals( 3, $code1->getCount() );
		$this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
		$this->assertEquals( null, $code1->getDateEnd() );

		$this->assertEquals( 5, $code2->getCount() );
		$this->assertEquals( null, $code2->getDateStart() );
		$this->assertEquals( null, $code2->getDateEnd() );
	}


	public function testRunException()
	{
		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
		$coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

		$dir = 'tmp/import/couponcode/unittest';
		$filepath = $dir . '/0.csv';

		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
		}

		$content = 'code,count,start,end
jobccimport1,,,';

		if( file_put_contents( $filepath, $content ) === false ) {
			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
		}

		$this->object->run();

		unlink( $filepath );
	}
}

1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2017
6			*/
7
8
9			namespace Aimeos\Controller\Jobs\Coupon\Import\Csv\Code;
10
11
12			class StandardTest extends \PHPUnit\Framework\TestCase
13			{
14			private $object;
15			private $context;
16			private $aimeos;
17
18
19			protected function setUp()
20			{
21			\Aimeos\MShop\Factory::setCache( true );
22
23			$this->context = \TestHelperJobs::getContext();
24			$this->aimeos = \TestHelperJobs::getAimeos();
25			$config = $this->context->getConfig();
26
27			$config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );
28
29			$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
30			}
31
32
33			protected function tearDown()
34			{
35			\Aimeos\MShop\Factory::setCache( false );
36			\Aimeos\MShop\Factory::clear();
37
38			unset( $this->object );
39			}
40
41
42			public function testGetName()
43			{
44			$this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
45			}
46
47
48			public function testGetDescription()
49			{
50			$text = 'Imports new and updates existing coupon code from CSV files';
51			$this->assertEquals( $text, $this->object->getDescription() );
52			}
53
54
55			public function testRun()
56			{
57			$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
58			$coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
			0 ignored issues – show Bug introduced 2017-08-09 15:28 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$coupon` is correct as `$manager->saveItem($mana...setProvider('Example'))` (which targets `Aimeos\MShop\Common\Manager\Iface::saveItem()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
59
60			$dir = 'tmp/import/couponcode/unittest';
61			$filepath = $dir . '/' . $coupon->getId() . '.csv';
			0 ignored issues – show Bug introduced 2017-08-09 15:28 UTC by Report Bug Copy Issue Report The method `getId` cannot be called on `$coupon` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
62
63			if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
64			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
65			}
66
67			$content = 'code,count,start,end
68			jobccimport1,3,2000-01-01 00:00:00,
69			jobccimport2,5,,';
70
71			if( file_put_contents( $filepath, $content ) === false ) {
72			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
73			}
74
75			$this->object->run();
76
77
78			unlink( $filepath );
79
80			$codeManager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon/code' );
81			$code1 = $codeManager->findItem( 'jobccimport1' );
82			$code2 = $codeManager->findItem( 'jobccimport2' );
83
84			$manager->deleteItem( $coupon->getId() );
			0 ignored issues – show Bug introduced 2017-08-09 15:28 UTC by Report Bug Copy Issue Report The method `getId` cannot be called on `$coupon` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
85
86			$this->assertEquals( 3, $code1->getCount() );
87			$this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
88			$this->assertEquals( null, $code1->getDateEnd() );
89
90			$this->assertEquals( 5, $code2->getCount() );
91			$this->assertEquals( null, $code2->getDateStart() );
92			$this->assertEquals( null, $code2->getDateEnd() );
93			}
94
95
96			public function testRunException()
97			{
98			$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
99			$coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
			0 ignored issues – show Bug introduced 2017-08-09 15:28 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$coupon` is correct as `$manager->saveItem($mana...setProvider('Example'))` (which targets `Aimeos\MShop\Common\Manager\Iface::saveItem()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... Unused Code introduced 2017-08-09 15:28 UTC by Report Bug Copy Issue Report `$coupon` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
100
101			$dir = 'tmp/import/couponcode/unittest';
102			$filepath = $dir . '/0.csv';
103
104			if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
105			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
106			}
107
108			$content = 'code,count,start,end
109			jobccimport1,,,';
110
111			if( file_put_contents( $filepath, $content ) === false ) {
112			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
113			}
114
115			$this->object->run();
116
117			unlink( $filepath );
118			}
119			}

aimeos / ai-controller-jobs

Push — master ( 0010c2...5cb668 )

StandardTest::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like