Completed
Push — master ( 6c002e...adcfe9 )
by Aimeos
03:19
created
controller/common/tests/TestHelperCntl.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -15,14 +15,14 @@  discard block
 block discarded – undo
15 15
 	public static function bootstrap()
16 16
 	{
17 17
 		self::getAimeos();
18
-		\Aimeos\MShop\Factory::setCache( false );
18
+		\Aimeos\MShop\Factory::setCache(false);
19 19
 	}
20 20
 
21 21
 
22
-	public static function getContext( $site = 'unittest' )
22
+	public static function getContext($site = 'unittest')
23 23
 	{
24
-		if( !isset( self::$context[$site] ) ) {
25
-			self::$context[$site] = self::createContext( $site );
24
+		if (!isset(self::$context[$site])) {
25
+			self::$context[$site] = self::createContext($site);
26 26
 		}
27 27
 
28 28
 		return clone self::$context[$site];
@@ -31,13 +31,13 @@  discard block
 block discarded – undo
31 31
 
32 32
 	public static function getAimeos()
33 33
 	{
34
-		if( !isset( self::$aimeos ) )
34
+		if (!isset(self::$aimeos))
35 35
 		{
36 36
 			require_once 'Bootstrap.php';
37
-			spl_autoload_register( 'Aimeos\\Bootstrap::autoload' );
37
+			spl_autoload_register('Aimeos\\Bootstrap::autoload');
38 38
 
39
-			$extdir = dirname( dirname( dirname( dirname( dirname( __FILE__ ) ) ) ) );
40
-			self::$aimeos = new \Aimeos\Bootstrap( array( $extdir ), true );
39
+			$extdir = dirname(dirname(dirname(dirname(dirname(__FILE__)))));
40
+			self::$aimeos = new \Aimeos\Bootstrap(array($extdir), true);
41 41
 		}
42 42
 
43 43
 		return self::$aimeos;
@@ -47,40 +47,40 @@  discard block
 block discarded – undo
47 47
 	/**
48 48
 	 * @param string $site
49 49
 	 */
50
-	private static function createContext( $site )
50
+	private static function createContext($site)
51 51
 	{
52 52
 		$ctx = new \Aimeos\MShop\Context\Item\Standard();
53 53
 		$aimeos = self::getAimeos();
54 54
 
55 55
 
56
-		$paths = $aimeos->getConfigPaths( 'mysql' );
56
+		$paths = $aimeos->getConfigPaths('mysql');
57 57
 		$paths[] = __DIR__ . DIRECTORY_SEPARATOR . 'config';
58 58
 		$file = __DIR__ . DIRECTORY_SEPARATOR . 'confdoc.ser';
59 59
 
60
-		$conf = new \Aimeos\MW\Config\PHPArray( [], $paths );
61
-		$conf = new \Aimeos\MW\Config\Decorator\Memory( $conf );
62
-		$conf = new \Aimeos\MW\Config\Decorator\Documentor( $conf, $file );
63
-		$ctx->setConfig( $conf );
60
+		$conf = new \Aimeos\MW\Config\PHPArray([], $paths);
61
+		$conf = new \Aimeos\MW\Config\Decorator\Memory($conf);
62
+		$conf = new \Aimeos\MW\Config\Decorator\Documentor($conf, $file);
63
+		$ctx->setConfig($conf);
64 64
 
65 65
 
66
-		$dbm = new \Aimeos\MW\DB\Manager\PDO( $conf );
67
-		$ctx->setDatabaseManager( $dbm );
66
+		$dbm = new \Aimeos\MW\DB\Manager\PDO($conf);
67
+		$ctx->setDatabaseManager($dbm);
68 68
 
69 69
 
70
-		$logger = new \Aimeos\MW\Logger\File( 'unittest.log', \Aimeos\MW\Logger\Base::DEBUG );
71
-		$ctx->setLogger( $logger );
70
+		$logger = new \Aimeos\MW\Logger\File('unittest.log', \Aimeos\MW\Logger\Base::DEBUG);
71
+		$ctx->setLogger($logger);
72 72
 
73 73
 
74 74
 		$session = new \Aimeos\MW\Session\None();
75
-		$ctx->setSession( $session );
75
+		$ctx->setSession($session);
76 76
 
77 77
 
78
-		$localeManager = \Aimeos\MShop\Locale\Manager\Factory::createManager( $ctx );
79
-		$locale = $localeManager->bootstrap( $site, '', '', false );
80
-		$ctx->setLocale( $locale );
78
+		$localeManager = \Aimeos\MShop\Locale\Manager\Factory::createManager($ctx);
79
+		$locale = $localeManager->bootstrap($site, '', '', false);
80
+		$ctx->setLocale($locale);
81 81
 
82 82
 
83
-		$ctx->setEditor( 'core:controller/common' );
83
+		$ctx->setEditor('core:controller/common');
84 84
 
85 85
 		return $ctx;
86 86
 	}
Please login to merge, or discard this patch.
controller/common/tests/Controller/Common/Product/Import/Csv/BaseTest.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -14,92 +14,92 @@  discard block
 block discarded – undo
14 14
 
15 15
 	protected function setUp()
16 16
 	{
17
-		\Aimeos\MShop\Factory::setCache( true );
17
+		\Aimeos\MShop\Factory::setCache(true);
18 18
 
19 19
 		$context = \TestHelperCntl::getContext();
20 20
 		$aimeos = \TestHelperCntl::getAimeos();
21 21
 
22
-		$this->object = new TestAbstract( $context, $aimeos );
22
+		$this->object = new TestAbstract($context, $aimeos);
23 23
 	}
24 24
 
25 25
 
26 26
 	protected function tearDown()
27 27
 	{
28
-		\Aimeos\MShop\Factory::setCache( false );
28
+		\Aimeos\MShop\Factory::setCache(false);
29 29
 		\Aimeos\MShop\Factory::clear();
30 30
 	}
31 31
 
32 32
 
33 33
 	public function testGetCache()
34 34
 	{
35
-		$cache = $this->object->getCachePublic( 'attribute' );
35
+		$cache = $this->object->getCachePublic('attribute');
36 36
 
37
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\Iface', $cache );
37
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\Iface', $cache);
38 38
 	}
39 39
 
40 40
 
41 41
 	public function testGetCacheInvalidType()
42 42
 	{
43
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
44
-		$this->object->getCachePublic( '$' );
43
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
44
+		$this->object->getCachePublic('$');
45 45
 	}
46 46
 
47 47
 
48 48
 	public function testGetCacheInvalidClass()
49 49
 	{
50
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
51
-		$this->object->getCachePublic( 'unknown' );
50
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
51
+		$this->object->getCachePublic('unknown');
52 52
 	}
53 53
 
54 54
 
55 55
 	public function testGetCacheInvalidInterface()
56 56
 	{
57
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
58
-		$this->object->getCachePublic( 'attribute', 'unknown' );
57
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
58
+		$this->object->getCachePublic('attribute', 'unknown');
59 59
 	}
60 60
 
61 61
 
62 62
 	public function testGetProcessors()
63 63
 	{
64
-		$processor = $this->object->getProcessorsPublic( array( 'attribute' => [] ) );
64
+		$processor = $this->object->getProcessorsPublic(array('attribute' => []));
65 65
 
66
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\Iface', $processor );
66
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\Iface', $processor);
67 67
 	}
68 68
 
69 69
 
70 70
 	public function testGetProcessorsInvalidType()
71 71
 	{
72
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
73
-		$this->object->getProcessorsPublic( array( '$' => [] ) );
72
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
73
+		$this->object->getProcessorsPublic(array('$' => []));
74 74
 	}
75 75
 
76 76
 
77 77
 	public function testGetProcessorsInvalidClass()
78 78
 	{
79
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
80
-		$this->object->getProcessorsPublic( array( 'unknown' => [] ) );
79
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
80
+		$this->object->getProcessorsPublic(array('unknown' => []));
81 81
 	}
82 82
 
83 83
 
84 84
 	public function testGetProcessorsInvalidInterface()
85 85
 	{
86
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
87
-		$this->object->getProcessorsPublic( array( 'unknown' => [] ) );
86
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
87
+		$this->object->getProcessorsPublic(array('unknown' => []));
88 88
 	}
89 89
 
90 90
 
91 91
 	public function testGetTypeId()
92 92
 	{
93
-		$typeid = $this->object->getTypeIdPublic( 'attribute/type', 'product', 'color' );
93
+		$typeid = $this->object->getTypeIdPublic('attribute/type', 'product', 'color');
94 94
 
95
-		$this->assertNotEquals( null, $typeid );
95
+		$this->assertNotEquals(null, $typeid);
96 96
 	}
97 97
 
98 98
 
99 99
 	public function testGetTypeIdUnknown()
100 100
 	{
101
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
102
-		$this->object->getTypeIdPublic( 'attribute/type', 'product', 'unknown' );
101
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
102
+		$this->object->getTypeIdPublic('attribute/type', 'product', 'unknown');
103 103
 	}
104 104
 }
105 105
 
@@ -107,21 +107,21 @@  discard block
 block discarded – undo
107 107
 class TestAbstract
108 108
 	extends \Aimeos\Controller\Common\Product\Import\Csv\Base
109 109
 {
110
-	public function getCachePublic( $type, $name = null )
110
+	public function getCachePublic($type, $name = null)
111 111
 	{
112
-		return $this->getCache( $type, $name );
112
+		return $this->getCache($type, $name);
113 113
 	}
114 114
 
115 115
 
116
-	public function getProcessorsPublic( array $mappings )
116
+	public function getProcessorsPublic(array $mappings)
117 117
 	{
118
-		return $this->getProcessors( $mappings );
118
+		return $this->getProcessors($mappings);
119 119
 	}
120 120
 
121 121
 
122
-	public function getTypeIdPublic( $path, $domain, $code )
122
+	public function getTypeIdPublic($path, $domain, $code)
123 123
 	{
124
-		return $this->getTypeId( $path, $domain, $code );
124
+		return $this->getTypeId($path, $domain, $code);
125 125
 	}
126 126
 }
127 127
 
Please login to merge, or discard this patch.
src/Controller/Common/Product/Import/Csv/Cache/Attribute/Standard.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -40,15 +40,15 @@  discard block
 block discarded – undo
40 40
 	 *
41 41
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
42 42
 	 */
43
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context )
43
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context)
44 44
 	{
45
-		parent::__construct( $context );
45
+		parent::__construct($context);
46 46
 
47
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'attribute' );
48
-		$result = $manager->searchItems( $manager->createSearch() );
47
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'attribute');
48
+		$result = $manager->searchItems($manager->createSearch());
49 49
 
50
-		foreach( $result as $id => $item ) {
51
-			$this->attributes[ $item->getCode() ][ $item->getType() ] = $item;
50
+		foreach ($result as $id => $item) {
51
+			$this->attributes[$item->getCode()][$item->getType()] = $item;
52 52
 		}
53 53
 	}
54 54
 
@@ -60,24 +60,24 @@  discard block
 block discarded – undo
60 60
 	 * @param string|null $type Attribute type
61 61
 	 * @return \Aimeos\MShop\Attribute\Item\Iface|null Attribute object or null if not found
62 62
 	 */
63
-	public function get( $code, $type = null )
63
+	public function get($code, $type = null)
64 64
 	{
65
-		if( isset( $this->attributes[$code] ) && isset( $this->attributes[$code][$type] ) ) {
65
+		if (isset($this->attributes[$code]) && isset($this->attributes[$code][$type])) {
66 66
 			return $this->attributes[$code][$type];
67 67
 		}
68 68
 
69
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'attribute' );
69
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'attribute');
70 70
 
71 71
 		$search = $manager->createSearch();
72 72
 		$expr = array(
73
-			$search->compare( '==', 'attribute.code', $code ),
74
-			$search->compare( '==', 'attribute.type.code', $type ),
73
+			$search->compare('==', 'attribute.code', $code),
74
+			$search->compare('==', 'attribute.type.code', $type),
75 75
 		);
76
-		$search->setConditions( $search->combine( '&&', $expr ) );
76
+		$search->setConditions($search->combine('&&', $expr));
77 77
 
78
-		$result = $manager->searchItems( $search );
78
+		$result = $manager->searchItems($search);
79 79
 
80
-		if( ( $item = reset( $result ) ) !== false )
80
+		if (($item = reset($result)) !== false)
81 81
 		{
82 82
 			$this->attributes[$code][$type] = $item;
83 83
 			return $item;
@@ -90,14 +90,14 @@  discard block
 block discarded – undo
90 90
 	 *
91 91
 	 * @param \Aimeos\MShop\Common\Item\Iface $item Attribute object
92 92
 	 */
93
-	public function set( \Aimeos\MShop\Common\Item\Iface $item )
93
+	public function set(\Aimeos\MShop\Common\Item\Iface $item)
94 94
 	{
95 95
 		$code = $item->getCode();
96 96
 
97
-		if( !isset( $this->attributes[$code] ) || !is_array( $this->attributes[$code] ) ) {
97
+		if (!isset($this->attributes[$code]) || !is_array($this->attributes[$code])) {
98 98
 			$this->attributes[$code] = [];
99 99
 		}
100 100
 
101
-		$this->attributes[$code][ $item->getType() ] = $item;
101
+		$this->attributes[$code][$item->getType()] = $item;
102 102
 	}
103 103
 }
104 104
\ No newline at end of file
Please login to merge, or discard this patch.
controller/common/src/Controller/Common/Product/Import/Csv/Base.php 1 patch
Spacing   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
30 30
 	 * @param array $data Associative list of product codes and lists of CSV field indexes and their data
31 31
 	 * @return array Associative list of CSV field indexes and their converted data
32 32
 	 */
33
-	protected function convertData( array $convlist, array $data )
33
+	protected function convertData(array $convlist, array $data)
34 34
 	{
35
-		foreach( $convlist as $idx => $converter )
35
+		foreach ($convlist as $idx => $converter)
36 36
 		{
37
-			foreach( $data as $code => $list )
37
+			foreach ($data as $code => $list)
38 38
 			{
39
-				if( isset( $list[$idx] ) ) {
40
-					$data[$code][$idx] = $converter->translate( $list[$idx] );
39
+				if (isset($list[$idx])) {
40
+					$data[$code][$idx] = $converter->translate($list[$idx]);
41 41
 				}
42 42
 			}
43 43
 		}
@@ -53,38 +53,38 @@  discard block
 block discarded – undo
53 53
 	 * @param string|null Name of the cache implementation
54 54
 	 * @return \Aimeos\Controller\Common\Product\Import\Csv\Cache\Iface Cache object
55 55
 	 */
56
-	protected function getCache( $type, $name = null )
56
+	protected function getCache($type, $name = null)
57 57
 	{
58 58
 		$context = $this->getContext();
59 59
 		$config = $context->getConfig();
60 60
 		$iface = '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\Iface';
61 61
 
62
-		if( ctype_alnum( $type ) === false )
62
+		if (ctype_alnum($type) === false)
63 63
 		{
64 64
 			$classname = is_string($name) ? '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\' . $type : '<not a string>';
65
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
65
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
66 66
 		}
67 67
 
68
-		if( $name === null ) {
69
-			$name = $config->get( 'controller/common/product/import/csv/cache/' . $type . '/name', 'Standard' );
68
+		if ($name === null) {
69
+			$name = $config->get('controller/common/product/import/csv/cache/' . $type . '/name', 'Standard');
70 70
 		}
71 71
 
72
-		if( ctype_alnum( $name ) === false )
72
+		if (ctype_alnum($name) === false)
73 73
 		{
74 74
 			$classname = is_string($name) ? '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\' . $type . '\\' . $name : '<not a string>';
75
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
75
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
76 76
 		}
77 77
 
78
-		$classname = '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\' . ucfirst( $type ) . '\\' . $name;
78
+		$classname = '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\' . ucfirst($type) . '\\' . $name;
79 79
 
80
-		if( class_exists( $classname ) === false ) {
81
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Class "%1$s" not found', $classname ) );
80
+		if (class_exists($classname) === false) {
81
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Class "%1$s" not found', $classname));
82 82
 		}
83 83
 
84
-		$object = new $classname( $context );
84
+		$object = new $classname($context);
85 85
 
86
-		if( !( $object instanceof $iface ) ) {
87
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Class "%1$s" does not implement interface "%2$s"', $classname, $iface ) );
86
+		if (!($object instanceof $iface)) {
87
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Class "%1$s" does not implement interface "%2$s"', $classname, $iface));
88 88
 		}
89 89
 
90 90
 		return $object;
@@ -97,12 +97,12 @@  discard block
 block discarded – undo
97 97
 	 * @param array $convmap List of converter names for the values at the position in the CSV file
98 98
 	 * @return array Associative list of positions and converter objects
99 99
 	 */
100
-	protected function getConverterList( array $convmap )
100
+	protected function getConverterList(array $convmap)
101 101
 	{
102 102
 		$convlist = [];
103 103
 
104
-		foreach( $convmap as $idx => $name ) {
105
-			$convlist[$idx] = \Aimeos\MW\Convert\Factory::createConverter( $name );
104
+		foreach ($convmap as $idx => $name) {
105
+			$convlist[$idx] = \Aimeos\MW\Convert\Factory::createConverter($name);
106 106
 		}
107 107
 
108 108
 		return $convlist;
@@ -117,15 +117,15 @@  discard block
 block discarded – undo
117 117
 	 * @param integer $codePos Column position which contains the unique product code (starting from 0)
118 118
 	 * @return array List of arrays with product codes as keys and list of values from the CSV file
119 119
 	 */
120
-	protected function getData( \Aimeos\MW\Container\Content\Iface $content, $maxcnt, $codePos )
120
+	protected function getData(\Aimeos\MW\Container\Content\Iface $content, $maxcnt, $codePos)
121 121
 	{
122 122
 		$count = 0;
123 123
 		$data = [];
124 124
 
125
-		while( $content->valid() && $count++ < $maxcnt )
125
+		while ($content->valid() && $count++ < $maxcnt)
126 126
 		{
127 127
 			$row = $content->current();
128
-			$data[ $row[$codePos] ] = $row;
128
+			$data[$row[$codePos]] = $row;
129 129
 			$content->next();
130 130
 		}
131 131
 
@@ -222,21 +222,21 @@  discard block
 block discarded – undo
222 222
 	 * @param array $mapping List of domain item keys with the CSV field position as key
223 223
 	 * @return array List of associative arrays containing the chunked properties
224 224
 	 */
225
-	protected function getMappedChunk( array &$data, array $mapping )
225
+	protected function getMappedChunk(array &$data, array $mapping)
226 226
 	{
227 227
 		$idx = 0;
228 228
 		$map = [];
229 229
 
230
-		foreach( $mapping as $pos => $key )
230
+		foreach ($mapping as $pos => $key)
231 231
 		{
232
-			if( isset( $map[$idx][$key] ) ) {
232
+			if (isset($map[$idx][$key])) {
233 233
 				$idx++;
234 234
 			}
235 235
 
236
-			if( isset( $data[$pos] ) )
236
+			if (isset($data[$pos]))
237 237
 			{
238 238
 				$map[$idx][$key] = $data[$pos];
239
-				unset( $data[$pos] );
239
+				unset($data[$pos]);
240 240
 			}
241 241
 		}
242 242
 
@@ -250,39 +250,39 @@  discard block
 block discarded – undo
250 250
 	 * @param array $mappings Associative list of processor types as keys and index/data mappings as values
251 251
 	 * @return \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface Processor object
252 252
 	 */
253
-	protected function getProcessors( array $mappings )
253
+	protected function getProcessors(array $mappings)
254 254
 	{
255 255
 		$context = $this->getContext();
256 256
 		$config = $context->getConfig();
257 257
 		$iface = '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\Iface';
258
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $context, [] );
258
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($context, []);
259 259
 
260
-		foreach( $mappings as $type => $mapping )
260
+		foreach ($mappings as $type => $mapping)
261 261
 		{
262
-			if( ctype_alnum( $type ) === false )
262
+			if (ctype_alnum($type) === false)
263 263
 			{
264 264
 				$classname = is_string($type) ? '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\' . $type : '<not a string>';
265
-				throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
265
+				throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
266 266
 			}
267 267
 
268
-			$name = $config->get( 'controller/common/product/import/csv/processor/' . $type . '/name', 'Standard' );
268
+			$name = $config->get('controller/common/product/import/csv/processor/' . $type . '/name', 'Standard');
269 269
 
270
-			if( ctype_alnum( $name ) === false )
270
+			if (ctype_alnum($name) === false)
271 271
 			{
272 272
 				$classname = is_string($name) ? '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\' . $type . '\\' . $name : '<not a string>';
273
-				throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
273
+				throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
274 274
 			}
275 275
 
276
-			$classname = '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\' . ucfirst( $type ) . '\\' . $name;
276
+			$classname = '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\' . ucfirst($type) . '\\' . $name;
277 277
 
278
-			if( class_exists( $classname ) === false ) {
279
-				throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Class "%1$s" not found', $classname ) );
278
+			if (class_exists($classname) === false) {
279
+				throw new \Aimeos\Controller\Jobs\Exception(sprintf('Class "%1$s" not found', $classname));
280 280
 			}
281 281
 
282
-			$object = new $classname( $context, $mapping, $object );
282
+			$object = new $classname($context, $mapping, $object);
283 283
 
284
-			if( !( $object instanceof $iface ) ) {
285
-				throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Class "%1$s" does not implement interface "%2$s"', $classname, $iface ) );
284
+			if (!($object instanceof $iface)) {
285
+				throw new \Aimeos\Controller\Jobs\Exception(sprintf('Class "%1$s" does not implement interface "%2$s"', $classname, $iface));
286 286
 			}
287 287
 		}
288 288
 
@@ -297,17 +297,17 @@  discard block
 block discarded – undo
297 297
 	 * @param array $domains List of domains whose items should be fetched too
298 298
 	 * @return array Associative list of product codes as key and product items as value
299 299
 	 */
300
-	protected function getProducts( array $codes, array $domains )
300
+	protected function getProducts(array $codes, array $domains)
301 301
 	{
302 302
 		$result = [];
303
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'product' );
303
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'product');
304 304
 
305 305
 		$search = $manager->createSearch();
306
-		$search->setConditions( $search->compare( '==', 'product.code', $codes ) );
307
-		$search->setSlice( 0, count( $codes ) );
306
+		$search->setConditions($search->compare('==', 'product.code', $codes));
307
+		$search->setSlice(0, count($codes));
308 308
 
309
-		foreach( $manager->searchItems( $search, $domains ) as $item ) {
310
-			$result[ $item->getCode() ] = $item;
309
+		foreach ($manager->searchItems($search, $domains) as $item) {
310
+			$result[$item->getCode()] = $item;
311 311
 		}
312 312
 
313 313
 		return $result;
@@ -322,23 +322,23 @@  discard block
 block discarded – undo
322 322
 	 * @param string $code Unique code of the type item
323 323
 	 * @return string Unique ID of the type item
324 324
 	 */
325
-	protected function getTypeId( $path, $domain, $code )
325
+	protected function getTypeId($path, $domain, $code)
326 326
 	{
327
-		if( !isset( self::$types[$path][$domain] ) )
327
+		if (!isset(self::$types[$path][$domain]))
328 328
 		{
329
-			$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), $path );
330
-			$key = str_replace( '/', '.', $path );
329
+			$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), $path);
330
+			$key = str_replace('/', '.', $path);
331 331
 
332 332
 			$search = $manager->createSearch();
333
-			$search->setConditions( $search->compare( '==', $key . '.domain', $domain ) );
333
+			$search->setConditions($search->compare('==', $key . '.domain', $domain));
334 334
 
335
-			foreach( $manager->searchItems( $search ) as $id => $item ) {
336
-				self::$types[$path][$domain][ $item->getCode() ] = $id;
335
+			foreach ($manager->searchItems($search) as $id => $item) {
336
+				self::$types[$path][$domain][$item->getCode()] = $id;
337 337
 			}
338 338
 		}
339 339
 
340
-		if( !isset( self::$types[$path][$domain][$code] ) ) {
341
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'No type item for "%1$s/%2$s" in "%3$s" found', $domain, $code, $path ) );
340
+		if (!isset(self::$types[$path][$domain][$code])) {
341
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('No type item for "%1$s/%2$s" in "%3$s" found', $domain, $code, $path));
342 342
 		}
343 343
 
344 344
 		return self::$types[$path][$domain][$code];
Please login to merge, or discard this patch.
controller/jobs/src/Controller/Jobs/Product/Export/Sitemap/Standard.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 	 */
29 29
 	public function getName()
30 30
 	{
31
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Product site map' );
31
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Product site map');
32 32
 	}
33 33
 
34 34
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 */
40 40
 	public function getDescription()
41 41
 	{
42
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Creates a product site map for search engines' );
42
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Creates a product site map for search engines');
43 43
 	}
44 44
 
45 45
 
@@ -52,8 +52,8 @@  discard block
 block discarded – undo
52 52
 	{
53 53
 		$container = $this->createContainer();
54 54
 
55
-		$files = $this->export( $container );
56
-		$this->createSitemapIndex( $container, $files );
55
+		$files = $this->export($container);
56
+		$this->createSitemapIndex($container, $files);
57 57
 
58 58
 		$container->close();
59 59
 	}
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	 * @param \Aimeos\MW\Container\Content\Iface $content File content object
66 66
 	 * @param \Aimeos\MShop\Product\Item\Iface[] $items List of product items
67 67
 	 */
68
-	protected function addItems( \Aimeos\MW\Container\Content\Iface $content, array $items )
68
+	protected function addItems(\Aimeos\MW\Container\Content\Iface $content, array $items)
69 69
 	{
70 70
 		$config = $this->getContext()->getConfig();
71 71
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 		 * @see controller/jobs/product/export/sitemap/max-items
97 97
 		 * @see controller/jobs/product/export/sitemap/max-query
98 98
 		 */
99
-		$changefreq = $config->get( 'controller/jobs/product/export/sitemap/changefreq', 'daily' );
99
+		$changefreq = $config->get('controller/jobs/product/export/sitemap/changefreq', 'daily');
100 100
 
101 101
 		/** controller/jobs/product/export/sitemap/standard/template-items
102 102
 		 * Relative path to the XML items template of the product site map job controller.
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 		$view->siteItems = $items;
130 130
 		$view->siteFreq = $changefreq;
131 131
 
132
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
132
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
133 133
 	}
134 134
 
135 135
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 		 * @see controller/jobs/product/export/sitemap/max-query
176 176
 		 * @see controller/jobs/product/export/sitemap/changefreq
177 177
 		 */
178
-		$location = $config->get( 'controller/jobs/product/export/sitemap/location', sys_get_temp_dir() );
178
+		$location = $config->get('controller/jobs/product/export/sitemap/location', sys_get_temp_dir());
179 179
 
180 180
 		/** controller/jobs/product/export/sitemap/container/options
181 181
 		 * List of file container options for the site map files
@@ -196,10 +196,10 @@  discard block
 block discarded – undo
196 196
 		 * @see controller/jobs/product/export/sitemap/max-query
197 197
 		 * @see controller/jobs/product/export/sitemap/changefreq
198 198
 		 */
199
-		$default = array( 'gzip-mode' => 'wb' );
200
-		$options = $config->get( 'controller/jobs/product/export/sitemap/container/options', $default );
199
+		$default = array('gzip-mode' => 'wb');
200
+		$options = $config->get('controller/jobs/product/export/sitemap/container/options', $default);
201 201
 
202
-		return \Aimeos\MW\Container\Factory::getContainer( $location, 'Directory', 'Gzip', $options );
202
+		return \Aimeos\MW\Container\Factory::getContainer($location, 'Directory', 'Gzip', $options);
203 203
 	}
204 204
 
205 205
 
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
 	 * @param integer $filenum New file number
211 211
 	 * @return \Aimeos\MW\Container\Content\Iface New content object
212 212
 	 */
213
-	protected function createContent( \Aimeos\MW\Container\Iface $container, $filenum )
213
+	protected function createContent(\Aimeos\MW\Container\Iface $container, $filenum)
214 214
 	{
215 215
 		/** controller/jobs/product/export/sitemap/standard/template-header
216 216
 		 * Relative path to the XML site map header template of the product site map job controller.
@@ -240,9 +240,9 @@  discard block
 block discarded – undo
240 240
 		$context = $this->getContext();
241 241
 		$view = $context->getView();
242 242
 
243
-		$content = $container->create( $this->getFilename( $filenum ) );
244
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
245
-		$container->add( $content );
243
+		$content = $container->create($this->getFilename($filenum));
244
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
245
+		$container->add($content);
246 246
 
247 247
 		return $content;
248 248
 	}
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 	 *
254 254
 	 * @param \Aimeos\MW\Container\Content\Iface $content
255 255
 	 */
256
-	protected function closeContent( \Aimeos\MW\Container\Content\Iface $content )
256
+	protected function closeContent(\Aimeos\MW\Container\Content\Iface $content)
257 257
 	{
258 258
 		/** controller/jobs/product/export/sitemap/standard/template-footer
259 259
 		 * Relative path to the XML site map footer template of the product site map job controller.
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 		$context = $this->getContext();
284 284
 		$view = $context->getView();
285 285
 
286
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
286
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
287 287
 	}
288 288
 
289 289
 
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 	 * @param \Aimeos\MW\Container\Iface $container File container object
294 294
 	 * @param array $files List of generated site map file names
295 295
 	 */
296
-	protected function createSitemapIndex( \Aimeos\MW\Container\Iface $container, array $files )
296
+	protected function createSitemapIndex(\Aimeos\MW\Container\Iface $container, array $files)
297 297
 	{
298 298
 		/** controller/jobs/product/export/sitemap/standard/template-index
299 299
 		 * Relative path to the XML site map index template of the product site map job controller.
@@ -325,9 +325,9 @@  discard block
 block discarded – undo
325 325
 
326 326
 		$view->siteFiles = $files;
327 327
 
328
-		$content = $container->create( 'aimeos-sitemap-index.xml' );
329
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
330
-		$container->add( $content );
328
+		$content = $container->create('aimeos-sitemap-index.xml');
329
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
330
+		$container->add($content);
331 331
 	}
332 332
 
333 333
 
@@ -338,11 +338,11 @@  discard block
 block discarded – undo
338 338
 	 * @param mixed $default Default value if name is unknown
339 339
 	 * @return mixed Configuration value
340 340
 	 */
341
-	protected function getConfig( $name, $default = null )
341
+	protected function getConfig($name, $default = null)
342 342
 	{
343 343
 		$config = $this->getContext()->getConfig();
344 344
 
345
-		switch( $name )
345
+		switch ($name)
346 346
 		{
347 347
 			case 'domain':
348 348
 				return [];
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
 				 * @see controller/jobs/product/export/sitemap/max-query
370 370
 				 * @see controller/jobs/product/export/sitemap/changefreq
371 371
 				 */
372
-				return $config->get( 'controller/jobs/product/export/sitemap/max-items', 50000 );
372
+				return $config->get('controller/jobs/product/export/sitemap/max-items', 50000);
373 373
 
374 374
 			case 'max-query':
375 375
 				/** controller/jobs/product/export/sitemap/max-query
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
 				 * @see controller/jobs/product/export/sitemap/max-items
390 390
 				 * @see controller/jobs/product/export/sitemap/changefreq
391 391
 				 */
392
-				return $config->get( 'controller/jobs/product/export/sitemap/max-query', 1000 );
392
+				return $config->get('controller/jobs/product/export/sitemap/max-query', 1000);
393 393
 		}
394 394
 
395 395
 		return $default;
@@ -402,8 +402,8 @@  discard block
 block discarded – undo
402 402
 	 * @param integer $number Current file number
403 403
 	 * @return string New file name
404 404
 	 */
405
-	protected function getFilename( $number )
405
+	protected function getFilename($number)
406 406
 	{
407
-		return sprintf( 'aimeos-sitemap-%d.xml', $number );
407
+		return sprintf('aimeos-sitemap-%d.xml', $number);
408 408
 	}
409 409
 }
Please login to merge, or discard this patch.
controller/jobs/src/Controller/Jobs/Product/Bought/Standard.php 1 patch
Spacing   +64 added lines, -64 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 	 */
30 30
 	public function getName()
31 31
 	{
32
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Products bought together' );
32
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Products bought together');
33 33
 	}
34 34
 
35 35
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 */
41 41
 	public function getDescription()
42 42
 	{
43
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Creates bought together product suggestions' );
43
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Creates bought together product suggestions');
44 44
 	}
45 45
 
46 46
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 		 * @see controller/jobs/product/bought/min-confidence
73 73
 		 * @see controller/jobs/product/bought/limit-days
74 74
 		 */
75
-		$maxItems = $config->get( 'controller/jobs/product/bought/max-items', 5 );
75
+		$maxItems = $config->get('controller/jobs/product/bought/max-items', 5);
76 76
 
77 77
 		/** controller/jobs/product/bought/min-support
78 78
 		 * Minimum support value to sort out all irrelevant combinations
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 		 * @see controller/jobs/product/bought/min-confidence
102 102
 		 * @see controller/jobs/product/bought/limit-days
103 103
 		 */
104
-		$minSupport = $config->get( 'controller/jobs/product/bought/min-support', 0.02 );
104
+		$minSupport = $config->get('controller/jobs/product/bought/min-support', 0.02);
105 105
 
106 106
 		/** controller/jobs/product/bought/min-confidence
107 107
 		 * Minimum confidence value for high quality suggestions
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 		 * @see controller/jobs/product/bought/min-support
127 127
 		 * @see controller/jobs/product/bought/limit-days
128 128
 		 */
129
-		$minConfidence = $config->get( 'controller/jobs/product/bought/min-confidence', 0.66 );
129
+		$minConfidence = $config->get('controller/jobs/product/bought/min-confidence', 0.66);
130 130
 
131 131
 		/** controller/jobs/product/bought/limit-days
132 132
 		 * Only use orders placed in the past within the configured number of days for calculating bought together products
@@ -150,45 +150,45 @@  discard block
 block discarded – undo
150 150
 		 * @see controller/jobs/product/bought/min-support
151 151
 		 * @see controller/jobs/product/bought/min-confidence
152 152
 		 */
153
-		$days = $config->get( 'controller/jobs/product/bought/limit-days', 180 );
154
-		$date = date( 'Y-m-d H:i:s', time() - $days * 86400 );
153
+		$days = $config->get('controller/jobs/product/bought/limit-days', 180);
154
+		$date = date('Y-m-d H:i:s', time() - $days * 86400);
155 155
 
156 156
 
157
-		$typeItem = $this->getTypeItem( 'product/lists/type', 'product', 'bought-together' );
157
+		$typeItem = $this->getTypeItem('product/lists/type', 'product', 'bought-together');
158 158
 
159
-		$baseManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
159
+		$baseManager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
160 160
 		$search = $baseManager->createSearch();
161
-		$search->setConditions( $search->compare( '>', 'order.base.ctime', $date ) );
162
-		$search->setSlice( 0, 0 );
161
+		$search->setConditions($search->compare('>', 'order.base.ctime', $date));
162
+		$search->setSlice(0, 0);
163 163
 		$totalOrders = 0;
164
-		$baseManager->searchItems( $search, [], $totalOrders );
164
+		$baseManager->searchItems($search, [], $totalOrders);
165 165
 
166
-		$baseProductManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base/product' );
166
+		$baseProductManager = \Aimeos\MShop\Factory::createManager($context, 'order/base/product');
167 167
 		$search = $baseProductManager->createSearch();
168
-		$search->setConditions( $search->compare( '>', 'order.base.product.ctime', $date ) );
168
+		$search->setConditions($search->compare('>', 'order.base.product.ctime', $date));
169 169
 		$start = 0;
170 170
 
171 171
 		do
172 172
 		{
173
-			$totalCounts = $baseProductManager->aggregate( $search, 'order.base.product.productid' );
174
-			$prodIds = array_keys( $totalCounts );
173
+			$totalCounts = $baseProductManager->aggregate($search, 'order.base.product.productid');
174
+			$prodIds = array_keys($totalCounts);
175 175
 
176
-			foreach( $totalCounts as $id => $count )
176
+			foreach ($totalCounts as $id => $count)
177 177
 			{
178
-				$this->removeListItems( $id, $typeItem->getId() );
178
+				$this->removeListItems($id, $typeItem->getId());
179 179
 
180
-				if( $count / $totalOrders > $minSupport )
180
+				if ($count / $totalOrders > $minSupport)
181 181
 				{
182
-					$productIds = $this->getSuggestions( $id, $prodIds, $count, $totalOrders, $maxItems, $minSupport, $minConfidence, $date );
183
-					$this->addListItems( $id, $typeItem->getId(), $productIds );
182
+					$productIds = $this->getSuggestions($id, $prodIds, $count, $totalOrders, $maxItems, $minSupport, $minConfidence, $date);
183
+					$this->addListItems($id, $typeItem->getId(), $productIds);
184 184
 				}
185 185
 			}
186 186
 
187
-			$count = count( $totalCounts );
187
+			$count = count($totalCounts);
188 188
 			$start += $count;
189
-			$search->setSlice( $start );
189
+			$search->setSlice($start);
190 190
 		}
191
-		while( $count >= $search->getSliceSize() );
191
+		while ($count >= $search->getSliceSize());
192 192
 	}
193 193
 
194 194
 
@@ -205,59 +205,59 @@  discard block
 block discarded – undo
205 205
 	 * @param string $date Date in YYYY-MM-DD HH:mm:ss format after which orders should be used for calculations
206 206
 	 * @return array List of suggested product IDs as key and their confidence as value
207 207
 	 */
208
-	protected function getSuggestions( $id, $prodIds, $count, $total, $maxItems, $minSupport, $minConfidence, $date )
208
+	protected function getSuggestions($id, $prodIds, $count, $total, $maxItems, $minSupport, $minConfidence, $date)
209 209
 	{
210 210
 		$refIds = [];
211 211
 		$context = $this->getContext();
212 212
 
213
-		$catalogListManager = \Aimeos\MShop\Factory::createManager( $context, 'catalog/lists' );
214
-		$baseProductManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base/product' );
213
+		$catalogListManager = \Aimeos\MShop\Factory::createManager($context, 'catalog/lists');
214
+		$baseProductManager = \Aimeos\MShop\Factory::createManager($context, 'order/base/product');
215 215
 
216 216
 
217 217
 		$search = $baseProductManager->createSearch();
218
-		$func = $search->createFunction( 'order.base.product.count', array( (string) $id ) );
218
+		$func = $search->createFunction('order.base.product.count', array((string) $id));
219 219
 		$expr = array(
220
-			$search->compare( '==', 'order.base.product.productid', $prodIds ),
221
-			$search->compare( '>', 'order.base.product.ctime', $date ),
222
-			$search->compare( '==', $func, 1 ),
220
+			$search->compare('==', 'order.base.product.productid', $prodIds),
221
+			$search->compare('>', 'order.base.product.ctime', $date),
222
+			$search->compare('==', $func, 1),
223 223
 		);
224
-		$search->setConditions( $search->combine( '&&', $expr ) );
224
+		$search->setConditions($search->combine('&&', $expr));
225 225
 
226
-		$relativeCounts = $baseProductManager->aggregate( $search, 'order.base.product.productid' );
226
+		$relativeCounts = $baseProductManager->aggregate($search, 'order.base.product.productid');
227 227
 
228 228
 
229 229
 		$search = $catalogListManager->createSearch();
230 230
 		$expr = array(
231
-			$search->compare( '==', 'catalog.lists.refid', array_keys( $relativeCounts ) ),
232
-			$search->compare( '==', 'catalog.lists.domain', 'product' ),
231
+			$search->compare('==', 'catalog.lists.refid', array_keys($relativeCounts)),
232
+			$search->compare('==', 'catalog.lists.domain', 'product'),
233 233
 		);
234
-		$search->setConditions( $search->combine( '&&', $expr ) );
234
+		$search->setConditions($search->combine('&&', $expr));
235 235
 
236
-		foreach( $catalogListManager->searchItems( $search ) as $listItem ) {
236
+		foreach ($catalogListManager->searchItems($search) as $listItem) {
237 237
 			$refIds[$listItem->getRefId()] = true;
238 238
 		}
239 239
 
240 240
 
241
-		unset( $relativeCounts[$id] );
241
+		unset($relativeCounts[$id]);
242 242
 		$supportA = $count / $total;
243 243
 		$products = [];
244 244
 
245
-		foreach( $relativeCounts as $prodId => $relCnt )
245
+		foreach ($relativeCounts as $prodId => $relCnt)
246 246
 		{
247
-			if( !isset( $refIds[$prodId] ) ) {
247
+			if (!isset($refIds[$prodId])) {
248 248
 				continue;
249 249
 			}
250 250
 
251 251
 			$supportAB = $relCnt / $total;
252 252
 
253
-			if( $supportAB > $minSupport && ( $conf = ( $supportAB / $supportA ) ) > $minConfidence ) {
253
+			if ($supportAB > $minSupport && ($conf = ($supportAB / $supportA)) > $minConfidence) {
254 254
 				$products[$prodId] = $conf;
255 255
 			}
256 256
 		}
257 257
 
258
-		arsort( $products );
258
+		arsort($products);
259 259
 
260
-		return array_keys( array_slice( $products, 0, $maxItems, true ) );
260
+		return array_keys(array_slice($products, 0, $maxItems, true));
261 261
 	}
262 262
 
263 263
 
@@ -268,26 +268,26 @@  discard block
 block discarded – undo
268 268
 	 * @param integer $typeId Unique ID of the list type used for the referenced products
269 269
 	 * @param array $productIds List of position as key and product ID as value
270 270
 	 */
271
-	protected function addListItems( $productId, $typeId, array $productIds )
271
+	protected function addListItems($productId, $typeId, array $productIds)
272 272
 	{
273
-		if( empty( $productIds ) ) {
273
+		if (empty($productIds)) {
274 274
 			return;
275 275
 		}
276 276
 
277
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'product/lists' );
277
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'product/lists');
278 278
 		$item = $manager->createItem();
279 279
 
280
-		foreach( $productIds as $pos => $refid )
280
+		foreach ($productIds as $pos => $refid)
281 281
 		{
282
-			$item->setId( null );
283
-			$item->setParentId( $productId );
284
-			$item->setDomain( 'product' );
285
-			$item->setTypeId( $typeId );
286
-			$item->setPosition( $pos );
287
-			$item->setRefId( $refid );
288
-			$item->setStatus( 1 );
289
-
290
-			$manager->saveItem( $item, false );
282
+			$item->setId(null);
283
+			$item->setParentId($productId);
284
+			$item->setDomain('product');
285
+			$item->setTypeId($typeId);
286
+			$item->setPosition($pos);
287
+			$item->setRefId($refid);
288
+			$item->setStatus(1);
289
+
290
+			$manager->saveItem($item, false);
291 291
 		}
292 292
 	}
293 293
 
@@ -298,20 +298,20 @@  discard block
 block discarded – undo
298 298
 	 * @param string $productId Unique ID of the product the references should be removed from
299 299
 	 * @param integer $typeId Unique ID of the list type the referenced products should be removed from
300 300
 	 */
301
-	protected function removeListItems( $productId, $typeId )
301
+	protected function removeListItems($productId, $typeId)
302 302
 	{
303
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'product/lists' );
303
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'product/lists');
304 304
 
305 305
 		$search = $manager->createSearch();
306 306
 		$expr = array(
307
-			$search->compare( '==', 'product.lists.parentid', $productId ),
308
-			$search->compare( '==', 'product.lists.domain', 'product' ),
309
-			$search->compare( '==', 'product.lists.typeid', $typeId ),
307
+			$search->compare('==', 'product.lists.parentid', $productId),
308
+			$search->compare('==', 'product.lists.domain', 'product'),
309
+			$search->compare('==', 'product.lists.typeid', $typeId),
310 310
 		);
311
-		$search->setConditions( $search->combine( '&&', $expr ) );
311
+		$search->setConditions($search->combine('&&', $expr));
312 312
 
313
-		$listItems = $manager->searchItems( $search );
313
+		$listItems = $manager->searchItems($search);
314 314
 
315
-		$manager->deleteItems( array_keys( $listItems ) );
315
+		$manager->deleteItems(array_keys($listItems));
316 316
 	}
317 317
 }
Please login to merge, or discard this patch.
Controller/Common/Product/Import/Csv/Processor/Catalog/StandardTest.php 1 patch
Spacing   +95 added lines, -95 removed lines patch added patch discarded remove patch
@@ -16,45 +16,45 @@  discard block
 block discarded – undo
16 16
 
17 17
 	public static function setUpBeforeClass()
18 18
 	{
19
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
20
-		$typeManager = $manager->getSubmanager( 'type' );
19
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
20
+		$typeManager = $manager->getSubmanager('type');
21 21
 
22 22
 		$typeSearch = $typeManager->createSearch();
23
-		$typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
24
-		$result = $typeManager->searchItems( $typeSearch );
23
+		$typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
24
+		$result = $typeManager->searchItems($typeSearch);
25 25
 
26
-		if( ( $typeItem = reset( $result ) ) === false ) {
27
-			throw new \RuntimeException( 'Product type "default" not found' );
26
+		if (($typeItem = reset($result)) === false) {
27
+			throw new \RuntimeException('Product type "default" not found');
28 28
 		}
29 29
 
30 30
 		$item = $manager->createItem();
31
-		$item->setCode( 'job_csv_prod' );
32
-		$item->setTypeId( $typeItem->getId() );
33
-		$item->setStatus( 1 );
31
+		$item->setCode('job_csv_prod');
32
+		$item->setTypeId($typeItem->getId());
33
+		$item->setStatus(1);
34 34
 
35
-		self::$product = $manager->saveItem( $item );
35
+		self::$product = $manager->saveItem($item);
36 36
 	}
37 37
 
38 38
 
39 39
 	public static function tearDownAfterClass()
40 40
 	{
41
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
42
-		$manager->deleteItem( self::$product->getId() );
41
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
42
+		$manager->deleteItem(self::$product->getId());
43 43
 	}
44 44
 
45 45
 
46 46
 	protected function setUp()
47 47
 	{
48
-		\Aimeos\MShop\Factory::setCache( true );
48
+		\Aimeos\MShop\Factory::setCache(true);
49 49
 
50 50
 		$this->context = \TestHelperCntl::getContext();
51
-		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
51
+		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
52 52
 	}
53 53
 
54 54
 
55 55
 	protected function tearDown()
56 56
 	{
57
-		\Aimeos\MShop\Factory::setCache( false );
57
+		\Aimeos\MShop\Factory::setCache(false);
58 58
 		\Aimeos\MShop\Factory::clear();
59 59
 	}
60 60
 
@@ -75,30 +75,30 @@  discard block
 block discarded – undo
75 75
 			3 => 'job_csv_test',
76 76
 		);
77 77
 
78
-		$this->create( 'job_csv_test' );
78
+		$this->create('job_csv_test');
79 79
 
80
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
81
-		$object->process( self::$product, $data );
80
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
81
+		$object->process(self::$product, $data);
82 82
 
83
-		$category = $this->get( 'job_csv_test' );
84
-		$this->delete( $category );
83
+		$category = $this->get('job_csv_test');
84
+		$this->delete($category);
85 85
 
86 86
 
87 87
 		$pos = 0;
88 88
 		$listItems = $category->getListItems();
89 89
 		$expected = array(
90
-			array( 'default', 'job_csv_prod' ),
91
-			array( 'promotion', 'job_csv_prod' ),
90
+			array('default', 'job_csv_prod'),
91
+			array('promotion', 'job_csv_prod'),
92 92
 		);
93 93
 
94
-		$this->assertEquals( 2, count( $listItems ) );
94
+		$this->assertEquals(2, count($listItems));
95 95
 
96
-		foreach( $listItems as $listItem )
96
+		foreach ($listItems as $listItem)
97 97
 		{
98
-			$this->assertEquals( 1, $listItem->getStatus() );
99
-			$this->assertEquals( 'product', $listItem->getDomain() );
100
-			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
101
-			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
98
+			$this->assertEquals(1, $listItem->getStatus());
99
+			$this->assertEquals('product', $listItem->getDomain());
100
+			$this->assertEquals($expected[$pos][0], $listItem->getType());
101
+			$this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
102 102
 			$pos++;
103 103
 		}
104 104
 	}
@@ -120,32 +120,32 @@  discard block
 block discarded – undo
120 120
 			3 => "job_csv_test\njob_csv_test2",
121 121
 		);
122 122
 
123
-		$this->create( 'job_csv_test' );
124
-		$this->create( 'job_csv_test2' );
123
+		$this->create('job_csv_test');
124
+		$this->create('job_csv_test2');
125 125
 
126
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
127
-		$object->process( self::$product, $data );
126
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
127
+		$object->process(self::$product, $data);
128 128
 
129
-		$category = $this->get( 'job_csv_test' );
130
-		$category2 = $this->get( 'job_csv_test2' );
129
+		$category = $this->get('job_csv_test');
130
+		$category2 = $this->get('job_csv_test2');
131 131
 
132
-		$this->delete( $category );
133
-		$this->delete( $category2 );
132
+		$this->delete($category);
133
+		$this->delete($category2);
134 134
 
135 135
 
136 136
 		$pos = 0;
137
-		$types = array( 'default', 'promotion', 'default', 'promotion' );
137
+		$types = array('default', 'promotion', 'default', 'promotion');
138 138
 
139
-		foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
139
+		foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
140 140
 		{
141
-			$this->assertEquals( 2, count( $listItems ) );
141
+			$this->assertEquals(2, count($listItems));
142 142
 
143
-			foreach( $listItems as $listItem )
143
+			foreach ($listItems as $listItem)
144 144
 			{
145
-				$this->assertEquals( 1, $listItem->getStatus() );
146
-				$this->assertEquals( 'product', $listItem->getDomain() );
147
-				$this->assertEquals( $types[$pos], $listItem->getType() );
148
-				$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
145
+				$this->assertEquals(1, $listItem->getStatus());
146
+				$this->assertEquals('product', $listItem->getDomain());
147
+				$this->assertEquals($types[$pos], $listItem->getType());
148
+				$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
149 149
 				$pos++;
150 150
 			}
151 151
 		}
@@ -169,23 +169,23 @@  discard block
 block discarded – undo
169 169
 			1 => 'job_csv_test',
170 170
 		);
171 171
 
172
-		$this->create( 'job_csv_test' );
172
+		$this->create('job_csv_test');
173 173
 
174
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
175
-		$object->process( self::$product, $data );
176
-		$object->process( self::$product, $dataUpdate );
174
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
175
+		$object->process(self::$product, $data);
176
+		$object->process(self::$product, $dataUpdate);
177 177
 
178
-		$category = $this->get( 'job_csv_test' );
179
-		$this->delete( $category );
178
+		$category = $this->get('job_csv_test');
179
+		$this->delete($category);
180 180
 
181 181
 
182 182
 		$listItems = $category->getListItems();
183
-		$listItem = reset( $listItems );
183
+		$listItem = reset($listItems);
184 184
 
185
-		$this->assertEquals( 1, count( $listItems ) );
186
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
185
+		$this->assertEquals(1, count($listItems));
186
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
187 187
 
188
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
188
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
189 189
 	}
190 190
 
191 191
 
@@ -201,21 +201,21 @@  discard block
 block discarded – undo
201 201
 			1 => 'job_csv_test',
202 202
 		);
203 203
 
204
-		$this->create( 'job_csv_test' );
204
+		$this->create('job_csv_test');
205 205
 
206
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
207
-		$object->process( self::$product, $data );
206
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
207
+		$object->process(self::$product, $data);
208 208
 
209
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, [], $this->endpoint );
210
-		$object->process( self::$product, [] );
209
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, [], $this->endpoint);
210
+		$object->process(self::$product, []);
211 211
 
212
-		$category = $this->get( 'job_csv_test' );
213
-		$this->delete( $category );
212
+		$category = $this->get('job_csv_test');
213
+		$this->delete($category);
214 214
 
215 215
 
216 216
 		$listItems = $category->getListItems();
217 217
 
218
-		$this->assertEquals( 0, count( $listItems ) );
218
+		$this->assertEquals(0, count($listItems));
219 219
 	}
220 220
 
221 221
 
@@ -235,18 +235,18 @@  discard block
 block discarded – undo
235 235
 			3 => 'job_csv_test',
236 236
 		);
237 237
 
238
-		$this->create( 'job_csv_test' );
238
+		$this->create('job_csv_test');
239 239
 
240
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
241
-		$object->process( self::$product, $data );
240
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
241
+		$object->process(self::$product, $data);
242 242
 
243
-		$category = $this->get( 'job_csv_test' );
244
-		$this->delete( $category );
243
+		$category = $this->get('job_csv_test');
244
+		$this->delete($category);
245 245
 
246 246
 
247 247
 		$listItems = $category->getListItems();
248 248
 
249
-		$this->assertEquals( 1, count( $listItems ) );
249
+		$this->assertEquals(1, count($listItems));
250 250
 	}
251 251
 
252 252
 
@@ -266,71 +266,71 @@  discard block
 block discarded – undo
266 266
 			3 => 'job_csv_test',
267 267
 		);
268 268
 
269
-		$this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
269
+		$this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
270 270
 
271
-		$this->create( 'job_csv_test' );
271
+		$this->create('job_csv_test');
272 272
 
273
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
274
-		$object->process( self::$product, $data );
273
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
274
+		$object->process(self::$product, $data);
275 275
 
276
-		$category = $this->get( 'job_csv_test' );
277
-		$this->delete( $category );
276
+		$category = $this->get('job_csv_test');
277
+		$this->delete($category);
278 278
 
279 279
 
280 280
 		$listItems = $category->getListItems();
281
-		$listItem = reset( $listItems );
281
+		$listItem = reset($listItems);
282 282
 
283
-		$this->assertEquals( 1, count( $listItems ) );
284
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
283
+		$this->assertEquals(1, count($listItems));
284
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
285 285
 
286
-		$this->assertEquals( 'default', $listItem->getType() );
287
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
286
+		$this->assertEquals('default', $listItem->getType());
287
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
288 288
 	}
289 289
 
290 290
 
291 291
 	/**
292 292
 	 * @param string $code
293 293
 	 */
294
-	protected function create( $code )
294
+	protected function create($code)
295 295
 	{
296
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
296
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
297 297
 
298 298
 		$item = $manager->createItem();
299
-		$item->setCode( $code );
299
+		$item->setCode($code);
300 300
 
301
-		$manager->insertItem( $item );
301
+		$manager->insertItem($item);
302 302
 
303 303
 		return $item;
304 304
 	}
305 305
 
306 306
 
307
-	protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
307
+	protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
308 308
 	{
309
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
310
-		$listManager = $manager->getSubManager( 'lists' );
309
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
310
+		$listManager = $manager->getSubManager('lists');
311 311
 
312
-		foreach( $catItem->getListItems('product') as $listItem ) {
313
-			$listManager->deleteItem( $listItem->getId() );
312
+		foreach ($catItem->getListItems('product') as $listItem) {
313
+			$listManager->deleteItem($listItem->getId());
314 314
 		}
315 315
 
316
-		$manager->deleteItem( $catItem->getId() );
316
+		$manager->deleteItem($catItem->getId());
317 317
 	}
318 318
 
319 319
 
320 320
 	/**
321 321
 	 * @param string $code
322 322
 	 */
323
-	protected function get( $code )
323
+	protected function get($code)
324 324
 	{
325
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
325
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
326 326
 
327 327
 		$search = $manager->createSearch();
328
-		$search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
328
+		$search->setConditions($search->compare('==', 'catalog.code', $code));
329 329
 
330
-		$result = $manager->searchItems( $search, array('product') );
330
+		$result = $manager->searchItems($search, array('product'));
331 331
 
332
-		if( ( $item = reset( $result ) ) === false ) {
333
-			throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
332
+		if (($item = reset($result)) === false) {
333
+			throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
334 334
 		}
335 335
 
336 336
 		return $item;
Please login to merge, or discard this patch.
tests/Controller/Common/Product/Import/Csv/Processor/Stock/StandardTest.php 1 patch
Spacing   +63 added lines, -63 removed lines patch added patch discarded remove patch
@@ -17,16 +17,16 @@  discard block
 block discarded – undo
17 17
 
18 18
 	protected function setUp()
19 19
 	{
20
-		\Aimeos\MShop\Factory::setCache( true );
20
+		\Aimeos\MShop\Factory::setCache(true);
21 21
 
22 22
 		$this->context = \TestHelperCntl::getContext();
23
-		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
23
+		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
24 24
 	}
25 25
 
26 26
 
27 27
 	protected function tearDown()
28 28
 	{
29
-		\Aimeos\MShop\Factory::setCache( false );
29
+		\Aimeos\MShop\Factory::setCache(false);
30 30
 		\Aimeos\MShop\Factory::clear();
31 31
 	}
32 32
 
@@ -43,21 +43,21 @@  discard block
 block discarded – undo
43 43
 			1 => '2000-01-01 00:00:00',
44 44
 		);
45 45
 
46
-		$product = $this->create( 'job_csv_test' );
46
+		$product = $this->create('job_csv_test');
47 47
 
48
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard( $this->context, $mapping, $this->endpoint );
49
-		$object->process( $product, $data );
48
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard($this->context, $mapping, $this->endpoint);
49
+		$object->process($product, $data);
50 50
 
51
-		$items = $this->getStockItems( $product->getCode() );
52
-		$this->delete( $product );
51
+		$items = $this->getStockItems($product->getCode());
52
+		$this->delete($product);
53 53
 
54 54
 
55
-		$this->assertEquals( 1, count( $items ) );
55
+		$this->assertEquals(1, count($items));
56 56
 
57
-		foreach( $items as $item )
57
+		foreach ($items as $item)
58 58
 		{
59
-			$this->assertEquals( 100, $item->getStocklevel() );
60
-			$this->assertEquals( '2000-01-01 00:00:00', $item->getDateBack() );
59
+			$this->assertEquals(100, $item->getStocklevel());
60
+			$this->assertEquals('2000-01-01 00:00:00', $item->getDateBack());
61 61
 		}
62 62
 	}
63 63
 
@@ -78,19 +78,19 @@  discard block
 block discarded – undo
78 78
 			3 => '200',
79 79
 		);
80 80
 
81
-		$product = $this->create( 'job_csv_test' );
81
+		$product = $this->create('job_csv_test');
82 82
 
83
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard( $this->context, $mapping, $this->endpoint );
84
-		$object->process( $product, $data );
83
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard($this->context, $mapping, $this->endpoint);
84
+		$object->process($product, $data);
85 85
 
86
-		$items = $this->getStockItems( $product->getCode() );
87
-		$this->delete( $product );
86
+		$items = $this->getStockItems($product->getCode());
87
+		$this->delete($product);
88 88
 
89 89
 
90
-		$this->assertEquals( 2, count( $items ) );
90
+		$this->assertEquals(2, count($items));
91 91
 
92
-		foreach( $items as $item ) {
93
-			$this->assertEquals( 200, $item->getStocklevel() );
92
+		foreach ($items as $item) {
93
+			$this->assertEquals(200, $item->getStocklevel());
94 94
 		}
95 95
 	}
96 96
 
@@ -109,21 +109,21 @@  discard block
 block discarded – undo
109 109
 			0 => '20',
110 110
 		);
111 111
 
112
-		$product = $this->create( 'job_csv_test' );
112
+		$product = $this->create('job_csv_test');
113 113
 
114
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard( $this->context, $mapping, $this->endpoint );
114
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard($this->context, $mapping, $this->endpoint);
115 115
 
116
-		$object->process( $product, $data );
117
-		$object->process( $product, $dataUpdate );
116
+		$object->process($product, $data);
117
+		$object->process($product, $dataUpdate);
118 118
 
119
-		$items = $this->getStockItems( $product->getCode() );
120
-		$this->delete( $product );
119
+		$items = $this->getStockItems($product->getCode());
120
+		$this->delete($product);
121 121
 
122 122
 
123
-		$item = reset( $items );
123
+		$item = reset($items);
124 124
 
125
-		$this->assertEquals( 1, count( $items ) );
126
-		$this->assertEquals( 20, $item->getStocklevel() );
125
+		$this->assertEquals(1, count($items));
126
+		$this->assertEquals(20, $item->getStocklevel());
127 127
 	}
128 128
 
129 129
 
@@ -137,19 +137,19 @@  discard block
 block discarded – undo
137 137
 			0 => 50,
138 138
 		);
139 139
 
140
-		$product = $this->create( 'job_csv_test' );
140
+		$product = $this->create('job_csv_test');
141 141
 
142
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard( $this->context, $mapping, $this->endpoint );
143
-		$object->process( $product, $data );
142
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard($this->context, $mapping, $this->endpoint);
143
+		$object->process($product, $data);
144 144
 
145
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard( $this->context, [], $this->endpoint );
146
-		$object->process( $product, [] );
145
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard($this->context, [], $this->endpoint);
146
+		$object->process($product, []);
147 147
 
148
-		$items = $this->getStockItems( $product->getCode() );
149
-		$this->delete( $product );
148
+		$items = $this->getStockItems($product->getCode());
149
+		$this->delete($product);
150 150
 
151 151
 
152
-		$this->assertEquals( 0, count( $items ) );
152
+		$this->assertEquals(0, count($items));
153 153
 	}
154 154
 
155 155
 
@@ -167,20 +167,20 @@  discard block
 block discarded – undo
167 167
 			2 => '',
168 168
 		);
169 169
 
170
-		$product = $this->create( 'job_csv_test' );
170
+		$product = $this->create('job_csv_test');
171 171
 
172
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard( $this->context, $mapping, $this->endpoint );
173
-		$object->process( $product, $data );
172
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Standard($this->context, $mapping, $this->endpoint);
173
+		$object->process($product, $data);
174 174
 
175
-		$items = $this->getStockItems( $product->getCode() );
176
-		$this->delete( $product );
175
+		$items = $this->getStockItems($product->getCode());
176
+		$this->delete($product);
177 177
 
178
-		$this->assertEquals( 1, count( $items ) );
178
+		$this->assertEquals(1, count($items));
179 179
 
180
-		foreach( $items as $item )
180
+		foreach ($items as $item)
181 181
 		{
182
-			$this->assertEquals( null, $item->getStocklevel() );
183
-			$this->assertEquals( null, $item->getDateBack() );
182
+			$this->assertEquals(null, $item->getStocklevel());
183
+			$this->assertEquals(null, $item->getDateBack());
184 184
 		}
185 185
 	}
186 186
 
@@ -188,41 +188,41 @@  discard block
 block discarded – undo
188 188
 	/**
189 189
 	 * @param string $code
190 190
 	 */
191
-	protected function create( $code )
191
+	protected function create($code)
192 192
 	{
193
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( $this->context );
194
-		$typeManager = $manager->getSubManager( 'type' );
193
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager($this->context);
194
+		$typeManager = $manager->getSubManager('type');
195 195
 
196 196
 		$typeSearch = $typeManager->createSearch();
197
-		$typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
198
-		$typeResult = $typeManager->searchItems( $typeSearch );
197
+		$typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
198
+		$typeResult = $typeManager->searchItems($typeSearch);
199 199
 
200
-		if( ( $typeItem = reset( $typeResult ) ) === false ) {
201
-			throw new \RuntimeException( 'No product type "default" found' );
200
+		if (($typeItem = reset($typeResult)) === false) {
201
+			throw new \RuntimeException('No product type "default" found');
202 202
 		}
203 203
 
204 204
 		$item = $manager->createItem();
205
-		$item->setTypeid( $typeItem->getId() );
206
-		$item->setCode( $code );
205
+		$item->setTypeid($typeItem->getId());
206
+		$item->setCode($code);
207 207
 
208
-		return $manager->saveItem( $item );
208
+		return $manager->saveItem($item);
209 209
 	}
210 210
 
211 211
 
212
-	protected function delete( \Aimeos\MShop\Product\Item\Iface $product )
212
+	protected function delete(\Aimeos\MShop\Product\Item\Iface $product)
213 213
 	{
214
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( $this->context );
215
-		$manager->deleteItem( $product->getId() );
214
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager($this->context);
215
+		$manager->deleteItem($product->getId());
216 216
 	}
217 217
 
218 218
 
219
-	protected function getStockItems( $code )
219
+	protected function getStockItems($code)
220 220
 	{
221
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' );
221
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'stock');
222 222
 
223 223
 		$search = $manager->createSearch();
224
-		$search->setConditions( $search->compare( '==', 'stock.productcode', $code ) );
224
+		$search->setConditions($search->compare('==', 'stock.productcode', $code));
225 225
 
226
-		return $manager->searchItems( $search );
226
+		return $manager->searchItems($search);
227 227
 	}
228 228
 }
229 229
\ No newline at end of file
Please login to merge, or discard this patch.
Controller/Common/Product/Import/Csv/Processor/Product/StandardTest.php 1 patch
Spacing   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -15,16 +15,16 @@  discard block
 block discarded – undo
15 15
 
16 16
 	protected function setUp()
17 17
 	{
18
-		\Aimeos\MShop\Factory::setCache( true );
18
+		\Aimeos\MShop\Factory::setCache(true);
19 19
 
20 20
 		$this->context = \TestHelperCntl::getContext();
21
-		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
21
+		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
22 22
 	}
23 23
 
24 24
 
25 25
 	protected function tearDown()
26 26
 	{
27
-		\Aimeos\MShop\Factory::setCache( false );
27
+		\Aimeos\MShop\Factory::setCache(false);
28 28
 		\Aimeos\MShop\Factory::clear();
29 29
 	}
30 30
 
@@ -45,26 +45,26 @@  discard block
 block discarded – undo
45 45
 			3 => 'CNE',
46 46
 		);
47 47
 
48
-		$product = $this->create( 'job_csv_test' );
48
+		$product = $this->create('job_csv_test');
49 49
 
50
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard( $this->context, $mapping, $this->endpoint );
51
-		$object->process( $product, $data );
50
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard($this->context, $mapping, $this->endpoint);
51
+		$object->process($product, $data);
52 52
 
53
-		$product = $this->get( 'job_csv_test' );
54
-		$this->delete( $product );
53
+		$product = $this->get('job_csv_test');
54
+		$this->delete($product);
55 55
 
56 56
 
57
-		$listItems1 = $product->getListItems( 'product', 'default' );
58
-		$listItems2 = $product->getListItems( 'product', 'suggestion' );
57
+		$listItems1 = $product->getListItems('product', 'default');
58
+		$listItems2 = $product->getListItems('product', 'suggestion');
59 59
 
60
-		$this->assertEquals( 1, count( $listItems1 ) );
61
-		$this->assertEquals( 1, count( $listItems2 ) );
60
+		$this->assertEquals(1, count($listItems1));
61
+		$this->assertEquals(1, count($listItems2));
62 62
 
63
-		$this->assertEquals( 1, reset( $listItems1 )->getStatus() );
64
-		$this->assertEquals( 1, reset( $listItems2 )->getStatus() );
63
+		$this->assertEquals(1, reset($listItems1)->getStatus());
64
+		$this->assertEquals(1, reset($listItems2)->getStatus());
65 65
 
66
-		$this->assertEquals( 'CNC', reset( $listItems1 )->getRefItem()->getCode() );
67
-		$this->assertEquals( 'CNE', reset( $listItems2 )->getRefItem()->getCode() );
66
+		$this->assertEquals('CNC', reset($listItems1)->getRefItem()->getCode());
67
+		$this->assertEquals('CNE', reset($listItems2)->getRefItem()->getCode());
68 68
 	}
69 69
 
70 70
 
@@ -80,27 +80,27 @@  discard block
 block discarded – undo
80 80
 			1 => "CNC\nCNE",
81 81
 		);
82 82
 
83
-		$product = $this->create( 'job_csv_test' );
83
+		$product = $this->create('job_csv_test');
84 84
 
85
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard( $this->context, $mapping, $this->endpoint );
86
-		$object->process( $product, $data );
85
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard($this->context, $mapping, $this->endpoint);
86
+		$object->process($product, $data);
87 87
 
88
-		$product = $this->get( 'job_csv_test' );
89
-		$this->delete( $product );
88
+		$product = $this->get('job_csv_test');
89
+		$this->delete($product);
90 90
 
91 91
 
92 92
 		$pos = 0;
93
-		$codes = array( 'CNC', 'CNE' );
93
+		$codes = array('CNC', 'CNE');
94 94
 		$listItems = $product->getListItems();
95 95
 
96
-		$this->assertEquals( 2, count( $listItems ) );
96
+		$this->assertEquals(2, count($listItems));
97 97
 
98
-		foreach( $listItems as $listItem )
98
+		foreach ($listItems as $listItem)
99 99
 		{
100
-			$this->assertEquals( 1, $listItem->getStatus() );
101
-			$this->assertEquals( 'product', $listItem->getDomain() );
102
-			$this->assertEquals( 'default', $listItem->getType() );
103
-			$this->assertEquals( $codes[$pos], $listItem->getRefItem()->getCode() );
100
+			$this->assertEquals(1, $listItem->getStatus());
101
+			$this->assertEquals('product', $listItem->getDomain());
102
+			$this->assertEquals('default', $listItem->getType());
103
+			$this->assertEquals($codes[$pos], $listItem->getRefItem()->getCode());
104 104
 			$pos++;
105 105
 		}
106 106
 	}
@@ -123,26 +123,26 @@  discard block
 block discarded – undo
123 123
 			1 => 'CNE',
124 124
 		);
125 125
 
126
-		$product = $this->create( 'job_csv_test' );
126
+		$product = $this->create('job_csv_test');
127 127
 
128
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard( $this->context, $mapping, $this->endpoint );
129
-		$object->process( $product, $data );
128
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard($this->context, $mapping, $this->endpoint);
129
+		$object->process($product, $data);
130 130
 
131
-		$product = $this->get( 'job_csv_test' );
131
+		$product = $this->get('job_csv_test');
132 132
 
133
-		$object->process( $product, $dataUpdate );
133
+		$object->process($product, $dataUpdate);
134 134
 
135
-		$product = $this->get( 'job_csv_test' );
136
-		$this->delete( $product );
135
+		$product = $this->get('job_csv_test');
136
+		$this->delete($product);
137 137
 
138 138
 
139 139
 		$listItems = $product->getListItems();
140
-		$listItem = reset( $listItems );
140
+		$listItem = reset($listItems);
141 141
 
142
-		$this->assertEquals( 1, count( $listItems ) );
143
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
142
+		$this->assertEquals(1, count($listItems));
143
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
144 144
 
145
-		$this->assertEquals( 'CNE', $listItem->getRefItem()->getCode() );
145
+		$this->assertEquals('CNE', $listItem->getRefItem()->getCode());
146 146
 	}
147 147
 
148 148
 
@@ -158,21 +158,21 @@  discard block
 block discarded – undo
158 158
 			1 => 'CNC',
159 159
 		);
160 160
 
161
-		$product = $this->create( 'job_csv_test' );
161
+		$product = $this->create('job_csv_test');
162 162
 
163
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard( $this->context, $mapping, $this->endpoint );
164
-		$object->process( $product, $data );
163
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard($this->context, $mapping, $this->endpoint);
164
+		$object->process($product, $data);
165 165
 
166
-		$product = $this->get( 'job_csv_test' );
166
+		$product = $this->get('job_csv_test');
167 167
 
168
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard( $this->context, [], $this->endpoint );
169
-		$object->process( $product, [] );
168
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard($this->context, [], $this->endpoint);
169
+		$object->process($product, []);
170 170
 
171
-		$product = $this->get( 'job_csv_test' );
172
-		$this->delete( $product );
171
+		$product = $this->get('job_csv_test');
172
+		$this->delete($product);
173 173
 
174 174
 
175
-		$this->assertEquals( 0, count( $product->getListItems() ) );
175
+		$this->assertEquals(0, count($product->getListItems()));
176 176
 	}
177 177
 
178 178
 
@@ -192,18 +192,18 @@  discard block
 block discarded – undo
192 192
 			3 => 'CNE',
193 193
 		);
194 194
 
195
-		$product = $this->create( 'job_csv_test' );
195
+		$product = $this->create('job_csv_test');
196 196
 
197
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard( $this->context, $mapping, $this->endpoint );
198
-		$object->process( $product, $data );
197
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard($this->context, $mapping, $this->endpoint);
198
+		$object->process($product, $data);
199 199
 
200
-		$product = $this->get( 'job_csv_test' );
201
-		$this->delete( $product );
200
+		$product = $this->get('job_csv_test');
201
+		$this->delete($product);
202 202
 
203 203
 
204 204
 		$listItems = $product->getListItems();
205 205
 
206
-		$this->assertEquals( 1, count( $listItems ) );
206
+		$this->assertEquals(1, count($listItems));
207 207
 	}
208 208
 
209 209
 
@@ -223,79 +223,79 @@  discard block
 block discarded – undo
223 223
 			3 => 'CNE',
224 224
 		);
225 225
 
226
-		$this->context->getConfig()->set( 'controller/common/product/import/csv/processor/product/listtypes', array( 'default' ) );
226
+		$this->context->getConfig()->set('controller/common/product/import/csv/processor/product/listtypes', array('default'));
227 227
 
228
-		$product = $this->create( 'job_csv_test' );
228
+		$product = $this->create('job_csv_test');
229 229
 
230
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard( $this->context, $mapping, $this->endpoint );
231
-		$object->process( $product, $data );
230
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Product\Standard($this->context, $mapping, $this->endpoint);
231
+		$object->process($product, $data);
232 232
 
233
-		$product = $this->get( 'job_csv_test' );
234
-		$this->delete( $product );
233
+		$product = $this->get('job_csv_test');
234
+		$this->delete($product);
235 235
 
236 236
 
237 237
 		$listItems = $product->getListItems();
238
-		$listItem = reset( $listItems );
238
+		$listItem = reset($listItems);
239 239
 
240
-		$this->assertEquals( 1, count( $listItems ) );
241
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
240
+		$this->assertEquals(1, count($listItems));
241
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
242 242
 
243
-		$this->assertEquals( 'default', $listItem->getType() );
244
-		$this->assertEquals( 'CNE', $listItem->getRefItem()->getCode() );
243
+		$this->assertEquals('default', $listItem->getType());
244
+		$this->assertEquals('CNE', $listItem->getRefItem()->getCode());
245 245
 	}
246 246
 
247 247
 
248 248
 	/**
249 249
 	 * @param string $code
250 250
 	 */
251
-	protected function create( $code )
251
+	protected function create($code)
252 252
 	{
253
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( $this->context );
254
-		$typeManager = $manager->getSubManager( 'type' );
253
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager($this->context);
254
+		$typeManager = $manager->getSubManager('type');
255 255
 
256 256
 		$typeSearch = $typeManager->createSearch();
257
-		$typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
258
-		$typeResult = $typeManager->searchItems( $typeSearch );
257
+		$typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
258
+		$typeResult = $typeManager->searchItems($typeSearch);
259 259
 
260
-		if( ( $typeItem = reset( $typeResult ) ) === false ) {
261
-			throw new \RuntimeException( 'No product type "default" found' );
260
+		if (($typeItem = reset($typeResult)) === false) {
261
+			throw new \RuntimeException('No product type "default" found');
262 262
 		}
263 263
 
264 264
 		$item = $manager->createItem();
265
-		$item->setTypeid( $typeItem->getId() );
266
-		$item->setCode( $code );
265
+		$item->setTypeid($typeItem->getId());
266
+		$item->setCode($code);
267 267
 
268
-		return $manager->saveItem( $item );
268
+		return $manager->saveItem($item);
269 269
 	}
270 270
 
271 271
 
272
-	protected function delete( \Aimeos\MShop\Product\Item\Iface $product )
272
+	protected function delete(\Aimeos\MShop\Product\Item\Iface $product)
273 273
 	{
274
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( $this->context );
275
-		$listManager = $manager->getSubManager( 'lists' );
274
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager($this->context);
275
+		$listManager = $manager->getSubManager('lists');
276 276
 
277
-		foreach( $product->getListItems('product') as $listItem ) {
278
-			$listManager->deleteItem( $listItem->getId() );
277
+		foreach ($product->getListItems('product') as $listItem) {
278
+			$listManager->deleteItem($listItem->getId());
279 279
 		}
280 280
 
281
-		$manager->deleteItem( $product->getId() );
281
+		$manager->deleteItem($product->getId());
282 282
 	}
283 283
 
284 284
 
285 285
 	/**
286 286
 	 * @param string $code
287 287
 	 */
288
-	protected function get( $code )
288
+	protected function get($code)
289 289
 	{
290
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( $this->context );
290
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager($this->context);
291 291
 
292 292
 		$search = $manager->createSearch();
293
-		$search->setConditions( $search->compare( '==', 'product.code', $code ) );
293
+		$search->setConditions($search->compare('==', 'product.code', $code));
294 294
 
295
-		$result = $manager->searchItems( $search, array('product') );
295
+		$result = $manager->searchItems($search, array('product'));
296 296
 
297
-		if( ( $item = reset( $result ) ) === false ) {
298
-			throw new \RuntimeException( sprintf( 'No product item for code "%1$s"', $code ) );
297
+		if (($item = reset($result)) === false) {
298
+			throw new \RuntimeException(sprintf('No product item for code "%1$s"', $code));
299 299
 		}
300 300
 
301 301
 		return $item;
Please login to merge, or discard this patch.