Standard::process() - Code Metrics - Inspection of "Use type codes instead of type IDs" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 984043...a9b00f )

by Aimeos

created 2018-12-20 19:17 UTC

Standard::process() B

↳ Parent: Standard

Complexity

Conditions	10
Paths	74

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	55
rs	7.1151
c	0
b	0
f	0
cc	10
nc	74
nop	2

How to fix Long Method Complexity

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2015-2018
 * @package Controller
 * @subpackage Common
 */


namespace Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock;


/**
 * Product stock processor for CSV imports
 *
 * @package Controller
 * @subpackage Common
 */
class Standard
	extends \Aimeos\Controller\Common\Product\Import\Csv\Processor\Base
	implements \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface
{
	/** controller/common/product/import/csv/processor/stock/name
	 * Name of the stock processor implementation
	 *
	 * Use "Myname" if your class is named "\Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Myname".
	 * The name is case-sensitive and you should avoid camel case names like "MyName".
	 *
	 * @param string Last part of the processor class name
	 * @since 2015.10
	 * @category Developer
	 */

	private $types = [];


	/**
	 * Initializes the object
	 *
	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
	 * @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
	 */
	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
		\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
	{
		parent::__construct( $context, $mapping, $object );

		$manager = \Aimeos\MShop\Factory::createManager( $context, 'stock/type' );
		$search = $manager->createSearch()->setSlice( 0, 0x7fffffff );

		foreach( $manager->searchItems( $search ) as $item ) {
			$this->types[$item->getCode()] = $item->getCode();
		}
	}


	/**
	 * Saves the product stock related data to the storage
	 *
	 * @param \Aimeos\MShop\Product\Item\Iface $product Product item with associated items
	 * @param array $data List of CSV fields with position as key and data as value
	 * @return array List of data which hasn't been imported
	 */
	public function process( \Aimeos\MShop\Product\Item\Iface $product, array $data )
	{
		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' );
		$manager->begin();

		try
		{
			$map = $this->getMappedChunk( $data, $this->getMapping() );
			$items = $this->getStockItems( $product->getCode() );

			foreach( $map as $pos => $list )
			{
				if( !array_key_exists( 'stock.stocklevel', $list ) ) {
					continue;
				}

				$list['stock.productcode'] = $product->getCode();
				$list['stock.type'] = trim( isset( $list['stock.type'] ) ? $list['stock.type'] : 'default' );

				if( !in_array( $list['stock.type'], $this->types ) )
				{
					$msg = sprintf( 'Invalid type "%1$s" (%2$s)', $list['stock.type'], 'stock' );
					throw new \Aimeos\Controller\Common\Exception( $msg );
				}

				if( isset( $list['stock.dateback'] ) && trim( $list['stock.dateback'] ) === '' ) {
					$list['stock.dateback'] = null;
				}

				if( trim( $list['stock.stocklevel'] ) === '' ) {
					$list['stock.stocklevel'] = null;
				}

				if( ( $item = array_pop( $items ) ) === null ) {
					$item = $manager->createItem();
				}

				$item->fromArray( $list );
				$manager->saveItem( $item, false );
			}

			$manager->deleteItems( array_keys( $items ) );

			$data = $this->getObject()->process( $product, $data );

			$manager->commit();
		}
		catch( \Exception $e )
		{
			$manager->rollback();
			throw $e;
		}

		return $data;
	}


	/**
	 * Returns the stock items for the given product code
	 *
	 * @param string $code Unique product code
	 * @return \Aimeos\MShop\Stock\Item\Iface[] Associative list of stock items
	 */
	protected function getStockItems( $code )
	{
		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' );

		$search = $manager->createSearch();
		$search->setConditions( $search->compare( '==', 'stock.productcode', $code ) );

		return $manager->searchItems( $search );
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2015-2018
6			* @package Controller
7			* @subpackage Common
8			*/
9
10
11			namespace Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock;
12
13
14			/**
15			* Product stock processor for CSV imports
16			*
17			* @package Controller
18			* @subpackage Common
19			*/
20			class Standard
21			extends \Aimeos\Controller\Common\Product\Import\Csv\Processor\Base
22			implements \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface
23			{
24			/** controller/common/product/import/csv/processor/stock/name
25			* Name of the stock processor implementation
26			*
27			* Use "Myname" if your class is named "\Aimeos\Controller\Common\Product\Import\Csv\Processor\Stock\Myname".
28			* The name is case-sensitive and you should avoid camel case names like "MyName".
29			*
30			* @param string Last part of the processor class name
31			* @since 2015.10
32			* @category Developer
33			*/
34
35			private $types = [];
36
37
38			/**
39			* Initializes the object
40			*
41			* @param \Aimeos\MShop\Context\Item\Iface $context Context object
42			* @param array $mapping Associative list of field position in CSV as key and domain item key as value
43			* @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
44			*/
45			public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
46			\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
47			{
48			parent::__construct( $context, $mapping, $object );
49
50			$manager = \Aimeos\MShop\Factory::createManager( $context, 'stock/type' );
51			$search = $manager->createSearch()->setSlice( 0, 0x7fffffff );
52
53			foreach( $manager->searchItems( $search ) as $item ) {
54			$this->types[$item->getCode()] = $item->getCode();
55			}
56			}
57
58
59			/**
60			* Saves the product stock related data to the storage
61			*
62			* @param \Aimeos\MShop\Product\Item\Iface $product Product item with associated items
63			* @param array $data List of CSV fields with position as key and data as value
64			* @return array List of data which hasn't been imported
65			*/
66			public function process( \Aimeos\MShop\Product\Item\Iface $product, array $data )
67			{
68			$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' );
69			$manager->begin();
70
71			try
72			{
73			$map = $this->getMappedChunk( $data, $this->getMapping() );
74			$items = $this->getStockItems( $product->getCode() );
75
76			foreach( $map as $pos => $list )
77			{
78			if( !array_key_exists( 'stock.stocklevel', $list ) ) {
79			continue;
80			}
81
82			$list['stock.productcode'] = $product->getCode();
83			$list['stock.type'] = trim( isset( $list['stock.type'] ) ? $list['stock.type'] : 'default' );
84
85			if( !in_array( $list['stock.type'], $this->types ) )
86			{
87			$msg = sprintf( 'Invalid type "%1$s" (%2$s)', $list['stock.type'], 'stock' );
88			throw new \Aimeos\Controller\Common\Exception( $msg );
89			}
90
91			if( isset( $list['stock.dateback'] ) && trim( $list['stock.dateback'] ) === '' ) {
92			$list['stock.dateback'] = null;
93			}
94
95			if( trim( $list['stock.stocklevel'] ) === '' ) {
96			$list['stock.stocklevel'] = null;
97			}
98
99			if( ( $item = array_pop( $items ) ) === null ) {
100			$item = $manager->createItem();
101			}
102
103			$item->fromArray( $list );
104			$manager->saveItem( $item, false );
105			}
106
107			$manager->deleteItems( array_keys( $items ) );
108
109			$data = $this->getObject()->process( $product, $data );
110
111			$manager->commit();
112			}
113			catch( \Exception $e )
114			{
115			$manager->rollback();
116			throw $e;
117			}
118
119			return $data;
120			}
121
122
123			/**
124			* Returns the stock items for the given product code
125			*
126			* @param string $code Unique product code
127			* @return \Aimeos\MShop\Stock\Item\Iface[] Associative list of stock items
128			*/
129			protected function getStockItems( $code )
130			{
131			$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' );
132
133			$search = $manager->createSearch();
134			$search->setConditions( $search->compare( '==', 'stock.productcode', $code ) );
135
136			return $manager->searchItems( $search );
137			}
138			}
139

aimeos / ai-controller-jobs

Push — master ( 984043...a9b00f )

Standard::process() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like