Completed
Pull Request — master (#7)
by
unknown
03:21
created
controller/jobs/tests/Controller/Jobs/Product/Export/StandardTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -18,18 +18,18 @@  discard block
 block discarded – undo
18 18
 
19 19
 	protected function setUp()
20 20
 	{
21
-		\Aimeos\MShop\Factory::setCache( true );
21
+		\Aimeos\MShop\Factory::setCache(true);
22 22
 
23 23
 		$this->context = \TestHelperJobs::getContext();
24 24
 		$this->aimeos = \TestHelperJobs::getAimeos();
25 25
 
26
-		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Standard( $this->context, $this->aimeos );
26
+		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Standard($this->context, $this->aimeos);
27 27
 	}
28 28
 
29 29
 
30 30
 	protected function tearDown()
31 31
 	{
32
-		\Aimeos\MShop\Factory::setCache( false );
32
+		\Aimeos\MShop\Factory::setCache(false);
33 33
 		\Aimeos\MShop\Factory::clear();
34 34
 
35 35
 		$this->object = null;
@@ -38,31 +38,31 @@  discard block
 block discarded – undo
38 38
 
39 39
 	public function testGetName()
40 40
 	{
41
-		$this->assertEquals( 'Product export', $this->object->getName() );
41
+		$this->assertEquals('Product export', $this->object->getName());
42 42
 	}
43 43
 
44 44
 
45 45
 	public function testGetDescription()
46 46
 	{
47 47
 		$text = 'Exports all available products';
48
-		$this->assertEquals( $text, $this->object->getDescription() );
48
+		$this->assertEquals($text, $this->object->getDescription());
49 49
 	}
50 50
 
51 51
 
52 52
 	public function testRun()
53 53
 	{
54
-		$this->context->getConfig()->set( 'controller/jobs/product/export/filename', 'aimeos-products-%1$d.xml' );
54
+		$this->context->getConfig()->set('controller/jobs/product/export/filename', 'aimeos-products-%1$d.xml');
55 55
 
56 56
 		$this->object->run();
57 57
 
58 58
 		$ds = DIRECTORY_SEPARATOR;
59
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-products-1.xml' );
59
+		$this->assertFileExists('tmp' . $ds . 'aimeos-products-1.xml');
60 60
 
61
-		$file1 = file_get_contents( 'tmp' . $ds . 'aimeos-products-1.xml' );
61
+		$file1 = file_get_contents('tmp' . $ds . 'aimeos-products-1.xml');
62 62
 
63
-		unlink( 'tmp' . $ds . 'aimeos-products-1.xml' );
63
+		unlink('tmp' . $ds . 'aimeos-products-1.xml');
64 64
 
65
-		$this->assertContains( 'CNE', $file1 );
66
-		$this->assertContains( 'U:BUNDLE', $file1 );
65
+		$this->assertContains('CNE', $file1);
66
+		$this->assertContains('U:BUNDLE', $file1);
67 67
 	}
68 68
 }
69 69
\ No newline at end of file
Please login to merge, or discard this patch.
jobs/tests/Controller/Jobs/Product/Export/Sitemap/StandardTest.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -18,18 +18,18 @@  discard block
 block discarded – undo
18 18
 
19 19
 	protected function setUp()
20 20
 	{
21
-		\Aimeos\MShop\Factory::setCache( true );
21
+		\Aimeos\MShop\Factory::setCache(true);
22 22
 
23 23
 		$this->context = \TestHelperJobs::getContext();
24 24
 		$this->aimeos = \TestHelperJobs::getAimeos();
25 25
 
26
-		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Sitemap\Standard( $this->context, $this->aimeos );
26
+		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Sitemap\Standard($this->context, $this->aimeos);
27 27
 	}
28 28
 
29 29
 
30 30
 	protected function tearDown()
31 31
 	{
32
-		\Aimeos\MShop\Factory::setCache( false );
32
+		\Aimeos\MShop\Factory::setCache(false);
33 33
 		\Aimeos\MShop\Factory::clear();
34 34
 
35 35
 		$this->object = null;
@@ -38,14 +38,14 @@  discard block
 block discarded – undo
38 38
 
39 39
 	public function testGetName()
40 40
 	{
41
-		$this->assertEquals( 'Product site map', $this->object->getName() );
41
+		$this->assertEquals('Product site map', $this->object->getName());
42 42
 	}
43 43
 
44 44
 
45 45
 	public function testGetDescription()
46 46
 	{
47 47
 		$text = 'Creates a product site map for search engines';
48
-		$this->assertEquals( $text, $this->object->getDescription() );
48
+		$this->assertEquals($text, $this->object->getDescription());
49 49
 	}
50 50
 
51 51
 
@@ -54,17 +54,17 @@  discard block
 block discarded – undo
54 54
 		$this->object->run();
55 55
 
56 56
 		$ds = DIRECTORY_SEPARATOR;
57
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz' );
58
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz' );
57
+		$this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-1.xml.gz');
58
+		$this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-index.xml.gz');
59 59
 
60
-		$file1 = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz', 'rb' ), 0x1000 );
61
-		$index = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz', 'rb' ), 0x1000 );
60
+		$file1 = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-1.xml.gz', 'rb'), 0x1000);
61
+		$index = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-index.xml.gz', 'rb'), 0x1000);
62 62
 
63
-		unlink( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz' );
64
-		unlink( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz' );
63
+		unlink('tmp' . $ds . 'aimeos-sitemap-1.xml.gz');
64
+		unlink('tmp' . $ds . 'aimeos-sitemap-index.xml.gz');
65 65
 
66
-		$this->assertContains( 'Cafe_Noire_Expresso', $file1 );
66
+		$this->assertContains('Cafe_Noire_Expresso', $file1);
67 67
 
68
-		$this->assertContains( 'aimeos-sitemap-1.xml.gz', $index );
68
+		$this->assertContains('aimeos-sitemap-1.xml.gz', $index);
69 69
 	}
70 70
 }
71 71
\ No newline at end of file
Please login to merge, or discard this patch.
controller/jobs/src/Controller/Jobs/Product/Export/Standard.php 1 patch
Spacing   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 	 */
29 29
 	public function getName()
30 30
 	{
31
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Product export' );
31
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Product export');
32 32
 	}
33 33
 
34 34
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 */
40 40
 	public function getDescription()
41 41
 	{
42
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Exports all available products' );
42
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Exports all available products');
43 43
 	}
44 44
 
45 45
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	public function run()
52 52
 	{
53 53
 		$container = $this->createContainer();
54
-		$this->export( $container, false );
54
+		$this->export($container, false);
55 55
 		$container->close();
56 56
 	}
57 57
 
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	 * @param \Aimeos\MW\Container\Content\Iface $content File content object
63 63
 	 * @param \Aimeos\MShop\Product\Item\Iface[] $items List of product items
64 64
 	 */
65
-	protected function addItems( \Aimeos\MW\Container\Content\Iface $content, array $items )
65
+	protected function addItems(\Aimeos\MW\Container\Content\Iface $content, array $items)
66 66
 	{
67 67
 		/** controller/jobs/product/export/standard/template-items
68 68
 		 * Relative path to the XML items template of the product site map job controller.
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
 		$view->exportItems = $items;
96 96
 
97
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
97
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
98 98
 	}
99 99
 
100 100
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 		 * @see controller/jobs/product/export/max-items
124 124
 		 * @see controller/jobs/product/export/max-query
125 125
 		 */
126
-		$location = $config->get( 'controller/jobs/product/export/location' );
126
+		$location = $config->get('controller/jobs/product/export/location');
127 127
 
128 128
 		/** controller/jobs/product/export/standard/container/type
129 129
 		 * List of file container options for the export files
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 		 * @see controller/jobs/product/export/max-items
141 141
 		 * @see controller/jobs/product/export/max-query
142 142
 		 */
143
-		$container = $config->get( 'controller/jobs/product/export/standard/container/type', 'Directory' );
143
+		$container = $config->get('controller/jobs/product/export/standard/container/type', 'Directory');
144 144
 
145 145
 		/** controller/jobs/product/export/standard/container/content
146 146
 		 * List of file container options for the export files
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 		 * @see controller/jobs/product/export/max-items
158 158
 		 * @see controller/jobs/product/export/max-query
159 159
 		 */
160
-		$content = $config->get( 'controller/jobs/product/export/standard/container/content', 'Binary' );
160
+		$content = $config->get('controller/jobs/product/export/standard/container/content', 'Binary');
161 161
 
162 162
 		/** controller/jobs/product/export/standard/container/options
163 163
 		 * List of file container options for the export files
@@ -174,15 +174,15 @@  discard block
 block discarded – undo
174 174
 		 * @see controller/jobs/product/export/max-items
175 175
 		 * @see controller/jobs/product/export/max-query
176 176
 		 */
177
-		$options = $config->get( 'controller/jobs/product/export/standard/container/options', [] );
177
+		$options = $config->get('controller/jobs/product/export/standard/container/options', []);
178 178
 
179
-		if( $location === null )
179
+		if ($location === null)
180 180
 		{
181
-			$msg = sprintf( 'Required configuration for "%1$s" is missing', 'controller/jobs/product/export/location' );
182
-			throw new \Aimeos\Controller\Jobs\Exception( $msg );
181
+			$msg = sprintf('Required configuration for "%1$s" is missing', 'controller/jobs/product/export/location');
182
+			throw new \Aimeos\Controller\Jobs\Exception($msg);
183 183
 		}
184 184
 
185
-		return \Aimeos\MW\Container\Factory::getContainer( $location, $container, $content, $options );
185
+		return \Aimeos\MW\Container\Factory::getContainer($location, $container, $content, $options);
186 186
 	}
187 187
 
188 188
 
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 	 * @param integer $filenum New file number
194 194
 	 * @return \Aimeos\MW\Container\Content\Iface New content object
195 195
 	 */
196
-	protected function createContent( \Aimeos\MW\Container\Iface $container, $filenum )
196
+	protected function createContent(\Aimeos\MW\Container\Iface $container, $filenum)
197 197
 	{
198 198
 		/** controller/jobs/product/export/standard/template-header
199 199
 		 * Relative path to the XML site map header template of the product site map job controller.
@@ -223,9 +223,9 @@  discard block
 block discarded – undo
223 223
 		$context = $this->getContext();
224 224
 		$view = $context->getView();
225 225
 
226
-		$content = $container->create( $this->getFilename( $filenum ) );
227
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
228
-		$container->add( $content );
226
+		$content = $container->create($this->getFilename($filenum));
227
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
228
+		$container->add($content);
229 229
 
230 230
 		return $content;
231 231
 	}
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 	 *
237 237
 	 * @param \Aimeos\MW\Container\Content\Iface $content
238 238
 	 */
239
-	protected function closeContent( \Aimeos\MW\Container\Content\Iface $content )
239
+	protected function closeContent(\Aimeos\MW\Container\Content\Iface $content)
240 240
 	{
241 241
 		/** controller/jobs/product/export/standard/template-footer
242 242
 		 * Relative path to the XML site map footer template of the product site map job controller.
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 		$context = $this->getContext();
267 267
 		$view = $context->getView();
268 268
 
269
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
269
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
270 270
 	}
271 271
 
272 272
 
@@ -277,50 +277,50 @@  discard block
 block discarded – undo
277 277
 	 * @param boolean $default True to filter exported products by default criteria
278 278
 	 * @return array List of content (file) names
279 279
 	 */
280
-	protected function export( \Aimeos\MW\Container\Iface $container, $default = true )
280
+	protected function export(\Aimeos\MW\Container\Iface $container, $default = true)
281 281
 	{
282
-		$domains = array( 'attribute', 'media', 'price', 'product', 'text' );
282
+		$domains = array('attribute', 'media', 'price', 'product', 'text');
283 283
 
284
-		$domains = $this->getConfig( 'domains', $domains );
285
-		$maxItems = $this->getConfig( 'max-items', 10000 );
286
-		$maxQuery = $this->getConfig( 'max-query', 1000 );
284
+		$domains = $this->getConfig('domains', $domains);
285
+		$maxItems = $this->getConfig('max-items', 10000);
286
+		$maxQuery = $this->getConfig('max-query', 1000);
287 287
 
288 288
 		$start = 0; $filenum = 1;
289 289
 		$names = [];
290 290
 
291
-		$indexManager = \Aimeos\MShop\Index\Manager\Factory::createManager( $this->getContext() );
291
+		$indexManager = \Aimeos\MShop\Index\Manager\Factory::createManager($this->getContext());
292 292
 
293
-		$search = $indexManager->createSearch( $default );
294
-		$search->setSlice( 0, $maxQuery );
293
+		$search = $indexManager->createSearch($default);
294
+		$search->setSlice(0, $maxQuery);
295 295
 		$search->setConditions(
296
-			$search->compare( '!=', 'index.catalog.id', null )
296
+			$search->compare('!=', 'index.catalog.id', null)
297 297
 		);
298 298
 		$search->setSortations(
299
-			[ $search->sort('+', 'product.id') ]
299
+			[$search->sort('+', 'product.id')]
300 300
 		);
301 301
 
302 302
 		$content = $this->createContent($container, $filenum);
303
-		$names[] = basename( $content->getResource() );
303
+		$names[] = basename($content->getResource());
304 304
 
305 305
 		do
306 306
 		{
307 307
 			$items = $indexManager->searchItems($search, $domains);
308 308
 			$this->addItems($content, $items);
309 309
 
310
-			$count = count( $items );
310
+			$count = count($items);
311 311
 			$start += $count;
312
-			$search->setSlice( $start, $maxQuery );
312
+			$search->setSlice($start, $maxQuery);
313 313
 
314
-			if( $start + $maxQuery > $maxItems * $filenum )
314
+			if ($start + $maxQuery > $maxItems * $filenum)
315 315
 			{
316
-				$this->closeContent( $content );
317
-				$content = $this->createContent( $container, ++$filenum );
316
+				$this->closeContent($content);
317
+				$content = $this->createContent($container, ++$filenum);
318 318
 				$names[] = basename($content->getResource());
319 319
 			}
320 320
 		}
321
-		while( $count >= $search->getSliceSize() );
321
+		while ($count >= $search->getSliceSize());
322 322
 
323
-		$this->closeContent( $content );
323
+		$this->closeContent($content);
324 324
 
325 325
 		return $names;
326 326
 	}
@@ -333,11 +333,11 @@  discard block
 block discarded – undo
333 333
 	 * @param mixed $default Default value if name is unknown
334 334
 	 * @return mixed Configuration value
335 335
 	 */
336
-	protected function getConfig( $name, $default = null )
336
+	protected function getConfig($name, $default = null)
337 337
 	{
338 338
 		$config = $this->getContext()->getConfig();
339 339
 
340
-		switch( $name )
340
+		switch ($name)
341 341
 		{
342 342
 			case 'domain':
343 343
 				/** controller/jobs/product/export/domains
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
 				 * @see controller/jobs/product/export/max-items
361 361
 				 * @see controller/jobs/product/export/max-query
362 362
 				 */
363
-				return $config->get( 'controller/jobs/product/export/domains', $default );
363
+				return $config->get('controller/jobs/product/export/domains', $default);
364 364
 
365 365
 			case 'max-items':
366 366
 				/** controller/jobs/product/export/max-items
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
 				 * @see controller/jobs/product/export/max-query
384 384
 				 * @see controller/jobs/product/export/domains
385 385
 				 */
386
-				return $config->get( 'controller/jobs/product/export/max-items', $default );
386
+				return $config->get('controller/jobs/product/export/max-items', $default);
387 387
 
388 388
 			case 'max-query':
389 389
 				/** controller/jobs/product/export/max-query
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 				 * @see controller/jobs/product/export/max-items
407 407
 				 * @see controller/jobs/product/export/domains
408 408
 				 */
409
-				return $config->get( 'controller/jobs/product/export/max-query', $default );
409
+				return $config->get('controller/jobs/product/export/max-query', $default);
410 410
 
411 411
 			case 'filename':
412 412
 				/** controller/jobs/product/export/filename
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 				 * @see controller/jobs/product/export/max-query
428 428
 				 * @see controller/jobs/product/export/domains
429 429
 				 */
430
-				return $config->get( 'controller/jobs/product/export/filename', $default );
430
+				return $config->get('controller/jobs/product/export/filename', $default);
431 431
 		}
432 432
 
433 433
 		return $default;
@@ -440,8 +440,8 @@  discard block
 block discarded – undo
440 440
 	 * @param integer $number Current file number
441 441
 	 * @return string New file name
442 442
 	 */
443
-	protected function getFilename( $number )
443
+	protected function getFilename($number)
444 444
 	{
445
-		return sprintf( $this->getConfig( 'filename', 'aimeos-products-%1$d_%2$s.xml' ), $number, date( 'Y-m-d_H:i:s' ) );
445
+		return sprintf($this->getConfig('filename', 'aimeos-products-%1$d_%2$s.xml'), $number, date('Y-m-d_H:i:s'));
446 446
 	}
447 447
 }
Please login to merge, or discard this patch.