Inspection of "Adapt to new create() factory method" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cbc921...0b1729 )

by Aimeos

created 2018-12-28 12:08 UTC

Status

Spacing +54 added lines, -54 removed lines patch added patch discarded remove patch

@@ -20,109 +20,109 @@
 block discarded – undo
 		$this->context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Export\Csv\Standard( $this->context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Export\Csv\Standard($this->context, $aimeos);
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->object, $this->context );
+		unset($this->object, $this->context);
 	}
 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Order export CSV', $this->object->getName() );
+		$this->assertEquals('Order export CSV', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
-		$this->assertEquals( 'Exports orders to CSV file', $this->object->getDescription() );
+		$this->assertEquals('Exports orders to CSV file', $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$mqmStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Manager\\Standard' )
-			->setConstructorArgs( [$this->context->getConfig()] )
-			->setMethods( ['get'] )
+		$mqmStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Manager\\Standard')
+			->setConstructorArgs([$this->context->getConfig()])
+			->setMethods(['get'])
 			->getMock();
 
-		$mqStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Standard' )
+		$mqStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['getQueue'] )
+			->setMethods(['getQueue'])
 			->getMock();
 
-		$queueStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Queue\\Standard' )
+		$queueStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Queue\\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['del', 'get'] )
+			->setMethods(['del', 'get'])
 			->getMock();
 
-		$msgStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Message\\Standard' )
+		$msgStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Message\\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['getBody'] )
+			->setMethods(['getBody'])
 			->getMock();
 
 
-		$this->context->setMessageQueueManager( $mqmStub );
+		$this->context->setMessageQueueManager($mqmStub);
 
 
-		$mqmStub->expects( $this->once() )->method( 'get' )
-			->will( $this->returnValue( $mqStub ) );
+		$mqmStub->expects($this->once())->method('get')
+			->will($this->returnValue($mqStub));
 
-		$mqStub->expects( $this->once() )->method( 'getQueue' )
-			->will( $this->returnValue( $queueStub ) );
+		$mqStub->expects($this->once())->method('getQueue')
+			->will($this->returnValue($queueStub));
 
-		$queueStub->expects( $this->exactly( 2 ) )->method( 'get' )
-			->will( $this->onConsecutiveCalls( $msgStub, null ) );
+		$queueStub->expects($this->exactly(2))->method('get')
+			->will($this->onConsecutiveCalls($msgStub, null));
 
-		$queueStub->expects( $this->once() )->method( 'del' );
+		$queueStub->expects($this->once())->method('del');
 
-		$msgStub->expects( $this->once() )->method( 'getBody' )
-			->will( $this->returnValue( '{"sitecode":"unittest"}' ) );
+		$msgStub->expects($this->once())->method('getBody')
+			->will($this->returnValue('{"sitecode":"unittest"}'));
 
 
 		$this->object->run();
 
 
-		$jobManager = \Aimeos\MAdmin::create( $this->context, 'job' );
+		$jobManager = \Aimeos\MAdmin::create($this->context, 'job');
 		$jobSearch = $jobManager->createSearch();
-		$jobSearch->setConditions( $jobSearch->compare( '=~', 'job.label', 'order-export_' ) );
-		$jobItems = $jobManager->searchItems( $jobSearch );
-		$jobManager->deleteItems( array_keys( $jobItems ) );
+		$jobSearch->setConditions($jobSearch->compare('=~', 'job.label', 'order-export_'));
+		$jobItems = $jobManager->searchItems($jobSearch);
+		$jobManager->deleteItems(array_keys($jobItems));
 
-		$this->assertEquals( 1, count( $jobItems ) );
+		$this->assertEquals(1, count($jobItems));
 
 
-		$filename = dirname( dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) ) . '/tmp/' . reset( $jobItems )->getLabel();
-		$fp = fopen( $filename, 'r' );
+		$filename = dirname(dirname(dirname(dirname(dirname(__DIR__))))) . '/tmp/' . reset($jobItems)->getLabel();
+		$fp = fopen($filename, 'r');
 
-		$invoice = fgetcsv( $fp );
-		$address1 = fgetcsv( $fp );
-		$address2 = fgetcsv( $fp );
-		$service1 = fgetcsv( $fp );
-		$service2 = fgetcsv( $fp );
+		$invoice = fgetcsv($fp);
+		$address1 = fgetcsv($fp);
+		$address2 = fgetcsv($fp);
+		$service1 = fgetcsv($fp);
+		$service2 = fgetcsv($fp);
 		$coupon1 = fgetcsv($fp);
 		$coupon2 = fgetcsv($fp);
-		$product1 = fgetcsv( $fp );
-		$product2 = fgetcsv( $fp );
-		$product3 = fgetcsv( $fp );
-		$product4 = fgetcsv( $fp );
-
-		fclose( $fp );
-		unlink( $filename );
-
-		$this->assertEquals( 'invoice', $invoice[0] );
-		$this->assertEquals( 'address', $address1[0] );
-		$this->assertEquals( 'address', $address2[0] );
-		$this->assertEquals( 'service', $service1[0] );
-		$this->assertEquals( 'service', $service2[0] );
-		$this->assertEquals( 'coupon', $coupon1[0]);
-		$this->assertEquals( 'coupon', $coupon2[0]);
-		$this->assertEquals( 'product', $product1[0] );
-		$this->assertEquals( 'product', $product2[0] );
-		$this->assertEquals( 'product', $product3[0] );
-		$this->assertEquals( 'product', $product4[0] );
+		$product1 = fgetcsv($fp);
+		$product2 = fgetcsv($fp);
+		$product3 = fgetcsv($fp);
+		$product4 = fgetcsv($fp);
+
+		fclose($fp);
+		unlink($filename);
+
+		$this->assertEquals('invoice', $invoice[0]);
+		$this->assertEquals('address', $address1[0]);
+		$this->assertEquals('address', $address2[0]);
+		$this->assertEquals('service', $service1[0]);
+		$this->assertEquals('service', $service2[0]);
+		$this->assertEquals('coupon', $coupon1[0]);
+		$this->assertEquals('coupon', $coupon2[0]);
+		$this->assertEquals('product', $product1[0]);
+		$this->assertEquals('product', $product2[0]);
+		$this->assertEquals('product', $product3[0]);
+		$this->assertEquals('product', $product4[0]);
 	}
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Coupon/Import/Csv/Code/StandardTest.php 1 patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -18,95 +18,95 @@
 block discarded – undo
 
 	protected function setUp()
 	{
-		\Aimeos\MShop::cache( true );
+		\Aimeos\MShop::cache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 		$config = $this->context->getConfig();
 
-		$config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );
+		$config->set('controller/jobs/product/import/csv/skip-lines', 1);
 
-		$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard($this->context, $this->aimeos);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop::cache( false );
+		\Aimeos\MShop::cache(false);
 		\Aimeos\MShop::clear();
 
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
+		$this->assertEquals('Coupon code import CSV', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Imports new and updates existing coupon code from CSV files';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$manager = \Aimeos\MShop::create( $this->context, 'coupon' );
-		$coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
+		$manager = \Aimeos\MShop::create($this->context, 'coupon');
+		$coupon = $manager->saveItem($manager->createItem()->setProvider('Example'));
 
 		$dir = 'tmp/import/couponcode/unittest';
 		$filepath = $dir . '/' . $coupon->getId() . '.csv';
 
-		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
+		if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
+			throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
 		}
 
 		$content = 'code,count,start,end
 jobccimport1,3,2000-01-01 00:00:00,
 jobccimport2,5,,';
 
-		if( file_put_contents( $filepath, $content ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
+		if (file_put_contents($filepath, $content) === false) {
+			throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
 		}
 
 		$this->object->run();
 
 
-		$codeManager = \Aimeos\MShop::create( $this->context, 'coupon/code' );
-		$code1 = $codeManager->findItem( 'jobccimport1' );
-		$code2 = $codeManager->findItem( 'jobccimport2' );
+		$codeManager = \Aimeos\MShop::create($this->context, 'coupon/code');
+		$code1 = $codeManager->findItem('jobccimport1');
+		$code2 = $codeManager->findItem('jobccimport2');
 
-		$manager->deleteItem( $coupon->getId() );
+		$manager->deleteItem($coupon->getId());
 
-		$this->assertEquals( 3, $code1->getCount() );
-		$this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
-		$this->assertEquals( null, $code1->getDateEnd() );
+		$this->assertEquals(3, $code1->getCount());
+		$this->assertEquals('2000-01-01 00:00:00', $code1->getDateStart());
+		$this->assertEquals(null, $code1->getDateEnd());
 
-		$this->assertEquals( 5, $code2->getCount() );
-		$this->assertEquals( null, $code2->getDateStart() );
-		$this->assertEquals( null, $code2->getDateEnd() );
+		$this->assertEquals(5, $code2->getCount());
+		$this->assertEquals(null, $code2->getDateStart());
+		$this->assertEquals(null, $code2->getDateEnd());
 	}
 
 
 	public function testRunException()
 	{
-		$manager = \Aimeos\MShop::create( $this->context, 'coupon' );
+		$manager = \Aimeos\MShop::create($this->context, 'coupon');
 
 		$dir = 'tmp/import/couponcode/unittest';
 		$filepath = $dir . '/0.csv';
 
-		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
+		if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
+			throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
 		}
 
 		$content = 'code,count,start,end
 jobccimport1,,,';
 
-		if( file_put_contents( $filepath, $content ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
+		if (file_put_contents($filepath, $content) === false) {
+			throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
 		}
 
 		$this->object->run();

Please login to merge, or discard this patch.

		@@ -20,109 +20,109 @@
		block discarded – undo
20	20	$this->context = \TestHelperJobs::getContext();
21	21	$aimeos = \TestHelperJobs::getAimeos();
22	22
23		- $this->object = new \Aimeos\Controller\Jobs\Order\Export\Csv\Standard( $this->context, $aimeos );
	23	+ $this->object = new \Aimeos\Controller\Jobs\Order\Export\Csv\Standard($this->context, $aimeos);
24	24	}
25	25
26	26
27	27	protected function tearDown()
28	28	{
29		- unset( $this->object, $this->context );
	29	+ unset($this->object, $this->context);
30	30	}
31	31
32	32
33	33	public function testGetName()
34	34	{
35		- $this->assertEquals( 'Order export CSV', $this->object->getName() );
	35	+ $this->assertEquals('Order export CSV', $this->object->getName());
36	36	}
37	37
38	38
39	39	public function testGetDescription()
40	40	{
41		- $this->assertEquals( 'Exports orders to CSV file', $this->object->getDescription() );
	41	+ $this->assertEquals('Exports orders to CSV file', $this->object->getDescription());
42	42	}
43	43
44	44
45	45	public function testRun()
46	46	{
47		- $mqmStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Manager\\Standard' )
48		- ->setConstructorArgs( [$this->context->getConfig()] )
49		- ->setMethods( ['get'] )
	47	+ $mqmStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Manager\\Standard')
	48	+ ->setConstructorArgs([$this->context->getConfig()])
	49	+ ->setMethods(['get'])
50	50	->getMock();
51	51
52		- $mqStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Standard' )
	52	+ $mqStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Standard')
53	53	->disableOriginalConstructor()
54		- ->setMethods( ['getQueue'] )
	54	+ ->setMethods(['getQueue'])
55	55	->getMock();
56	56
57		- $queueStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Queue\\Standard' )
	57	+ $queueStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Queue\\Standard')
58	58	->disableOriginalConstructor()
59		- ->setMethods( ['del', 'get'] )
	59	+ ->setMethods(['del', 'get'])
60	60	->getMock();
61	61
62		- $msgStub = $this->getMockBuilder( '\\Aimeos\\MW\\MQueue\\Message\\Standard' )
	62	+ $msgStub = $this->getMockBuilder('\\Aimeos\\MW\\MQueue\\Message\\Standard')
63	63	->disableOriginalConstructor()
64		- ->setMethods( ['getBody'] )
	64	+ ->setMethods(['getBody'])
65	65	->getMock();
66	66
67	67
68		- $this->context->setMessageQueueManager( $mqmStub );
	68	+ $this->context->setMessageQueueManager($mqmStub);
69	69
70	70
71		- $mqmStub->expects( $this->once() )->method( 'get' )
72		- ->will( $this->returnValue( $mqStub ) );
	71	+ $mqmStub->expects($this->once())->method('get')
	72	+ ->will($this->returnValue($mqStub));
73	73
74		- $mqStub->expects( $this->once() )->method( 'getQueue' )
75		- ->will( $this->returnValue( $queueStub ) );
	74	+ $mqStub->expects($this->once())->method('getQueue')
	75	+ ->will($this->returnValue($queueStub));
76	76
77		- $queueStub->expects( $this->exactly( 2 ) )->method( 'get' )
78		- ->will( $this->onConsecutiveCalls( $msgStub, null ) );
	77	+ $queueStub->expects($this->exactly(2))->method('get')
	78	+ ->will($this->onConsecutiveCalls($msgStub, null));
79	79
80		- $queueStub->expects( $this->once() )->method( 'del' );
	80	+ $queueStub->expects($this->once())->method('del');
81	81
82		- $msgStub->expects( $this->once() )->method( 'getBody' )
83		- ->will( $this->returnValue( '{"sitecode":"unittest"}' ) );
	82	+ $msgStub->expects($this->once())->method('getBody')
	83	+ ->will($this->returnValue('{"sitecode":"unittest"}'));
84	84
85	85
86	86	$this->object->run();
87	87
88	88
89		- $jobManager = \Aimeos\MAdmin::create( $this->context, 'job' );
	89	+ $jobManager = \Aimeos\MAdmin::create($this->context, 'job');
90	90	$jobSearch = $jobManager->createSearch();
91		- $jobSearch->setConditions( $jobSearch->compare( '=~', 'job.label', 'order-export_' ) );
92		- $jobItems = $jobManager->searchItems( $jobSearch );
93		- $jobManager->deleteItems( array_keys( $jobItems ) );
	91	+ $jobSearch->setConditions($jobSearch->compare('=~', 'job.label', 'order-export_'));
	92	+ $jobItems = $jobManager->searchItems($jobSearch);
	93	+ $jobManager->deleteItems(array_keys($jobItems));
94	94
95		- $this->assertEquals( 1, count( $jobItems ) );
	95	+ $this->assertEquals(1, count($jobItems));
96	96
97	97
98		- $filename = dirname( dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) ) . '/tmp/' . reset( $jobItems )->getLabel();
99		- $fp = fopen( $filename, 'r' );
	98	+ $filename = dirname(dirname(dirname(dirname(dirname(__DIR__))))) . '/tmp/' . reset($jobItems)->getLabel();
	99	+ $fp = fopen($filename, 'r');
100	100
101		- $invoice = fgetcsv( $fp );
102		- $address1 = fgetcsv( $fp );
103		- $address2 = fgetcsv( $fp );
104		- $service1 = fgetcsv( $fp );
105		- $service2 = fgetcsv( $fp );
	101	+ $invoice = fgetcsv($fp);
	102	+ $address1 = fgetcsv($fp);
	103	+ $address2 = fgetcsv($fp);
	104	+ $service1 = fgetcsv($fp);
	105	+ $service2 = fgetcsv($fp);
106	106	$coupon1 = fgetcsv($fp);
107	107	$coupon2 = fgetcsv($fp);
108		- $product1 = fgetcsv( $fp );
109		- $product2 = fgetcsv( $fp );
110		- $product3 = fgetcsv( $fp );
111		- $product4 = fgetcsv( $fp );
112		-
113		- fclose( $fp );
114		- unlink( $filename );
115		-
116		- $this->assertEquals( 'invoice', $invoice[0] );
117		- $this->assertEquals( 'address', $address1[0] );
118		- $this->assertEquals( 'address', $address2[0] );
119		- $this->assertEquals( 'service', $service1[0] );
120		- $this->assertEquals( 'service', $service2[0] );
121		- $this->assertEquals( 'coupon', $coupon1[0]);
122		- $this->assertEquals( 'coupon', $coupon2[0]);
123		- $this->assertEquals( 'product', $product1[0] );
124		- $this->assertEquals( 'product', $product2[0] );
125		- $this->assertEquals( 'product', $product3[0] );
126		- $this->assertEquals( 'product', $product4[0] );
	108	+ $product1 = fgetcsv($fp);
	109	+ $product2 = fgetcsv($fp);
	110	+ $product3 = fgetcsv($fp);
	111	+ $product4 = fgetcsv($fp);
	112	+
	113	+ fclose($fp);
	114	+ unlink($filename);
	115	+
	116	+ $this->assertEquals('invoice', $invoice[0]);
	117	+ $this->assertEquals('address', $address1[0]);
	118	+ $this->assertEquals('address', $address2[0]);
	119	+ $this->assertEquals('service', $service1[0]);
	120	+ $this->assertEquals('service', $service2[0]);
	121	+ $this->assertEquals('coupon', $coupon1[0]);
	122	+ $this->assertEquals('coupon', $coupon2[0]);
	123	+ $this->assertEquals('product', $product1[0]);
	124	+ $this->assertEquals('product', $product2[0]);
	125	+ $this->assertEquals('product', $product3[0]);
	126	+ $this->assertEquals('product', $product4[0]);
127	127	}
128	128	}

		@@ -18,95 +18,95 @@
		block discarded – undo
18	18
19	19	protected function setUp()
20	20	{
21		- \Aimeos\MShop::cache( true );
	21	+ \Aimeos\MShop::cache(true);
22	22
23	23	$this->context = \TestHelperJobs::getContext();
24	24	$this->aimeos = \TestHelperJobs::getAimeos();
25	25	$config = $this->context->getConfig();
26	26
27		- $config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );
	27	+ $config->set('controller/jobs/product/import/csv/skip-lines', 1);
28	28
29		- $this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
	29	+ $this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard($this->context, $this->aimeos);
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- \Aimeos\MShop::cache( false );
	35	+ \Aimeos\MShop::cache(false);
36	36	\Aimeos\MShop::clear();
37	37
38		- unset( $this->object );
	38	+ unset($this->object);
39	39	}
40	40
41	41
42	42	public function testGetName()
43	43	{
44		- $this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
	44	+ $this->assertEquals('Coupon code import CSV', $this->object->getName());
45	45	}
46	46
47	47
48	48	public function testGetDescription()
49	49	{
50	50	$text = 'Imports new and updates existing coupon code from CSV files';
51		- $this->assertEquals( $text, $this->object->getDescription() );
	51	+ $this->assertEquals($text, $this->object->getDescription());
52	52	}
53	53
54	54
55	55	public function testRun()
56	56	{
57		- $manager = \Aimeos\MShop::create( $this->context, 'coupon' );
58		- $coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
	57	+ $manager = \Aimeos\MShop::create($this->context, 'coupon');
	58	+ $coupon = $manager->saveItem($manager->createItem()->setProvider('Example'));
59	59
60	60	$dir = 'tmp/import/couponcode/unittest';
61	61	$filepath = $dir . '/' . $coupon->getId() . '.csv';
62	62
63		- if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
64		- throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
	63	+ if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
	64	+ throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
65	65	}
66	66
67	67	$content = 'code,count,start,end
68	68	jobccimport1,3,2000-01-01 00:00:00,
69	69	jobccimport2,5,,';
70	70
71		- if( file_put_contents( $filepath, $content ) === false ) {
72		- throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
	71	+ if (file_put_contents($filepath, $content) === false) {
	72	+ throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
73	73	}
74	74
75	75	$this->object->run();
76	76
77	77
78		- $codeManager = \Aimeos\MShop::create( $this->context, 'coupon/code' );
79		- $code1 = $codeManager->findItem( 'jobccimport1' );
80		- $code2 = $codeManager->findItem( 'jobccimport2' );
	78	+ $codeManager = \Aimeos\MShop::create($this->context, 'coupon/code');
	79	+ $code1 = $codeManager->findItem('jobccimport1');
	80	+ $code2 = $codeManager->findItem('jobccimport2');
81	81
82		- $manager->deleteItem( $coupon->getId() );
	82	+ $manager->deleteItem($coupon->getId());
83	83
84		- $this->assertEquals( 3, $code1->getCount() );
85		- $this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
86		- $this->assertEquals( null, $code1->getDateEnd() );
	84	+ $this->assertEquals(3, $code1->getCount());
	85	+ $this->assertEquals('2000-01-01 00:00:00', $code1->getDateStart());
	86	+ $this->assertEquals(null, $code1->getDateEnd());
87	87
88		- $this->assertEquals( 5, $code2->getCount() );
89		- $this->assertEquals( null, $code2->getDateStart() );
90		- $this->assertEquals( null, $code2->getDateEnd() );
	88	+ $this->assertEquals(5, $code2->getCount());
	89	+ $this->assertEquals(null, $code2->getDateStart());
	90	+ $this->assertEquals(null, $code2->getDateEnd());
91	91	}
92	92
93	93
94	94	public function testRunException()
95	95	{
96		- $manager = \Aimeos\MShop::create( $this->context, 'coupon' );
	96	+ $manager = \Aimeos\MShop::create($this->context, 'coupon');
97	97
98	98	$dir = 'tmp/import/couponcode/unittest';
99	99	$filepath = $dir . '/0.csv';
100	100
101		- if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
102		- throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
	101	+ if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
	102	+ throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
103	103	}
104	104
105	105	$content = 'code,count,start,end
106	106	jobccimport1,,,';
107	107
108		- if( file_put_contents( $filepath, $content ) === false ) {
109		- throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
	108	+ if (file_put_contents($filepath, $content) === false) {
	109	+ throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
110	110	}
111	111
112	112	$this->object->run();

aimeos / ai-controller-jobs

Push — master ( cbc921...0b1729 )

Status

Category

Spacing +54 added lines, -54 removed lines patch added patch discarded remove patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch