Inspection of "Adapt to new create() factory method" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cbc921...0b1729 )

by Aimeos

created 2018-12-28 12:08 UTC

Status

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -18,95 +18,95 @@
 block discarded – undo
 
 	protected function setUp()
 	{
-		\Aimeos\MShop::cache( true );
+		\Aimeos\MShop::cache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 		$config = $this->context->getConfig();
 
-		$config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );
+		$config->set('controller/jobs/product/import/csv/skip-lines', 1);
 
-		$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard($this->context, $this->aimeos);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop::cache( false );
+		\Aimeos\MShop::cache(false);
 		\Aimeos\MShop::clear();
 
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
+		$this->assertEquals('Coupon code import CSV', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Imports new and updates existing coupon code from CSV files';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$manager = \Aimeos\MShop::create( $this->context, 'coupon' );
-		$coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
+		$manager = \Aimeos\MShop::create($this->context, 'coupon');
+		$coupon = $manager->saveItem($manager->createItem()->setProvider('Example'));
 
 		$dir = 'tmp/import/couponcode/unittest';
 		$filepath = $dir . '/' . $coupon->getId() . '.csv';
 
-		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
+		if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
+			throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
 		}
 
 		$content = 'code,count,start,end
 jobccimport1,3,2000-01-01 00:00:00,
 jobccimport2,5,,';
 
-		if( file_put_contents( $filepath, $content ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
+		if (file_put_contents($filepath, $content) === false) {
+			throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
 		}
 
 		$this->object->run();
 
 
-		$codeManager = \Aimeos\MShop::create( $this->context, 'coupon/code' );
-		$code1 = $codeManager->findItem( 'jobccimport1' );
-		$code2 = $codeManager->findItem( 'jobccimport2' );
+		$codeManager = \Aimeos\MShop::create($this->context, 'coupon/code');
+		$code1 = $codeManager->findItem('jobccimport1');
+		$code2 = $codeManager->findItem('jobccimport2');
 
-		$manager->deleteItem( $coupon->getId() );
+		$manager->deleteItem($coupon->getId());
 
-		$this->assertEquals( 3, $code1->getCount() );
-		$this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
-		$this->assertEquals( null, $code1->getDateEnd() );
+		$this->assertEquals(3, $code1->getCount());
+		$this->assertEquals('2000-01-01 00:00:00', $code1->getDateStart());
+		$this->assertEquals(null, $code1->getDateEnd());
 
-		$this->assertEquals( 5, $code2->getCount() );
-		$this->assertEquals( null, $code2->getDateStart() );
-		$this->assertEquals( null, $code2->getDateEnd() );
+		$this->assertEquals(5, $code2->getCount());
+		$this->assertEquals(null, $code2->getDateStart());
+		$this->assertEquals(null, $code2->getDateEnd());
 	}
 
 
 	public function testRunException()
 	{
-		$manager = \Aimeos\MShop::create( $this->context, 'coupon' );
+		$manager = \Aimeos\MShop::create($this->context, 'coupon');
 
 		$dir = 'tmp/import/couponcode/unittest';
 		$filepath = $dir . '/0.csv';
 
-		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
+		if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
+			throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
 		}
 
 		$content = 'code,count,start,end
 jobccimport1,,,';
 
-		if( file_put_contents( $filepath, $content ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
+		if (file_put_contents($filepath, $content) === false) {
+			throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
 		}
 
 		$this->object->run();

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Catalog/Import/Csv/StandardTest.php 1 patch

Spacing +66 added lines, -66 removed lines patch added patch discarded remove patch

@@ -18,65 +18,65 @@  discard block
 block discarded – undo
 
 	protected function setUp()
 	{
-		\Aimeos\MShop::cache( true );
+		\Aimeos\MShop::cache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 		$config = $this->context->getConfig();
 
-		$config->set( 'controller/jobs/catalog/import/csv/skip-lines', 1 );
-		$config->set( 'controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/valid' );
+		$config->set('controller/jobs/catalog/import/csv/skip-lines', 1);
+		$config->set('controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/valid');
 
-		$this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard($this->context, $this->aimeos);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop::cache( false );
+		\Aimeos\MShop::cache(false);
 		\Aimeos\MShop::clear();
 
 		$this->object = null;
 
-		if( file_exists( 'tmp/import.zip' ) ) {
-			unlink( 'tmp/import.zip' );
+		if (file_exists('tmp/import.zip')) {
+			unlink('tmp/import.zip');
 		}
 	}
 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Catalog import CSV', $this->object->getName() );
+		$this->assertEquals('Catalog import CSV', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Imports new and updates existing categories from CSV files';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$catcodes = array( 'job_csv_test', 'job_csv_test2', 'job_csv_test3', 'job_csv_test4' );
-		$domains = array( 'media', 'text' );
+		$catcodes = array('job_csv_test', 'job_csv_test2', 'job_csv_test3', 'job_csv_test4');
+		$domains = array('media', 'text');
 
 		$convert = array(
 			1 => 'Text/LatinUTF8',
 		);
 
-		$this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/converter', $convert );
+		$this->context->getConfig()->set('controller/jobs/catalog/import/csv/converter', $convert);
 
 		$this->object->run();
 
-		$tree = $this->get( 'job_csv_test', $domains );
-		$this->delete( $tree, $domains );
+		$tree = $this->get('job_csv_test', $domains);
+		$this->delete($tree, $domains);
 
-		$this->assertEquals( 2, count( $tree->getListItems() ) );
+		$this->assertEquals(2, count($tree->getListItems()));
 
-		foreach( $tree->getChildren() as $node ) {
-			$this->assertEquals( 2, count( $node->getListItems() ) );
+		foreach ($tree->getChildren() as $node) {
+			$this->assertEquals(2, count($node->getListItems()));
 		}
 	}
 
@@ -86,13 +86,13 @@  discard block
 block discarded – undo
 		$this->object->run();
 		$this->object->run();
 
-		$tree = $this->get( 'job_csv_test', ['media', 'text'] );
-		$this->delete( $tree, ['media', 'text'] );
+		$tree = $this->get('job_csv_test', ['media', 'text']);
+		$this->delete($tree, ['media', 'text']);
 
-		$this->assertEquals( 2, count( $tree->getListItems() ) );
+		$this->assertEquals(2, count($tree->getListItems()));
 
-		foreach( $tree->getChildren() as $node ) {
-			$this->assertEquals( 2, count( $node->getListItems() ) );
+		foreach ($tree->getChildren() as $node) {
+			$this->assertEquals(2, count($node->getListItems()));
 		}
 	}
 
@@ -100,18 +100,18 @@  discard block
 block discarded – undo
 	public function testRunPosition()
 	{
 		$config = $this->context->getConfig();
-		$mapping = $config->set( 'controller/jobs/catalog/import/csv/mapping', [] );
-		$mapping['item'] = array( 0 => 'catalog.label', 1 => 'catalog.code', 2 => 'catalog.parent' );
+		$mapping = $config->set('controller/jobs/catalog/import/csv/mapping', []);
+		$mapping['item'] = array(0 => 'catalog.label', 1 => 'catalog.code', 2 => 'catalog.parent');
 
-		$config->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
-		$config->set( 'controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/position' );
+		$config->set('controller/jobs/catalog/import/csv/mapping', $mapping);
+		$config->set('controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/position');
 
 		$this->object->run();
 
-		$tree = $this->get( 'job_csv_test' );
-		$this->delete( $tree );
+		$tree = $this->get('job_csv_test');
+		$this->delete($tree);
 
-		$this->assertEquals( 1, count( $tree->getChildren() ) );
+		$this->assertEquals(1, count($tree->getChildren()));
 	}
 
 
@@ -135,12 +135,12 @@  discard block
 block discarded – undo
 			),
 		);
 
-		$this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
+		$this->context->getConfig()->set('controller/jobs/catalog/import/csv/mapping', $mapping);
 
 		$this->object->run();
 
-		$tree = $this->get( 'job_csv_test' );
-		$this->delete( $tree );
+		$tree = $this->get('job_csv_test');
+		$this->delete($tree);
 	}
 
 
@@ -152,9 +152,9 @@  discard block
 block discarded – undo
 			),
 		);
 
-		$this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
+		$this->context->getConfig()->set('controller/jobs/catalog/import/csv/mapping', $mapping);
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
 		$this->object->run();
 	}
 
@@ -178,15 +178,15 @@  discard block
 block discarded – undo
 			),
 		);
 
-		$this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
+		$this->context->getConfig()->set('controller/jobs/catalog/import/csv/mapping', $mapping);
 
 		$config = $this->context->getConfig();
-		$config->set( 'controller/jobs/catalog/import/csv/skip-lines', 0 );
-		$config->set( 'controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/invalid' );
+		$config->set('controller/jobs/catalog/import/csv/skip-lines', 0);
+		$config->set('controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/invalid');
 
-		$this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard($this->context, $this->aimeos);
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
 		$this->object->run();
 	}
 
@@ -194,65 +194,65 @@  discard block
 block discarded – undo
 	public function testRunBackup()
 	{
 		$config = $this->context->getConfig();
-		$config->set( 'controller/jobs/catalog/import/csv/container/type', 'Zip' );
-		$config->set( 'controller/jobs/catalog/import/csv/location', 'tmp/import.zip' );
-		$config->set( 'controller/jobs/catalog/import/csv/backup', 'tmp/test-%Y-%m-%d.zip' );
+		$config->set('controller/jobs/catalog/import/csv/container/type', 'Zip');
+		$config->set('controller/jobs/catalog/import/csv/location', 'tmp/import.zip');
+		$config->set('controller/jobs/catalog/import/csv/backup', 'tmp/test-%Y-%m-%d.zip');
 
-		if( copy( __DIR__ . '/_testfiles/import.zip', 'tmp/import.zip' ) === false ) {
-			throw new \RuntimeException( 'Unable to copy test file' );
+		if (copy(__DIR__ . '/_testfiles/import.zip', 'tmp/import.zip') === false) {
+			throw new \RuntimeException('Unable to copy test file');
 		}
 
 		$this->object->run();
 
-		$filename = strftime( 'tmp/test-%Y-%m-%d.zip' );
-		$this->assertTrue( file_exists( $filename ) );
+		$filename = strftime('tmp/test-%Y-%m-%d.zip');
+		$this->assertTrue(file_exists($filename));
 
-		unlink( $filename );
+		unlink($filename);
 	}
 
 
 	public function testRunBackupInvalid()
 	{
 		$config = $this->context->getConfig();
-		$config->set( 'controller/jobs/catalog/import/csv/container/type', 'Zip' );
-		$config->set( 'controller/jobs/catalog/import/csv/location', 'tmp/import.zip' );
-		$config->set( 'controller/jobs/catalog/import/csv/backup', 'tmp/notexist/import.zip' );
+		$config->set('controller/jobs/catalog/import/csv/container/type', 'Zip');
+		$config->set('controller/jobs/catalog/import/csv/location', 'tmp/import.zip');
+		$config->set('controller/jobs/catalog/import/csv/backup', 'tmp/notexist/import.zip');
 
-		if( copy( __DIR__ . '/_testfiles/import.zip', 'tmp/import.zip' ) === false ) {
-			throw new \RuntimeException( 'Unable to copy test file' );
+		if (copy(__DIR__ . '/_testfiles/import.zip', 'tmp/import.zip') === false) {
+			throw new \RuntimeException('Unable to copy test file');
 		}
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
 		$this->object->run();
 	}
 
 
-	protected function delete( \Aimeos\MShop\Catalog\Item\Iface $tree, array $domains = [] )
+	protected function delete(\Aimeos\MShop\Catalog\Item\Iface $tree, array $domains = [])
 	{
-		$catalogManager = \Aimeos\MShop\Catalog\Manager\Factory::create( $this->context );
+		$catalogManager = \Aimeos\MShop\Catalog\Manager\Factory::create($this->context);
 
-		foreach( $domains as $domain )
+		foreach ($domains as $domain)
 		{
-			$manager = \Aimeos\MShop::create( $this->context, $domain );
+			$manager = \Aimeos\MShop::create($this->context, $domain);
 
-			foreach( $tree->getListItems( $domain ) as $listItem ) {
-				$manager->deleteItem( $listItem->getRefItem()->getId() );
+			foreach ($tree->getListItems($domain) as $listItem) {
+				$manager->deleteItem($listItem->getRefItem()->getId());
 			}
 		}
 
-		foreach( $tree->getChildren() as $node ) {
-			$this->delete( $node, $domains );
+		foreach ($tree->getChildren() as $node) {
+			$this->delete($node, $domains);
 		}
 
-		$catalogManager->deleteItem( $tree->getId() );
+		$catalogManager->deleteItem($tree->getId());
 	}
 
 
-	protected function get( $catcode, array $domains = [] )
+	protected function get($catcode, array $domains = [])
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::create( $this->context );
-		$root = $manager->findItem( $catcode );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::create($this->context);
+		$root = $manager->findItem($catcode);
 
-		return $manager->getTree( $root->getId(), $domains, \Aimeos\MW\Tree\Manager\Base::LEVEL_TREE );
+		return $manager->getTree($root->getId(), $domains, \Aimeos\MW\Tree\Manager\Base::LEVEL_TREE);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -18,95 +18,95 @@
		block discarded – undo
18	18
19	19	protected function setUp()
20	20	{
21		- \Aimeos\MShop::cache( true );
	21	+ \Aimeos\MShop::cache(true);
22	22
23	23	$this->context = \TestHelperJobs::getContext();
24	24	$this->aimeos = \TestHelperJobs::getAimeos();
25	25	$config = $this->context->getConfig();
26	26
27		- $config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );
	27	+ $config->set('controller/jobs/product/import/csv/skip-lines', 1);
28	28
29		- $this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
	29	+ $this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard($this->context, $this->aimeos);
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- \Aimeos\MShop::cache( false );
	35	+ \Aimeos\MShop::cache(false);
36	36	\Aimeos\MShop::clear();
37	37
38		- unset( $this->object );
	38	+ unset($this->object);
39	39	}
40	40
41	41
42	42	public function testGetName()
43	43	{
44		- $this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
	44	+ $this->assertEquals('Coupon code import CSV', $this->object->getName());
45	45	}
46	46
47	47
48	48	public function testGetDescription()
49	49	{
50	50	$text = 'Imports new and updates existing coupon code from CSV files';
51		- $this->assertEquals( $text, $this->object->getDescription() );
	51	+ $this->assertEquals($text, $this->object->getDescription());
52	52	}
53	53
54	54
55	55	public function testRun()
56	56	{
57		- $manager = \Aimeos\MShop::create( $this->context, 'coupon' );
58		- $coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
	57	+ $manager = \Aimeos\MShop::create($this->context, 'coupon');
	58	+ $coupon = $manager->saveItem($manager->createItem()->setProvider('Example'));
59	59
60	60	$dir = 'tmp/import/couponcode/unittest';
61	61	$filepath = $dir . '/' . $coupon->getId() . '.csv';
62	62
63		- if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
64		- throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
	63	+ if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
	64	+ throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
65	65	}
66	66
67	67	$content = 'code,count,start,end
68	68	jobccimport1,3,2000-01-01 00:00:00,
69	69	jobccimport2,5,,';
70	70
71		- if( file_put_contents( $filepath, $content ) === false ) {
72		- throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
	71	+ if (file_put_contents($filepath, $content) === false) {
	72	+ throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
73	73	}
74	74
75	75	$this->object->run();
76	76
77	77
78		- $codeManager = \Aimeos\MShop::create( $this->context, 'coupon/code' );
79		- $code1 = $codeManager->findItem( 'jobccimport1' );
80		- $code2 = $codeManager->findItem( 'jobccimport2' );
	78	+ $codeManager = \Aimeos\MShop::create($this->context, 'coupon/code');
	79	+ $code1 = $codeManager->findItem('jobccimport1');
	80	+ $code2 = $codeManager->findItem('jobccimport2');
81	81
82		- $manager->deleteItem( $coupon->getId() );
	82	+ $manager->deleteItem($coupon->getId());
83	83
84		- $this->assertEquals( 3, $code1->getCount() );
85		- $this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
86		- $this->assertEquals( null, $code1->getDateEnd() );
	84	+ $this->assertEquals(3, $code1->getCount());
	85	+ $this->assertEquals('2000-01-01 00:00:00', $code1->getDateStart());
	86	+ $this->assertEquals(null, $code1->getDateEnd());
87	87
88		- $this->assertEquals( 5, $code2->getCount() );
89		- $this->assertEquals( null, $code2->getDateStart() );
90		- $this->assertEquals( null, $code2->getDateEnd() );
	88	+ $this->assertEquals(5, $code2->getCount());
	89	+ $this->assertEquals(null, $code2->getDateStart());
	90	+ $this->assertEquals(null, $code2->getDateEnd());
91	91	}
92	92
93	93
94	94	public function testRunException()
95	95	{
96		- $manager = \Aimeos\MShop::create( $this->context, 'coupon' );
	96	+ $manager = \Aimeos\MShop::create($this->context, 'coupon');
97	97
98	98	$dir = 'tmp/import/couponcode/unittest';
99	99	$filepath = $dir . '/0.csv';
100	100
101		- if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
102		- throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
	101	+ if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
	102	+ throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
103	103	}
104	104
105	105	$content = 'code,count,start,end
106	106	jobccimport1,,,';
107	107
108		- if( file_put_contents( $filepath, $content ) === false ) {
109		- throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
	108	+ if (file_put_contents($filepath, $content) === false) {
	109	+ throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
110	110	}
111	111
112	112	$this->object->run();

		@@ -18,65 +18,65 @@ discard block
		block discarded – undo
18	18
19	19	protected function setUp()
20	20	{
21		- \Aimeos\MShop::cache( true );
	21	+ \Aimeos\MShop::cache(true);
22	22
23	23	$this->context = \TestHelperJobs::getContext();
24	24	$this->aimeos = \TestHelperJobs::getAimeos();
25	25	$config = $this->context->getConfig();
26	26
27		- $config->set( 'controller/jobs/catalog/import/csv/skip-lines', 1 );
28		- $config->set( 'controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/valid' );
	27	+ $config->set('controller/jobs/catalog/import/csv/skip-lines', 1);
	28	+ $config->set('controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/valid');
29	29
30		- $this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard( $this->context, $this->aimeos );
	30	+ $this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard($this->context, $this->aimeos);
31	31	}
32	32
33	33
34	34	protected function tearDown()
35	35	{
36		- \Aimeos\MShop::cache( false );
	36	+ \Aimeos\MShop::cache(false);
37	37	\Aimeos\MShop::clear();
38	38
39	39	$this->object = null;
40	40
41		- if( file_exists( 'tmp/import.zip' ) ) {
42		- unlink( 'tmp/import.zip' );
	41	+ if (file_exists('tmp/import.zip')) {
	42	+ unlink('tmp/import.zip');
43	43	}
44	44	}
45	45
46	46
47	47	public function testGetName()
48	48	{
49		- $this->assertEquals( 'Catalog import CSV', $this->object->getName() );
	49	+ $this->assertEquals('Catalog import CSV', $this->object->getName());
50	50	}
51	51
52	52
53	53	public function testGetDescription()
54	54	{
55	55	$text = 'Imports new and updates existing categories from CSV files';
56		- $this->assertEquals( $text, $this->object->getDescription() );
	56	+ $this->assertEquals($text, $this->object->getDescription());
57	57	}
58	58
59	59
60	60	public function testRun()
61	61	{
62		- $catcodes = array( 'job_csv_test', 'job_csv_test2', 'job_csv_test3', 'job_csv_test4' );
63		- $domains = array( 'media', 'text' );
	62	+ $catcodes = array('job_csv_test', 'job_csv_test2', 'job_csv_test3', 'job_csv_test4');
	63	+ $domains = array('media', 'text');
64	64
65	65	$convert = array(
66	66	1 => 'Text/LatinUTF8',
67	67	);
68	68
69		- $this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/converter', $convert );
	69	+ $this->context->getConfig()->set('controller/jobs/catalog/import/csv/converter', $convert);
70	70
71	71	$this->object->run();
72	72
73		- $tree = $this->get( 'job_csv_test', $domains );
74		- $this->delete( $tree, $domains );
	73	+ $tree = $this->get('job_csv_test', $domains);
	74	+ $this->delete($tree, $domains);
75	75
76		- $this->assertEquals( 2, count( $tree->getListItems() ) );
	76	+ $this->assertEquals(2, count($tree->getListItems()));
77	77
78		- foreach( $tree->getChildren() as $node ) {
79		- $this->assertEquals( 2, count( $node->getListItems() ) );
	78	+ foreach ($tree->getChildren() as $node) {
	79	+ $this->assertEquals(2, count($node->getListItems()));
80	80	}
81	81	}
82	82
		@@ -86,13 +86,13 @@ discard block
		block discarded – undo
86	86	$this->object->run();
87	87	$this->object->run();
88	88
89		- $tree = $this->get( 'job_csv_test', ['media', 'text'] );
90		- $this->delete( $tree, ['media', 'text'] );
	89	+ $tree = $this->get('job_csv_test', ['media', 'text']);
	90	+ $this->delete($tree, ['media', 'text']);
91	91
92		- $this->assertEquals( 2, count( $tree->getListItems() ) );
	92	+ $this->assertEquals(2, count($tree->getListItems()));
93	93
94		- foreach( $tree->getChildren() as $node ) {
95		- $this->assertEquals( 2, count( $node->getListItems() ) );
	94	+ foreach ($tree->getChildren() as $node) {
	95	+ $this->assertEquals(2, count($node->getListItems()));
96	96	}
97	97	}
98	98
		@@ -100,18 +100,18 @@ discard block
		block discarded – undo
100	100	public function testRunPosition()
101	101	{
102	102	$config = $this->context->getConfig();
103		- $mapping = $config->set( 'controller/jobs/catalog/import/csv/mapping', [] );
104		- $mapping['item'] = array( 0 => 'catalog.label', 1 => 'catalog.code', 2 => 'catalog.parent' );
	103	+ $mapping = $config->set('controller/jobs/catalog/import/csv/mapping', []);
	104	+ $mapping['item'] = array(0 => 'catalog.label', 1 => 'catalog.code', 2 => 'catalog.parent');
105	105
106		- $config->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
107		- $config->set( 'controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/position' );
	106	+ $config->set('controller/jobs/catalog/import/csv/mapping', $mapping);
	107	+ $config->set('controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/position');
108	108
109	109	$this->object->run();
110	110
111		- $tree = $this->get( 'job_csv_test' );
112		- $this->delete( $tree );
	111	+ $tree = $this->get('job_csv_test');
	112	+ $this->delete($tree);
113	113
114		- $this->assertEquals( 1, count( $tree->getChildren() ) );
	114	+ $this->assertEquals(1, count($tree->getChildren()));
115	115	}
116	116
117	117
		@@ -135,12 +135,12 @@ discard block
		block discarded – undo
135	135	),
136	136	);
137	137
138		- $this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
	138	+ $this->context->getConfig()->set('controller/jobs/catalog/import/csv/mapping', $mapping);
139	139
140	140	$this->object->run();
141	141
142		- $tree = $this->get( 'job_csv_test' );
143		- $this->delete( $tree );
	142	+ $tree = $this->get('job_csv_test');
	143	+ $this->delete($tree);
144	144	}
145	145
146	146
		@@ -152,9 +152,9 @@ discard block
		block discarded – undo
152	152	),
153	153	);
154	154
155		- $this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
	155	+ $this->context->getConfig()->set('controller/jobs/catalog/import/csv/mapping', $mapping);
156	156
157		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
	157	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
158	158	$this->object->run();
159	159	}
160	160
		@@ -178,15 +178,15 @@ discard block
		block discarded – undo
178	178	),
179	179	);
180	180
181		- $this->context->getConfig()->set( 'controller/jobs/catalog/import/csv/mapping', $mapping );
	181	+ $this->context->getConfig()->set('controller/jobs/catalog/import/csv/mapping', $mapping);
182	182
183	183	$config = $this->context->getConfig();
184		- $config->set( 'controller/jobs/catalog/import/csv/skip-lines', 0 );
185		- $config->set( 'controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/invalid' );
	184	+ $config->set('controller/jobs/catalog/import/csv/skip-lines', 0);
	185	+ $config->set('controller/jobs/catalog/import/csv/location', __DIR__ . '/_testfiles/invalid');
186	186
187		- $this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard( $this->context, $this->aimeos );
	187	+ $this->object = new \Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard($this->context, $this->aimeos);
188	188
189		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
	189	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
190	190	$this->object->run();
191	191	}
192	192
		@@ -194,65 +194,65 @@ discard block
		block discarded – undo
194	194	public function testRunBackup()
195	195	{
196	196	$config = $this->context->getConfig();
197		- $config->set( 'controller/jobs/catalog/import/csv/container/type', 'Zip' );
198		- $config->set( 'controller/jobs/catalog/import/csv/location', 'tmp/import.zip' );
199		- $config->set( 'controller/jobs/catalog/import/csv/backup', 'tmp/test-%Y-%m-%d.zip' );
	197	+ $config->set('controller/jobs/catalog/import/csv/container/type', 'Zip');
	198	+ $config->set('controller/jobs/catalog/import/csv/location', 'tmp/import.zip');
	199	+ $config->set('controller/jobs/catalog/import/csv/backup', 'tmp/test-%Y-%m-%d.zip');
200	200
201		- if( copy( __DIR__ . '/_testfiles/import.zip', 'tmp/import.zip' ) === false ) {
202		- throw new \RuntimeException( 'Unable to copy test file' );
	201	+ if (copy(__DIR__ . '/_testfiles/import.zip', 'tmp/import.zip') === false) {
	202	+ throw new \RuntimeException('Unable to copy test file');
203	203	}
204	204
205	205	$this->object->run();
206	206
207		- $filename = strftime( 'tmp/test-%Y-%m-%d.zip' );
208		- $this->assertTrue( file_exists( $filename ) );
	207	+ $filename = strftime('tmp/test-%Y-%m-%d.zip');
	208	+ $this->assertTrue(file_exists($filename));
209	209
210		- unlink( $filename );
	210	+ unlink($filename);
211	211	}
212	212
213	213
214	214	public function testRunBackupInvalid()
215	215	{
216	216	$config = $this->context->getConfig();
217		- $config->set( 'controller/jobs/catalog/import/csv/container/type', 'Zip' );
218		- $config->set( 'controller/jobs/catalog/import/csv/location', 'tmp/import.zip' );
219		- $config->set( 'controller/jobs/catalog/import/csv/backup', 'tmp/notexist/import.zip' );
	217	+ $config->set('controller/jobs/catalog/import/csv/container/type', 'Zip');
	218	+ $config->set('controller/jobs/catalog/import/csv/location', 'tmp/import.zip');
	219	+ $config->set('controller/jobs/catalog/import/csv/backup', 'tmp/notexist/import.zip');
220	220
221		- if( copy( __DIR__ . '/_testfiles/import.zip', 'tmp/import.zip' ) === false ) {
222		- throw new \RuntimeException( 'Unable to copy test file' );
	221	+ if (copy(__DIR__ . '/_testfiles/import.zip', 'tmp/import.zip') === false) {
	222	+ throw new \RuntimeException('Unable to copy test file');
223	223	}
224	224
225		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
	225	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
226	226	$this->object->run();
227	227	}
228	228
229	229
230		- protected function delete( \Aimeos\MShop\Catalog\Item\Iface $tree, array $domains = [] )
	230	+ protected function delete(\Aimeos\MShop\Catalog\Item\Iface $tree, array $domains = [])
231	231	{
232		- $catalogManager = \Aimeos\MShop\Catalog\Manager\Factory::create( $this->context );
	232	+ $catalogManager = \Aimeos\MShop\Catalog\Manager\Factory::create($this->context);
233	233
234		- foreach( $domains as $domain )
	234	+ foreach ($domains as $domain)
235	235	{
236		- $manager = \Aimeos\MShop::create( $this->context, $domain );
	236	+ $manager = \Aimeos\MShop::create($this->context, $domain);
237	237
238		- foreach( $tree->getListItems( $domain ) as $listItem ) {
239		- $manager->deleteItem( $listItem->getRefItem()->getId() );
	238	+ foreach ($tree->getListItems($domain) as $listItem) {
	239	+ $manager->deleteItem($listItem->getRefItem()->getId());
240	240	}
241	241	}
242	242
243		- foreach( $tree->getChildren() as $node ) {
244		- $this->delete( $node, $domains );
	243	+ foreach ($tree->getChildren() as $node) {
	244	+ $this->delete($node, $domains);
245	245	}
246	246
247		- $catalogManager->deleteItem( $tree->getId() );
	247	+ $catalogManager->deleteItem($tree->getId());
248	248	}
249	249
250	250
251		- protected function get( $catcode, array $domains = [] )
	251	+ protected function get($catcode, array $domains = [])
252	252	{
253		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::create( $this->context );
254		- $root = $manager->findItem( $catcode );
	253	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::create($this->context);
	254	+ $root = $manager->findItem($catcode);
255	255
256		- return $manager->getTree( $root->getId(), $domains, \Aimeos\MW\Tree\Manager\Base::LEVEL_TREE );
	256	+ return $manager->getTree($root->getId(), $domains, \Aimeos\MW\Tree\Manager\Base::LEVEL_TREE);
257	257	}
258	258	}
259	259	\ No newline at end of file

aimeos / ai-controller-jobs

Push — master ( cbc921...0b1729 )

Status

Category

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

Spacing +66 added lines, -66 removed lines patch added patch discarded remove patch