Inspection of "Adapt to new create() factory method" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cbc921...0b1729 )

by Aimeos

created 2018-12-28 12:08 UTC

Status

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 		$this->context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard( $this->context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard($this->context, $aimeos);
 	}
 
 
@@ -44,14 +44,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Log cleanup', $this->object->getName() );
+		$this->assertEquals('Log cleanup', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Removes the old log entries from the database and archives them (optional)';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -59,38 +59,38 @@  discard block
 block discarded – undo
 	{
 		$config = $this->context->getConfig();
 
-		$mock = $this->getMockBuilder( '\\Aimeos\\MAdmin\\Log\\Manager\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $this->context ) )
+		$mock = $this->getMockBuilder('\\Aimeos\\MAdmin\\Log\\Manager\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($this->context))
 			->getMock();
 
-		$mock->expects( $this->atLeastOnce() )->method( 'deleteItems' );
+		$mock->expects($this->atLeastOnce())->method('deleteItems');
 
-		$tmppath = dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) . DIRECTORY_SEPARATOR . 'tmp';
+		$tmppath = dirname(dirname(dirname(dirname(__DIR__)))) . DIRECTORY_SEPARATOR . 'tmp';
 		$name = 'ControllerJobsAdminLogDefaultRun';
-		$config->set( 'madmin/log/manager/name', $name );
-		$config->set( 'controller/jobs/admin/log/standard/limit-days', 0 );
-		$config->set( 'controller/jobs/admin/log/standard/path', $tmppath );
+		$config->set('madmin/log/manager/name', $name);
+		$config->set('controller/jobs/admin/log/standard/limit-days', 0);
+		$config->set('controller/jobs/admin/log/standard/path', $tmppath);
 
-		\Aimeos\MAdmin\Log\Manager\Factory::injectManager( '\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock );
+		\Aimeos\MAdmin\Log\Manager\Factory::injectManager('\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock);
 
-		if( !is_dir( $tmppath ) && mkdir( $tmppath ) === false ) {
-			throw new \RuntimeException( sprintf( 'Unable to create temporary path "%1$s"', $tmppath ) );
+		if (!is_dir($tmppath) && mkdir($tmppath) === false) {
+			throw new \RuntimeException(sprintf('Unable to create temporary path "%1$s"', $tmppath));
 		}
 
 		$this->object->run();
 
-		foreach( new \DirectoryIterator( $tmppath ) as $file )
+		foreach (new \DirectoryIterator($tmppath) as $file)
 		{
-			if( $file->isFile() && $file->getExtension() === 'zip' )
+			if ($file->isFile() && $file->getExtension() === 'zip')
 			{
-				$container = \Aimeos\MW\Container\Factory::getContainer( $file->getPathName(), 'Zip', 'CSV', [] );
-				$container->get( 'unittest facility.csv' );
-				unlink( $file->getPathName() );
+				$container = \Aimeos\MW\Container\Factory::getContainer($file->getPathName(), 'Zip', 'CSV', []);
+				$container->get('unittest facility.csv');
+				unlink($file->getPathName());
 				return;
 			}
 		}
 
-		$this->fail( 'Log archive file not found' );
+		$this->fail('Log archive file not found');
 	}
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Service/Payment/StandardTest.php 1 patch

Spacing +67 added lines, -67 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Capture authorized payments', $this->object->getName() );
+		$this->assertEquals('Capture authorized payments', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Authorized payments of orders will be captured after dispatching or after a configurable amount of time';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -60,49 +60,49 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 		$orderItem = $orderManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
-			->setMethods( array( 'isImplemented', 'capture' ) )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
+			->setMethods(array('isImplemented', 'capture'))
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), []));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
-			->will( $this->returnValue( true ) );
+		$serviceProviderStub->expects($this->once())->method('isImplemented')
+			->will($this->returnValue(true));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'capture' );
+		$serviceProviderStub->expects($this->once())->method('capture');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -114,52 +114,52 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 		$orderItem = $orderManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
-			->setMethods( array( 'isImplemented', 'capture' ) )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
+			->setMethods(array('isImplemented', 'capture'))
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), []));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
-			->will( $this->returnValue( true ) );
+		$serviceProviderStub->expects($this->once())->method('isImplemented')
+			->will($this->returnValue(true));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'capture' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test oder service payment: capture' ) ) );
+		$serviceProviderStub->expects($this->once())->method('capture')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception('test oder service payment: capture')));
 
-		$orderManagerStub->expects( $this->never() )->method( 'saveItem' );
+		$orderManagerStub->expects($this->never())->method('saveItem');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -171,36 +171,36 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test service delivery process: getProvider' ) ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception('test service delivery process: getProvider')));
 
-		$orderManagerStub->expects( $this->never() )->method( 'searchItems' );
+		$orderManagerStub->expects($this->never())->method('searchItems');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Export/Csv/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/src/Controller/Jobs/Order/Export/Csv/Factory.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/order/export/csv/name
 		 * Class name of the used order suggestions scheduler controller implementation
@@ -64,20 +64,20 @@  discard block
 block discarded – undo
 		 * @since 2015.01
 		 * @category Developer
 		 */
-		if ( $name === null ) {
+		if ($name === null) {
 			$name = $context->getConfig()->get('controller/jobs/order/export/csv/name', 'Standard');
 		}
 
-		if ( ctype_alnum($name) === false )
+		if (ctype_alnum($name) === false)
 		{
 			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Order\\Export\\Csv\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Order\\Export\\Csv\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/order/export/csv/decorators/excludes
 		 * Excludes decorators added by the "common" option from the order export CSV job controller
@@ -154,6 +154,6 @@  discard block
 block discarded – undo
 		 * @see controller/jobs/order/export/csv/decorators/excludes
 		 * @see controller/jobs/order/export/csv/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'order/export/csv' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'order/export/csv');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

common/src/Controller/Common/Order/Export/Csv/Processor/Coupon/Standard.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -40,17 +40,17 @@
 block discarded – undo
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
 	{
 		$result = [];
 
-		foreach( $order->getCoupons() as $code => $products )
+		foreach ($order->getCoupons() as $code => $products)
 		{
 			$data = [];
 
-			foreach( $this->getMapping() as $pos => $key )
+			foreach ($this->getMapping() as $pos => $key)
 			{
-				if( $key === 'order.base.coupon.code' ) {
+				if ($key === 'order.base.coupon.code') {
 					$data[$pos] = $code;
 				} else {
 					$data[$pos] = '';

Please login to merge, or discard this patch.

controller/common/src/Controller/Common/Order/Export/Csv/Processor/Base.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@
 block discarded – undo
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping)
 	{
 		$this->context = $context;
 		$this->mapping = $mapping;

Please login to merge, or discard this patch.

src/Controller/Common/Order/Export/Csv/Processor/Address/Standard.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -40,28 +40,28 @@
 block discarded – undo
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
 	{
 		$result = [];
 		$addresses = $order->getAddresses();
 
-		krsort( $addresses );
+		krsort($addresses);
 
-		foreach( $addresses as $item )
+		foreach ($addresses as $item)
 		{
 			$data = [];
 			$list = $item->toArray();
 
-			foreach( $this->getMapping() as $pos => $key )
+			foreach ($this->getMapping() as $pos => $key)
 			{
-				if( array_key_exists( $key, $list ) ) {
+				if (array_key_exists($key, $list)) {
 					$data[$pos] = $list[$key];
 				} else {
 					$data[$pos] = '';
 				}
 			}
 
-			ksort( $data );
+			ksort($data);
 			$result[] = $data;
 		}
 

Please login to merge, or discard this patch.

src/Controller/Common/Order/Export/Csv/Processor/Invoice/Standard.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -40,21 +40,21 @@
 block discarded – undo
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
 	{
 		$result = [];
 		$list = $invoice->toArray() + $order->toArray();
 
-		foreach( $this->getMapping() as $pos => $key )
+		foreach ($this->getMapping() as $pos => $key)
 		{
-			if( array_key_exists( $key, $list ) ) {
+			if (array_key_exists($key, $list)) {
 				$result[$pos] = $list[$key];
 			} else {
 				$result[$pos] = '';
 			}
 		}
 
-		ksort( $result );
+		ksort($result);
 
 		return [$result];
 	}

Please login to merge, or discard this patch.

common/src/Controller/Common/Order/Export/Csv/Processor/Iface.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping );
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping);
 
 
 	/**
@@ -35,5 +35,5 @@  discard block
 block discarded – undo
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order );
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order);
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	* @param string\|null $name Name of the controller or "Standard" if null
30	30	* @return \Aimeos\Controller\Jobs\Iface New controller object
31	31	*/
32		- public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
	32	+ public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
33	33	{
34	34	/** controller/jobs/order/export/csv/name
35	35	* Class name of the used order suggestions scheduler controller implementation
		@@ -64,20 +64,20 @@ discard block
		block discarded – undo
64	64	* @since 2015.01
65	65	* @category Developer
66	66	*/
67		- if ( $name === null ) {
	67	+ if ($name === null) {
68	68	$name = $context->getConfig()->get('controller/jobs/order/export/csv/name', 'Standard');
69	69	}
70	70
71		- if ( ctype_alnum($name) === false )
	71	+ if (ctype_alnum($name) === false)
72	72	{
73	73	$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Order\\Export\\Csv\\' . $name : '<not a string>';
74		- throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
	74	+ throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
75	75	}
76	76
77	77	$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
78	78	$classname = '\\Aimeos\\Controller\\Jobs\\Order\\Export\\Csv\\' . $name;
79	79
80		- $controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
	80	+ $controller = self::createControllerBase($context, $aimeos, $classname, $iface);
81	81
82	82	/** controller/jobs/order/export/csv/decorators/excludes
83	83	* Excludes decorators added by the "common" option from the order export CSV job controller
		@@ -154,6 +154,6 @@ discard block
		block discarded – undo
154	154	* @see controller/jobs/order/export/csv/decorators/excludes
155	155	* @see controller/jobs/order/export/csv/decorators/global
156	156	*/
157		- return self::addControllerDecorators( $context, $aimeos, $controller, 'order/export/csv' );
	157	+ return self::addControllerDecorators($context, $aimeos, $controller, 'order/export/csv');
158	158	}
159	159	}
160	160	\ No newline at end of file

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	$this->context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard( $this->context, $aimeos );
	28	+ $this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard($this->context, $aimeos);
29	29	}
30	30
31	31
		@@ -44,14 +44,14 @@ discard block
		block discarded – undo
44	44
45	45	public function testGetName()
46	46	{
47		- $this->assertEquals( 'Log cleanup', $this->object->getName() );
	47	+ $this->assertEquals('Log cleanup', $this->object->getName());
48	48	}
49	49
50	50
51	51	public function testGetDescription()
52	52	{
53	53	$text = 'Removes the old log entries from the database and archives them (optional)';
54		- $this->assertEquals( $text, $this->object->getDescription() );
	54	+ $this->assertEquals($text, $this->object->getDescription());
55	55	}
56	56
57	57
		@@ -59,38 +59,38 @@ discard block
		block discarded – undo
59	59	{
60	60	$config = $this->context->getConfig();
61	61
62		- $mock = $this->getMockBuilder( '\\Aimeos\\MAdmin\\Log\\Manager\\Standard' )
63		- ->setMethods( array( 'deleteItems' ) )
64		- ->setConstructorArgs( array( $this->context ) )
	62	+ $mock = $this->getMockBuilder('\\Aimeos\\MAdmin\\Log\\Manager\\Standard')
	63	+ ->setMethods(array('deleteItems'))
	64	+ ->setConstructorArgs(array($this->context))
65	65	->getMock();
66	66
67		- $mock->expects( $this->atLeastOnce() )->method( 'deleteItems' );
	67	+ $mock->expects($this->atLeastOnce())->method('deleteItems');
68	68
69		- $tmppath = dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) . DIRECTORY_SEPARATOR . 'tmp';
	69	+ $tmppath = dirname(dirname(dirname(dirname(__DIR__)))) . DIRECTORY_SEPARATOR . 'tmp';
70	70	$name = 'ControllerJobsAdminLogDefaultRun';
71		- $config->set( 'madmin/log/manager/name', $name );
72		- $config->set( 'controller/jobs/admin/log/standard/limit-days', 0 );
73		- $config->set( 'controller/jobs/admin/log/standard/path', $tmppath );
	71	+ $config->set('madmin/log/manager/name', $name);
	72	+ $config->set('controller/jobs/admin/log/standard/limit-days', 0);
	73	+ $config->set('controller/jobs/admin/log/standard/path', $tmppath);
74	74
75		- \Aimeos\MAdmin\Log\Manager\Factory::injectManager( '\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock );
	75	+ \Aimeos\MAdmin\Log\Manager\Factory::injectManager('\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock);
76	76
77		- if( !is_dir( $tmppath ) && mkdir( $tmppath ) === false ) {
78		- throw new \RuntimeException( sprintf( 'Unable to create temporary path "%1$s"', $tmppath ) );
	77	+ if (!is_dir($tmppath) && mkdir($tmppath) === false) {
	78	+ throw new \RuntimeException(sprintf('Unable to create temporary path "%1$s"', $tmppath));
79	79	}
80	80
81	81	$this->object->run();
82	82
83		- foreach( new \DirectoryIterator( $tmppath ) as $file )
	83	+ foreach (new \DirectoryIterator($tmppath) as $file)
84	84	{
85		- if( $file->isFile() && $file->getExtension() === 'zip' )
	85	+ if ($file->isFile() && $file->getExtension() === 'zip')
86	86	{
87		- $container = \Aimeos\MW\Container\Factory::getContainer( $file->getPathName(), 'Zip', 'CSV', [] );
88		- $container->get( 'unittest facility.csv' );
89		- unlink( $file->getPathName() );
	87	+ $container = \Aimeos\MW\Container\Factory::getContainer($file->getPathName(), 'Zip', 'CSV', []);
	88	+ $container->get('unittest facility.csv');
	89	+ unlink($file->getPathName());
90	90	return;
91	91	}
92	92	}
93	93
94		- $this->fail( 'Log archive file not found' );
	94	+ $this->fail('Log archive file not found');
95	95	}
96	96	}

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	$context = \TestHelperJobs::getContext();
25	25	$aimeos = \TestHelperJobs::getAimeos();
26	26
27		- $this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
	27	+ $this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
28	28	}
29	29
30	30
		@@ -42,14 +42,14 @@ discard block
		block discarded – undo
42	42
43	43	public function testGetName()
44	44	{
45		- $this->assertEquals( 'Capture authorized payments', $this->object->getName() );
	45	+ $this->assertEquals('Capture authorized payments', $this->object->getName());
46	46	}
47	47
48	48
49	49	public function testGetDescription()
50	50	{
51	51	$text = 'Authorized payments of orders will be captured after dispatching or after a configurable amount of time';
52		- $this->assertEquals( $text, $this->object->getDescription() );
	52	+ $this->assertEquals($text, $this->object->getDescription());
53	53	}
54	54
55	55
		@@ -60,49 +60,49 @@ discard block
		block discarded – undo
60	60
61	61
62	62	$name = 'ControllerJobsServicePaymentProcessDefaultRun';
63		- $context->getConfig()->set( 'mshop/service/manager/name', $name );
64		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
	63	+ $context->getConfig()->set('mshop/service/manager/name', $name);
	64	+ $context->getConfig()->set('mshop/order/manager/name', $name);
65	65
66	66
67		- $serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
68		- ->setMethods( array( 'getProvider', 'searchItems' ) )
69		- ->setConstructorArgs( array( $context ) )
	67	+ $serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
	68	+ ->setMethods(array('getProvider', 'searchItems'))
	69	+ ->setConstructorArgs(array($context))
70	70	->getMock();
71	71
72		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
73		- ->setMethods( array( 'saveItem', 'searchItems' ) )
74		- ->setConstructorArgs( array( $context ) )
	72	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	73	+ ->setMethods(array('saveItem', 'searchItems'))
	74	+ ->setConstructorArgs(array($context))
75	75	->getMock();
76	76
77		- \Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
78		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
	77	+ \Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
	78	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
79	79
80	80
81	81	$serviceItem = $serviceManagerStub->createItem();
82	82	$orderItem = $orderManagerStub->createItem();
83	83
84		- $serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
85		- ->setMethods( array( 'isImplemented', 'capture' ) )
86		- ->setConstructorArgs( array( $context, $serviceItem ) )
	84	+ $serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
	85	+ ->setMethods(array('isImplemented', 'capture'))
	86	+ ->setConstructorArgs(array($context, $serviceItem))
87	87	->getMock();
88	88
89	89
90		- $serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
91		- ->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
	90	+ $serviceManagerStub->expects($this->once())->method('searchItems')
	91	+ ->will($this->onConsecutiveCalls(array($serviceItem), []));
92	92
93		- $serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
94		- ->will( $this->returnValue( $serviceProviderStub ) );
	93	+ $serviceManagerStub->expects($this->once())->method('getProvider')
	94	+ ->will($this->returnValue($serviceProviderStub));
95	95
96		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
97		- ->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
	96	+ $orderManagerStub->expects($this->once())->method('searchItems')
	97	+ ->will($this->onConsecutiveCalls(array($orderItem), []));
98	98
99		- $serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
100		- ->will( $this->returnValue( true ) );
	99	+ $serviceProviderStub->expects($this->once())->method('isImplemented')
	100	+ ->will($this->returnValue(true));
101	101
102		- $serviceProviderStub->expects( $this->once() )->method( 'capture' );
	102	+ $serviceProviderStub->expects($this->once())->method('capture');
103	103
104	104
105		- $object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
	105	+ $object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
106	106	$object->run();
107	107	}
108	108
		@@ -114,52 +114,52 @@ discard block
		block discarded – undo
114	114
115	115
116	116	$name = 'ControllerJobsServicePaymentProcessDefaultRun';
117		- $context->getConfig()->set( 'mshop/service/manager/name', $name );
118		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
	117	+ $context->getConfig()->set('mshop/service/manager/name', $name);
	118	+ $context->getConfig()->set('mshop/order/manager/name', $name);
119	119
120	120
121		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
122		- ->setMethods( array( 'saveItem', 'searchItems' ) )
123		- ->setConstructorArgs( array( $context ) )
	121	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	122	+ ->setMethods(array('saveItem', 'searchItems'))
	123	+ ->setConstructorArgs(array($context))
124	124	->getMock();
125	125
126		- $serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
127		- ->setMethods( array( 'getProvider', 'searchItems' ) )
128		- ->setConstructorArgs( array( $context ) )
	126	+ $serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
	127	+ ->setMethods(array('getProvider', 'searchItems'))
	128	+ ->setConstructorArgs(array($context))
129	129	->getMock();
130	130
131		- \Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
132		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
	131	+ \Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
	132	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
133	133
134	134
135	135	$serviceItem = $serviceManagerStub->createItem();
136	136	$orderItem = $orderManagerStub->createItem();
137	137
138		- $serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
139		- ->setMethods( array( 'isImplemented', 'capture' ) )
140		- ->setConstructorArgs( array( $context, $serviceItem ) )
	138	+ $serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
	139	+ ->setMethods(array('isImplemented', 'capture'))
	140	+ ->setConstructorArgs(array($context, $serviceItem))
141	141	->getMock();
142	142
143	143
144		- $serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
145		- ->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
	144	+ $serviceManagerStub->expects($this->once())->method('searchItems')
	145	+ ->will($this->onConsecutiveCalls(array($serviceItem), []));
146	146
147		- $serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
148		- ->will( $this->returnValue( $serviceProviderStub ) );
	147	+ $serviceManagerStub->expects($this->once())->method('getProvider')
	148	+ ->will($this->returnValue($serviceProviderStub));
149	149
150		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
151		- ->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
	150	+ $orderManagerStub->expects($this->once())->method('searchItems')
	151	+ ->will($this->onConsecutiveCalls(array($orderItem), []));
152	152
153		- $serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
154		- ->will( $this->returnValue( true ) );
	153	+ $serviceProviderStub->expects($this->once())->method('isImplemented')
	154	+ ->will($this->returnValue(true));
155	155
156		- $serviceProviderStub->expects( $this->once() )->method( 'capture' )
157		- ->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test oder service payment: capture' ) ) );
	156	+ $serviceProviderStub->expects($this->once())->method('capture')
	157	+ ->will($this->throwException(new \Aimeos\MShop\Service\Exception('test oder service payment: capture')));
158	158
159		- $orderManagerStub->expects( $this->never() )->method( 'saveItem' );
	159	+ $orderManagerStub->expects($this->never())->method('saveItem');
160	160
161	161
162		- $object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
	162	+ $object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
163	163	$object->run();
164	164	}
165	165
		@@ -171,36 +171,36 @@ discard block
		block discarded – undo
171	171
172	172
173	173	$name = 'ControllerJobsServicePaymentProcessDefaultRun';
174		- $context->getConfig()->set( 'mshop/service/manager/name', $name );
175		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
	174	+ $context->getConfig()->set('mshop/service/manager/name', $name);
	175	+ $context->getConfig()->set('mshop/order/manager/name', $name);
176	176
177	177
178		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
179		- ->setMethods( array( 'saveItem', 'searchItems' ) )
180		- ->setConstructorArgs( array( $context ) )
	178	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	179	+ ->setMethods(array('saveItem', 'searchItems'))
	180	+ ->setConstructorArgs(array($context))
181	181	->getMock();
182	182
183		- $serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
184		- ->setMethods( array( 'getProvider', 'searchItems' ) )
185		- ->setConstructorArgs( array( $context ) )
	183	+ $serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
	184	+ ->setMethods(array('getProvider', 'searchItems'))
	185	+ ->setConstructorArgs(array($context))
186	186	->getMock();
187	187
188		- \Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
189		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
	188	+ \Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
	189	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
190	190
191	191
192	192	$serviceItem = $serviceManagerStub->createItem();
193	193
194		- $serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
195		- ->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
	194	+ $serviceManagerStub->expects($this->once())->method('searchItems')
	195	+ ->will($this->onConsecutiveCalls(array($serviceItem), []));
196	196
197		- $serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
198		- ->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test service delivery process: getProvider' ) ) );
	197	+ $serviceManagerStub->expects($this->once())->method('getProvider')
	198	+ ->will($this->throwException(new \Aimeos\MShop\Service\Exception('test service delivery process: getProvider')));
199	199
200		- $orderManagerStub->expects( $this->never() )->method( 'searchItems' );
	200	+ $orderManagerStub->expects($this->never())->method('searchItems');
201	201
202	202
203		- $object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
	203	+ $object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
204	204	$object->run();
205	205	}
206	206	}

		@@ -16,8 +16,8 @@ discard block
		block discarded – undo
16	16	$context = \TestHelperJobs::getContext();
17	17	$aimeos = \TestHelperJobs::getAimeos();
18	18
19		- $obj = \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos );
20		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	19	+ $obj = \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos);
	20	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
21	21	}
22	22
23	23
		@@ -26,8 +26,8 @@ discard block
		block discarded – undo
26	26	$context = \TestHelperJobs::getContext();
27	27	$aimeos = \TestHelperJobs::getAimeos();
28	28
29		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
30		- \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	29	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	30	+ \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos, 'Wrong$$$Name');
31	31	}
32	32
33	33
		@@ -36,8 +36,8 @@ discard block
		block discarded – undo
36	36	$context = \TestHelperJobs::getContext();
37	37	$aimeos = \TestHelperJobs::getAimeos();
38	38
39		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
40		- \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos, 'WrongClass' );
	39	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	40	+ \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos, 'WrongClass');
41	41	}
42	42
43	43
		@@ -46,8 +46,8 @@ discard block
		block discarded – undo
46	46	$context = \TestHelperJobs::getContext();
47	47	$aimeos = \TestHelperJobs::getAimeos();
48	48
49		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
50		- \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController( $context, $aimeos, 'Factory' );
	49	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	50	+ \Aimeos\Controller\Jobs\Order\Export\Csv\Factory::createController($context, $aimeos, 'Factory');
51	51	}
52	52
53	53	}

		@@ -40,17 +40,17 @@
		block discarded – undo
40	40	* @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
41	41	* @return array Two dimensional associative list of order data representing the lines in CSV
42	42	*/
43		- public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
	43	+ public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
44	44	{
45	45	$result = [];
46	46
47		- foreach( $order->getCoupons() as $code => $products )
	47	+ foreach ($order->getCoupons() as $code => $products)
48	48	{
49	49	$data = [];
50	50
51		- foreach( $this->getMapping() as $pos => $key )
	51	+ foreach ($this->getMapping() as $pos => $key)
52	52	{
53		- if( $key === 'order.base.coupon.code' ) {
	53	+ if ($key === 'order.base.coupon.code') {
54	54	$data[$pos] = $code;
55	55	} else {
56	56	$data[$pos] = '';

		@@ -29,7 +29,7 @@
		block discarded – undo
29	29	* @param \Aimeos\MShop\Context\Item\Iface $context Context object
30	30	* @param array $mapping Associative list of field position in CSV as key and domain item key as value
31	31	*/
32		- public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping )
	32	+ public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping)
33	33	{
34	34	$this->context = $context;
35	35	$this->mapping = $mapping;

		@@ -40,28 +40,28 @@
		block discarded – undo
40	40	* @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
41	41	* @return array Two dimensional associative list of order data representing the lines in CSV
42	42	*/
43		- public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
	43	+ public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
44	44	{
45	45	$result = [];
46	46	$addresses = $order->getAddresses();
47	47
48		- krsort( $addresses );
	48	+ krsort($addresses);
49	49
50		- foreach( $addresses as $item )
	50	+ foreach ($addresses as $item)
51	51	{
52	52	$data = [];
53	53	$list = $item->toArray();
54	54
55		- foreach( $this->getMapping() as $pos => $key )
	55	+ foreach ($this->getMapping() as $pos => $key)
56	56	{
57		- if( array_key_exists( $key, $list ) ) {
	57	+ if (array_key_exists($key, $list)) {
58	58	$data[$pos] = $list[$key];
59	59	} else {
60	60	$data[$pos] = '';
61	61	}
62	62	}
63	63
64		- ksort( $data );
	64	+ ksort($data);
65	65	$result[] = $data;
66	66	}
67	67

		@@ -40,21 +40,21 @@
		block discarded – undo
40	40	* @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
41	41	* @return array Two dimensional associative list of order data representing the lines in CSV
42	42	*/
43		- public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
	43	+ public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
44	44	{
45	45	$result = [];
46	46	$list = $invoice->toArray() + $order->toArray();
47	47
48		- foreach( $this->getMapping() as $pos => $key )
	48	+ foreach ($this->getMapping() as $pos => $key)
49	49	{
50		- if( array_key_exists( $key, $list ) ) {
	50	+ if (array_key_exists($key, $list)) {
51	51	$result[$pos] = $list[$key];
52	52	} else {
53	53	$result[$pos] = '';
54	54	}
55	55	}
56	56
57		- ksort( $result );
	57	+ ksort($result);
58	58
59	59	return [$result];
60	60	}

aimeos / ai-controller-jobs

Push — master ( cbc921...0b1729 )

Status

Category

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

Spacing +67 added lines, -67 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch