Inspection of "Adapt to new create() factory method" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cbc921...0b1729 )

by Aimeos

created 2018-12-28 12:08 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Cleanup/Unpaid/StandardTest.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
 	}
 
 
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Removes unpaid orders', $this->object->getName() );
+		$this->assertEquals('Removes unpaid orders', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Deletes unpaid orders to keep the database clean';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -61,47 +61,47 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsOrderCleanupUnpaidDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/order/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
+		$context->getConfig()->set('controller/common/order/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems', 'getSubManager' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems', 'getSubManager'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
-		->setMethods( array( 'unblock' ) )
-		->setConstructorArgs( array( $context ) )
+		$orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
+		->setMethods(array('unblock'))
+		->setConstructorArgs(array($context))
 		->getMock();
 
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
-		\Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
+		\Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
 
 
 		$orderItem = $orderManagerStub->createItem();
-		$orderItem->setBaseId( 1 );
-		$orderItem->setId( 2 );
+		$orderItem->setBaseId(1);
+		$orderItem->setId(2);
 
 
-		$orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
-			->will( $this->returnValue( $orderBaseManagerStub ) );
+		$orderManagerStub->expects($this->once())->method('getSubManager')
+			->will($this->returnValue($orderBaseManagerStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue(array($orderItem->getId() => $orderItem)));
 
-		$orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
+		$orderBaseManagerStub->expects($this->once())->method('deleteItems');
 
-		$orderCntlStub->expects( $this->once() )->method( 'unblock' );
+		$orderCntlStub->expects($this->once())->method('unblock');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Cleanup/Unfinished/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Cleanup/Unfinished/StandardTest.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
 	}
 
 
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Removes unfinished orders', $this->object->getName() );
+		$this->assertEquals('Removes unfinished orders', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Deletes unfinished orders an makes their products and coupon codes available again';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -61,47 +61,47 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsOrderCleanupUnfinishedDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/order/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
+		$context->getConfig()->set('controller/common/order/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems', 'getSubManager' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems', 'getSubManager'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
-			->setMethods( array( 'unblock' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
+			->setMethods(array('unblock'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
-		\Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
+		\Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
 
 
 		$orderItem = $orderManagerStub->createItem();
-		$orderItem->setBaseId( 1 );
-		$orderItem->setId( 2 );
+		$orderItem->setBaseId(1);
+		$orderItem->setId(2);
 
 
-		$orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
-			->will( $this->returnValue( $orderBaseManagerStub ) );
+		$orderManagerStub->expects($this->once())->method('getSubManager')
+			->will($this->returnValue($orderBaseManagerStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue(array($orderItem->getId() => $orderItem)));
 
-		$orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
+		$orderBaseManagerStub->expects($this->once())->method('deleteItems');
 
-		$orderCntlStub->expects( $this->once() )->method( 'unblock' );
+		$orderCntlStub->expects($this->once())->method('unblock');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Service/Async/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Service/Payment/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Service/Delivery/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Cache/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Cache/StandardTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Cache cleanup', $this->object->getName() );
+		$this->assertEquals('Cache cleanup', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Removes the expired entries from the cache';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 

Please login to merge, or discard this patch.

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
	28	+ $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
29	29	}
30	30
31	31
		@@ -43,14 +43,14 @@ discard block
		block discarded – undo
43	43
44	44	public function testGetName()
45	45	{
46		- $this->assertEquals( 'Removes unpaid orders', $this->object->getName() );
	46	+ $this->assertEquals('Removes unpaid orders', $this->object->getName());
47	47	}
48	48
49	49
50	50	public function testGetDescription()
51	51	{
52	52	$text = 'Deletes unpaid orders to keep the database clean';
53		- $this->assertEquals( $text, $this->object->getDescription() );
	53	+ $this->assertEquals($text, $this->object->getDescription());
54	54	}
55	55
56	56
		@@ -61,47 +61,47 @@ discard block
		block discarded – undo
61	61
62	62
63	63	$name = 'ControllerJobsOrderCleanupUnpaidDefaultRun';
64		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
65		- $context->getConfig()->set( 'controller/common/order/name', $name );
	64	+ $context->getConfig()->set('mshop/order/manager/name', $name);
	65	+ $context->getConfig()->set('controller/common/order/name', $name);
66	66
67	67
68		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
69		- ->setMethods( array( 'searchItems', 'getSubManager' ) )
70		- ->setConstructorArgs( array( $context ) )
	68	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	69	+ ->setMethods(array('searchItems', 'getSubManager'))
	70	+ ->setConstructorArgs(array($context))
71	71	->getMock();
72	72
73		- $orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
74		- ->setMethods( array( 'deleteItems' ) )
75		- ->setConstructorArgs( array( $context ) )
	73	+ $orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
	74	+ ->setMethods(array('deleteItems'))
	75	+ ->setConstructorArgs(array($context))
76	76	->getMock();
77	77
78		- $orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
79		- ->setMethods( array( 'unblock' ) )
80		- ->setConstructorArgs( array( $context ) )
	78	+ $orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
	79	+ ->setMethods(array('unblock'))
	80	+ ->setConstructorArgs(array($context))
81	81	->getMock();
82	82
83	83
84		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
85		- \Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
	84	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
	85	+ \Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
86	86
87	87
88	88	$orderItem = $orderManagerStub->createItem();
89		- $orderItem->setBaseId( 1 );
90		- $orderItem->setId( 2 );
	89	+ $orderItem->setBaseId(1);
	90	+ $orderItem->setId(2);
91	91
92	92
93		- $orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
94		- ->will( $this->returnValue( $orderBaseManagerStub ) );
	93	+ $orderManagerStub->expects($this->once())->method('getSubManager')
	94	+ ->will($this->returnValue($orderBaseManagerStub));
95	95
96		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
97		- ->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
	96	+ $orderManagerStub->expects($this->once())->method('searchItems')
	97	+ ->will($this->returnValue(array($orderItem->getId() => $orderItem)));
98	98
99		- $orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
	99	+ $orderBaseManagerStub->expects($this->once())->method('deleteItems');
100	100
101		- $orderCntlStub->expects( $this->once() )->method( 'unblock' );
	101	+ $orderCntlStub->expects($this->once())->method('unblock');
102	102
103	103
104		- $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
	104	+ $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
105	105	$object->run();
106	106	}
107	107	}

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
	28	+ $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
29	29	}
30	30
31	31
		@@ -43,14 +43,14 @@ discard block
		block discarded – undo
43	43
44	44	public function testGetName()
45	45	{
46		- $this->assertEquals( 'Removes unfinished orders', $this->object->getName() );
	46	+ $this->assertEquals('Removes unfinished orders', $this->object->getName());
47	47	}
48	48
49	49
50	50	public function testGetDescription()
51	51	{
52	52	$text = 'Deletes unfinished orders an makes their products and coupon codes available again';
53		- $this->assertEquals( $text, $this->object->getDescription() );
	53	+ $this->assertEquals($text, $this->object->getDescription());
54	54	}
55	55
56	56
		@@ -61,47 +61,47 @@ discard block
		block discarded – undo
61	61
62	62
63	63	$name = 'ControllerJobsOrderCleanupUnfinishedDefaultRun';
64		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
65		- $context->getConfig()->set( 'controller/common/order/name', $name );
	64	+ $context->getConfig()->set('mshop/order/manager/name', $name);
	65	+ $context->getConfig()->set('controller/common/order/name', $name);
66	66
67	67
68		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
69		- ->setMethods( array( 'searchItems', 'getSubManager' ) )
70		- ->setConstructorArgs( array( $context ) )
	68	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	69	+ ->setMethods(array('searchItems', 'getSubManager'))
	70	+ ->setConstructorArgs(array($context))
71	71	->getMock();
72	72
73		- $orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
74		- ->setMethods( array( 'deleteItems' ) )
75		- ->setConstructorArgs( array( $context ) )
	73	+ $orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
	74	+ ->setMethods(array('deleteItems'))
	75	+ ->setConstructorArgs(array($context))
76	76	->getMock();
77	77
78		- $orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
79		- ->setMethods( array( 'unblock' ) )
80		- ->setConstructorArgs( array( $context ) )
	78	+ $orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
	79	+ ->setMethods(array('unblock'))
	80	+ ->setConstructorArgs(array($context))
81	81	->getMock();
82	82
83	83
84		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
85		- \Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
	84	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
	85	+ \Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
86	86
87	87
88	88	$orderItem = $orderManagerStub->createItem();
89		- $orderItem->setBaseId( 1 );
90		- $orderItem->setId( 2 );
	89	+ $orderItem->setBaseId(1);
	90	+ $orderItem->setId(2);
91	91
92	92
93		- $orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
94		- ->will( $this->returnValue( $orderBaseManagerStub ) );
	93	+ $orderManagerStub->expects($this->once())->method('getSubManager')
	94	+ ->will($this->returnValue($orderBaseManagerStub));
95	95
96		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
97		- ->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
	96	+ $orderManagerStub->expects($this->once())->method('searchItems')
	97	+ ->will($this->returnValue(array($orderItem->getId() => $orderItem)));
98	98
99		- $orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
	99	+ $orderBaseManagerStub->expects($this->once())->method('deleteItems');
100	100
101		- $orderCntlStub->expects( $this->once() )->method( 'unblock' );
	101	+ $orderCntlStub->expects($this->once())->method('unblock');
102	102
103	103
104		- $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
	104	+ $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
105	105	$object->run();
106	106	}
107	107	}

		@@ -16,8 +16,8 @@ discard block
		block discarded – undo
16	16	$context = \TestHelperJobs::getContext();
17	17	$aimeos = \TestHelperJobs::getAimeos();
18	18
19		- $obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos );
20		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	19	+ $obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos);
	20	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
21	21	}
22	22
23	23
		@@ -26,8 +26,8 @@ discard block
		block discarded – undo
26	26	$context = \TestHelperJobs::getContext();
27	27	$aimeos = \TestHelperJobs::getAimeos();
28	28
29		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
30		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	29	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	30	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Wrong$$$Name');
31	31	}
32	32
33	33
		@@ -36,8 +36,8 @@ discard block
		block discarded – undo
36	36	$context = \TestHelperJobs::getContext();
37	37	$aimeos = \TestHelperJobs::getAimeos();
38	38
39		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
40		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'WrongClass' );
	39	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	40	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'WrongClass');
41	41	}
42	42
43	43
		@@ -46,8 +46,8 @@ discard block
		block discarded – undo
46	46	$context = \TestHelperJobs::getContext();
47	47	$aimeos = \TestHelperJobs::getAimeos();
48	48
49		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
50		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Factory' );
	49	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	50	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Factory');
51	51	}
52	52
53	53	}

		@@ -15,8 +15,8 @@ discard block
		block discarded – undo
15	15	$context = \TestHelperJobs::getContext();
16	16	$aimeos = \TestHelperJobs::getAimeos();
17	17
18		- $obj = \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos );
19		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	18	+ $obj = \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos);
	19	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
20	20	}
21	21
22	22
		@@ -25,8 +25,8 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
29		- \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	28	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	29	+ \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'Wrong$$$Name');
30	30	}
31	31
32	32
		@@ -35,8 +35,8 @@ discard block
		block discarded – undo
35	35	$context = \TestHelperJobs::getContext();
36	36	$aimeos = \TestHelperJobs::getAimeos();
37	37
38		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
39		- \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'WrongClass' );
	38	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	39	+ \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'WrongClass');
40	40	}
41	41
42	42
		@@ -45,8 +45,8 @@ discard block
		block discarded – undo
45	45	$context = \TestHelperJobs::getContext();
46	46	$aimeos = \TestHelperJobs::getAimeos();
47	47
48		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
49		- \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'Factory' );
	48	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	49	+ \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'Factory');
50	50	}
51	51
52	52	}

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	$context = \TestHelperJobs::getContext();
25	25	$aimeos = \TestHelperJobs::getAimeos();
26	26
27		- $this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard( $context, $aimeos );
	27	+ $this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard($context, $aimeos);
28	28	}
29	29
30	30
		@@ -42,14 +42,14 @@ discard block
		block discarded – undo
42	42
43	43	public function testGetName()
44	44	{
45		- $this->assertEquals( 'Cache cleanup', $this->object->getName() );
	45	+ $this->assertEquals('Cache cleanup', $this->object->getName());
46	46	}
47	47
48	48
49	49	public function testGetDescription()
50	50	{
51	51	$text = 'Removes the expired entries from the cache';
52		- $this->assertEquals( $text, $this->object->getDescription() );
	52	+ $this->assertEquals($text, $this->object->getDescription());
53	53	}
54	54
55	55

aimeos / ai-controller-jobs

Push — master ( cbc921...0b1729 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch