Standard::import() - Code Metrics - Inspection of "Implemented customer XML importer" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 29f10b...e68c42 )

by Aimeos
created 2019-02-28 10:45 UTC
Standard::import() B

↳ Parent: Standard
Complexity

Conditions	10
Paths	10
Size

Total Lines	110
Code Lines	29
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	10
eloc	29
nc	10
nop	1
dl	0
loc	110
rs	7.6666
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2019
 * @package Controller
 * @subpackage Jobs
 */


namespace Aimeos\Controller\Jobs\Customer\Import\Xml;


/**
 * Job controller for XML customer imports
 *
 * @package Controller
 * @subpackage Jobs
 */
class Standard
	extends \Aimeos\Controller\Jobs\Base
	implements \Aimeos\Controller\Jobs\Iface
{
	use \Aimeos\Controller\Common\Common\Import\Xml\Traits;


	/**
	 * Returns the localized name of the job.
	 *
	 * @return string Name of the job
	 */
	public function getName()
	{
		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Customer import XML' );
	}


	/**
	 * Returns the localized description of the job.
	 *
	 * @return string Description of the job
	 */
	public function getDescription()
	{
		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Imports new and updates existing customers from XML files' );
	}


	/**
	 * Executes the job.
	 *
	 * @throws \Aimeos\Controller\Jobs\Exception If an error occurs
	 */
	public function run()
	{
		$context = $this->getContext();
		$config = $context->getConfig();
		$logger = $context->getLogger();

		/** controller/jobs/customer/import/xml/location
		 * File or directory where the content is stored which should be imported
		 *
		 * You need to configure the XML file or directory with the XML files that
		 * should be imported. It should be an absolute path to be sure but can be
		 * relative path if you absolutely know from where the job will be executed
		 * from.
		 *
		 * @param string Absolute file or directory path
		 * @since 2019.04
		 * @category Developer
		 * @category User
		 * @see controller/jobs/customer/import/xml/container/type
		 * @see controller/jobs/customer/import/xml/container/content
		 * @see controller/jobs/customer/import/xml/container/options
		 */
		$location = $config->get( 'controller/jobs/customer/import/xml/location' );

		try
		{
			$msg = sprintf( 'Started customer import from "%1$s" (%2$s)', $location, __CLASS__ );
			$logger->log( $msg, \Aimeos\MW\Logger\Base::INFO );

			if( !file_exists( $location ) )
			{
				$msg = sprintf( 'File or directory "%1$s" doesn\'t exist', $location );
				throw new \Aimeos\Controller\Jobs\Exception( $msg );
			}

			$files = [];

			if( is_dir( $location ) )
			{
				foreach( new \DirectoryIterator( $location ) as $entry )
				{
					if( strncmp( $entry->getFilename(), 'customer', 8 ) === 0 && $entry->getExtension() === 'xml' ) {
						$files[] = $entry->getPathname();
					}
				}
			}
			else
			{
				$files[] = $location;
			}

			sort( $files );
			$total = 0;

			foreach( $files as $filepath ) {
				$total += $this->import( $filepath );
			}

			$msg = 'Finished customer import from "%1$s": %2$s total (%3$s MB)';
			$mem = number_format( memory_get_peak_usage() / 1024 / 1024, 2 );

			$logger->log( sprintf( $msg, $location, $total, $mem ), \Aimeos\MW\Logger\Base::INFO );
		}
		catch( \Exception $e )
		{
			$logger->log( 'Customer import error: ' . $e->getMessage() . "\n" . $e->getTraceAsString() );
			throw $e;
		}
	}


	/**
	 * Imports the XML file given by its path
	 *
	 * @param $filename Absolute or relative path to the XML file
filter:
    dependency_paths: ["lib/*"]
	 * @return integer Total number of imported customers
	 */
	protected function import( $filename )
	{
		$context = $this->getContext();
		$config = $context->getConfig();
		$domains = ['customer', 'customer/address', 'customer/property', 'media', 'product', 'text'];

		/** controller/jobs/customer/import/xml/domains
		 * List of item domain names that should be retrieved along with the customer items
		 *
		 * This configuration setting overwrites the shared option
		 * "controller/common/customer/import/xml/domains" if you need a
		 * specific setting for the job controller. Otherwise, you should
		 * use the shared option for consistency.
		 *
		 * @param array Associative list of MShop item domain names
		 * @since 2019.04
		 * @category Developer
		 * @see controller/jobs/customer/import/xml/backup
		 * @see controller/jobs/customer/import/xml/max-query
		 */
		$domains = $config->get( 'controller/jobs/customer/import/xml/domains', $domains );

		/** controller/jobs/customer/import/xml/backup
		 * Name of the backup for sucessfully imported files
		 *
		 * After a XML file was imported successfully, you can move it to another
		 * location, so it won't be imported again and isn't overwritten by the
		 * next file that is stored at the same location in the file system.
		 *
		 * You should use an absolute path to be sure but can be relative path
		 * if you absolutely know from where the job will be executed from. The
		 * name of the new backup location can contain placeholders understood
		 * by the PHP strftime() function to create dynamic paths, e.g. "backup/%Y-%m-%d"
		 * which would create "backup/2000-01-01". For more information about the
		 * strftime() placeholders, please have a look into the PHP documentation of
		 * the {@link http://php.net/manual/en/function.strftime.php strftime() function}.
		 *
		 * '''Note:''' If no backup name is configured, the file or directory
		 * won't be moved away. Please make also sure that the parent directory
		 * and the new directory are writable so the file or directory could be
		 * moved.
		 *
		 * @param integer Name of the backup file, optionally with date/time placeholders
		 * @since 2019.04
		 * @category Developer
		 * @see controller/jobs/customer/import/xml/domains
		 * @see controller/jobs/customer/import/xml/max-query
		 */
		$backup = $config->get( 'controller/jobs/customer/import/xml/backup' );

		/** controller/jobs/customer/import/xml/max-query
		 * Maximum number of XML nodes processed at once
		 *
		 * Processing and fetching several customer items at once speeds up importing
		 * the XML files. The more items can be processed at once, the faster the
		 * import. More items also increases the memory usage of the importer and
		 * thus, this parameter should be low enough to avoid reaching the memory
		 * limit of the PHP process.
		 *
		 * @param integer Number of XML nodes
		 * @since 2019.04
		 * @category Developer
		 * @category User
		 * @see controller/jobs/customer/import/xml/domains
		 * @see controller/jobs/customer/import/xml/backup
		 */
		$maxquery = $config->get( 'controller/jobs/customer/import/xml/max-query', 1000 );

		$nodes = [];
		$total = $slice = 0;
		$xml = new \XMLReader();

		if( $xml->open( $filename, LIBXML_COMPACT | LIBXML_PARSEHUGE ) === false ) {
			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'No XML file "%1$s" found', $filename ) );
		}

		while( $xml->read() === true )
		{
			if( $xml->depth === 1 && $xml->nodeType === \XMLReader::ELEMENT && $xml->name === 'customeritem' )
			{
				if( ( $dom = $xml->expand() ) === false )
				{
					$msg = sprintf( 'Expanding "%1$s" node failed', 'customeritem' );
					throw new \Aimeos\Controller\Jobs\Exception( $msg );
				}

				$nodes[] = $dom;

				if( $slice++ >= $maxquery )
				{
					$this->importNodes( $nodes, $domains );
					unset( $nodes );
					$nodes = [];
					$slice = 0;
				}

				$total++;
			}
		}

		$this->importNodes( $nodes, $domains );
		unset( $nodes );

		if( !empty( $backup ) && @rename( $filename, strftime( $backup ) ) === false )
		{
			$msg = sprintf( 'Unable to move imported file "%1$s" to "%2$s"', $filename, $backup );
			throw new \Aimeos\Controller\Jobs\Exception( $msg );
		}

		return $total;
	}


	/**
	 * Imports the given DOM nodes
	 *
	 * @param \DomElement[] $nodes List of nodes to import
	 * @param string[] $ref List of domain names whose referenced items will be updated in the customer items
	 */
	protected function importNodes( array $nodes, array $ref )
	{
		$codes = $map = [];

		foreach( $nodes as $node )
		{
			if( ( $attr = $node->attributes->getNamedItem( 'ref' ) ) !== null ) {
				$codes[$attr->nodeValue] = null;
			}
		}

		$manager = \Aimeos\MShop::create( $this->getContext(), 'customer' );
		$search = $manager->createSearch()->setSlice( 0, count( $codes ) );
		$search->setConditions( $search->compare( '==', 'customer.code', array_keys( $codes ) ) );

		foreach( $manager->searchItems( $search, $ref ) as $item ) {
			$map[$item->getCode()] = $item;
		}

		foreach( $nodes as $node )
		{
			if( ( $attr = $node->attributes->getNamedItem( 'ref' ) ) !== null && isset( $map[$attr->nodeValue] ) ) {
				$item = $this->process( $map[$attr->nodeValue], $node );
			} else {
				$item = $this->process( $manager->createItem(), $node );
				$item = $this->process( /** @scrutinizer ignore-type */ $manager->createItem(), $node );
			}

			$manager->saveItem( $item );
		}
	}


	/**
	 * Updates the customer item and its referenced items using the given DOM node
	 *
	 * @param \Aimeos\MShop\Customer\Item\Iface $item Customer item object to update
	 * @param \DomElement $node DOM node used for updateding the customer item
	 * @return \Aimeos\MShop\Customer\Item\Iface $item Updated customer item object
	 */
	protected function process( \Aimeos\MShop\Customer\Item\Iface $item, \DomElement $node )
	{
		$list = [];

		foreach( $node->attributes as $attr ) {
			$list[$attr->nodeName] = $attr->nodeValue;
		}

		foreach( $node->childNodes as $tag )
		{
			if( in_array( $tag->nodeName, ['address', 'lists', 'property'] ) ) {
				$item = $this->getProcessor( $tag->nodeName )->process( $item, $tag );
			} else {
				$list[$tag->nodeName] = $tag->nodeValue;
			}
		}

		return $item->fromArray( $list, true );
	}
}

aimeos / ai-controller-jobs

Push — master ( 29f10b...e68c42 )

Standard::import() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
