Standard::process() - Code Metrics - Inspection of "Revert "Use product csv import instead of special..." - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7da6af...c0c3c8 )

by Aimeos

created 2019-08-11 10:31 UTC

Standard::process() C

↳ Parent: Standard

Complexity

Conditions	12
Paths	60

Size

Total Lines	71
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	12
eloc	40
c	3
b	0
f	0
nc	60
nop	2
dl	0
loc	71
rs	6.9666

How to fix Long Method Complexity

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2015-2018
 * @package Controller
 * @subpackage Common
 */


namespace Aimeos\Controller\Common\Product\Import\Csv\Processor\Media;


/**
 * Media processor for CSV imports
 *
 * @package Controller
 * @subpackage Common
 */
class Standard
	extends \Aimeos\Controller\Common\Product\Import\Csv\Processor\Base
	implements \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface
{
	/** controller/common/product/import/csv/processor/media/name
	 * Name of the media processor implementation
	 *
	 * Use "Myname" if your class is named "\Aimeos\Controller\Common\Product\Import\Csv\Processor\Media\Myname".
	 * The name is case-sensitive and you should avoid camel case names like "MyName".
	 *
	 * @param string Last part of the processor class name
	 * @since 2015.10
	 * @category Developer
	 */

	private $listTypes;
	private $types = [];
	private $mimes = [];


	/**
	 * Initializes the object
	 *
	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
	 * @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
	 */
	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
			\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
	{
		parent::__construct( $context, $mapping, $object );

		$this->mimes = array_flip( $context->getConfig()->get( 'controller/common/media/standard/extensions', [] ) );

		/** controller/common/product/import/csv/processor/media/listtypes
		 * Names of the product list types for media that are updated or removed
		 *
		 * If you want to associate media items manually via the administration
		 * interface to products and don't want these to be touched during the
		 * import, you can specify the product list types for these media
		 * that shouldn't be updated or removed.
		 *
		 * @param array|null List of product list type names or null for all
		 * @since 2015.05
		 * @category Developer
		 * @category User
		 * @see controller/common/product/import/csv/domains
		 * @see controller/common/product/import/csv/processor/attribute/listtypes
		 * @see controller/common/product/import/csv/processor/catalog/listtypes
		 * @see controller/common/product/import/csv/processor/product/listtypes
		 * @see controller/common/product/import/csv/processor/price/listtypes
		 * @see controller/common/product/import/csv/processor/text/listtypes
		 */
		$key = 'controller/common/product/import/csv/processor/media/listtypes';
		$this->listTypes = $context->getConfig()->get( $key );

		if( $this->listTypes === null )
		{
			$this->listTypes = [];
			$manager = \Aimeos\MShop::create( $context, 'product/lists/type' );

			$search = $manager->createSearch()->setSlice( 0, 0x7fffffff );
			$search->setConditions( $search->compare( '==', 'product.lists.type.domain', 'media' ) );

			foreach( $manager->searchItems( $search ) as $item ) {
				$this->listTypes[$item->getCode()] = $item->getCode();
			}
		}
		else
		{
			$this->listTypes = array_flip( $this->listTypes );
		}


		$manager = \Aimeos\MShop::create( $context, 'media/type' );

		$search = $manager->createSearch()->setSlice( 0, 0x7fffffff );
		$search->setConditions( $search->compare( '==', 'media.type.domain', 'product' ) );

		foreach( $manager->searchItems( $search ) as $item ) {
			$this->types[$item->getCode()] = $item->getCode();
		}
	}


	/**
	 * Saves the product related data to the storage
	 *
	 * @param \Aimeos\MShop\Product\Item\Iface $product Product item with associated items
	 * @param array $data List of CSV fields with position as key and data as value
	 * @return array List of data which hasn't been imported
	 */
	public function process( \Aimeos\MShop\Product\Item\Iface $product, array $data )
	{
		$context = $this->getContext();
		$manager = \Aimeos\MShop::create( $context, 'media' );
		$listManager = \Aimeos\MShop::create( $context, 'product/lists' );
		$separator = $context->getConfig()->get( 'controller/common/product/import/csv/separator', "\n" );

		$listMap = [];
		$map = $this->getMappedChunk( $data, $this->getMapping() );
		$listItems = $product->getListItems( 'media', $this->listTypes );

		foreach( $listItems as $listItem )
		{
			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
				$listMap[$refItem->getUrl()][$refItem->getType()][$listItem->getType()] = $listItem;
			}
		}

		foreach( $map as $pos => $list )
		{
			if( $this->checkEntry( $list ) === false ) {
				continue;
			}

			$type = $this->getValue( $list, 'media.type', 'default' );
			$listtype = $this->getValue( $list, 'product.lists.type', 'default' );
			$urls = explode( $separator, $this->getValue( $list, 'media.url', '' ) );

			if( ( $previews = $this->getValue( $list, 'media.previews' ) ) != null ) {

				$previews = explode( $separator, $previews );
			}

			foreach( $urls as $idx => $url )
			{
				$url = trim( $url );

				if( isset( $listMap[$url][$type][$listtype] ) )
				{
					$listItem = $listMap[$url][$type][$listtype];
					$refItem = $listItem->getRefItem();
					unset( $listItems[$listItem->getId()] );
				}
				else
				{
					$listItem = $listManager->createItem()->setType( $listtype );
					$refItem = $manager->createItem()->setType( $type );
				}

				$ext = pathinfo( $url, PATHINFO_EXTENSION );
				if( isset( $this->mimes[$ext] ) ) {
					$refItem->setMimeType( $this->mimes[$ext] );
				}

				if( is_array( $previews ) && isset( $previews[$idx] )
					&& ( $map = json_decode( $previews[$idx], true ) ) !== null
				) {
					$list['media.previews'] = $map;
				} else {
					$refItem->setPreview( $url );
				}

				$listItem = $listItem->setPosition( $pos++ )->fromArray( $list );
				$refItem = $refItem->setLabel( $url )->fromArray( $list )->setUrl( $url );

				$product->addListItem( 'media', $listItem, $refItem );
			}
		}

		$product->deleteListItems( $listItems, true );

		return $this->getObject()->process( $product, $data );
	}


	/**
	 * Checks if an entry can be used for updating a media item
	 *
	 * @param array $list Associative list of key/value pairs from the mapping
	 * @return boolean True if valid, false if not
	 */
	protected function checkEntry( array $list )
	{
		if( $this->getValue( $list, 'media.url' ) === null ) {
			return false;
		}

		if( ( $type = $this->getValue( $list, 'product.lists.type' ) ) && !isset( $this->listTypes[$type] ) )
		{
			$msg = sprintf( 'Invalid type "%1$s" (%2$s)', $type, 'product list' );
			throw new \Aimeos\Controller\Common\Exception( $msg );
		}

		if( ( $type = $this->getValue( $list, 'media.type' ) ) && !isset( $this->types[$type] ) )
		{
			$msg = sprintf( 'Invalid type "%1$s" (%2$s)', $type, 'media' );
			throw new \Aimeos\Controller\Common\Exception( $msg );
		}

		return true;
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2015-2018
6			* @package Controller
7			* @subpackage Common
8			*/
9
10
11			namespace Aimeos\Controller\Common\Product\Import\Csv\Processor\Media;
12
13
14			/**
15			* Media processor for CSV imports
16			*
17			* @package Controller
18			* @subpackage Common
19			*/
20			class Standard
21			extends \Aimeos\Controller\Common\Product\Import\Csv\Processor\Base
22			implements \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface
23			{
24			/** controller/common/product/import/csv/processor/media/name
25			* Name of the media processor implementation
26			*
27			* Use "Myname" if your class is named "\Aimeos\Controller\Common\Product\Import\Csv\Processor\Media\Myname".
28			* The name is case-sensitive and you should avoid camel case names like "MyName".
29			*
30			* @param string Last part of the processor class name
31			* @since 2015.10
32			* @category Developer
33			*/
34
35			private $listTypes;
36			private $types = [];
37			private $mimes = [];
38
39
40			/**
41			* Initializes the object
42			*
43			* @param \Aimeos\MShop\Context\Item\Iface $context Context object
44			* @param array $mapping Associative list of field position in CSV as key and domain item key as value
45			* @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
46			*/
47			public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
48			\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
49			{
50			parent::__construct( $context, $mapping, $object );
51
52			$this->mimes = array_flip( $context->getConfig()->get( 'controller/common/media/standard/extensions', [] ) );
53
54			/** controller/common/product/import/csv/processor/media/listtypes
55			* Names of the product list types for media that are updated or removed
56			*
57			* If you want to associate media items manually via the administration
58			* interface to products and don't want these to be touched during the
59			* import, you can specify the product list types for these media
60			* that shouldn't be updated or removed.
61			*
62			* @param array\|null List of product list type names or null for all
63			* @since 2015.05
64			* @category Developer
65			* @category User
66			* @see controller/common/product/import/csv/domains
67			* @see controller/common/product/import/csv/processor/attribute/listtypes
68			* @see controller/common/product/import/csv/processor/catalog/listtypes
69			* @see controller/common/product/import/csv/processor/product/listtypes
70			* @see controller/common/product/import/csv/processor/price/listtypes
71			* @see controller/common/product/import/csv/processor/text/listtypes
72			*/
73			$key = 'controller/common/product/import/csv/processor/media/listtypes';
74			$this->listTypes = $context->getConfig()->get( $key );
75
76			if( $this->listTypes === null )
77			{
78			$this->listTypes = [];
79			$manager = \Aimeos\MShop::create( $context, 'product/lists/type' );
80
81			$search = $manager->createSearch()->setSlice( 0, 0x7fffffff );
82			$search->setConditions( $search->compare( '==', 'product.lists.type.domain', 'media' ) );
83
84			foreach( $manager->searchItems( $search ) as $item ) {
85			$this->listTypes[$item->getCode()] = $item->getCode();
86			}
87			}
88			else
89			{
90			$this->listTypes = array_flip( $this->listTypes );
91			}
92
93
94			$manager = \Aimeos\MShop::create( $context, 'media/type' );
95
96			$search = $manager->createSearch()->setSlice( 0, 0x7fffffff );
97			$search->setConditions( $search->compare( '==', 'media.type.domain', 'product' ) );
98
99			foreach( $manager->searchItems( $search ) as $item ) {
100			$this->types[$item->getCode()] = $item->getCode();
101			}
102			}
103
104
105			/**
106			* Saves the product related data to the storage
107			*
108			* @param \Aimeos\MShop\Product\Item\Iface $product Product item with associated items
109			* @param array $data List of CSV fields with position as key and data as value
110			* @return array List of data which hasn't been imported
111			*/
112			public function process( \Aimeos\MShop\Product\Item\Iface $product, array $data )
113			{
114			$context = $this->getContext();
115			$manager = \Aimeos\MShop::create( $context, 'media' );
116			$listManager = \Aimeos\MShop::create( $context, 'product/lists' );
117			$separator = $context->getConfig()->get( 'controller/common/product/import/csv/separator', "\n" );
118
119			$listMap = [];
120			$map = $this->getMappedChunk( $data, $this->getMapping() );
121			$listItems = $product->getListItems( 'media', $this->listTypes );
122
123			foreach( $listItems as $listItem )
124			{
125			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
126			$listMap[$refItem->getUrl()][$refItem->getType()][$listItem->getType()] = $listItem;
127			}
128			}
129
130			foreach( $map as $pos => $list )
131			{
132			if( $this->checkEntry( $list ) === false ) {
133			continue;
134			}
135
136			$type = $this->getValue( $list, 'media.type', 'default' );
137			$listtype = $this->getValue( $list, 'product.lists.type', 'default' );
138			$urls = explode( $separator, $this->getValue( $list, 'media.url', '' ) );
139
140			if( ( $previews = $this->getValue( $list, 'media.previews' ) ) != null ) {
			0 ignored issues – show Bug introduced 2019-08-11 10:34 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$previews = $this->getVa...list, 'media.previews')` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `!==` instead. Loading history...
141			$previews = explode( $separator, $previews );
142			}
143
144			foreach( $urls as $idx => $url )
145			{
146			$url = trim( $url );
147
148			if( isset( $listMap[$url][$type][$listtype] ) )
149			{
150			$listItem = $listMap[$url][$type][$listtype];
151			$refItem = $listItem->getRefItem();
152			unset( $listItems[$listItem->getId()] );
153			}
154			else
155			{
156			$listItem = $listManager->createItem()->setType( $listtype );
157			$refItem = $manager->createItem()->setType( $type );
158			}
159
160			$ext = pathinfo( $url, PATHINFO_EXTENSION );
161			if( isset( $this->mimes[$ext] ) ) {
162			$refItem->setMimeType( $this->mimes[$ext] );
163			}
164
165			if( is_array( $previews ) && isset( $previews[$idx] )
166			&& ( $map = json_decode( $previews[$idx], true ) ) !== null
167			) {
168			$list['media.previews'] = $map;
169			} else {
170			$refItem->setPreview( $url );
171			}
172
173			$listItem = $listItem->setPosition( $pos++ )->fromArray( $list );
174			$refItem = $refItem->setLabel( $url )->fromArray( $list )->setUrl( $url );
175
176			$product->addListItem( 'media', $listItem, $refItem );
177			}
178			}
179
180			$product->deleteListItems( $listItems, true );
181
182			return $this->getObject()->process( $product, $data );
183			}
184
185
186			/**
187			* Checks if an entry can be used for updating a media item
188			*
189			* @param array $list Associative list of key/value pairs from the mapping
190			* @return boolean True if valid, false if not
191			*/
192			protected function checkEntry( array $list )
193			{
194			if( $this->getValue( $list, 'media.url' ) === null ) {
195			return false;
196			}
197
198			if( ( $type = $this->getValue( $list, 'product.lists.type' ) ) && !isset( $this->listTypes[$type] ) )
199			{
200			$msg = sprintf( 'Invalid type "%1$s" (%2$s)', $type, 'product list' );
201			throw new \Aimeos\Controller\Common\Exception( $msg );
202			}
203
204			if( ( $type = $this->getValue( $list, 'media.type' ) ) && !isset( $this->types[$type] ) )
205			{
206			$msg = sprintf( 'Invalid type "%1$s" (%2$s)', $type, 'media' );
207			throw new \Aimeos\Controller\Common\Exception( $msg );
208			}
209
210			return true;
211			}
212			}
213

aimeos / ai-controller-jobs

Push — master ( 7da6af...c0c3c8 )

Standard::process() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like