aimeos / ai-controller-jobs

controller/jobs/src/Controller/Jobs/Order/Export/Csv/Factory.php

Spacing +6 added lines, -6 removed lines

@@ -29,7 +29,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/order/export/csv/name
 		 * Class name of the used order suggestions scheduler controller implementation
@@ -64,20 +64,20 @@ 
 		 * @since 2015.01
 		 * @category Developer
 		 */
-		if ( $name === null ) {
+		if ($name === null) {
 			$name = $context->getConfig()->get('controller/jobs/order/export/csv/name', 'Standard');
 		}
 
-		if ( ctype_alnum($name) === false )
+		if (ctype_alnum($name) === false)
 		{
 			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Order\\Export\\Csv\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Order\\Export\\Csv\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/order/export/csv/decorators/excludes
 		 * Excludes decorators added by the "common" option from the order export CSV job controller
@@ -154,6 +154,6 @@ 
 		 * @see controller/jobs/order/export/csv/decorators/excludes
 		 * @see controller/jobs/order/export/csv/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'order/export/csv' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'order/export/csv');
 	}
 }
\ No newline at end of file

controller/common/tests/Controller/Common/Order/Export/Csv/Processor/Coupon/StandardTest.php

Spacing +15 added lines, -15 removed lines

@@ -18,37 +18,37 @@
 		);
 
 
-		$object = new \Aimeos\Controller\Common\Order\Export\Csv\Processor\Coupon\Standard( $context, $mapping );
+		$object = new \Aimeos\Controller\Common\Order\Export\Csv\Processor\Coupon\Standard($context, $mapping);
 
-		$invoice = $this->getInvoice( $context );
-		$order = \Aimeos\MShop\Factory::createManager( $context, 'order/base' )->load( $invoice->getBaseId() );
+		$invoice = $this->getInvoice($context);
+		$order = \Aimeos\MShop\Factory::createManager($context, 'order/base')->load($invoice->getBaseId());
 
-		$data = $object->process( $invoice, $order );
+		$data = $object->process($invoice, $order);
 
 
-		$this->assertEquals( 2, count( $data ) );
+		$this->assertEquals(2, count($data));
 
-		$this->assertEquals( 1, count( $data[0] ) );
-		$this->assertEquals( '5678', $data[0][0] );
+		$this->assertEquals(1, count($data[0]));
+		$this->assertEquals('5678', $data[0][0]);
 
-		$this->assertEquals( 1, count( $data[1] ) );
-		$this->assertEquals( 'OPQR', $data[1][0] );
+		$this->assertEquals(1, count($data[1]));
+		$this->assertEquals('OPQR', $data[1][0]);
 	}
 
 
-	protected function getInvoice( $context )
+	protected function getInvoice($context)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order');
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'order.datepayment', '2008-02-15 12:34:56' ) );
+		$search->setConditions($search->compare('==', 'order.datepayment', '2008-02-15 12:34:56'));
 
-		$items = $manager->searchItems( $search );
+		$items = $manager->searchItems($search);
 
-		if( ( $item = reset( $items ) ) !== false ) {
+		if (($item = reset($items)) !== false) {
 			return $item;
 		}
 
-		throw new \Exception( 'No order item found' );
+		throw new \Exception('No order item found');
 	}
 }

controller/common/tests/Controller/Common/Order/Export/Csv/Processor/Address/StandardTest.php

Spacing +61 added lines, -61 removed lines

@@ -38,77 +38,77 @@
 		);
 
 
-		$object = new \Aimeos\Controller\Common\Order\Export\Csv\Processor\Address\Standard( $context, $mapping );
-
-		$invoice = $this->getInvoice( $context );
-		$order = \Aimeos\MShop\Factory::createManager( $context, 'order/base' )->load( $invoice->getBaseId() );
-
-		$data = $object->process( $invoice, $order );
-
-
-		$this->assertEquals( 2, count( $data ) );
-
-		$this->assertEquals( 21, count( $data[0] ) );
-		$this->assertEquals( 'payment', $data[0][0] );
-		$this->assertEquals( 'mr', $data[0][1] );
-		$this->assertEquals( '', $data[0][2] );
-		$this->assertEquals( '', $data[0][3] );
-		$this->assertEquals( '', $data[0][4] );
-		$this->assertEquals( 'Our', $data[0][5] );
-		$this->assertEquals( 'Unittest', $data[0][6] );
-		$this->assertEquals( 'Durchschnitt', $data[0][7] );
-		$this->assertEquals( '1', $data[0][8] );
-		$this->assertEquals( '', $data[0][9] );
-		$this->assertEquals( '20146', $data[0][10] );
-		$this->assertEquals( 'Hamburg', $data[0][11] );
-		$this->assertEquals( 'Hamburg', $data[0][12] );
-		$this->assertEquals( 'DE', $data[0][13] );
-		$this->assertEquals( 'de', $data[0][14] );
-		$this->assertEquals( '055544332211', $data[0][15] );
-		$this->assertEquals( '055544332213', $data[0][16] );
-		$this->assertEquals( 'test@example.com', $data[0][17] );
-		$this->assertEquals( 'www.metaways.net', $data[0][18] );
-		$this->assertEquals( '11.000000', $data[0][19] );
-		$this->assertEquals( '52.000000', $data[0][20] );
-
-		$this->assertEquals( 21, count( $data[1] ) );
-		$this->assertEquals( 'delivery', $data[1][0] );
-		$this->assertEquals( 'mr', $data[1][1] );
-		$this->assertEquals( 'Example company', $data[1][2] );
-		$this->assertEquals( 'DE999999999', $data[1][3] );
-		$this->assertEquals( 'Dr.', $data[1][4] );
-		$this->assertEquals( 'Our', $data[1][5] );
-		$this->assertEquals( 'Unittest', $data[1][6] );
-		$this->assertEquals( 'Pickhuben', $data[1][7] );
-		$this->assertEquals( '2-4', $data[1][8] );
-		$this->assertEquals( '', $data[1][9] );
-		$this->assertEquals( '20457', $data[1][10] );
-		$this->assertEquals( 'Hamburg', $data[1][11] );
-		$this->assertEquals( 'Hamburg', $data[1][12] );
-		$this->assertEquals( 'DE', $data[1][13] );
-		$this->assertEquals( 'de', $data[1][14] );
-		$this->assertEquals( '055544332211', $data[1][15] );
-		$this->assertEquals( '055544332212', $data[1][16] );
-		$this->assertEquals( 'test@example.com', $data[1][17] );
-		$this->assertEquals( 'www.example.com', $data[1][18] );
-		$this->assertEquals( '10.000000', $data[1][19] );
-		$this->assertEquals( '50.000000', $data[1][20] );
+		$object = new \Aimeos\Controller\Common\Order\Export\Csv\Processor\Address\Standard($context, $mapping);
+
+		$invoice = $this->getInvoice($context);
+		$order = \Aimeos\MShop\Factory::createManager($context, 'order/base')->load($invoice->getBaseId());
+
+		$data = $object->process($invoice, $order);
+
+
+		$this->assertEquals(2, count($data));
+
+		$this->assertEquals(21, count($data[0]));
+		$this->assertEquals('payment', $data[0][0]);
+		$this->assertEquals('mr', $data[0][1]);
+		$this->assertEquals('', $data[0][2]);
+		$this->assertEquals('', $data[0][3]);
+		$this->assertEquals('', $data[0][4]);
+		$this->assertEquals('Our', $data[0][5]);
+		$this->assertEquals('Unittest', $data[0][6]);
+		$this->assertEquals('Durchschnitt', $data[0][7]);
+		$this->assertEquals('1', $data[0][8]);
+		$this->assertEquals('', $data[0][9]);
+		$this->assertEquals('20146', $data[0][10]);
+		$this->assertEquals('Hamburg', $data[0][11]);
+		$this->assertEquals('Hamburg', $data[0][12]);
+		$this->assertEquals('DE', $data[0][13]);
+		$this->assertEquals('de', $data[0][14]);
+		$this->assertEquals('055544332211', $data[0][15]);
+		$this->assertEquals('055544332213', $data[0][16]);
+		$this->assertEquals('test@example.com', $data[0][17]);
+		$this->assertEquals('www.metaways.net', $data[0][18]);
+		$this->assertEquals('11.000000', $data[0][19]);
+		$this->assertEquals('52.000000', $data[0][20]);
+
+		$this->assertEquals(21, count($data[1]));
+		$this->assertEquals('delivery', $data[1][0]);
+		$this->assertEquals('mr', $data[1][1]);
+		$this->assertEquals('Example company', $data[1][2]);
+		$this->assertEquals('DE999999999', $data[1][3]);
+		$this->assertEquals('Dr.', $data[1][4]);
+		$this->assertEquals('Our', $data[1][5]);
+		$this->assertEquals('Unittest', $data[1][6]);
+		$this->assertEquals('Pickhuben', $data[1][7]);
+		$this->assertEquals('2-4', $data[1][8]);
+		$this->assertEquals('', $data[1][9]);
+		$this->assertEquals('20457', $data[1][10]);
+		$this->assertEquals('Hamburg', $data[1][11]);
+		$this->assertEquals('Hamburg', $data[1][12]);
+		$this->assertEquals('DE', $data[1][13]);
+		$this->assertEquals('de', $data[1][14]);
+		$this->assertEquals('055544332211', $data[1][15]);
+		$this->assertEquals('055544332212', $data[1][16]);
+		$this->assertEquals('test@example.com', $data[1][17]);
+		$this->assertEquals('www.example.com', $data[1][18]);
+		$this->assertEquals('10.000000', $data[1][19]);
+		$this->assertEquals('50.000000', $data[1][20]);
 	}
 
 
-	protected function getInvoice( $context )
+	protected function getInvoice($context)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order');
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'order.datepayment', '2008-02-15 12:34:56' ) );
+		$search->setConditions($search->compare('==', 'order.datepayment', '2008-02-15 12:34:56'));
 
-		$items = $manager->searchItems( $search );
+		$items = $manager->searchItems($search);
 
-		if( ( $item = reset( $items ) ) !== false ) {
+		if (($item = reset($items)) !== false) {
 			return $item;
 		}
 
-		throw new \Exception( 'No order item found' );
+		throw new \Exception('No order item found');
 	}
 }

controller/common/src/Controller/Common/Order/Export/Csv/Processor/Coupon/Standard.php

Spacing +4 added lines, -4 removed lines

@@ -40,17 +40,17 @@
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
 	{
 		$result = [];
 
-		foreach( $order->getCoupons() as $code => $products )
+		foreach ($order->getCoupons() as $code => $products)
 		{
 			$data = [];
 
-			foreach( $this->getMapping() as $pos => $key )
+			foreach ($this->getMapping() as $pos => $key)
 			{
-				if( $key === 'order.base.coupon.code' ) {
+				if ($key === 'order.base.coupon.code') {
 					$data[$pos] = $code;
 				} else {
 					$data[$pos] = '';

controller/common/src/Controller/Common/Order/Export/Csv/Processor/Base.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping)
 	{
 		$this->context = $context;
 		$this->mapping = $mapping;

controller/common/src/Controller/Common/Order/Export/Csv/Processor/Address/Standard.php

Spacing +6 added lines, -6 removed lines

@@ -40,28 +40,28 @@
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
 	{
 		$result = [];
 		$addresses = $order->getAddresses();
 
-		krsort( $addresses );
+		krsort($addresses);
 
-		foreach( $addresses as $item )
+		foreach ($addresses as $item)
 		{
 			$data = [];
 			$list = $item->toArray();
 
-			foreach( $this->getMapping() as $pos => $key )
+			foreach ($this->getMapping() as $pos => $key)
 			{
-				if( array_key_exists( $key, $list ) ) {
+				if (array_key_exists($key, $list)) {
 					$data[$pos] = $list[$key];
 				} else {
 					$data[$pos] = '';
 				}
 			}
 
-			ksort( $data );
+			ksort($data);
 			$result[] = $data;
 		}
 

controller/common/src/Controller/Common/Order/Export/Csv/Processor/Invoice/Standard.php

Spacing +4 added lines, -4 removed lines

@@ -40,21 +40,21 @@
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order )
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order)
 	{
 		$result = [];
 		$list = $invoice->toArray() + $order->toArray();
 
-		foreach( $this->getMapping() as $pos => $key )
+		foreach ($this->getMapping() as $pos => $key)
 		{
-			if( array_key_exists( $key, $list ) ) {
+			if (array_key_exists($key, $list)) {
 				$result[$pos] = $list[$key];
 			} else {
 				$result[$pos] = '';
 			}
 		}
 
-		ksort( $result );
+		ksort($result);
 
 		return [$result];
 	}

controller/common/src/Controller/Common/Order/Export/Csv/Processor/Iface.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping );
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping);
 
 
 	/**
@@ -35,5 +35,5 @@ 
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $order Full order with associated items
 	 * @return array Two dimensional associative list of order data representing the lines in CSV
 	 */
-	public function process( \Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order );
+	public function process(\Aimeos\MShop\Order\Item\Iface $invoice, \Aimeos\MShop\Order\Item\Base\Iface $order);
 }
\ No newline at end of file

controller/common/src/Controller/Common/Coupon/Import/Csv/Processor/Base.php

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 	 * Initializes the object
 	 *
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
-	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
+	 * @param string[] $mapping Associative list of field position in CSV as key and domain item key as value
 	 * @param \Aimeos\Controller\Common\Coupon\Import\Csv\Processor\Iface $object Decorated processor
 	 */
 	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,

Spacing +4 added lines, -4 removed lines

@@ -32,8 +32,8 @@ 
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 * @param \Aimeos\Controller\Common\Coupon\Import\Csv\Processor\Iface $object Decorated processor
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
-		\Aimeos\Controller\Common\Coupon\Import\Csv\Processor\Iface $object = null )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping,
+		\Aimeos\Controller\Common\Coupon\Import\Csv\Processor\Iface $object = null)
 	{
 		$this->context = $context;
 		$this->mapping = $mapping;
@@ -71,8 +71,8 @@ 
 	 */
 	protected function getObject()
 	{
-		if( $this->object === null ) {
-			throw new \Aimeos\Controller\Jobs\Exception( 'No processor object available' );
+		if ($this->object === null) {
+			throw new \Aimeos\Controller\Jobs\Exception('No processor object available');
 		}
 
 		return $this->object;