Inspection of "Use getValue() method for retrieving CSV content" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9b00f...475749 )

by Aimeos

created 2018-12-21 12:08 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/product/export/sitemap/name
 		 * Class name of the used product suggestions scheduler controller implementation
@@ -64,20 +64,20 @@  discard block
 block discarded – undo
 		 * @since 2015.01
 		 * @category Developer
 		 */
-		if ( $name === null ) {
+		if ($name === null) {
 			$name = $context->getConfig()->get('controller/jobs/product/export/sitemap/name', 'Standard');
 		}
 
-		if ( ctype_alnum($name) === false )
+		if (ctype_alnum($name) === false)
 		{
 			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Product\\Export\\Sitemap\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Product\\Export\\Sitemap\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/product/export/sitemap/decorators/excludes
 		 * Excludes decorators added by the "common" option from the product export sitemap job controller
@@ -154,6 +154,6 @@  discard block
 block discarded – undo
 		 * @see controller/jobs/product/export/sitemap/export/sitemap/decorators/excludes
 		 * @see controller/jobs/product/export/sitemap/export/sitemap/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'product/export/sitemap' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'product/export/sitemap');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/src/Controller/Jobs/Product/Bought/Factory.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/product/bought/name
 		 * Class name of the used product suggestions scheduler controller implementation
@@ -65,20 +65,20 @@  discard block
 block discarded – undo
 		 * @since 2014.03
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/product/bought/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/product/bought/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Product\\Bought\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Product\\Bought\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Product\\Bought\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/product/bought/decorators/excludes
 		 * Excludes decorators added by the "common" option from the product bought job controller
@@ -155,6 +155,6 @@  discard block
 block discarded – undo
 		 * @see controller/jobs/product/bought/decorators/excludes
 		 * @see controller/jobs/product/bought/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'product/bought' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'product/bought');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/src/Controller/Jobs/Product/Import/Csv/Factory.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/product/import/csv/name
 		 * Class name of the used product suggestions scheduler controller implementation
@@ -64,20 +64,20 @@  discard block
 block discarded – undo
 		 * @since 2015.01
 		 * @category Developer
 		 */
-		if ( $name === null ) {
+		if ($name === null) {
 			$name = $context->getConfig()->get('controller/jobs/product/import/csv/name', 'Standard');
 		}
 
-		if ( ctype_alnum($name) === false )
+		if (ctype_alnum($name) === false)
 		{
 			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Product\\Import\\Csv\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Product\\Import\\Csv\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/product/import/csv/decorators/excludes
 		 * Excludes decorators added by the "common" option from the product import CSV job controller
@@ -154,6 +154,6 @@  discard block
 block discarded – undo
 		 * @see controller/jobs/product/import/csv/decorators/excludes
 		 * @see controller/jobs/product/import/csv/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'product/import/csv' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'product/import/csv');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/tests/bootstrap.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -11,22 +11,22 @@
 block discarded – undo
  * Set error reporting to maximum
  */
 error_reporting( -1 );
-ini_set( 'display_errors', '1' );
+ini_set('display_errors', '1');
 
-date_default_timezone_set( 'UTC' );
+date_default_timezone_set('UTC');
 
 /**
  * Set locale settings to reasonable defaults
  */
-setlocale( LC_ALL, 'en_US.UTF-8' );
-setlocale( LC_NUMERIC, 'POSIX' );
-setlocale( LC_CTYPE, 'en_US.UTF-8' );
-setlocale( LC_TIME, 'POSIX' );
+setlocale(LC_ALL, 'en_US.UTF-8');
+setlocale(LC_NUMERIC, 'POSIX');
+setlocale(LC_CTYPE, 'en_US.UTF-8');
+setlocale(LC_TIME, 'POSIX');
 
 /*
  * Set include path for tests
  */
-define( 'PATH_TESTS', __DIR__ );
+define('PATH_TESTS', __DIR__);
 
 require_once 'TestHelperJobs.php';
 \TestHelperJobs::bootstrap();

Please login to merge, or discard this patch.

controller/jobs/tests/config/controller.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -4,11 +4,11 @@
 block discarded – undo
 	'jobs' => array(
 		'product' => array(
 			'export' => array(
-				'location' => dirname( __DIR__ ) . DIRECTORY_SEPARATOR . 'tmp',
+				'location' => dirname(__DIR__) . DIRECTORY_SEPARATOR . 'tmp',
 				'max-items' => 15,
 				'max-query' => 5,
 				'sitemap' => array(
-					'location' => dirname( __DIR__ ) . DIRECTORY_SEPARATOR . 'tmp',
+					'location' => dirname(__DIR__) . DIRECTORY_SEPARATOR . 'tmp',
 					'max-items' => 15,
 					'max-query' => 5,
 				),

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Cleanup/Unpaid/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Cleanup/Unpaid/StandardTest.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
 	}
 
 
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Removes unpaid orders', $this->object->getName() );
+		$this->assertEquals('Removes unpaid orders', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Deletes unpaid orders to keep the database clean';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -61,47 +61,47 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsOrderCleanupUnpaidDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/order/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
+		$context->getConfig()->set('controller/common/order/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems', 'getSubManager' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems', 'getSubManager'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
-		->setMethods( array( 'unblock' ) )
-		->setConstructorArgs( array( $context ) )
+		$orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
+		->setMethods(array('unblock'))
+		->setConstructorArgs(array($context))
 		->getMock();
 
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
-		\Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
+		\Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
 
 
 		$orderItem = $orderManagerStub->createItem();
-		$orderItem->setBaseId( 1 );
-		$orderItem->setId( 2 );
+		$orderItem->setBaseId(1);
+		$orderItem->setId(2);
 
 
-		$orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
-			->will( $this->returnValue( $orderBaseManagerStub ) );
+		$orderManagerStub->expects($this->once())->method('getSubManager')
+			->will($this->returnValue($orderBaseManagerStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue(array($orderItem->getId() => $orderItem)));
 
-		$orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
+		$orderBaseManagerStub->expects($this->once())->method('deleteItems');
 
-		$orderCntlStub->expects( $this->once() )->method( 'unblock' );
+		$orderCntlStub->expects($this->once())->method('unblock');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Cleanup/Unfinished/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Cleanup/Unfinished/StandardTest.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
 	}
 
 
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Removes unfinished orders', $this->object->getName() );
+		$this->assertEquals('Removes unfinished orders', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Deletes unfinished orders an makes their products and coupon codes available again';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -61,47 +61,47 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsOrderCleanupUnfinishedDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/order/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
+		$context->getConfig()->set('controller/common/order/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems', 'getSubManager' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems', 'getSubManager'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
-			->setMethods( array( 'unblock' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
+			->setMethods(array('unblock'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
-		\Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
+		\Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
 
 
 		$orderItem = $orderManagerStub->createItem();
-		$orderItem->setBaseId( 1 );
-		$orderItem->setId( 2 );
+		$orderItem->setBaseId(1);
+		$orderItem->setId(2);
 
 
-		$orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
-			->will( $this->returnValue( $orderBaseManagerStub ) );
+		$orderManagerStub->expects($this->once())->method('getSubManager')
+			->will($this->returnValue($orderBaseManagerStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue(array($orderItem->getId() => $orderItem)));
 
-		$orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
+		$orderBaseManagerStub->expects($this->once())->method('deleteItems');
 
-		$orderCntlStub->expects( $this->once() )->method( 'unblock' );
+		$orderCntlStub->expects($this->once())->method('unblock');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	* @param string\|null $name Name of the controller or "Standard" if null
31	31	* @return \Aimeos\Controller\Jobs\Iface New controller object
32	32	*/
33		- public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
	33	+ public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
34	34	{
35	35	/** controller/jobs/product/bought/name
36	36	* Class name of the used product suggestions scheduler controller implementation
		@@ -65,20 +65,20 @@ discard block
		block discarded – undo
65	65	* @since 2014.03
66	66	* @category Developer
67	67	*/
68		- if( $name === null ) {
69		- $name = $context->getConfig()->get( 'controller/jobs/product/bought/name', 'Standard' );
	68	+ if ($name === null) {
	69	+ $name = $context->getConfig()->get('controller/jobs/product/bought/name', 'Standard');
70	70	}
71	71
72		- if( ctype_alnum( $name ) === false )
	72	+ if (ctype_alnum($name) === false)
73	73	{
74		- $classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Product\\Bought\\' . $name : '<not a string>';
75		- throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
	74	+ $classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Product\\Bought\\' . $name : '<not a string>';
	75	+ throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
76	76	}
77	77
78	78	$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
79	79	$classname = '\\Aimeos\\Controller\\Jobs\\Product\\Bought\\' . $name;
80	80
81		- $controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
	81	+ $controller = self::createControllerBase($context, $aimeos, $classname, $iface);
82	82
83	83	/** controller/jobs/product/bought/decorators/excludes
84	84	* Excludes decorators added by the "common" option from the product bought job controller
		@@ -155,6 +155,6 @@ discard block
		block discarded – undo
155	155	* @see controller/jobs/product/bought/decorators/excludes
156	156	* @see controller/jobs/product/bought/decorators/global
157	157	*/
158		- return self::addControllerDecorators( $context, $aimeos, $controller, 'product/bought' );
	158	+ return self::addControllerDecorators($context, $aimeos, $controller, 'product/bought');
159	159	}
160	160	}
161	161	\ No newline at end of file

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
	28	+ $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
29	29	}
30	30
31	31
		@@ -43,14 +43,14 @@ discard block
		block discarded – undo
43	43
44	44	public function testGetName()
45	45	{
46		- $this->assertEquals( 'Removes unpaid orders', $this->object->getName() );
	46	+ $this->assertEquals('Removes unpaid orders', $this->object->getName());
47	47	}
48	48
49	49
50	50	public function testGetDescription()
51	51	{
52	52	$text = 'Deletes unpaid orders to keep the database clean';
53		- $this->assertEquals( $text, $this->object->getDescription() );
	53	+ $this->assertEquals($text, $this->object->getDescription());
54	54	}
55	55
56	56
		@@ -61,47 +61,47 @@ discard block
		block discarded – undo
61	61
62	62
63	63	$name = 'ControllerJobsOrderCleanupUnpaidDefaultRun';
64		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
65		- $context->getConfig()->set( 'controller/common/order/name', $name );
	64	+ $context->getConfig()->set('mshop/order/manager/name', $name);
	65	+ $context->getConfig()->set('controller/common/order/name', $name);
66	66
67	67
68		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
69		- ->setMethods( array( 'searchItems', 'getSubManager' ) )
70		- ->setConstructorArgs( array( $context ) )
	68	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	69	+ ->setMethods(array('searchItems', 'getSubManager'))
	70	+ ->setConstructorArgs(array($context))
71	71	->getMock();
72	72
73		- $orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
74		- ->setMethods( array( 'deleteItems' ) )
75		- ->setConstructorArgs( array( $context ) )
	73	+ $orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
	74	+ ->setMethods(array('deleteItems'))
	75	+ ->setConstructorArgs(array($context))
76	76	->getMock();
77	77
78		- $orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
79		- ->setMethods( array( 'unblock' ) )
80		- ->setConstructorArgs( array( $context ) )
	78	+ $orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
	79	+ ->setMethods(array('unblock'))
	80	+ ->setConstructorArgs(array($context))
81	81	->getMock();
82	82
83	83
84		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
85		- \Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
	84	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
	85	+ \Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
86	86
87	87
88	88	$orderItem = $orderManagerStub->createItem();
89		- $orderItem->setBaseId( 1 );
90		- $orderItem->setId( 2 );
	89	+ $orderItem->setBaseId(1);
	90	+ $orderItem->setId(2);
91	91
92	92
93		- $orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
94		- ->will( $this->returnValue( $orderBaseManagerStub ) );
	93	+ $orderManagerStub->expects($this->once())->method('getSubManager')
	94	+ ->will($this->returnValue($orderBaseManagerStub));
95	95
96		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
97		- ->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
	96	+ $orderManagerStub->expects($this->once())->method('searchItems')
	97	+ ->will($this->returnValue(array($orderItem->getId() => $orderItem)));
98	98
99		- $orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
	99	+ $orderBaseManagerStub->expects($this->once())->method('deleteItems');
100	100
101		- $orderCntlStub->expects( $this->once() )->method( 'unblock' );
	101	+ $orderCntlStub->expects($this->once())->method('unblock');
102	102
103	103
104		- $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
	104	+ $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
105	105	$object->run();
106	106	}
107	107	}

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
	28	+ $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
29	29	}
30	30
31	31
		@@ -43,14 +43,14 @@ discard block
		block discarded – undo
43	43
44	44	public function testGetName()
45	45	{
46		- $this->assertEquals( 'Removes unfinished orders', $this->object->getName() );
	46	+ $this->assertEquals('Removes unfinished orders', $this->object->getName());
47	47	}
48	48
49	49
50	50	public function testGetDescription()
51	51	{
52	52	$text = 'Deletes unfinished orders an makes their products and coupon codes available again';
53		- $this->assertEquals( $text, $this->object->getDescription() );
	53	+ $this->assertEquals($text, $this->object->getDescription());
54	54	}
55	55
56	56
		@@ -61,47 +61,47 @@ discard block
		block discarded – undo
61	61
62	62
63	63	$name = 'ControllerJobsOrderCleanupUnfinishedDefaultRun';
64		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
65		- $context->getConfig()->set( 'controller/common/order/name', $name );
	64	+ $context->getConfig()->set('mshop/order/manager/name', $name);
	65	+ $context->getConfig()->set('controller/common/order/name', $name);
66	66
67	67
68		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
69		- ->setMethods( array( 'searchItems', 'getSubManager' ) )
70		- ->setConstructorArgs( array( $context ) )
	68	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	69	+ ->setMethods(array('searchItems', 'getSubManager'))
	70	+ ->setConstructorArgs(array($context))
71	71	->getMock();
72	72
73		- $orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
74		- ->setMethods( array( 'deleteItems' ) )
75		- ->setConstructorArgs( array( $context ) )
	73	+ $orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
	74	+ ->setMethods(array('deleteItems'))
	75	+ ->setConstructorArgs(array($context))
76	76	->getMock();
77	77
78		- $orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
79		- ->setMethods( array( 'unblock' ) )
80		- ->setConstructorArgs( array( $context ) )
	78	+ $orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
	79	+ ->setMethods(array('unblock'))
	80	+ ->setConstructorArgs(array($context))
81	81	->getMock();
82	82
83	83
84		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
85		- \Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
	84	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
	85	+ \Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
86	86
87	87
88	88	$orderItem = $orderManagerStub->createItem();
89		- $orderItem->setBaseId( 1 );
90		- $orderItem->setId( 2 );
	89	+ $orderItem->setBaseId(1);
	90	+ $orderItem->setId(2);
91	91
92	92
93		- $orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
94		- ->will( $this->returnValue( $orderBaseManagerStub ) );
	93	+ $orderManagerStub->expects($this->once())->method('getSubManager')
	94	+ ->will($this->returnValue($orderBaseManagerStub));
95	95
96		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
97		- ->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
	96	+ $orderManagerStub->expects($this->once())->method('searchItems')
	97	+ ->will($this->returnValue(array($orderItem->getId() => $orderItem)));
98	98
99		- $orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
	99	+ $orderBaseManagerStub->expects($this->once())->method('deleteItems');
100	100
101		- $orderCntlStub->expects( $this->once() )->method( 'unblock' );
	101	+ $orderCntlStub->expects($this->once())->method('unblock');
102	102
103	103
104		- $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
	104	+ $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
105	105	$object->run();
106	106	}
107	107	}

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	* @param string\|null $name Name of the controller or "Standard" if null
30	30	* @return \Aimeos\Controller\Jobs\Iface New controller object
31	31	*/
32		- public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
	32	+ public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
33	33	{
34	34	/** controller/jobs/product/export/sitemap/name
35	35	* Class name of the used product suggestions scheduler controller implementation
		@@ -64,20 +64,20 @@ discard block
		block discarded – undo
64	64	* @since 2015.01
65	65	* @category Developer
66	66	*/
67		- if ( $name === null ) {
	67	+ if ($name === null) {
68	68	$name = $context->getConfig()->get('controller/jobs/product/export/sitemap/name', 'Standard');
69	69	}
70	70
71		- if ( ctype_alnum($name) === false )
	71	+ if (ctype_alnum($name) === false)
72	72	{
73	73	$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Product\\Export\\Sitemap\\' . $name : '<not a string>';
74		- throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
	74	+ throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
75	75	}
76	76
77	77	$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
78	78	$classname = '\\Aimeos\\Controller\\Jobs\\Product\\Export\\Sitemap\\' . $name;
79	79
80		- $controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
	80	+ $controller = self::createControllerBase($context, $aimeos, $classname, $iface);
81	81
82	82	/** controller/jobs/product/export/sitemap/decorators/excludes
83	83	* Excludes decorators added by the "common" option from the product export sitemap job controller
		@@ -154,6 +154,6 @@ discard block
		block discarded – undo
154	154	* @see controller/jobs/product/export/sitemap/export/sitemap/decorators/excludes
155	155	* @see controller/jobs/product/export/sitemap/export/sitemap/decorators/global
156	156	*/
157		- return self::addControllerDecorators( $context, $aimeos, $controller, 'product/export/sitemap' );
	157	+ return self::addControllerDecorators($context, $aimeos, $controller, 'product/export/sitemap');
158	158	}
159	159	}
160	160	\ No newline at end of file

		@@ -11,22 +11,22 @@
		block discarded – undo
11	11	* Set error reporting to maximum
12	12	*/
13	13	error_reporting( -1 );
14		-ini_set( 'display_errors', '1' );
	14	+ini_set('display_errors', '1');
15	15
16		-date_default_timezone_set( 'UTC' );
	16	+date_default_timezone_set('UTC');
17	17
18	18	/**
19	19	* Set locale settings to reasonable defaults
20	20	*/
21		-setlocale( LC_ALL, 'en_US.UTF-8' );
22		-setlocale( LC_NUMERIC, 'POSIX' );
23		-setlocale( LC_CTYPE, 'en_US.UTF-8' );
24		-setlocale( LC_TIME, 'POSIX' );
	21	+setlocale(LC_ALL, 'en_US.UTF-8');
	22	+setlocale(LC_NUMERIC, 'POSIX');
	23	+setlocale(LC_CTYPE, 'en_US.UTF-8');
	24	+setlocale(LC_TIME, 'POSIX');
25	25
26	26	/*
27	27	* Set include path for tests
28	28	*/
29		-define( 'PATH_TESTS', __DIR__ );
	29	+define('PATH_TESTS', __DIR__);
30	30
31	31	require_once 'TestHelperJobs.php';
32	32	\TestHelperJobs::bootstrap();

		@@ -4,11 +4,11 @@
		block discarded – undo
4	4	'jobs' => array(
5	5	'product' => array(
6	6	'export' => array(
7		- 'location' => dirname( __DIR__ ) . DIRECTORY_SEPARATOR . 'tmp',
	7	+ 'location' => dirname(__DIR__) . DIRECTORY_SEPARATOR . 'tmp',
8	8	'max-items' => 15,
9	9	'max-query' => 5,
10	10	'sitemap' => array(
11		- 'location' => dirname( __DIR__ ) . DIRECTORY_SEPARATOR . 'tmp',
	11	+ 'location' => dirname(__DIR__) . DIRECTORY_SEPARATOR . 'tmp',
12	12	'max-items' => 15,
13	13	'max-query' => 5,
14	14	),

		@@ -16,8 +16,8 @@ discard block
		block discarded – undo
16	16	$context = \TestHelperJobs::getContext();
17	17	$aimeos = \TestHelperJobs::getAimeos();
18	18
19		- $obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos );
20		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	19	+ $obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos);
	20	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
21	21	}
22	22
23	23
		@@ -26,8 +26,8 @@ discard block
		block discarded – undo
26	26	$context = \TestHelperJobs::getContext();
27	27	$aimeos = \TestHelperJobs::getAimeos();
28	28
29		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
30		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	29	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	30	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Wrong$$$Name');
31	31	}
32	32
33	33
		@@ -36,8 +36,8 @@ discard block
		block discarded – undo
36	36	$context = \TestHelperJobs::getContext();
37	37	$aimeos = \TestHelperJobs::getAimeos();
38	38
39		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
40		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'WrongClass' );
	39	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	40	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'WrongClass');
41	41	}
42	42
43	43
		@@ -46,8 +46,8 @@ discard block
		block discarded – undo
46	46	$context = \TestHelperJobs::getContext();
47	47	$aimeos = \TestHelperJobs::getAimeos();
48	48
49		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
50		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Factory' );
	49	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	50	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Factory');
51	51	}
52	52
53	53	}

aimeos / ai-controller-jobs

Push — master ( a9b00f...475749 )

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch