Inspection of "Fixed scrutinizer-ci issues" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5cb668...1d0d83 )

by Aimeos

created 2017-08-09 15:31 UTC

Status

Spacing +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -18,101 +18,101 @@
 block discarded – undo
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 		$config = $this->context->getConfig();
 
-		$config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );
+		$config->set('controller/jobs/product/import/csv/skip-lines', 1);
 
-		$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard($this->context, $this->aimeos);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
+		$this->assertEquals('Coupon code import CSV', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Imports new and updates existing coupon code from CSV files';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
-		$coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'coupon');
+		$coupon = $manager->saveItem($manager->createItem()->setProvider('Example'));
 
 		$dir = 'tmp/import/couponcode/unittest';
 		$filepath = $dir . '/' . $coupon->getId() . '.csv';
 
-		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
+		if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
+			throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
 		}
 
 		$content = 'code,count,start,end
 jobccimport1,3,2000-01-01 00:00:00,
 jobccimport2,5,,';
 
-		if( file_put_contents( $filepath, $content ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
+		if (file_put_contents($filepath, $content) === false) {
+			throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
 		}
 
 		$this->object->run();
 
 
-		unlink( $filepath );
+		unlink($filepath);
 
-		$codeManager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon/code' );
-		$code1 = $codeManager->findItem( 'jobccimport1' );
-		$code2 = $codeManager->findItem( 'jobccimport2' );
+		$codeManager = \Aimeos\MShop\Factory::createManager($this->context, 'coupon/code');
+		$code1 = $codeManager->findItem('jobccimport1');
+		$code2 = $codeManager->findItem('jobccimport2');
 
-		$manager->deleteItem( $coupon->getId() );
+		$manager->deleteItem($coupon->getId());
 
-		$this->assertEquals( 3, $code1->getCount() );
-		$this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
-		$this->assertEquals( null, $code1->getDateEnd() );
+		$this->assertEquals(3, $code1->getCount());
+		$this->assertEquals('2000-01-01 00:00:00', $code1->getDateStart());
+		$this->assertEquals(null, $code1->getDateEnd());
 
-		$this->assertEquals( 5, $code2->getCount() );
-		$this->assertEquals( null, $code2->getDateStart() );
-		$this->assertEquals( null, $code2->getDateEnd() );
+		$this->assertEquals(5, $code2->getCount());
+		$this->assertEquals(null, $code2->getDateStart());
+		$this->assertEquals(null, $code2->getDateEnd());
 	}
 
 
 	public function testRunException()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'coupon');
 
 		$dir = 'tmp/import/couponcode/unittest';
 		$filepath = $dir . '/0.csv';
 
-		if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
+		if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
+			throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
 		}
 
 		$content = 'code,count,start,end
 jobccimport1,,,';
 
-		if( file_put_contents( $filepath, $content ) === false ) {
-			throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
+		if (file_put_contents($filepath, $content) === false) {
+			throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
 		}
 
 		$this->object->run();
 
-		unlink( $filepath );
+		unlink($filepath);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -18,101 +18,101 @@
		block discarded – undo
18	18
19	19	protected function setUp()
20	20	{
21		- \Aimeos\MShop\Factory::setCache( true );
	21	+ \Aimeos\MShop\Factory::setCache(true);
22	22
23	23	$this->context = \TestHelperJobs::getContext();
24	24	$this->aimeos = \TestHelperJobs::getAimeos();
25	25	$config = $this->context->getConfig();
26	26
27		- $config->set( 'controller/jobs/product/import/csv/skip-lines', 1 );
	27	+ $config->set('controller/jobs/product/import/csv/skip-lines', 1);
28	28
29		- $this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard( $this->context, $this->aimeos );
	29	+ $this->object = new \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Standard($this->context, $this->aimeos);
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- \Aimeos\MShop\Factory::setCache( false );
	35	+ \Aimeos\MShop\Factory::setCache(false);
36	36	\Aimeos\MShop\Factory::clear();
37	37
38		- unset( $this->object );
	38	+ unset($this->object);
39	39	}
40	40
41	41
42	42	public function testGetName()
43	43	{
44		- $this->assertEquals( 'Coupon code import CSV', $this->object->getName() );
	44	+ $this->assertEquals('Coupon code import CSV', $this->object->getName());
45	45	}
46	46
47	47
48	48	public function testGetDescription()
49	49	{
50	50	$text = 'Imports new and updates existing coupon code from CSV files';
51		- $this->assertEquals( $text, $this->object->getDescription() );
	51	+ $this->assertEquals($text, $this->object->getDescription());
52	52	}
53	53
54	54
55	55	public function testRun()
56	56	{
57		- $manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
58		- $coupon = $manager->saveItem( $manager->createItem()->setProvider( 'Example' ) );
	57	+ $manager = \Aimeos\MShop\Factory::createManager($this->context, 'coupon');
	58	+ $coupon = $manager->saveItem($manager->createItem()->setProvider('Example'));
59	59
60	60	$dir = 'tmp/import/couponcode/unittest';
61	61	$filepath = $dir . '/' . $coupon->getId() . '.csv';
62	62
63		- if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
64		- throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
	63	+ if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
	64	+ throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
65	65	}
66	66
67	67	$content = 'code,count,start,end
68	68	jobccimport1,3,2000-01-01 00:00:00,
69	69	jobccimport2,5,,';
70	70
71		- if( file_put_contents( $filepath, $content ) === false ) {
72		- throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
	71	+ if (file_put_contents($filepath, $content) === false) {
	72	+ throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
73	73	}
74	74
75	75	$this->object->run();
76	76
77	77
78		- unlink( $filepath );
	78	+ unlink($filepath);
79	79
80		- $codeManager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon/code' );
81		- $code1 = $codeManager->findItem( 'jobccimport1' );
82		- $code2 = $codeManager->findItem( 'jobccimport2' );
	80	+ $codeManager = \Aimeos\MShop\Factory::createManager($this->context, 'coupon/code');
	81	+ $code1 = $codeManager->findItem('jobccimport1');
	82	+ $code2 = $codeManager->findItem('jobccimport2');
83	83
84		- $manager->deleteItem( $coupon->getId() );
	84	+ $manager->deleteItem($coupon->getId());
85	85
86		- $this->assertEquals( 3, $code1->getCount() );
87		- $this->assertEquals( '2000-01-01 00:00:00', $code1->getDateStart() );
88		- $this->assertEquals( null, $code1->getDateEnd() );
	86	+ $this->assertEquals(3, $code1->getCount());
	87	+ $this->assertEquals('2000-01-01 00:00:00', $code1->getDateStart());
	88	+ $this->assertEquals(null, $code1->getDateEnd());
89	89
90		- $this->assertEquals( 5, $code2->getCount() );
91		- $this->assertEquals( null, $code2->getDateStart() );
92		- $this->assertEquals( null, $code2->getDateEnd() );
	90	+ $this->assertEquals(5, $code2->getCount());
	91	+ $this->assertEquals(null, $code2->getDateStart());
	92	+ $this->assertEquals(null, $code2->getDateEnd());
93	93	}
94	94
95	95
96	96	public function testRunException()
97	97	{
98		- $manager = \Aimeos\MShop\Factory::createManager( $this->context, 'coupon' );
	98	+ $manager = \Aimeos\MShop\Factory::createManager($this->context, 'coupon');
99	99
100	100	$dir = 'tmp/import/couponcode/unittest';
101	101	$filepath = $dir . '/0.csv';
102	102
103		- if( !is_dir( $dir ) && mkdir( 'tmp/import/couponcode/unittest', 0775, true ) === false ) {
104		- throw new \Exception( sprintf( 'Unable to create directory "%1$s"', $dir ) );
	103	+ if (!is_dir($dir) && mkdir('tmp/import/couponcode/unittest', 0775, true) === false) {
	104	+ throw new \Exception(sprintf('Unable to create directory "%1$s"', $dir));
105	105	}
106	106
107	107	$content = 'code,count,start,end
108	108	jobccimport1,,,';
109	109
110		- if( file_put_contents( $filepath, $content ) === false ) {
111		- throw new \Exception( sprintf( 'Unable to create file "%1$s"', $file ) );
	110	+ if (file_put_contents($filepath, $content) === false) {
	111	+ throw new \Exception(sprintf('Unable to create file "%1$s"', $file));
112	112	}
113	113
114	114	$this->object->run();
115	115
116		- unlink( $filepath );
	116	+ unlink($filepath);
117	117	}
118	118	}
119	119	\ No newline at end of file

aimeos / ai-controller-jobs

Push — master ( 5cb668...1d0d83 )

Status

Category

Spacing +30 added lines, -30 removed lines patch added patch discarded remove patch