aimeos / ai-controller-jobs

controller/common/tests/Controller/Common/Product/Import/Csv/Cache/Stocktype/StandardTest.php

Spacing +12 added lines, -12 removed lines

@@ -16,43 +16,43 @@
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$context = \TestHelperCntl::getContext();
-		$this->object = new \Aimeos\Controller\Common\Product\Import\Csv\Cache\Stocktype\Standard( $context );
+		$this->object = new \Aimeos\Controller\Common\Product\Import\Csv\Cache\Stocktype\Standard($context);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 	}
 
 
 	public function testGet()
 	{
-		$result = $this->object->get( 'default' );
+		$result = $this->object->get('default');
 
-		$this->assertNotEquals( null, $result );
+		$this->assertNotEquals(null, $result);
 	}
 
 
 	public function testGetUnknown()
 	{
-		$this->assertEquals( null, $this->object->get( 'cache-test' ) );
+		$this->assertEquals(null, $this->object->get('cache-test'));
 	}
 
 
 	public function testSet()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( \TestHelperCntl::getContext(), 'stock/type' )->createItem();
-		$item->setCode( 'cache-test' );
-		$item->setId( 1 );
+		$item = \Aimeos\MShop\Factory::createManager(\TestHelperCntl::getContext(), 'stock/type')->createItem();
+		$item->setCode('cache-test');
+		$item->setId(1);
 
-		$this->object->set( $item );
-		$id = $this->object->get( 'cache-test' );
+		$this->object->set($item);
+		$id = $this->object->get('cache-test');
 
-		$this->assertEquals( $item->getId(), $id );
+		$this->assertEquals($item->getId(), $id);
 	}
 }
\ No newline at end of file

controller/jobs/src/Controller/Jobs/Media/Scale/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -29,7 +29,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/media/scale/name
 		 * Class name of the used media scale job controller implementation
@@ -64,20 +64,20 @@ 
 		 * @since 2017.01
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/media/scale/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/media/scale/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Media\\Scale\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Media\\Scale\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Media\\Scale\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/media/scale/decorators/excludes
 		 * Excludes decorators added by the "common" option from the media scale controllers
@@ -153,6 +153,6 @@ 
 		 * @see controller/jobs/media/scale/decorators/excludes
 		 * @see controller/jobs/media/scale/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'media/scale' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'media/scale');
 	}
 }
\ No newline at end of file

controller/jobs/tests/Controller/Jobs/Media/Scale/FactoryTest.php

Spacing +8 added lines, -8 removed lines

@@ -16,8 +16,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

controller/jobs/src/Controller/Jobs/Media/Scale/Standard.php

Spacing +15 added lines, -15 removed lines

@@ -28,7 +28,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Rescale product images' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Rescale product images');
 	}
 
 
@@ -39,7 +39,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Rescales product images to the new sizes' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Rescales product images to the new sizes');
 	}
 
 
@@ -50,33 +50,33 @@ 
 	 */
 	public function run()
 	{
-		$cntl = \Aimeos\Controller\Common\Media\Factory::createController( $this->getContext() );
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'media' );
+		$cntl = \Aimeos\Controller\Common\Media\Factory::createController($this->getContext());
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'media');
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'media.domain', 'product' ),
-			$search->compare( '=~', 'media.mimetype', 'image/' ),
+			$search->compare('==', 'media.domain', 'product'),
+			$search->compare('=~', 'media.mimetype', 'image/'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'media.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'media.id')));
 
 		$start = 0;
 
 		do
 		{
-			$search->setSlice( $start );
-			$items = $manager->searchItems( $search );
+			$search->setSlice($start);
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $item )
+			foreach ($items as $item)
 			{
-				$cntl->scale( $item, 'fs-media' );
-				$manager->saveItem( $item );
+				$cntl->scale($item, 'fs-media');
+				$manager->saveItem($item);
 			}
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
 		}
-		while( $count === $search->getSliceSize() );
+		while ($count === $search->getSliceSize());
 	}
 }

controller/jobs/tests/Controller/Jobs/Media/Scale/StandardTest.php

Spacing +16 added lines, -16 removed lines

@@ -19,7 +19,7 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Media\Scale\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Media\Scale\Standard($context, $aimeos);
 	}
 
 
@@ -31,14 +31,14 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Rescale product images', $this->object->getName() );
+		$this->assertEquals('Rescale product images', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Rescales product images to the new sizes';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -49,31 +49,31 @@ 
 
 
 		$name = 'ControllerJobsMediaScaleStandardRun';
-		$context->getConfig()->set( 'mshop/media/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/media/name', $name );
+		$context->getConfig()->set('mshop/media/manager/name', $name);
+		$context->getConfig()->set('controller/common/media/name', $name);
 
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Media\\Manager\\Standard' )
-			->setMethods( array( 'saveItem' ) )
-			->setConstructorArgs( array( $context ) )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Media\\Manager\\Standard')
+			->setMethods(array('saveItem'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Media\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Media\\Manager\\' . $name, $managerStub );
+		\Aimeos\MShop\Media\Manager\Factory::injectManager('\\Aimeos\\MShop\\Media\\Manager\\' . $name, $managerStub);
 
-		$managerStub->expects( $this->atLeast( 1 ) )->method( 'saveItem' );
+		$managerStub->expects($this->atLeast(1))->method('saveItem');
 
 
-		$cntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Media\\Standard' )
-			->setMethods( array( 'scale' ) )
-			->setConstructorArgs( array( $context ) )
+		$cntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Media\\Standard')
+			->setMethods(array('scale'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\Controller\Common\Media\Factory::injectController( '\\Aimeos\\Controller\\Common\\Media\\' . $name, $cntlStub );
+		\Aimeos\Controller\Common\Media\Factory::injectController('\\Aimeos\\Controller\\Common\\Media\\' . $name, $cntlStub);
 
-		$cntlStub->expects( $this->atLeast( 1 ) )->method( 'scale' );
+		$cntlStub->expects($this->atLeast(1))->method('scale');
 
 
-		$object = new \Aimeos\Controller\Jobs\Media\Scale\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Media\Scale\Standard($context, $aimeos);
 		$object->run();
 	}
 }

controller/common/src/Controller/Common/Product/Import/Csv/Processor/Base.php

Doc Comments +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
 	 *
 	 * @param array $list Associative list of key/value pairs
 	 * @param string $key Key for the value to retrieve
-	 * @param mixed $default Default value if key isn't found
+	 * @param string $default Default value if key isn't found
 	 * @param mixed Value for the key in the list of the default value
 	 */
 	protected function getValue( array $list, $key, $default )

Spacing +9 added lines, -9 removed lines

@@ -32,8 +32,8 @@ 
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 * @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
-		\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping,
+		\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null)
 	{
 		$this->context = $context;
 		$this->mapping = $mapping;
@@ -48,13 +48,13 @@ 
 	 * @param integer $pos Computed position of the list item in the associated list of items
 	 * @return array Given associative list enriched by default values if they were not already set
 	 */
-	protected function addListItemDefaults( array $list, $pos )
+	protected function addListItemDefaults(array $list, $pos)
 	{
-		if( !isset( $list['product.lists.position'] ) ) {
+		if (!isset($list['product.lists.position'])) {
 			$list['product.lists.position'] = $pos;
 		}
 
-		if( !isset( $list['product.lists.status'] ) ) {
+		if (!isset($list['product.lists.status'])) {
 			$list['product.lists.status'] = 1;
 		}
 
@@ -92,8 +92,8 @@ 
 	 */
 	protected function getObject()
 	{
-		if( $this->object === null ) {
-			throw new \Aimeos\Controller\Jobs\Exception( 'No processor object available' );
+		if ($this->object === null) {
+			throw new \Aimeos\Controller\Jobs\Exception('No processor object available');
 		}
 
 		return $this->object;
@@ -108,8 +108,8 @@ 
 	 * @param mixed $default Default value if key isn't found
 	 * @param mixed Value for the key in the list of the default value
 	 */
-	protected function getValue( array $list, $key, $default )
+	protected function getValue(array $list, $key, $default)
 	{
-		return ( isset( $list[$key] ) ? $list[$key] : $default );
+		return (isset($list[$key]) ? $list[$key] : $default);
 	}
 }

controller/common/src/Controller/Common/Product/Import/Csv/Processor/Media/Standard.php

Braces +2 added lines, -4 removed lines

@@ -116,8 +116,7 @@ 
 						$listItem = $listMap[$url][$type][$typecode];
 						$refItem = $listItem->getRefItem();
 						unset( $listItems[ $listItem->getId() ] );
-					}
-					else
+					} else
 					{
 						$listItem = $listManager->createItem();
 						$refItem = $manager->createItem();
@@ -150,8 +149,7 @@ 
 			$data = $this->getObject()->process( $product, $data );
 
 			$manager->commit();
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$manager->rollback();
 			throw $e;

Spacing +39 added lines, -39 removed lines

@@ -42,10 +42,10 @@ 
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 * @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
-			\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping,
+			\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null)
 	{
-		parent::__construct( $context, $mapping, $object );
+		parent::__construct($context, $mapping, $object);
 
 		/** controller/common/product/import/csv/processor/media/listtypes
 		 * Names of the product list types for media that are updated or removed
@@ -66,7 +66,7 @@ 
 		 * @see controller/common/product/import/csv/processor/price/listtypes
 		 * @see controller/common/product/import/csv/processor/text/listtypes
 		 */
-		$this->listTypes = $context->getConfig()->get( 'controller/common/product/import/csv/processor/media/listtypes' );
+		$this->listTypes = $context->getConfig()->get('controller/common/product/import/csv/processor/media/listtypes');
 	}
 
 
@@ -77,45 +77,45 @@ 
 	 * @param array $data List of CSV fields with position as key and data as value
 	 * @return array List of data which hasn't been imported
 	 */
-	public function process( \Aimeos\MShop\Product\Item\Iface $product, array $data )
+	public function process(\Aimeos\MShop\Product\Item\Iface $product, array $data)
 	{
 		$context = $this->getContext();
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'media' );
-		$listManager = \Aimeos\MShop\Factory::createManager( $context, 'product/lists' );
-		$separator = $context->getConfig()->get( 'controller/common/product/import/csv/separator', "\n" );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'media');
+		$listManager = \Aimeos\MShop\Factory::createManager($context, 'product/lists');
+		$separator = $context->getConfig()->get('controller/common/product/import/csv/separator', "\n");
 
 		$manager->begin();
 
 		try
 		{
 			$delete = $listMap = [];
-			$map = $this->getMappedChunk( $data, $this->getMapping() );
-			$listItems = $product->getListItems( 'media', $this->listTypes );
+			$map = $this->getMappedChunk($data, $this->getMapping());
+			$listItems = $product->getListItems('media', $this->listTypes);
 
-			foreach( $listItems as $listItem )
+			foreach ($listItems as $listItem)
 			{
-				if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-					$listMap[ $refItem->getUrl() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
+				if (($refItem = $listItem->getRefItem()) !== null) {
+					$listMap[$refItem->getUrl()][$refItem->getType()][$listItem->getType()] = $listItem;
 				}
 			}
 
-			foreach( $map as $pos => $list )
+			foreach ($map as $pos => $list)
 			{
-				if( $this->checkEntry( $list ) === false ) {
+				if ($this->checkEntry($list) === false) {
 					continue;
 				}
 
-				$urls = explode( $separator, $list['media.url'] );
-				$type = $this->getValue( $list, 'media.type', 'default' );
-				$typecode = $this->getValue( $list, 'product.lists.type', 'default' );
+				$urls = explode($separator, $list['media.url']);
+				$type = $this->getValue($list, 'media.type', 'default');
+				$typecode = $this->getValue($list, 'product.lists.type', 'default');
 
-				foreach( $urls as $url )
+				foreach ($urls as $url)
 				{
-					if( isset( $listMap[$url][$type][$typecode] ) )
+					if (isset($listMap[$url][$type][$typecode]))
 					{
 						$listItem = $listMap[$url][$type][$typecode];
 						$refItem = $listItem->getRefItem();
-						unset( $listItems[ $listItem->getId() ] );
+						unset($listItems[$listItem->getId()]);
 					}
 					else
 					{
@@ -123,35 +123,35 @@ 
 						$refItem = $manager->createItem();
 					}
 
-					$list['media.typeid'] = $this->getTypeId( 'media/type', 'product', $type );
+					$list['media.typeid'] = $this->getTypeId('media/type', 'product', $type);
 					$list['media.domain'] = 'product';
 					$list['media.url'] = $url;
 
-					$refItem->fromArray( $this->addItemDefaults( $list ) );
-					$refItem = $manager->saveItem( $refItem );
+					$refItem->fromArray($this->addItemDefaults($list));
+					$refItem = $manager->saveItem($refItem);
 
-					$list['product.lists.typeid'] = $this->getTypeId( 'product/lists/type', 'media', $typecode );
+					$list['product.lists.typeid'] = $this->getTypeId('product/lists/type', 'media', $typecode);
 					$list['product.lists.parentid'] = $product->getId();
 					$list['product.lists.refid'] = $refItem->getId();
 					$list['product.lists.domain'] = 'media';
 
-					$listItem->fromArray( $this->addListItemDefaults( $list, $pos++ ) );
-					$listManager->saveItem( $listItem, false );
+					$listItem->fromArray($this->addListItemDefaults($list, $pos++));
+					$listManager->saveItem($listItem, false);
 				}
 			}
 
-			foreach( $listItems as $listItem ) {
+			foreach ($listItems as $listItem) {
 				$delete[] = $listItem->getRefId();
 			}
 
-			$manager->deleteItems( $delete );
-			$listManager->deleteItems( array_keys( $listItems ) );
+			$manager->deleteItems($delete);
+			$listManager->deleteItems(array_keys($listItems));
 
-			$data = $this->getObject()->process( $product, $data );
+			$data = $this->getObject()->process($product, $data);
 
 			$manager->commit();
 		}
-		catch( \Exception $e )
+		catch (\Exception $e)
 		{
 			$manager->rollback();
 			throw $e;
@@ -167,17 +167,17 @@ 
 	 * @param array $list Associative list of domain item keys and their values, e.g. "media.status" => 1
 	 * @return array Given associative list enriched by default values if they were not already set
 	 */
-	protected function addItemDefaults( array $list )
+	protected function addItemDefaults(array $list)
 	{
-		if( !isset( $list['media.label'] ) ) {
+		if (!isset($list['media.label'])) {
 			$list['media.label'] = $list['media.url'];
 		}
 
-		if( !isset( $list['media.preview'] ) ) {
+		if (!isset($list['media.preview'])) {
 			$list['media.preview'] = $list['media.url'];
 		}
 
-		if( !isset( $list['media.status'] ) ) {
+		if (!isset($list['media.status'])) {
 			$list['media.status'] = 1;
 		}
 
@@ -191,10 +191,10 @@ 
 	 * @param array $list Associative list of key/value pairs from the mapping
 	 * @return boolean True if valid, false if not
 	 */
-	protected function checkEntry( array $list )
+	protected function checkEntry(array $list)
 	{
-		if( !isset( $list['media.url'] ) || $list['media.url'] === '' || isset( $list['product.lists.type'] )
-				&& $this->listTypes !== null && !in_array( $list['product.lists.type'], (array) $this->listTypes )
+		if (!isset($list['media.url']) || $list['media.url'] === '' || isset($list['product.lists.type'])
+				&& $this->listTypes !== null && !in_array($list['product.lists.type'], (array) $this->listTypes)
 		) {
 			return false;
 		}

controller/common/src/Controller/Common/Product/Import/Csv/Processor/Property/Standard.php

Braces +2 added lines, -4 removed lines

@@ -69,8 +69,7 @@ 
 				{
 					$item = $propMap[ $list['product.property.value'] ][$typecode];
 					unset( $items[ $item->getId() ] );
-				}
-				else
+				} else
 				{
 					$item = $manager->createItem();
 				}
@@ -84,8 +83,7 @@ 
 			$data = $this->getObject()->process( $product, $data );
 
 			$manager->commit();
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$manager->rollback();
 			throw $e;

Spacing +21 added lines, -21 removed lines

@@ -40,52 +40,52 @@ 
 	 * @param array $data List of CSV fields with position as key and data as value
 	 * @return array List of data which hasn't been imported
 	 */
-	public function process( \Aimeos\MShop\Product\Item\Iface $product, array $data )
+	public function process(\Aimeos\MShop\Product\Item\Iface $product, array $data)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'product/property' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'product/property');
 		$manager->begin();
 
 		try
 		{
 			$propMap = [];
-			$map = $this->getMappedChunk( $data, $this->getMapping() );
-			$items = $this->getPropertyItems( $product->getId() );
+			$map = $this->getMappedChunk($data, $this->getMapping());
+			$items = $this->getPropertyItems($product->getId());
 
-			foreach( $items as $item ) {
-				$propMap[ $item->getValue() ][ $item->getType() ] = $item;
+			foreach ($items as $item) {
+				$propMap[$item->getValue()][$item->getType()] = $item;
 			}
 
-			foreach( $map as $list )
+			foreach ($map as $list)
 			{
-				if( $list['product.property.type'] == '' || $list['product.property.value'] == '' ) {
+				if ($list['product.property.type'] == '' || $list['product.property.value'] == '') {
 					continue;
 				}
 
 				$typecode = $list['product.property.type'];
-				$list['product.property.typeid'] = $this->getTypeId( 'product/property/type', 'product', $typecode );
+				$list['product.property.typeid'] = $this->getTypeId('product/property/type', 'product', $typecode);
 				$list['product.property.parentid'] = $product->getId();
 
-				if( isset( $propMap[ $list['product.property.value'] ][$typecode] ) )
+				if (isset($propMap[$list['product.property.value']][$typecode]))
 				{
-					$item = $propMap[ $list['product.property.value'] ][$typecode];
-					unset( $items[ $item->getId() ] );
+					$item = $propMap[$list['product.property.value']][$typecode];
+					unset($items[$item->getId()]);
 				}
 				else
 				{
 					$item = $manager->createItem();
 				}
 
-				$item->fromArray( $list );
-				$manager->saveItem( $item, false );
+				$item->fromArray($list);
+				$manager->saveItem($item, false);
 			}
 
-			$manager->deleteItems( array_keys( $items ) );
+			$manager->deleteItems(array_keys($items));
 
-			$data = $this->getObject()->process( $product, $data );
+			$data = $this->getObject()->process($product, $data);
 
 			$manager->commit();
 		}
-		catch( \Exception $e )
+		catch (\Exception $e)
 		{
 			$manager->rollback();
 			throw $e;
@@ -101,13 +101,13 @@ 
 	 * @param string $prodid Unique product ID
 	 * @return array Associative list of product property items
 	 */
-	protected function getPropertyItems( $prodid )
+	protected function getPropertyItems($prodid)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'product/property' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'product/property');
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'product.property.parentid', $prodid ) );
+		$search->setConditions($search->compare('==', 'product.property.parentid', $prodid));
 
-		return $manager->searchItems( $search );
+		return $manager->searchItems($search);
 	}
 }

controller/common/src/Controller/Common/Product/Import/Csv/Processor/Attribute/Standard.php

Braces +2 added lines, -4 removed lines

@@ -127,8 +127,7 @@ 
 					{
 						$listItem = $listMap[$code][$typecode];
 						unset( $listItems[ $listItem->getId() ] );
-					}
-					else
+					} else
 					{
 						$listItem = $listManager->createItem();
 					}
@@ -143,8 +142,7 @@ 
 			$data = $this->getObject()->process( $product, $data );
 
 			$manager->commit();
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$manager->rollback();
 			throw $e;

Spacing +45 added lines, -45 removed lines

@@ -43,10 +43,10 @@ 
 	 * @param array $mapping Associative list of field position in CSV as key and domain item key as value
 	 * @param \Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object Decorated processor
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context, array $mapping,
-		\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context, array $mapping,
+		\Aimeos\Controller\Common\Product\Import\Csv\Processor\Iface $object = null)
 	{
-		parent::__construct( $context, $mapping, $object );
+		parent::__construct($context, $mapping, $object);
 
 		/** controller/common/product/import/csv/processor/attribute/listtypes
 		 * Names of the product list types for attributes that are updated or removed
@@ -67,9 +67,9 @@ 
 		 * @see controller/common/product/import/csv/processor/price/listtypes
 		 * @see controller/common/product/import/csv/processor/text/listtypes
 		 */
-		$this->listTypes = $context->getConfig()->get( 'controller/common/product/import/csv/processor/attribute/listtypes');
+		$this->listTypes = $context->getConfig()->get('controller/common/product/import/csv/processor/attribute/listtypes');
 
-		$this->cache = $this->getCache( 'attribute' );
+		$this->cache = $this->getCache('attribute');
 	}
 
 
@@ -80,71 +80,71 @@ 
 	 * @param array $data List of CSV fields with position as key and data as value
 	 * @return array List of data which hasn't been imported
 	 */
-	public function process( \Aimeos\MShop\Product\Item\Iface $product, array $data )
+	public function process(\Aimeos\MShop\Product\Item\Iface $product, array $data)
 	{
 		$context = $this->getContext();
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'attribute' );
-		$listManager = \Aimeos\MShop\Factory::createManager( $context, 'product/lists' );
-		$separator = $context->getConfig()->get( 'controller/common/product/import/csv/separator', "\n" );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'attribute');
+		$listManager = \Aimeos\MShop\Factory::createManager($context, 'product/lists');
+		$separator = $context->getConfig()->get('controller/common/product/import/csv/separator', "\n");
 
 		$manager->begin();
 
 		try
 		{
 			$listMap = [];
-			$map = $this->getMappedChunk( $data, $this->getMapping() );
-			$listItems = $product->getListItems( 'attribute', $this->listTypes );
+			$map = $this->getMappedChunk($data, $this->getMapping());
+			$listItems = $product->getListItems('attribute', $this->listTypes);
 
-			foreach( $listItems as $listItem )
+			foreach ($listItems as $listItem)
 			{
-				if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-					$listMap[ $refItem->getCode() ][ $listItem->getType() ] = $listItem;
+				if (($refItem = $listItem->getRefItem()) !== null) {
+					$listMap[$refItem->getCode()][$listItem->getType()] = $listItem;
 				}
 			}
 
-			foreach( $map as $pos => $list )
+			foreach ($map as $pos => $list)
 			{
-				if( $this->checkEntry( $list ) === false ) {
+				if ($this->checkEntry($list) === false) {
 					continue;
 				}
 
-				$codes = explode( $separator, $list['attribute.code'] );
+				$codes = explode($separator, $list['attribute.code']);
 
-				foreach( $codes as $code )
+				foreach ($codes as $code)
 				{
-					$attrItem = $this->getAttributeItem( $code, $list['attribute.type'] );
-					$attrItem->fromArray( $list );
-					$attrItem->setCode( $code );
-					$attrItem = $manager->saveItem( $attrItem );
+					$attrItem = $this->getAttributeItem($code, $list['attribute.type']);
+					$attrItem->fromArray($list);
+					$attrItem->setCode($code);
+					$attrItem = $manager->saveItem($attrItem);
 
-					$typecode = $this->getValue( $list, 'product.lists.type', 'default' );
-					$list['product.lists.typeid'] = $this->getTypeId( 'product/lists/type', 'attribute', $typecode );
+					$typecode = $this->getValue($list, 'product.lists.type', 'default');
+					$list['product.lists.typeid'] = $this->getTypeId('product/lists/type', 'attribute', $typecode);
 					$list['product.lists.refid'] = $attrItem->getId();
 					$list['product.lists.parentid'] = $product->getId();
 					$list['product.lists.domain'] = 'attribute';
 
-					if( isset( $listMap[$code][$typecode] ) )
+					if (isset($listMap[$code][$typecode]))
 					{
 						$listItem = $listMap[$code][$typecode];
-						unset( $listItems[ $listItem->getId() ] );
+						unset($listItems[$listItem->getId()]);
 					}
 					else
 					{
 						$listItem = $listManager->createItem();
 					}
 
-					$listItem->fromArray( $this->addListItemDefaults( $list, $pos ) );
-					$listManager->saveItem( $listItem, false );
+					$listItem->fromArray($this->addListItemDefaults($list, $pos));
+					$listManager->saveItem($listItem, false);
 				}
 			}
 
-			$listManager->deleteItems( array_keys( $listItems ) );
+			$listManager->deleteItems(array_keys($listItems));
 
-			$data = $this->getObject()->process( $product, $data );
+			$data = $this->getObject()->process($product, $data);
 
 			$manager->commit();
 		}
-		catch( \Exception $e )
+		catch (\Exception $e)
 		{
 			$manager->rollback();
 			throw $e;
@@ -160,11 +160,11 @@ 
 	 * @param array $list Associative list of key/value pairs from the mapped data
 	 * @return boolean True if the entry is valid, false if not
 	 */
-	protected function checkEntry( array $list )
+	protected function checkEntry(array $list)
 	{
-		if( !isset( $list['attribute.code'] ) || $list['attribute.code'] === '' || $list['attribute.type'] === ''
-			|| isset( $list['product.lists.type'] ) && $this->listTypes !== null
-			&& !in_array( $list['product.lists.type'], (array) $this->listTypes )
+		if (!isset($list['attribute.code']) || $list['attribute.code'] === '' || $list['attribute.type'] === ''
+			|| isset($list['product.lists.type']) && $this->listTypes !== null
+			&& !in_array($list['product.lists.type'], (array) $this->listTypes)
 		) {
 			return false;
 		}
@@ -180,22 +180,22 @@ 
 	 * @param string $type Attribute type
 	 * @return \Aimeos\MShop\Attribute\Item\Iface Attribute item object
 	 */
-	protected function getAttributeItem( $code, $type )
+	protected function getAttributeItem($code, $type)
 	{
-		if( ( $item = $this->cache->get( $code, $type ) ) === null )
+		if (($item = $this->cache->get($code, $type)) === null)
 		{
-			$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'attribute' );
+			$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'attribute');
 
 			$item = $manager->createItem();
-			$item->setTypeId( $this->getTypeId( 'attribute/type', 'product', $type ) );
-			$item->setDomain( 'product' );
-			$item->setLabel( $type . ' ' . $code );
-			$item->setCode( $code );
-			$item->setStatus( 1 );
+			$item->setTypeId($this->getTypeId('attribute/type', 'product', $type));
+			$item->setDomain('product');
+			$item->setLabel($type . ' ' . $code);
+			$item->setCode($code);
+			$item->setStatus(1);
 
-			$item = $manager->saveItem( $item );
+			$item = $manager->saveItem($item);
 
-			$this->cache->set( $item );
+			$this->cache->set($item);
 		}
 
 		return $item;