Inspection of "Implements job controller for terminating subscrip..." - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7313f0...a0f3ba )

by Aimeos

created 2018-03-14 10:00 UTC

Status

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -20,30 +20,30 @@  discard block
 block discarded – undo
 		$aimeos = \TestHelperJobs::getAimeos();
 		$this->context = \TestHelperJobs::getContext();
 
-		$this->object = new \Aimeos\Controller\Jobs\Subscription\Process\End\Standard( $this->context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Subscription\Process\End\Standard($this->context, $aimeos);
 
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 
-		unset( $this->object, $this->context );
+		unset($this->object, $this->context);
 	}
 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Subscription process end', $this->object->getName() );
+		$this->assertEquals('Subscription process end', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
-		$this->assertEquals( 'Terminates expired subscriptions', $this->object->getDescription() );
+		$this->assertEquals('Terminates expired subscriptions', $this->object->getDescription());
 	}
 
 
@@ -51,17 +51,17 @@  discard block
 block discarded – undo
 	{
 		$item = $this->getSubscription();
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Subscription\\Manager\\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['searchItems', 'saveItem'] )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Subscription\\Manager\\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['searchItems', 'saveItem'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'subscription', $managerStub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'subscription', $managerStub);
 
-		$managerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [$item] ) );
+		$managerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([$item]));
 
-		$managerStub->expects( $this->once() )->method( 'saveItem' );
+		$managerStub->expects($this->once())->method('saveItem');
 
 		$this->object->run();
 	}
@@ -71,18 +71,18 @@  discard block
 block discarded – undo
 	{
 		$item = $this->getSubscription();
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Subscription\\Manager\\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['searchItems', 'saveItem'] )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Subscription\\Manager\\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['searchItems', 'saveItem'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'subscription', $managerStub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'subscription', $managerStub);
 
-		$managerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [$item] ) );
+		$managerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([$item]));
 
-		$managerStub->expects( $this->once() )->method( 'saveItem' )
-			->will( $this->throwException( new \Exception() ) );
+		$managerStub->expects($this->once())->method('saveItem')
+			->will($this->throwException(new \Exception()));
 
 		$this->object->run();
 	}
@@ -90,17 +90,17 @@  discard block
 block discarded – undo
 
 	protected function getSubscription()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'subscription' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'subscription');
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'subscription.dateend', '2010-01-01' ) );
+		$search->setConditions($search->compare('==', 'subscription.dateend', '2010-01-01'));
 
-		$items = $manager->searchItems( $search );
+		$items = $manager->searchItems($search);
 
-		if( ( $item = reset( $items ) ) !== false ) {
+		if (($item = reset($items)) !== false) {
 			return $item;
 		}
 
-		throw new \Exception( 'No subscription item found' );
+		throw new \Exception('No subscription item found');
 	}
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Subscription/Process/End/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

		@@ -20,30 +20,30 @@ discard block
		block discarded – undo
20	20	$aimeos = \TestHelperJobs::getAimeos();
21	21	$this->context = \TestHelperJobs::getContext();
22	22
23		- $this->object = new \Aimeos\Controller\Jobs\Subscription\Process\End\Standard( $this->context, $aimeos );
	23	+ $this->object = new \Aimeos\Controller\Jobs\Subscription\Process\End\Standard($this->context, $aimeos);
24	24
25		- \Aimeos\MShop\Factory::setCache( true );
	25	+ \Aimeos\MShop\Factory::setCache(true);
26	26	}
27	27
28	28
29	29	protected function tearDown()
30	30	{
31		- \Aimeos\MShop\Factory::setCache( false );
	31	+ \Aimeos\MShop\Factory::setCache(false);
32	32	\Aimeos\MShop\Factory::clear();
33	33
34		- unset( $this->object, $this->context );
	34	+ unset($this->object, $this->context);
35	35	}
36	36
37	37
38	38	public function testGetName()
39	39	{
40		- $this->assertEquals( 'Subscription process end', $this->object->getName() );
	40	+ $this->assertEquals('Subscription process end', $this->object->getName());
41	41	}
42	42
43	43
44	44	public function testGetDescription()
45	45	{
46		- $this->assertEquals( 'Terminates expired subscriptions', $this->object->getDescription() );
	46	+ $this->assertEquals('Terminates expired subscriptions', $this->object->getDescription());
47	47	}
48	48
49	49
		@@ -51,17 +51,17 @@ discard block
		block discarded – undo
51	51	{
52	52	$item = $this->getSubscription();
53	53
54		- $managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Subscription\\Manager\\Standard' )
55		- ->setConstructorArgs( [$this->context] )
56		- ->setMethods( ['searchItems', 'saveItem'] )
	54	+ $managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Subscription\\Manager\\Standard')
	55	+ ->setConstructorArgs([$this->context])
	56	+ ->setMethods(['searchItems', 'saveItem'])
57	57	->getMock();
58	58
59		- \Aimeos\MShop\Factory::injectManager( $this->context, 'subscription', $managerStub );
	59	+ \Aimeos\MShop\Factory::injectManager($this->context, 'subscription', $managerStub);
60	60
61		- $managerStub->expects( $this->once() )->method( 'searchItems' )
62		- ->will( $this->returnValue( [$item] ) );
	61	+ $managerStub->expects($this->once())->method('searchItems')
	62	+ ->will($this->returnValue([$item]));
63	63
64		- $managerStub->expects( $this->once() )->method( 'saveItem' );
	64	+ $managerStub->expects($this->once())->method('saveItem');
65	65
66	66	$this->object->run();
67	67	}
		@@ -71,18 +71,18 @@ discard block
		block discarded – undo
71	71	{
72	72	$item = $this->getSubscription();
73	73
74		- $managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Subscription\\Manager\\Standard' )
75		- ->setConstructorArgs( [$this->context] )
76		- ->setMethods( ['searchItems', 'saveItem'] )
	74	+ $managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Subscription\\Manager\\Standard')
	75	+ ->setConstructorArgs([$this->context])
	76	+ ->setMethods(['searchItems', 'saveItem'])
77	77	->getMock();
78	78
79		- \Aimeos\MShop\Factory::injectManager( $this->context, 'subscription', $managerStub );
	79	+ \Aimeos\MShop\Factory::injectManager($this->context, 'subscription', $managerStub);
80	80
81		- $managerStub->expects( $this->once() )->method( 'searchItems' )
82		- ->will( $this->returnValue( [$item] ) );
	81	+ $managerStub->expects($this->once())->method('searchItems')
	82	+ ->will($this->returnValue([$item]));
83	83
84		- $managerStub->expects( $this->once() )->method( 'saveItem' )
85		- ->will( $this->throwException( new \Exception() ) );
	84	+ $managerStub->expects($this->once())->method('saveItem')
	85	+ ->will($this->throwException(new \Exception()));
86	86
87	87	$this->object->run();
88	88	}
		@@ -90,17 +90,17 @@ discard block
		block discarded – undo
90	90
91	91	protected function getSubscription()
92	92	{
93		- $manager = \Aimeos\MShop\Factory::createManager( $this->context, 'subscription' );
	93	+ $manager = \Aimeos\MShop\Factory::createManager($this->context, 'subscription');
94	94
95	95	$search = $manager->createSearch();
96		- $search->setConditions( $search->compare( '==', 'subscription.dateend', '2010-01-01' ) );
	96	+ $search->setConditions($search->compare('==', 'subscription.dateend', '2010-01-01'));
97	97
98		- $items = $manager->searchItems( $search );
	98	+ $items = $manager->searchItems($search);
99	99
100		- if( ( $item = reset( $items ) ) !== false ) {
	100	+ if (($item = reset($items)) !== false) {
101	101	return $item;
102	102	}
103	103
104		- throw new \Exception( 'No subscription item found' );
	104	+ throw new \Exception('No subscription item found');
105	105	}
106	106	}

		@@ -16,8 +16,8 @@ discard block
		block discarded – undo
16	16	$context = \TestHelperJobs::getContext();
17	17	$aimeos = \TestHelperJobs::getAimeos();
18	18
19		- $obj = \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos );
20		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	19	+ $obj = \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos);
	20	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
21	21	}
22	22
23	23
		@@ -26,8 +26,8 @@ discard block
		block discarded – undo
26	26	$context = \TestHelperJobs::getContext();
27	27	$aimeos = \TestHelperJobs::getAimeos();
28	28
29		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
30		- \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	29	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	30	+ \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos, 'Wrong$$$Name');
31	31	}
32	32
33	33
		@@ -36,8 +36,8 @@ discard block
		block discarded – undo
36	36	$context = \TestHelperJobs::getContext();
37	37	$aimeos = \TestHelperJobs::getAimeos();
38	38
39		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
40		- \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos, 'WrongClass' );
	39	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	40	+ \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos, 'WrongClass');
41	41	}
42	42
43	43
		@@ -46,8 +46,8 @@ discard block
		block discarded – undo
46	46	$context = \TestHelperJobs::getContext();
47	47	$aimeos = \TestHelperJobs::getAimeos();
48	48
49		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
50		- \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController( $context, $aimeos, 'Factory' );
	49	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	50	+ \Aimeos\Controller\Jobs\Subscription\Process\End\Factory::createController($context, $aimeos, 'Factory');
51	51	}
52	52
53	53	}

aimeos / ai-controller-jobs

Push — master ( 7313f0...a0f3ba )

Status

Category

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch