Aimeos\Controller\Jobs\Catalog\Import\Csv\Standard::import()

Complexity

Conditions	8
Paths	75

Size

Total Lines	62
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	protected function import( array &$catalogMap, array $data, array $mapping,
		\Aimeos\Controller\Common\Catalog\Import\Csv\Processor\Iface $processor, $strict )
	{
		$errors = 0;
		$context = $this->getContext();
		$manager = \Aimeos\MShop\Factory::createManager( $context, 'catalog' );

		foreach( $data as $code => $list )
		{
			$manager->begin();

			try
			{
				$code = trim( $code );

				if( isset( $catalogMap[$code] )  ) {
					$catalogItem = $catalogMap[$code];
				} else {
					$catalogItem = $manager->createItem();
				}

				$map = $this->getMappedChunk( $list, $mapping );

				if( isset( $map[0] ) )
				{
					$map = $map[0]; // there can only be one chunk for the base catalog data
					$parentid = $this->getParentId( $catalogMap, $map, $code );
					$catalogItem->fromArray( $this->addItemDefaults( $map ) );

					if( isset( $catalogMap[$code] ) )
					{
						$manager->moveItem( $catalogItem->getId(), $catalogItem->getParentId(), $parentid );
						$catalogItem = $manager->saveItem( $catalogItem );

Are you sure the assignment to $catalogItem is correct as $manager->saveItem($catalogItem) (which targets Aimeos\MShop\Common\Manager\Iface::saveItem()) seems to always return null.

					}
					else
					{
						$catalogItem = $manager->insertItem( $catalogItem, $parentid );
					}

					$list = $processor->process( $catalogItem, $list );
					$catalogMap[$code] = $catalogItem;
				}

				$manager->commit();
			}
			catch( \Exception $e )
			{
				$manager->rollback();

				$msg = sprintf( 'Unable to import catalog with code "%1$s": %2$s', $code, $e->getMessage() );
				$context->getLogger()->log( $msg );

				$errors++;
			}

			if( $strict && !empty( $list ) ) {
				$context->getLogger()->log( 'Not imported: ' . print_r( $list, true ) );
			}
		}

		return $errors;
	}