aimeos / ai-controller-jobs

controller/common/tests/Controller/Common/Product/Import/Csv/BaseTest.php

Spacing +29 added lines, -29 removed lines

@@ -14,92 +14,92 @@ 
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$context = \TestHelperCntl::getContext();
 		$aimeos = \TestHelperCntl::getAimeos();
 
-		$this->object = new TestAbstract( $context, $aimeos );
+		$this->object = new TestAbstract($context, $aimeos);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 	}
 
 
 	public function testGetCache()
 	{
-		$cache = $this->object->getCachePublic( 'attribute' );
+		$cache = $this->object->getCachePublic('attribute');
 
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\Iface', $cache );
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Cache\\Iface', $cache);
 	}
 
 
 	public function testGetCacheInvalidType()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		$this->object->getCachePublic( '$' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		$this->object->getCachePublic('$');
 	}
 
 
 	public function testGetCacheInvalidClass()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		$this->object->getCachePublic( 'unknown' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		$this->object->getCachePublic('unknown');
 	}
 
 
 	public function testGetCacheInvalidInterface()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		$this->object->getCachePublic( 'attribute', 'unknown' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		$this->object->getCachePublic('attribute', 'unknown');
 	}
 
 
 	public function testGetProcessors()
 	{
-		$processor = $this->object->getProcessorsPublic( array( 'attribute' => array() ) );
+		$processor = $this->object->getProcessorsPublic(array('attribute' => array()));
 
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\Iface', $processor );
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Common\\Product\\Import\\Csv\\Processor\\Iface', $processor);
 	}
 
 
 	public function testGetProcessorsInvalidType()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		$this->object->getProcessorsPublic( array( '$' => array() ) );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		$this->object->getProcessorsPublic(array('$' => array()));
 	}
 
 
 	public function testGetProcessorsInvalidClass()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		$this->object->getProcessorsPublic( array( 'unknown' => array() ) );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		$this->object->getProcessorsPublic(array('unknown' => array()));
 	}
 
 
 	public function testGetProcessorsInvalidInterface()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		$this->object->getProcessorsPublic( array( 'unknown' => array() ) );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		$this->object->getProcessorsPublic(array('unknown' => array()));
 	}
 
 
 	public function testGetTypeId()
 	{
-		$typeid = $this->object->getTypeIdPublic( 'attribute/type', 'product', 'color' );
+		$typeid = $this->object->getTypeIdPublic('attribute/type', 'product', 'color');
 
-		$this->assertNotEquals( null, $typeid );
+		$this->assertNotEquals(null, $typeid);
 	}
 
 
 	public function testGetTypeIdUnknown()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		$this->object->getTypeIdPublic( 'attribute/type', 'product', 'unknown' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		$this->object->getTypeIdPublic('attribute/type', 'product', 'unknown');
 	}
 }
 
@@ -107,21 +107,21 @@ 
 class TestAbstract
 	extends \Aimeos\Controller\Common\Product\Import\Csv\Base
 {
-	public function getCachePublic( $type, $name = null )
+	public function getCachePublic($type, $name = null)
 	{
-		return $this->getCache( $type, $name );
+		return $this->getCache($type, $name);
 	}
 
 
-	public function getProcessorsPublic( array $mappings )
+	public function getProcessorsPublic(array $mappings)
 	{
-		return $this->getProcessors( $mappings );
+		return $this->getProcessors($mappings);
 	}
 
 
-	public function getTypeIdPublic( $path, $domain, $code )
+	public function getTypeIdPublic($path, $domain, $code)
 	{
-		return $this->getTypeId( $path, $domain, $code );
+		return $this->getTypeId($path, $domain, $code);
 	}
 }
 

controller/jobs/src/Controller/Jobs/Order/Cleanup/Unpaid/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -30,7 +30,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/order/cleanup/unpaid/name
 		 * Class name of the used order cleanup unpaid scheduler controller implementation
@@ -65,20 +65,20 @@ 
 		 * @since 2014.07
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/order/cleanup/unpaid/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/order/cleanup/unpaid/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Order\\Cleanup\\Unpaid\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Order\\Cleanup\\Unpaid\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Order\\Cleanup\\Unpaid\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/order/cleanup/unpaid/decorators/excludes
 		 * Excludes decorators added by the "common" option from the order cleanup unpaid controllers
@@ -154,6 +154,6 @@ 
 		 * @see controller/jobs/order/cleanup/unpaid/decorators/excludes
 		 * @see controller/jobs/order/cleanup/unpaid/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'order/cleanup/unpaid' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'order/cleanup/unpaid');
 	}
 }
\ No newline at end of file

controller/jobs/src/Controller/Jobs/Order/Cleanup/Unpaid/Standard.php

Spacing +17 added lines, -17 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Removes unpaid orders' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Removes unpaid orders');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Deletes unpaid orders to keep the database clean' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Deletes unpaid orders to keep the database clean');
 	}
 
 
@@ -52,9 +52,9 @@ 
 	public function run()
 	{
 		$context = $this->getContext();
-		$controller = \Aimeos\Controller\Common\Order\Factory::createController( $context );
-		$baseManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$controller = \Aimeos\Controller\Common\Order\Factory::createController($context);
+		$baseManager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order');
 
 		/** controller/jobs/order/cleanup/unpaid/keep-days
 		 * Removes all orders from the database that are unpaid
@@ -71,35 +71,35 @@ 
 		 * @since 2014.07
 		 * @category User
 		 */
-		$days = $context->getConfig()->get( 'controller/jobs/order/cleanup/unpaid/keep-days', 3 );
-		$limit = date( 'Y-m-d H:i:s', time() - 86400 * $days );
+		$days = $context->getConfig()->get('controller/jobs/order/cleanup/unpaid/keep-days', 3);
+		$limit = date('Y-m-d H:i:s', time() - 86400 * $days);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '<', 'order.mtime', $limit ),
-			$search->compare( '<', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_REFUND ),
+			$search->compare('<', 'order.mtime', $limit),
+			$search->compare('<', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_REFUND),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
 		$start = 0;
 
 		do
 		{
 			$baseIds = array();
-			$items = $manager->searchItems( $search );
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $item )
+			foreach ($items as $item)
 			{
-				$controller->unblock( $item );
+				$controller->unblock($item);
 				$baseIds[] = $item->getBaseId();
 			}
 
-			$baseManager->deleteItems( $baseIds );
+			$baseManager->deleteItems($baseIds);
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count >= $search->getSliceSize() );
+		while ($count >= $search->getSliceSize());
 	}
 }

controller/jobs/src/Controller/Jobs/Order/Cleanup/Unfinished/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -30,7 +30,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/order/cleanup/unfinished/name
 		 * Class name of the used order cleanup unfinished scheduler controller implementation
@@ -65,20 +65,20 @@ 
 		 * @since 2014.03
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/order/cleanup/unfinished/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/order/cleanup/unfinished/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Order\\Cleanup\\Unfinished\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Order\\Cleanup\\Unfinished\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Order\\Cleanup\\Unfinished\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/order/cleanup/unfinished/decorators/excludes
 		 * Excludes decorators added by the "common" option from the order cleanup unfinished controllers
@@ -154,6 +154,6 @@ 
 		 * @see controller/jobs/order/cleanup/unfinished/decorators/excludes
 		 * @see controller/jobs/order/cleanup/unfinished/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'order/cleanup/unfinished' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'order/cleanup/unfinished');
 	}
 }
\ No newline at end of file

controller/jobs/src/Controller/Jobs/Order/Cleanup/Unfinished/Standard.php

Spacing +17 added lines, -17 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Removes unfinished orders' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Removes unfinished orders');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Deletes unfinished orders an makes their products and coupon codes available again' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Deletes unfinished orders an makes their products and coupon codes available again');
 	}
 
 
@@ -52,9 +52,9 @@ 
 	public function run()
 	{
 		$context = $this->getContext();
-		$controller = \Aimeos\Controller\Common\Order\Factory::createController( $context );
-		$baseManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$controller = \Aimeos\Controller\Common\Order\Factory::createController($context);
+		$baseManager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order');
 
 		/** controller/jobs/order/cleanup/unfinished/keep-hours
 		 * Release the ordered products after the configured time if no payment was confirmed
@@ -74,35 +74,35 @@ 
 		 * @since 2014.07
 		 * @category User
 		 */
-		$hours = $context->getConfig()->get( 'controller/jobs/order/cleanup/unfinished/keep-hours', 24 );
-		$limit = date( 'Y-m-d H:i:s', time() - 3600 * $hours );
+		$hours = $context->getConfig()->get('controller/jobs/order/cleanup/unfinished/keep-hours', 24);
+		$limit = date('Y-m-d H:i:s', time() - 3600 * $hours);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '<', 'order.mtime', $limit ),
-			$search->compare( '==', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_UNFINISHED ),
+			$search->compare('<', 'order.mtime', $limit),
+			$search->compare('==', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_UNFINISHED),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
 		$start = 0;
 
 		do
 		{
 			$baseIds = array();
-			$items = $manager->searchItems( $search );
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $item )
+			foreach ($items as $item)
 			{
-				$controller->unblock( $item );
+				$controller->unblock($item);
 				$baseIds[] = $item->getBaseId();
 			}
 
-			$baseManager->deleteItems( $baseIds );
+			$baseManager->deleteItems($baseIds);
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count >= $search->getSliceSize() );
+		while ($count >= $search->getSliceSize());
 	}
 }

controller/jobs/src/Controller/Jobs/Order/Service/Async/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -30,7 +30,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/order/service/async/name
 		 * Class name of the used order service async scheduler controller implementation
@@ -65,20 +65,20 @@ 
 		 * @since 2014.07
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/order/service/async/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/order/service/async/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Order\\Service\\Async\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Order\\Service\\Async\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Order\\Service\\Async\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/order/service/async/decorators/excludes
 		 * Excludes decorators added by the "common" option from the order service async controllers
@@ -154,6 +154,6 @@ 
 		 * @see controller/jobs/order/service/async/decorators/excludes
 		 * @see controller/jobs/order/service/async/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'order/service/async' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'order/service/async');
 	}
 }
\ No newline at end of file

controller/jobs/src/Controller/Jobs/Order/Service/Async/Standard.php

Spacing +11 added lines, -11 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Batch update of payment/delivery status' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Batch update of payment/delivery status');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Executes payment or delivery service providers that uses batch updates' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Executes payment or delivery service providers that uses batch updates');
 	}
 
 
@@ -52,32 +52,32 @@ 
 	public function run()
 	{
 		$context = $this->getContext();
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $context, 'service' );
+		$serviceManager = \Aimeos\MShop\Factory::createManager($context, 'service');
 
 		$search = $serviceManager->createSearch();
 		$start = 0;
 
 		do
 		{
-			$serviceItems = $serviceManager->searchItems( $search );
+			$serviceItems = $serviceManager->searchItems($search);
 
-			foreach( $serviceItems as $serviceItem )
+			foreach ($serviceItems as $serviceItem)
 			{
 				try
 				{
-					$serviceManager->getProvider( $serviceItem )->updateAsync();
+					$serviceManager->getProvider($serviceItem)->updateAsync();
 				}
-				catch( \Exception $e )
+				catch (\Exception $e)
 				{
 					$msg = 'Executing updateAsyc() of "%1$s" failed: %2$s';
-					$context->getLogger()->log( sprintf( $msg, $serviceItem->getProvider(), $e->getMessage() ) );
+					$context->getLogger()->log(sprintf($msg, $serviceItem->getProvider(), $e->getMessage()));
 				}
 			}
 
-			$count = count( $serviceItems );
+			$count = count($serviceItems);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count >= $search->getSliceSize() );
+		while ($count >= $search->getSliceSize());
 	}
 }

Braces +1 added lines, -2 removed lines

@@ -66,8 +66,7 @@
 				try
 				{
 					$serviceManager->getProvider( $serviceItem )->updateAsync();
-				}
-				catch( \Exception $e )
+				} catch( \Exception $e )
 				{
 					$msg = 'Executing updateAsyc() of "%1$s" failed: %2$s';
 					$context->getLogger()->log( sprintf( $msg, $serviceItem->getProvider(), $e->getMessage() ) );

controller/jobs/src/Controller/Jobs/Order/Service/Payment/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -30,7 +30,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/order/service/payment/name
 		 * Class name of the used order service payment scheduler controller implementation
@@ -65,20 +65,20 @@ 
 		 * @since 2014.07
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/order/service/payment/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/order/service/payment/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Order\\Service\\Payment\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Order\\Service\\Payment\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Order\\Service\\Payment\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/order/service/payment/decorators/excludes
 		 * Excludes decorators added by the "common" option from the order service payment controllers
@@ -154,6 +154,6 @@ 
 		 * @see controller/jobs/order/service/payment/decorators/excludes
 		 * @see controller/jobs/order/service/payment/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'order/service/payment' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'order/service/payment');
 	}
 }
\ No newline at end of file

controller/jobs/src/Controller/Jobs/Order/Service/Payment/Standard.php

Braces +3 added lines, -6 removed lines

@@ -120,8 +120,7 @@ 
 					{
 						$capdate = date( 'Y-m-d 00:00:00', time() - 86400 * $capDays );
 						$expr[] = $orderSearch->compare( '<=', 'order.datepayment', $capdate );
-					}
-					else
+					} else
 					{
 						$expr[] = $orderSearch->compare( '==', 'order.statusdelivery', $status );
 					}
@@ -144,8 +143,7 @@ 
 							try
 							{
 								$serviceProvider->capture( $orderItem );
-							}
-							catch( \Exception $e )
+							} catch( \Exception $e )
 							{
 								$str = 'Error while capturing payment for order with ID "%1$s": %2$s';
 								$context->getLogger()->log( sprintf( $str, $orderItem->getId(), $e->getMessage() ) );
@@ -157,8 +155,7 @@ 
 						$orderSearch->setSlice( $orderStart );
 					}
 					while( $orderCount >= $orderSearch->getSliceSize() );
-				}
-				catch( \Exception $e )
+				} catch( \Exception $e )
 				{
 					$str = 'Error while capturing payments for service with ID "%1$s": %2$s';
 					$context->getLogger()->log( sprintf( $str, $serviceItem->getId(), $e->getMessage() ) );

Spacing +35 added lines, -35 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Capture authorized payments' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Capture authorized payments');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Authorized payments of orders will be captured after dispatching or after a configurable amount of time' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Authorized payments of orders will be captured after dispatching or after a configurable amount of time');
 	}
 
 
@@ -68,8 +68,8 @@ 
 		 * @category User
 		 * @category Developer
 		 */
-		$days = $config->get( 'controller/jobs/order/service/payment/limit-days', 90 );
-		$date = date( 'Y-m-d 00:00:00', time() - 86400 * $days );
+		$days = $config->get('controller/jobs/order/service/payment/limit-days', 90);
+		$date = date('Y-m-d 00:00:00', time() - 86400 * $days);
 
 		/** controller/jobs/order/service/payment/capture-days
 		 * Automatically capture payments after the configured amount of days
@@ -84,90 +84,90 @@ 
 		 * @category User
 		 * @category Developer
 		 */
-		$capDays = $config->get( 'controller/jobs/order/service/payment/capture-days', null );
+		$capDays = $config->get('controller/jobs/order/service/payment/capture-days', null);
 
 
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $context, 'service' );
+		$serviceManager = \Aimeos\MShop\Factory::createManager($context, 'service');
 		$serviceSearch = $serviceManager->createSearch();
-		$serviceSearch->setConditions( $serviceSearch->compare( '==', 'service.type.code', 'payment' ) );
+		$serviceSearch->setConditions($serviceSearch->compare('==', 'service.type.code', 'payment'));
 
-		$orderManager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$orderManager = \Aimeos\MShop\Factory::createManager($context, 'order');
 		$orderSearch = $orderManager->createSearch();
 
-		$status = array( \Aimeos\MShop\Order\Item\Base::STAT_DISPATCHED, \Aimeos\MShop\Order\Item\Base::STAT_DELIVERED );
+		$status = array(\Aimeos\MShop\Order\Item\Base::STAT_DISPATCHED, \Aimeos\MShop\Order\Item\Base::STAT_DELIVERED);
 		$start = 0;
 
 		do
 		{
-			$serviceItems = $serviceManager->searchItems( $serviceSearch );
+			$serviceItems = $serviceManager->searchItems($serviceSearch);
 
-			foreach( $serviceItems as $serviceItem )
+			foreach ($serviceItems as $serviceItem)
 			{
 				try
 				{
-					$serviceProvider = $serviceManager->getProvider( $serviceItem );
+					$serviceProvider = $serviceManager->getProvider($serviceItem);
 
-					if( !$serviceProvider->isImplemented( \Aimeos\MShop\Service\Provider\Payment\Base::FEAT_CAPTURE ) ) {
+					if (!$serviceProvider->isImplemented(\Aimeos\MShop\Service\Provider\Payment\Base::FEAT_CAPTURE)) {
 						continue;
 					}
 
 
 					$expr = array();
-					$expr[] = $orderSearch->compare( '>', 'order.datepayment', $date );
+					$expr[] = $orderSearch->compare('>', 'order.datepayment', $date);
 
-					if( $capDays !== null )
+					if ($capDays !== null)
 					{
-						$capdate = date( 'Y-m-d 00:00:00', time() - 86400 * $capDays );
-						$expr[] = $orderSearch->compare( '<=', 'order.datepayment', $capdate );
+						$capdate = date('Y-m-d 00:00:00', time() - 86400 * $capDays);
+						$expr[] = $orderSearch->compare('<=', 'order.datepayment', $capdate);
 					}
 					else
 					{
-						$expr[] = $orderSearch->compare( '==', 'order.statusdelivery', $status );
+						$expr[] = $orderSearch->compare('==', 'order.statusdelivery', $status);
 					}
 
-					$expr[] = $orderSearch->compare( '==', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_AUTHORIZED );
-					$expr[] = $orderSearch->compare( '==', 'order.base.service.code', $serviceItem->getCode() );
-					$expr[] = $orderSearch->compare( '==', 'order.base.service.type', 'payment' );
+					$expr[] = $orderSearch->compare('==', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_AUTHORIZED);
+					$expr[] = $orderSearch->compare('==', 'order.base.service.code', $serviceItem->getCode());
+					$expr[] = $orderSearch->compare('==', 'order.base.service.type', 'payment');
 
-					$orderSearch->setConditions( $orderSearch->combine( '&&', $expr ) );
+					$orderSearch->setConditions($orderSearch->combine('&&', $expr));
 
 
 					$orderStart = 0;
 
 					do
 					{
-						$orderItems = $orderManager->searchItems( $orderSearch );
+						$orderItems = $orderManager->searchItems($orderSearch);
 
-						foreach( $orderItems as $orderItem )
+						foreach ($orderItems as $orderItem)
 						{
 							try
 							{
-								$serviceProvider->capture( $orderItem );
+								$serviceProvider->capture($orderItem);
 							}
-							catch( \Exception $e )
+							catch (\Exception $e)
 							{
 								$str = 'Error while capturing payment for order with ID "%1$s": %2$s';
-								$context->getLogger()->log( sprintf( $str, $orderItem->getId(), $e->getMessage() ) );
+								$context->getLogger()->log(sprintf($str, $orderItem->getId(), $e->getMessage()));
 							}
 						}
 
-						$orderCount = count( $orderItems );
+						$orderCount = count($orderItems);
 						$orderStart += $orderCount;
-						$orderSearch->setSlice( $orderStart );
+						$orderSearch->setSlice($orderStart);
 					}
-					while( $orderCount >= $orderSearch->getSliceSize() );
+					while ($orderCount >= $orderSearch->getSliceSize());
 				}
-				catch( \Exception $e )
+				catch (\Exception $e)
 				{
 					$str = 'Error while capturing payments for service with ID "%1$s": %2$s';
-					$context->getLogger()->log( sprintf( $str, $serviceItem->getId(), $e->getMessage() ) );
+					$context->getLogger()->log(sprintf($str, $serviceItem->getId(), $e->getMessage()));
 				}
 			}
 
-			$count = count( $serviceItems );
+			$count = count($serviceItems);
 			$start += $count;
-			$serviceSearch->setSlice( $start );
+			$serviceSearch->setSlice($start);
 		}
-		while( $count >= $serviceSearch->getSliceSize() );
+		while ($count >= $serviceSearch->getSliceSize());
 	}
 }