Inspection of "Fixed scrutinizer-ci issues" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96b5a6...c41e60 )

by Aimeos

created 2016-04-27 22:54 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Email/Delivery/StandardTest.php 1 patch

Spacing +43 added lines, -43 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Order delivery related e-mails', $this->object->getName() );
+		$this->assertEquals('Order delivery related e-mails', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Sends order delivery status update e-mails';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -59,67 +59,67 @@  discard block
 block discarded – undo
 		$aimeos = \TestHelperJobs::getAimeos();
 
 
-		$mailStub = $this->getMockBuilder( '\\Aimeos\\MW\\Mail\\None' )
+		$mailStub = $this->getMockBuilder('\\Aimeos\\MW\\Mail\\None')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$mailMsgStub = $this->getMockBuilder( '\\Aimeos\\MW\\Mail\\Message\\None' )
+		$mailMsgStub = $this->getMockBuilder('\\Aimeos\\MW\\Mail\\Message\\None')
 			->disableOriginalConstructor()
 			->disableOriginalClone()
 			->getMock();
 
-		$mailStub->expects( $this->once() )
-			->method( 'createMessage' )
-			->will( $this->returnValue( $mailMsgStub ) );
+		$mailStub->expects($this->once())
+			->method('createMessage')
+			->will($this->returnValue($mailMsgStub));
 
-		$mailStub->expects( $this->once() )->method( 'send' );
+		$mailStub->expects($this->once())->method('send');
 
-		$context->setMail( $mailStub );
+		$context->setMail($mailStub);
 
 
-		$orderAddressItem = \Aimeos\MShop\Order\Manager\Factory::createManager( $context )
-			->getSubManager( 'base' )->getSubManager( 'address' )->createItem();
+		$orderAddressItem = \Aimeos\MShop\Order\Manager\Factory::createManager($context)
+			->getSubManager('base')->getSubManager('address')->createItem();
 
 
 		$name = 'ControllerJobsEmailDeliveryDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems', 'getSubManager' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems', 'getSubManager'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderStatusManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Status\\Standard' )
-			->setMethods( array( 'saveItem' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderStatusManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Status\\Standard')
+			->setMethods(array('saveItem'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setMethods( array( 'load' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setMethods(array('load'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
-		$orderItem = new \Aimeos\MShop\Order\Item\Standard( array( 'ctime' => '2000-01-01 00:00:00' ) );
+		$orderItem = new \Aimeos\MShop\Order\Item\Standard(array('ctime' => '2000-01-01 00:00:00'));
 		$orderBaseItem = $orderBaseManagerStub->createItem();
-		$orderBaseItem->setAddress( $orderAddressItem );
+		$orderBaseItem->setAddress($orderAddressItem);
 
 
-		$orderManagerStub->expects( $this->exactly( 2 ) )->method( 'getSubManager' )
-			->will( $this->onConsecutiveCalls( $orderStatusManagerStub, $orderBaseManagerStub ) );
+		$orderManagerStub->expects($this->exactly(2))->method('getSubManager')
+			->will($this->onConsecutiveCalls($orderStatusManagerStub, $orderBaseManagerStub));
 
-		$orderManagerStub->expects( $this->exactly( 4 ) )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), array(), array(), array() ) );
+		$orderManagerStub->expects($this->exactly(4))->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), array(), array(), array()));
 
-		$orderBaseManagerStub->expects( $this->once() )->method( 'load' )
-			->will( $this->returnValue( $orderBaseItem ) );
+		$orderBaseManagerStub->expects($this->once())->method('load')
+			->will($this->returnValue($orderBaseItem));
 
-		$orderStatusManagerStub->expects( $this->once() )->method( 'saveItem' );
+		$orderStatusManagerStub->expects($this->once())->method('saveItem');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -130,33 +130,33 @@  discard block
 block discarded – undo
 		$aimeos = \TestHelperJobs::getAimeos();
 
 
-		$mailStub = $this->getMockBuilder( '\\Aimeos\\MW\\Mail\\None' )
+		$mailStub = $this->getMockBuilder('\\Aimeos\\MW\\Mail\\None')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$context->setMail( $mailStub );
+		$context->setMail($mailStub);
 
 
 		$name = 'ControllerJobsEmailDeliveryDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$orderItem = $orderManagerStub->createItem();
 
 
-		$orderManagerStub->expects( $this->exactly( 4 ) )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), array(), array(), array() ) );
+		$orderManagerStub->expects($this->exactly(4))->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), array(), array(), array()));
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard($context, $aimeos);
 		$object->run();
 	}
 

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Cleanup/Unpaid/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Cleanup/Unpaid/StandardTest.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
 	}
 
 
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Removes unpaid orders', $this->object->getName() );
+		$this->assertEquals('Removes unpaid orders', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Deletes unpaid orders to keep the database clean';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -61,47 +61,47 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsOrderCleanupUnpaidDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/order/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
+		$context->getConfig()->set('controller/common/order/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems', 'getSubManager' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems', 'getSubManager'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
-		->setMethods( array( 'unblock' ) )
-		->setConstructorArgs( array( $context ) )
+		$orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
+		->setMethods(array('unblock'))
+		->setConstructorArgs(array($context))
 		->getMock();
 
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
-		\Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
+		\Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
 
 
 		$orderItem = $orderManagerStub->createItem();
-		$orderItem->setBaseId( 1 );
-		$orderItem->setId( 2 );
+		$orderItem->setBaseId(1);
+		$orderItem->setId(2);
 
 
-		$orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
-			->will( $this->returnValue( $orderBaseManagerStub ) );
+		$orderManagerStub->expects($this->once())->method('getSubManager')
+			->will($this->returnValue($orderBaseManagerStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue(array($orderItem->getId() => $orderItem)));
 
-		$orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
+		$orderBaseManagerStub->expects($this->once())->method('deleteItems');
 
-		$orderCntlStub->expects( $this->once() )->method( 'unblock' );
+		$orderCntlStub->expects($this->once())->method('unblock');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Cleanup/Unfinished/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Cleanup/Unfinished/StandardTest.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
 	}
 
 
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Removes unfinished orders', $this->object->getName() );
+		$this->assertEquals('Removes unfinished orders', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Deletes unfinished orders an makes their products and coupon codes available again';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -61,47 +61,47 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsOrderCleanupUnfinishedDefaultRun';
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
-		$context->getConfig()->set( 'controller/common/order/name', $name );
+		$context->getConfig()->set('mshop/order/manager/name', $name);
+		$context->getConfig()->set('controller/common/order/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'searchItems', 'getSubManager' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('searchItems', 'getSubManager'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
-			->setMethods( array( 'unblock' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
+			->setMethods(array('unblock'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
 
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
-		\Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
+		\Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
 
 
 		$orderItem = $orderManagerStub->createItem();
-		$orderItem->setBaseId( 1 );
-		$orderItem->setId( 2 );
+		$orderItem->setBaseId(1);
+		$orderItem->setId(2);
 
 
-		$orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
-			->will( $this->returnValue( $orderBaseManagerStub ) );
+		$orderManagerStub->expects($this->once())->method('getSubManager')
+			->will($this->returnValue($orderBaseManagerStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue(array($orderItem->getId() => $orderItem)));
 
-		$orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
+		$orderBaseManagerStub->expects($this->once())->method('deleteItems');
 
-		$orderCntlStub->expects( $this->once() )->method( 'unblock' );
+		$orderCntlStub->expects($this->once())->method('unblock');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Service/Async/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Async\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Service/Async/StandardTest.php 1 patch

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Batch update of payment/delivery status', $this->object->getName() );
+		$this->assertEquals('Batch update of payment/delivery status', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Executes payment or delivery service providers that uses batch updates';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -60,34 +60,34 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsServiceAsyncProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
 
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Manual' )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Manual')
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), array() ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), array()));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'updateAsync' );
+		$serviceProviderStub->expects($this->once())->method('updateAsync');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -99,27 +99,27 @@  discard block
 block discarded – undo
 
 
 		$name = 'ControllerJobsServiceAsyncProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
 
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), array() ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), array()));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception() ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception()));
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
 		$object->run();
 	}
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Order/Service/Payment/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	$context = \TestHelperJobs::getContext();
25	25	$aimeos = \TestHelperJobs::getAimeos();
26	26
27		- $this->object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard( $context, $aimeos );
	27	+ $this->object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard($context, $aimeos);
28	28	}
29	29
30	30
		@@ -42,14 +42,14 @@ discard block
		block discarded – undo
42	42
43	43	public function testGetName()
44	44	{
45		- $this->assertEquals( 'Order delivery related e-mails', $this->object->getName() );
	45	+ $this->assertEquals('Order delivery related e-mails', $this->object->getName());
46	46	}
47	47
48	48
49	49	public function testGetDescription()
50	50	{
51	51	$text = 'Sends order delivery status update e-mails';
52		- $this->assertEquals( $text, $this->object->getDescription() );
	52	+ $this->assertEquals($text, $this->object->getDescription());
53	53	}
54	54
55	55
		@@ -59,67 +59,67 @@ discard block
		block discarded – undo
59	59	$aimeos = \TestHelperJobs::getAimeos();
60	60
61	61
62		- $mailStub = $this->getMockBuilder( '\\Aimeos\\MW\\Mail\\None' )
	62	+ $mailStub = $this->getMockBuilder('\\Aimeos\\MW\\Mail\\None')
63	63	->disableOriginalConstructor()
64	64	->getMock();
65	65
66		- $mailMsgStub = $this->getMockBuilder( '\\Aimeos\\MW\\Mail\\Message\\None' )
	66	+ $mailMsgStub = $this->getMockBuilder('\\Aimeos\\MW\\Mail\\Message\\None')
67	67	->disableOriginalConstructor()
68	68	->disableOriginalClone()
69	69	->getMock();
70	70
71		- $mailStub->expects( $this->once() )
72		- ->method( 'createMessage' )
73		- ->will( $this->returnValue( $mailMsgStub ) );
	71	+ $mailStub->expects($this->once())
	72	+ ->method('createMessage')
	73	+ ->will($this->returnValue($mailMsgStub));
74	74
75		- $mailStub->expects( $this->once() )->method( 'send' );
	75	+ $mailStub->expects($this->once())->method('send');
76	76
77		- $context->setMail( $mailStub );
	77	+ $context->setMail($mailStub);
78	78
79	79
80		- $orderAddressItem = \Aimeos\MShop\Order\Manager\Factory::createManager( $context )
81		- ->getSubManager( 'base' )->getSubManager( 'address' )->createItem();
	80	+ $orderAddressItem = \Aimeos\MShop\Order\Manager\Factory::createManager($context)
	81	+ ->getSubManager('base')->getSubManager('address')->createItem();
82	82
83	83
84	84	$name = 'ControllerJobsEmailDeliveryDefaultRun';
85		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
	85	+ $context->getConfig()->set('mshop/order/manager/name', $name);
86	86
87		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
88		- ->setMethods( array( 'searchItems', 'getSubManager' ) )
89		- ->setConstructorArgs( array( $context ) )
	87	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	88	+ ->setMethods(array('searchItems', 'getSubManager'))
	89	+ ->setConstructorArgs(array($context))
90	90	->getMock();
91	91
92		- $orderStatusManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Status\\Standard' )
93		- ->setMethods( array( 'saveItem' ) )
94		- ->setConstructorArgs( array( $context ) )
	92	+ $orderStatusManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Status\\Standard')
	93	+ ->setMethods(array('saveItem'))
	94	+ ->setConstructorArgs(array($context))
95	95	->getMock();
96	96
97		- $orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
98		- ->setMethods( array( 'load' ) )
99		- ->setConstructorArgs( array( $context ) )
	97	+ $orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
	98	+ ->setMethods(array('load'))
	99	+ ->setConstructorArgs(array($context))
100	100	->getMock();
101	101
102		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
	102	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
103	103
104	104
105		- $orderItem = new \Aimeos\MShop\Order\Item\Standard( array( 'ctime' => '2000-01-01 00:00:00' ) );
	105	+ $orderItem = new \Aimeos\MShop\Order\Item\Standard(array('ctime' => '2000-01-01 00:00:00'));
106	106	$orderBaseItem = $orderBaseManagerStub->createItem();
107		- $orderBaseItem->setAddress( $orderAddressItem );
	107	+ $orderBaseItem->setAddress($orderAddressItem);
108	108
109	109
110		- $orderManagerStub->expects( $this->exactly( 2 ) )->method( 'getSubManager' )
111		- ->will( $this->onConsecutiveCalls( $orderStatusManagerStub, $orderBaseManagerStub ) );
	110	+ $orderManagerStub->expects($this->exactly(2))->method('getSubManager')
	111	+ ->will($this->onConsecutiveCalls($orderStatusManagerStub, $orderBaseManagerStub));
112	112
113		- $orderManagerStub->expects( $this->exactly( 4 ) )->method( 'searchItems' )
114		- ->will( $this->onConsecutiveCalls( array( $orderItem ), array(), array(), array() ) );
	113	+ $orderManagerStub->expects($this->exactly(4))->method('searchItems')
	114	+ ->will($this->onConsecutiveCalls(array($orderItem), array(), array(), array()));
115	115
116		- $orderBaseManagerStub->expects( $this->once() )->method( 'load' )
117		- ->will( $this->returnValue( $orderBaseItem ) );
	116	+ $orderBaseManagerStub->expects($this->once())->method('load')
	117	+ ->will($this->returnValue($orderBaseItem));
118	118
119		- $orderStatusManagerStub->expects( $this->once() )->method( 'saveItem' );
	119	+ $orderStatusManagerStub->expects($this->once())->method('saveItem');
120	120
121	121
122		- $object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard( $context, $aimeos );
	122	+ $object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard($context, $aimeos);
123	123	$object->run();
124	124	}
125	125
		@@ -130,33 +130,33 @@ discard block
		block discarded – undo
130	130	$aimeos = \TestHelperJobs::getAimeos();
131	131
132	132
133		- $mailStub = $this->getMockBuilder( '\\Aimeos\\MW\\Mail\\None' )
	133	+ $mailStub = $this->getMockBuilder('\\Aimeos\\MW\\Mail\\None')
134	134	->disableOriginalConstructor()
135	135	->getMock();
136	136
137		- $context->setMail( $mailStub );
	137	+ $context->setMail($mailStub);
138	138
139	139
140	140	$name = 'ControllerJobsEmailDeliveryDefaultRun';
141		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
	141	+ $context->getConfig()->set('mshop/order/manager/name', $name);
142	142
143	143
144		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
145		- ->setMethods( array( 'searchItems' ) )
146		- ->setConstructorArgs( array( $context ) )
	144	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	145	+ ->setMethods(array('searchItems'))
	146	+ ->setConstructorArgs(array($context))
147	147	->getMock();
148	148
149		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
	149	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
150	150
151	151
152	152	$orderItem = $orderManagerStub->createItem();
153	153
154	154
155		- $orderManagerStub->expects( $this->exactly( 4 ) )->method( 'searchItems' )
156		- ->will( $this->onConsecutiveCalls( array( $orderItem ), array(), array(), array() ) );
	155	+ $orderManagerStub->expects($this->exactly(4))->method('searchItems')
	156	+ ->will($this->onConsecutiveCalls(array($orderItem), array(), array(), array()));
157	157
158	158
159		- $object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard( $context, $aimeos );
	159	+ $object = new \Aimeos\Controller\Jobs\Order\Email\Delivery\Standard($context, $aimeos);
160	160	$object->run();
161	161	}
162	162

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
	28	+ $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
29	29	}
30	30
31	31
		@@ -43,14 +43,14 @@ discard block
		block discarded – undo
43	43
44	44	public function testGetName()
45	45	{
46		- $this->assertEquals( 'Removes unpaid orders', $this->object->getName() );
	46	+ $this->assertEquals('Removes unpaid orders', $this->object->getName());
47	47	}
48	48
49	49
50	50	public function testGetDescription()
51	51	{
52	52	$text = 'Deletes unpaid orders to keep the database clean';
53		- $this->assertEquals( $text, $this->object->getDescription() );
	53	+ $this->assertEquals($text, $this->object->getDescription());
54	54	}
55	55
56	56
		@@ -61,47 +61,47 @@ discard block
		block discarded – undo
61	61
62	62
63	63	$name = 'ControllerJobsOrderCleanupUnpaidDefaultRun';
64		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
65		- $context->getConfig()->set( 'controller/common/order/name', $name );
	64	+ $context->getConfig()->set('mshop/order/manager/name', $name);
	65	+ $context->getConfig()->set('controller/common/order/name', $name);
66	66
67	67
68		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
69		- ->setMethods( array( 'searchItems', 'getSubManager' ) )
70		- ->setConstructorArgs( array( $context ) )
	68	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	69	+ ->setMethods(array('searchItems', 'getSubManager'))
	70	+ ->setConstructorArgs(array($context))
71	71	->getMock();
72	72
73		- $orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
74		- ->setMethods( array( 'deleteItems' ) )
75		- ->setConstructorArgs( array( $context ) )
	73	+ $orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
	74	+ ->setMethods(array('deleteItems'))
	75	+ ->setConstructorArgs(array($context))
76	76	->getMock();
77	77
78		- $orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
79		- ->setMethods( array( 'unblock' ) )
80		- ->setConstructorArgs( array( $context ) )
	78	+ $orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
	79	+ ->setMethods(array('unblock'))
	80	+ ->setConstructorArgs(array($context))
81	81	->getMock();
82	82
83	83
84		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
85		- \Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
	84	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
	85	+ \Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
86	86
87	87
88	88	$orderItem = $orderManagerStub->createItem();
89		- $orderItem->setBaseId( 1 );
90		- $orderItem->setId( 2 );
	89	+ $orderItem->setBaseId(1);
	90	+ $orderItem->setId(2);
91	91
92	92
93		- $orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
94		- ->will( $this->returnValue( $orderBaseManagerStub ) );
	93	+ $orderManagerStub->expects($this->once())->method('getSubManager')
	94	+ ->will($this->returnValue($orderBaseManagerStub));
95	95
96		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
97		- ->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
	96	+ $orderManagerStub->expects($this->once())->method('searchItems')
	97	+ ->will($this->returnValue(array($orderItem->getId() => $orderItem)));
98	98
99		- $orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
	99	+ $orderBaseManagerStub->expects($this->once())->method('deleteItems');
100	100
101		- $orderCntlStub->expects( $this->once() )->method( 'unblock' );
	101	+ $orderCntlStub->expects($this->once())->method('unblock');
102	102
103	103
104		- $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard( $context, $aimeos );
	104	+ $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Standard($context, $aimeos);
105	105	$object->run();
106	106	}
107	107	}

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
	28	+ $this->object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
29	29	}
30	30
31	31
		@@ -43,14 +43,14 @@ discard block
		block discarded – undo
43	43
44	44	public function testGetName()
45	45	{
46		- $this->assertEquals( 'Removes unfinished orders', $this->object->getName() );
	46	+ $this->assertEquals('Removes unfinished orders', $this->object->getName());
47	47	}
48	48
49	49
50	50	public function testGetDescription()
51	51	{
52	52	$text = 'Deletes unfinished orders an makes their products and coupon codes available again';
53		- $this->assertEquals( $text, $this->object->getDescription() );
	53	+ $this->assertEquals($text, $this->object->getDescription());
54	54	}
55	55
56	56
		@@ -61,47 +61,47 @@ discard block
		block discarded – undo
61	61
62	62
63	63	$name = 'ControllerJobsOrderCleanupUnfinishedDefaultRun';
64		- $context->getConfig()->set( 'mshop/order/manager/name', $name );
65		- $context->getConfig()->set( 'controller/common/order/name', $name );
	64	+ $context->getConfig()->set('mshop/order/manager/name', $name);
	65	+ $context->getConfig()->set('controller/common/order/name', $name);
66	66
67	67
68		- $orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
69		- ->setMethods( array( 'searchItems', 'getSubManager' ) )
70		- ->setConstructorArgs( array( $context ) )
	68	+ $orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
	69	+ ->setMethods(array('searchItems', 'getSubManager'))
	70	+ ->setConstructorArgs(array($context))
71	71	->getMock();
72	72
73		- $orderBaseManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
74		- ->setMethods( array( 'deleteItems' ) )
75		- ->setConstructorArgs( array( $context ) )
	73	+ $orderBaseManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
	74	+ ->setMethods(array('deleteItems'))
	75	+ ->setConstructorArgs(array($context))
76	76	->getMock();
77	77
78		- $orderCntlStub = $this->getMockBuilder( '\\Aimeos\\Controller\\Common\\Order\\Standard' )
79		- ->setMethods( array( 'unblock' ) )
80		- ->setConstructorArgs( array( $context ) )
	78	+ $orderCntlStub = $this->getMockBuilder('\\Aimeos\\Controller\\Common\\Order\\Standard')
	79	+ ->setMethods(array('unblock'))
	80	+ ->setConstructorArgs(array($context))
81	81	->getMock();
82	82
83	83
84		- \Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
85		- \Aimeos\Controller\Common\Order\Factory::injectController( '\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub );
	84	+ \Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
	85	+ \Aimeos\Controller\Common\Order\Factory::injectController('\\Aimeos\\Controller\\Common\\Order\\' . $name, $orderCntlStub);
86	86
87	87
88	88	$orderItem = $orderManagerStub->createItem();
89		- $orderItem->setBaseId( 1 );
90		- $orderItem->setId( 2 );
	89	+ $orderItem->setBaseId(1);
	90	+ $orderItem->setId(2);
91	91
92	92
93		- $orderManagerStub->expects( $this->once() )->method( 'getSubManager' )
94		- ->will( $this->returnValue( $orderBaseManagerStub ) );
	93	+ $orderManagerStub->expects($this->once())->method('getSubManager')
	94	+ ->will($this->returnValue($orderBaseManagerStub));
95	95
96		- $orderManagerStub->expects( $this->once() )->method( 'searchItems' )
97		- ->will( $this->returnValue( array( $orderItem->getId() => $orderItem ) ) );
	96	+ $orderManagerStub->expects($this->once())->method('searchItems')
	97	+ ->will($this->returnValue(array($orderItem->getId() => $orderItem)));
98	98
99		- $orderBaseManagerStub->expects( $this->once() )->method( 'deleteItems' );
	99	+ $orderBaseManagerStub->expects($this->once())->method('deleteItems');
100	100
101		- $orderCntlStub->expects( $this->once() )->method( 'unblock' );
	101	+ $orderCntlStub->expects($this->once())->method('unblock');
102	102
103	103
104		- $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard( $context, $aimeos );
	104	+ $object = new \Aimeos\Controller\Jobs\Order\Cleanup\Unfinished\Standard($context, $aimeos);
105	105	$object->run();
106	106	}
107	107	}

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	$context = \TestHelperJobs::getContext();
25	25	$aimeos = \TestHelperJobs::getAimeos();
26	26
27		- $this->object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
	27	+ $this->object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
28	28	}
29	29
30	30
		@@ -42,14 +42,14 @@ discard block
		block discarded – undo
42	42
43	43	public function testGetName()
44	44	{
45		- $this->assertEquals( 'Batch update of payment/delivery status', $this->object->getName() );
	45	+ $this->assertEquals('Batch update of payment/delivery status', $this->object->getName());
46	46	}
47	47
48	48
49	49	public function testGetDescription()
50	50	{
51	51	$text = 'Executes payment or delivery service providers that uses batch updates';
52		- $this->assertEquals( $text, $this->object->getDescription() );
	52	+ $this->assertEquals($text, $this->object->getDescription());
53	53	}
54	54
55	55
		@@ -60,34 +60,34 @@ discard block
		block discarded – undo
60	60
61	61
62	62	$name = 'ControllerJobsServiceAsyncProcessDefaultRun';
63		- $context->getConfig()->set( 'mshop/service/manager/name', $name );
	63	+ $context->getConfig()->set('mshop/service/manager/name', $name);
64	64
65	65
66		- $serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
67		- ->setMethods( array( 'getProvider', 'searchItems' ) )
68		- ->setConstructorArgs( array( $context ) )
	66	+ $serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
	67	+ ->setMethods(array('getProvider', 'searchItems'))
	68	+ ->setConstructorArgs(array($context))
69	69	->getMock();
70	70
71		- \Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
	71	+ \Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
72	72
73	73
74	74	$serviceItem = $serviceManagerStub->createItem();
75	75
76		- $serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Manual' )
77		- ->setConstructorArgs( array( $context, $serviceItem ) )
	76	+ $serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Manual')
	77	+ ->setConstructorArgs(array($context, $serviceItem))
78	78	->getMock();
79	79
80	80
81		- $serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
82		- ->will( $this->onConsecutiveCalls( array( $serviceItem ), array() ) );
	81	+ $serviceManagerStub->expects($this->once())->method('searchItems')
	82	+ ->will($this->onConsecutiveCalls(array($serviceItem), array()));
83	83
84		- $serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
85		- ->will( $this->returnValue( $serviceProviderStub ) );
	84	+ $serviceManagerStub->expects($this->once())->method('getProvider')
	85	+ ->will($this->returnValue($serviceProviderStub));
86	86
87		- $serviceProviderStub->expects( $this->once() )->method( 'updateAsync' );
	87	+ $serviceProviderStub->expects($this->once())->method('updateAsync');
88	88
89	89
90		- $object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
	90	+ $object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
91	91	$object->run();
92	92	}
93	93
		@@ -99,27 +99,27 @@ discard block
		block discarded – undo
99	99
100	100
101	101	$name = 'ControllerJobsServiceAsyncProcessDefaultRun';
102		- $context->getConfig()->set( 'mshop/service/manager/name', $name );
	102	+ $context->getConfig()->set('mshop/service/manager/name', $name);
103	103
104	104
105		- $serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
106		- ->setMethods( array( 'getProvider', 'searchItems' ) )
107		- ->setConstructorArgs( array( $context ) )
	105	+ $serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
	106	+ ->setMethods(array('getProvider', 'searchItems'))
	107	+ ->setConstructorArgs(array($context))
108	108	->getMock();
109	109
110		- \Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
	110	+ \Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
111	111
112	112
113	113	$serviceItem = $serviceManagerStub->createItem();
114	114
115		- $serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
116		- ->will( $this->onConsecutiveCalls( array( $serviceItem ), array() ) );
	115	+ $serviceManagerStub->expects($this->once())->method('searchItems')
	116	+ ->will($this->onConsecutiveCalls(array($serviceItem), array()));
117	117
118		- $serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
119		- ->will( $this->throwException( new \Aimeos\MShop\Service\Exception() ) );
	118	+ $serviceManagerStub->expects($this->once())->method('getProvider')
	119	+ ->will($this->throwException(new \Aimeos\MShop\Service\Exception()));
120	120
121	121
122		- $object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard( $context, $aimeos );
	122	+ $object = new \Aimeos\Controller\Jobs\Order\Service\Async\Standard($context, $aimeos);
123	123	$object->run();
124	124	}
125	125	}

		@@ -15,8 +15,8 @@ discard block
		block discarded – undo
15	15	$context = \TestHelperJobs::getContext();
16	16	$aimeos = \TestHelperJobs::getAimeos();
17	17
18		- $obj = \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos );
19		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	18	+ $obj = \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos);
	19	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
20	20	}
21	21
22	22
		@@ -25,8 +25,8 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
29		- \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	28	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	29	+ \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos, 'Wrong$$$Name');
30	30	}
31	31
32	32
		@@ -35,8 +35,8 @@ discard block
		block discarded – undo
35	35	$context = \TestHelperJobs::getContext();
36	36	$aimeos = \TestHelperJobs::getAimeos();
37	37
38		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
39		- \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos, 'WrongClass' );
	38	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	39	+ \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos, 'WrongClass');
40	40	}
41	41
42	42
		@@ -45,8 +45,8 @@ discard block
		block discarded – undo
45	45	$context = \TestHelperJobs::getContext();
46	46	$aimeos = \TestHelperJobs::getAimeos();
47	47
48		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
49		- \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController( $context, $aimeos, 'Factory' );
	48	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	49	+ \Aimeos\Controller\Jobs\Order\Email\Delivery\Factory::createController($context, $aimeos, 'Factory');
50	50	}
51	51
52	52	}

		@@ -16,8 +16,8 @@ discard block
		block discarded – undo
16	16	$context = \TestHelperJobs::getContext();
17	17	$aimeos = \TestHelperJobs::getAimeos();
18	18
19		- $obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos );
20		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	19	+ $obj = \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos);
	20	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
21	21	}
22	22
23	23
		@@ -26,8 +26,8 @@ discard block
		block discarded – undo
26	26	$context = \TestHelperJobs::getContext();
27	27	$aimeos = \TestHelperJobs::getAimeos();
28	28
29		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
30		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	29	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	30	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Wrong$$$Name');
31	31	}
32	32
33	33
		@@ -36,8 +36,8 @@ discard block
		block discarded – undo
36	36	$context = \TestHelperJobs::getContext();
37	37	$aimeos = \TestHelperJobs::getAimeos();
38	38
39		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
40		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'WrongClass' );
	39	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	40	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'WrongClass');
41	41	}
42	42
43	43
		@@ -46,8 +46,8 @@ discard block
		block discarded – undo
46	46	$context = \TestHelperJobs::getContext();
47	47	$aimeos = \TestHelperJobs::getAimeos();
48	48
49		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
50		- \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController( $context, $aimeos, 'Factory' );
	49	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	50	+ \Aimeos\Controller\Jobs\Order\Cleanup\Unpaid\Factory::createController($context, $aimeos, 'Factory');
51	51	}
52	52
53	53	}

aimeos / ai-controller-jobs

Push — master ( 96b5a6...c41e60 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +43 added lines, -43 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch