StandardTest::testProcessUpdate() - Code Metrics - Inspection of "Implements media, price and text processors for XM..." - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e3443a...9a4066 )

by Aimeos

created 2019-02-15 17:10 UTC

StandardTest::testProcessUpdate() A

↳ Parent: StandardTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	56
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	28
nc	2
nop	0
dl	0
loc	56
rs	9.472
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2019
 */


namespace Aimeos\Controller\Common\Common\Import\Xml\Processor\Lists\Price;


class StandardTest extends \PHPUnit\Framework\TestCase
filter:
    dependency_paths: ["lib/*"]
{
	private $context;
	private $object;


	protected function setUp()
	{
		$this->context = \TestHelperCntl::getContext();
		$this->object = new \Aimeos\Controller\Common\Common\Import\Xml\Processor\Lists\Price\Standard( $this->context );
	}


	protected function tearDown()
	{
		unset( $this->object, $this->context );
	}


	public function testProcess()
	{
		$dom = new \DOMDocument();
		$product = \Aimeos\MShop::create( $this->context, 'product' )->createItem();

		$dom->loadXML( '<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<price>
	<priceitem lists.type="default">
		<price.type><![CDATA[test]]></price.type>
		<price.currencyid><![CDATA[EUR]]></price.currencyid>
		<price.taxrate><![CDATA[20.00]]></price.taxrate>
		<price.quantity><![CDATA[1]]></price.quantity>
		<price.value><![CDATA[10.00]]></price.value>
	</priceitem>
	<priceitem lists.type="test">
		<price.type><![CDATA[default]]></price.type>
		<price.currencyid><![CDATA[USD]]></price.currencyid>
		<price.taxrate><![CDATA[10.00]]></price.taxrate>
		<price.quantity><![CDATA[2]]></price.quantity>
		<price.value><![CDATA[20.00]]></price.value>
	</priceitem>
</price>' );

		$product = $this->object->process( $product, $dom->firstChild );

		$pos = 0;
		$expected = [
			['default', 'test', '1', 'EUR', '20.00', '10.00'],
			['test', 'default', '2', 'USD', '10.00', '20.00'],
		];

		$listItems = $product->getListItems( 'price' );
		$this->assertEquals( 2, count( $listItems ) );

		foreach( $listItems as $listItem )
		{
			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getType() );
			$this->assertEquals( $expected[$pos][2], $listItem->getRefItem()->getQuantity() );
			$this->assertEquals( $expected[$pos][3], $listItem->getRefItem()->getCurrencyId() );
			$this->assertEquals( $expected[$pos][4], $listItem->getRefItem()->getTaxrate() );
			$this->assertEquals( $expected[$pos][5], $listItem->getRefItem()->getValue() );
			$pos++;
		}
	}


	public function testProcessUpdate()
	{
		$dom = new \DOMDocument();
		$manager = \Aimeos\MShop::create( $this->context, 'price' );
		$listManager = \Aimeos\MShop::create( $this->context, 'product/lists' );
		$product = \Aimeos\MShop::create( $this->context, 'product' )->createItem();

		$product->addListItem( 'price',
			$listManager->createItem()->setType( 'default' )->setId( 1 ),
			$manager->createItem()->setType( 'test' )->setCurrencyId( 'EUR' )
				->setTaxrate( '20.00' )->setQuantity( 1 )->setValue( '10.00' )
		);
		$product->addListItem( 'price',
			$listManager->createItem()->setType( 'test' )->setId( 2 ),
			$manager->createItem()->setType( 'default' )->setCurrencyId( 'USD' )
				->setTaxrate( '10.00' )->setQuantity( 2 )->setValue( '20.00' )
		);

		$dom->loadXML( '<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<price>
	<priceitem lists.type="test">
		<price.type><![CDATA[default]]></price.type>
		<price.currencyid><![CDATA[USD]]></price.currencyid>
		<price.taxrate><![CDATA[10.00]]></price.taxrate>
		<price.quantity><![CDATA[2]]></price.quantity>
		<price.value><![CDATA[20.00]]></price.value>
	</priceitem>
	<priceitem lists.type="default">
		<price.type><![CDATA[test]]></price.type>
		<price.currencyid><![CDATA[EUR]]></price.currencyid>
		<price.taxrate><![CDATA[20.00]]></price.taxrate>
		<price.quantity><![CDATA[1]]></price.quantity>
		<price.value><![CDATA[10.00]]></price.value>
	</priceitem>
</price>' );

		$product = $this->object->process( $product, $dom->firstChild );

		$pos = 0;
		$expected = [
			['test', 'default', '2', 'USD', '10.00', '20.00'],
			['default', 'test', '1', 'EUR', '20.00', '10.00'],
		];

		$listItems = $product->getListItems();
		$this->assertEquals( 2, count( $listItems ) );

		foreach( $listItems as $listItem )
		{
			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getType() );
			$this->assertEquals( $expected[$pos][2], $listItem->getRefItem()->getQuantity() );
			$this->assertEquals( $expected[$pos][3], $listItem->getRefItem()->getCurrencyId() );
			$this->assertEquals( $expected[$pos][4], $listItem->getRefItem()->getTaxrate() );
			$this->assertEquals( $expected[$pos][5], $listItem->getRefItem()->getValue() );
			$pos++;
		}
	}


	public function testProcessDelete()
	{
		$dom = new \DOMDocument();
		$manager = \Aimeos\MShop::create( $this->context, 'price' );
		$listManager = \Aimeos\MShop::create( $this->context, 'product/lists' );
		$product = \Aimeos\MShop::create( $this->context, 'product' )->createItem();

		$product->addListItem( 'price',
			$listManager->createItem()->setType( 'default' )->setId( 1 ),
			$manager->createItem()->setType( 'test' )->setCurrencyId( 'EUR' )
				->setTaxrate( '20.00' )->setQuantity( 1 )->setValue( '10.00' )
		);
		$product->addListItem( 'price',
			$listManager->createItem()->setType( 'test' )->setId( 2 ),
			$manager->createItem()->setType( 'default' )->setCurrencyId( 'USD' )
				->setTaxrate( '10.00' )->setQuantity( 2 )->setValue( '20.00' )
		);

		$dom->loadXML( '<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<price>
	<priceitem lists.type="test">
		<price.type><![CDATA[default]]></price.type>
		<price.currencyid><![CDATA[USD]]></price.currencyid>
		<price.taxrate><![CDATA[10.00]]></price.taxrate>
		<price.quantity><![CDATA[2]]></price.quantity>
		<price.value><![CDATA[20.00]]></price.value>
	</priceitem>
</price>' );

		$product = $this->object->process( $product, $dom->firstChild );

		$pos = 0;
		$expected = [['test', 'default', '2', 'USD', '10.00', '20.00']];

		$listItems = $product->getListItems();
		$this->assertEquals( 1, count( $listItems ) );

		foreach( $listItems as $listItem )
		{
			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getType() );
			$this->assertEquals( $expected[$pos][2], $listItem->getRefItem()->getQuantity() );
			$this->assertEquals( $expected[$pos][3], $listItem->getRefItem()->getCurrencyId() );
			$this->assertEquals( $expected[$pos][4], $listItem->getRefItem()->getTaxrate() );
			$this->assertEquals( $expected[$pos][5], $listItem->getRefItem()->getValue() );
			$pos++;
		}
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2019
6			*/
7
8
9			namespace Aimeos\Controller\Common\Common\Import\Xml\Processor\Lists\Price;
10
11
12			class StandardTest extends \PHPUnit\Framework\TestCase
			1 ignored issue – show Bug introduced 2019-02-15 17:12 UTC by Report Bug Copy Issue Report The type `PHPUnit\Framework\TestCase` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
13			{
14			private $context;
15			private $object;
16
17
18			protected function setUp()
19			{
20			$this->context = \TestHelperCntl::getContext();
21			$this->object = new \Aimeos\Controller\Common\Common\Import\Xml\Processor\Lists\Price\Standard( $this->context );
22			}
23
24
25			protected function tearDown()
26			{
27			unset( $this->object, $this->context );
28			}
29
30
31			public function testProcess()
32			{
33			$dom = new \DOMDocument();
34			$product = \Aimeos\MShop::create( $this->context, 'product' )->createItem();
35
36			$dom->loadXML( '<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
37			<price>
38			<priceitem lists.type="default">
39			<price.type><![CDATA[test]]></price.type>
40			<price.currencyid><![CDATA[EUR]]></price.currencyid>
41			<price.taxrate><![CDATA[20.00]]></price.taxrate>
42			<price.quantity><![CDATA[1]]></price.quantity>
43			<price.value><![CDATA[10.00]]></price.value>
44			</priceitem>
45			<priceitem lists.type="test">
46			<price.type><![CDATA[default]]></price.type>
47			<price.currencyid><![CDATA[USD]]></price.currencyid>
48			<price.taxrate><![CDATA[10.00]]></price.taxrate>
49			<price.quantity><![CDATA[2]]></price.quantity>
50			<price.value><![CDATA[20.00]]></price.value>
51			</priceitem>
52			</price>' );
53
54			$product = $this->object->process( $product, $dom->firstChild );
55
56			$pos = 0;
57			$expected = [
58			['default', 'test', '1', 'EUR', '20.00', '10.00'],
59			['test', 'default', '2', 'USD', '10.00', '20.00'],
60			];
61
62			$listItems = $product->getListItems( 'price' );
63			$this->assertEquals( 2, count( $listItems ) );
64
65			foreach( $listItems as $listItem )
66			{
67			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
68			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getType() );
69			$this->assertEquals( $expected[$pos][2], $listItem->getRefItem()->getQuantity() );
70			$this->assertEquals( $expected[$pos][3], $listItem->getRefItem()->getCurrencyId() );
71			$this->assertEquals( $expected[$pos][4], $listItem->getRefItem()->getTaxrate() );
72			$this->assertEquals( $expected[$pos][5], $listItem->getRefItem()->getValue() );
73			$pos++;
74			}
75			}
76
77
78			public function testProcessUpdate()
79			{
80			$dom = new \DOMDocument();
81			$manager = \Aimeos\MShop::create( $this->context, 'price' );
82			$listManager = \Aimeos\MShop::create( $this->context, 'product/lists' );
83			$product = \Aimeos\MShop::create( $this->context, 'product' )->createItem();
84
85			$product->addListItem( 'price',
86			$listManager->createItem()->setType( 'default' )->setId( 1 ),
87			$manager->createItem()->setType( 'test' )->setCurrencyId( 'EUR' )
88			->setTaxrate( '20.00' )->setQuantity( 1 )->setValue( '10.00' )
89			);
90			$product->addListItem( 'price',
91			$listManager->createItem()->setType( 'test' )->setId( 2 ),
92			$manager->createItem()->setType( 'default' )->setCurrencyId( 'USD' )
93			->setTaxrate( '10.00' )->setQuantity( 2 )->setValue( '20.00' )
94			);
95
96			$dom->loadXML( '<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
97			<price>
98			<priceitem lists.type="test">
99			<price.type><![CDATA[default]]></price.type>
100			<price.currencyid><![CDATA[USD]]></price.currencyid>
101			<price.taxrate><![CDATA[10.00]]></price.taxrate>
102			<price.quantity><![CDATA[2]]></price.quantity>
103			<price.value><![CDATA[20.00]]></price.value>
104			</priceitem>
105			<priceitem lists.type="default">
106			<price.type><![CDATA[test]]></price.type>
107			<price.currencyid><![CDATA[EUR]]></price.currencyid>
108			<price.taxrate><![CDATA[20.00]]></price.taxrate>
109			<price.quantity><![CDATA[1]]></price.quantity>
110			<price.value><![CDATA[10.00]]></price.value>
111			</priceitem>
112			</price>' );
113
114			$product = $this->object->process( $product, $dom->firstChild );
115
116			$pos = 0;
117			$expected = [
118			['test', 'default', '2', 'USD', '10.00', '20.00'],
119			['default', 'test', '1', 'EUR', '20.00', '10.00'],
120			];
121
122			$listItems = $product->getListItems();
123			$this->assertEquals( 2, count( $listItems ) );
124
125			foreach( $listItems as $listItem )
126			{
127			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
128			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getType() );
129			$this->assertEquals( $expected[$pos][2], $listItem->getRefItem()->getQuantity() );
130			$this->assertEquals( $expected[$pos][3], $listItem->getRefItem()->getCurrencyId() );
131			$this->assertEquals( $expected[$pos][4], $listItem->getRefItem()->getTaxrate() );
132			$this->assertEquals( $expected[$pos][5], $listItem->getRefItem()->getValue() );
133			$pos++;
134			}
135			}
136
137
138			public function testProcessDelete()
139			{
140			$dom = new \DOMDocument();
141			$manager = \Aimeos\MShop::create( $this->context, 'price' );
142			$listManager = \Aimeos\MShop::create( $this->context, 'product/lists' );
143			$product = \Aimeos\MShop::create( $this->context, 'product' )->createItem();
144
145			$product->addListItem( 'price',
146			$listManager->createItem()->setType( 'default' )->setId( 1 ),
147			$manager->createItem()->setType( 'test' )->setCurrencyId( 'EUR' )
148			->setTaxrate( '20.00' )->setQuantity( 1 )->setValue( '10.00' )
149			);
150			$product->addListItem( 'price',
151			$listManager->createItem()->setType( 'test' )->setId( 2 ),
152			$manager->createItem()->setType( 'default' )->setCurrencyId( 'USD' )
153			->setTaxrate( '10.00' )->setQuantity( 2 )->setValue( '20.00' )
154			);
155
156			$dom->loadXML( '<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
157			<price>
158			<priceitem lists.type="test">
159			<price.type><![CDATA[default]]></price.type>
160			<price.currencyid><![CDATA[USD]]></price.currencyid>
161			<price.taxrate><![CDATA[10.00]]></price.taxrate>
162			<price.quantity><![CDATA[2]]></price.quantity>
163			<price.value><![CDATA[20.00]]></price.value>
164			</priceitem>
165			</price>' );
166
167			$product = $this->object->process( $product, $dom->firstChild );
168
169			$pos = 0;
170			$expected = [['test', 'default', '2', 'USD', '10.00', '20.00']];
171
172			$listItems = $product->getListItems();
173			$this->assertEquals( 1, count( $listItems ) );
174
175			foreach( $listItems as $listItem )
176			{
177			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
178			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getType() );
179			$this->assertEquals( $expected[$pos][2], $listItem->getRefItem()->getQuantity() );
180			$this->assertEquals( $expected[$pos][3], $listItem->getRefItem()->getCurrencyId() );
181			$this->assertEquals( $expected[$pos][4], $listItem->getRefItem()->getTaxrate() );
182			$this->assertEquals( $expected[$pos][5], $listItem->getRefItem()->getValue() );
183			$pos++;
184			}
185			}
186			}
187

aimeos / ai-controller-jobs

Push — master ( e3443a...9a4066 )

StandardTest::testProcessUpdate() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like