Inspection of "Fixed sitemap product link generation" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

unknown

created 2017-03-18 12:45 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Index/Rebuild/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Product/Export/Sitemap/StandardTest.php 1 patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -22,12 +22,12 @@  discard block
 block discarded – undo
 	 */
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Sitemap\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Sitemap\Standard($this->context, $this->aimeos);
 	}
 
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
 	 */
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 
 		$this->object = null;
@@ -48,14 +48,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Product site map', $this->object->getName() );
+		$this->assertEquals('Product site map', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Creates a product site map for search engines';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -64,22 +64,22 @@  discard block
 block discarded – undo
 		$this->object->run();
 		
 		$ds = DIRECTORY_SEPARATOR;
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz' );
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-2.xml.gz' );
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz' );
+		$this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-1.xml.gz');
+		$this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-2.xml.gz');
+		$this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-index.xml.gz');
 		
-		$file1 = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz', 'rb' ), 0x1000 );
-		$file2 = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-2.xml.gz', 'rb' ), 0x1000 );
-		$index = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz', 'rb' ), 0x1000 );
+		$file1 = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-1.xml.gz', 'rb'), 0x1000);
+		$file2 = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-2.xml.gz', 'rb'), 0x1000);
+		$index = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-index.xml.gz', 'rb'), 0x1000);
 
-		unlink( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz' );
-		unlink( 'tmp' . $ds . 'aimeos-sitemap-2.xml.gz' );
-		unlink( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz' );
+		unlink('tmp' . $ds . 'aimeos-sitemap-1.xml.gz');
+		unlink('tmp' . $ds . 'aimeos-sitemap-2.xml.gz');
+		unlink('tmp' . $ds . 'aimeos-sitemap-index.xml.gz');
 
-		$this->assertContains( 'Cafe-Noire-Expresso', $file1 );
-		$this->assertContains( 'Unittest%3A-Bundle', $file2 );
+		$this->assertContains('Cafe-Noire-Expresso', $file1);
+		$this->assertContains('Unittest%3A-Bundle', $file2);
 
-		$this->assertContains( 'aimeos-sitemap-1.xml.gz', $index );
-		$this->assertContains( 'aimeos-sitemap-2.xml.gz', $index );
+		$this->assertContains('aimeos-sitemap-1.xml.gz', $index);
+		$this->assertContains('aimeos-sitemap-2.xml.gz', $index);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Product/Export/StandardTest.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -22,12 +22,12 @@  discard block
 block discarded – undo
 	 */
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Product\Export\Standard($this->context, $this->aimeos);
 	}
 
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
 	 */
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 
 		$this->object = null;
@@ -48,14 +48,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Product export', $this->object->getName() );
+		$this->assertEquals('Product export', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Exports all available products';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -64,16 +64,16 @@  discard block
 block discarded – undo
 		$this->object->run();
 		
 		$ds = DIRECTORY_SEPARATOR;
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-products-1.xml' );
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-products-2.xml' );
+		$this->assertFileExists('tmp' . $ds . 'aimeos-products-1.xml');
+		$this->assertFileExists('tmp' . $ds . 'aimeos-products-2.xml');
 		
-		$file1 = file_get_contents( 'tmp' . $ds . 'aimeos-products-1.xml' );
-		$file2 = file_get_contents( 'tmp' . $ds . 'aimeos-products-2.xml' );
+		$file1 = file_get_contents('tmp' . $ds . 'aimeos-products-1.xml');
+		$file2 = file_get_contents('tmp' . $ds . 'aimeos-products-2.xml');
 
-		unlink( 'tmp' . $ds . 'aimeos-products-1.xml' );
-		unlink( 'tmp' . $ds . 'aimeos-products-2.xml' );
+		unlink('tmp' . $ds . 'aimeos-products-1.xml');
+		unlink('tmp' . $ds . 'aimeos-products-2.xml');
 
-		$this->assertContains( 'CNE', $file1 );
-		$this->assertContains( 'U:BUNDLE', $file2 );
+		$this->assertContains('CNE', $file1);
+		$this->assertContains('U:BUNDLE', $file2);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Product/Bought/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Product/Bought/StandardTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -23,12 +23,12 @@  discard block
 block discarded – undo
 	 */
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Product\Bought\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Product\Bought\Standard($this->context, $this->aimeos);
 	}
 
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 	 */
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 
 		$this->object = null;
@@ -49,28 +49,28 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Products bought together', $this->object->getName() );
+		$this->assertEquals('Products bought together', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Creates bought together product suggestions';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$stub = $this->getMockBuilder( '\\Aimeos\\MShop\\Product\\Manager\\Lists\\Standard' )
-			->setConstructorArgs( array( $this->context ) )
-			->setMethods( array( 'deleteItems', 'saveItem' ) )
+		$stub = $this->getMockBuilder('\\Aimeos\\MShop\\Product\\Manager\\Lists\\Standard')
+			->setConstructorArgs(array($this->context))
+			->setMethods(array('deleteItems', 'saveItem'))
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'product/lists', $stub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'product/lists', $stub);
 
-		$stub->expects( $this->atLeastOnce() )->method( 'deleteItems' );
-		$stub->expects( $this->atLeastOnce() )->method( 'saveItem' );
+		$stub->expects($this->atLeastOnce())->method('deleteItems');
+		$stub->expects($this->atLeastOnce())->method('saveItem');
 
 		$this->object->run();
 	}

Please login to merge, or discard this patch.

Controller/Common/Product/Import/Csv/Processor/Catalog/StandardTest.php 2 patches

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -321,6 +321,7 @@
 block discarded – undo
 
 	/**
 	 * @param string $code
+	 * @return \Aimeos\MShop\Catalog\Item\Iface
 	 */
 	protected function get( $code )
 	{

Please login to merge, or discard this patch.

Spacing +95 added lines, -95 removed lines patch added patch discarded remove patch

@@ -16,23 +16,23 @@  discard block
 block discarded – undo
 
 	public static function setUpBeforeClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
-		$typeManager = $manager->getSubmanager( 'type' );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
+		$typeManager = $manager->getSubmanager('type');
 
 		$typeSearch = $typeManager->createSearch();
-		$typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
-		$result = $typeManager->searchItems( $typeSearch );
+		$typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
+		$result = $typeManager->searchItems($typeSearch);
 
-		if( ( $typeItem = reset( $result ) ) === false ) {
-			throw new \RuntimeException( 'Product type "default" not found' );
+		if (($typeItem = reset($result)) === false) {
+			throw new \RuntimeException('Product type "default" not found');
 		}
 
 		$item = $manager->createItem();
-		$item->setCode( 'job_csv_prod' );
-		$item->setTypeId( $typeItem->getId() );
-		$item->setStatus( 1 );
+		$item->setCode('job_csv_prod');
+		$item->setTypeId($typeItem->getId());
+		$item->setStatus(1);
 
-		$manager->saveItem( $item );
+		$manager->saveItem($item);
 
 		self::$product = $item;
 	}
@@ -40,23 +40,23 @@  discard block
 block discarded – undo
 
 	public static function tearDownAfterClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
-		$manager->deleteItem( self::$product->getId() );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
+		$manager->deleteItem(self::$product->getId());
 	}
 
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperCntl::getContext();
-		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, array() );
+		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, array());
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 	}
 
@@ -77,30 +77,30 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$pos = 0;
 		$listItems = $category->getListItems();
 		$expected = array(
-			array( 'default', 'job_csv_prod' ),
-			array( 'promotion', 'job_csv_prod' ),
+			array('default', 'job_csv_prod'),
+			array('promotion', 'job_csv_prod'),
 		);
 
-		$this->assertEquals( 2, count( $listItems ) );
+		$this->assertEquals(2, count($listItems));
 
-		foreach( $listItems as $listItem )
+		foreach ($listItems as $listItem)
 		{
-			$this->assertEquals( 1, $listItem->getStatus() );
-			$this->assertEquals( 'product', $listItem->getDomain() );
-			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
-			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
+			$this->assertEquals(1, $listItem->getStatus());
+			$this->assertEquals('product', $listItem->getDomain());
+			$this->assertEquals($expected[$pos][0], $listItem->getType());
+			$this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
 			$pos++;
 		}
 	}
@@ -122,32 +122,32 @@  discard block
 block discarded – undo
 			3 => "job_csv_test\njob_csv_test2",
 		);
 
-		$this->create( 'job_csv_test' );
-		$this->create( 'job_csv_test2' );
+		$this->create('job_csv_test');
+		$this->create('job_csv_test2');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$category2 = $this->get( 'job_csv_test2' );
+		$category = $this->get('job_csv_test');
+		$category2 = $this->get('job_csv_test2');
 
-		$this->delete( $category );
-		$this->delete( $category2 );
+		$this->delete($category);
+		$this->delete($category2);
 
 
 		$pos = 0;
-		$types = array( 'default', 'promotion', 'default', 'promotion' );
+		$types = array('default', 'promotion', 'default', 'promotion');
 
-		foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
+		foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
 		{
-			$this->assertEquals( 2, count( $listItems ) );
+			$this->assertEquals(2, count($listItems));
 
-			foreach( $listItems as $listItem )
+			foreach ($listItems as $listItem)
 			{
-				$this->assertEquals( 1, $listItem->getStatus() );
-				$this->assertEquals( 'product', $listItem->getDomain() );
-				$this->assertEquals( $types[$pos], $listItem->getType() );
-				$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+				$this->assertEquals(1, $listItem->getStatus());
+				$this->assertEquals('product', $listItem->getDomain());
+				$this->assertEquals($types[$pos], $listItem->getType());
+				$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 				$pos++;
 			}
 		}
@@ -171,23 +171,23 @@  discard block
 block discarded – undo
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
-		$object->process( self::$product, $dataUpdate );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
+		$object->process(self::$product, $dataUpdate);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
-		$listItem = reset( $listItems );
+		$listItem = reset($listItems);
 
-		$this->assertEquals( 1, count( $listItems ) );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
+		$this->assertEquals(1, count($listItems));
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
 
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 	}
 
 
@@ -203,21 +203,21 @@  discard block
 block discarded – undo
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, array(), $this->endpoint );
-		$object->process( self::$product, array() );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, array(), $this->endpoint);
+		$object->process(self::$product, array());
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 0, count( $listItems ) );
+		$this->assertEquals(0, count($listItems));
 	}
 
 
@@ -237,18 +237,18 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 1, count( $listItems ) );
+		$this->assertEquals(1, count($listItems));
 	}
 
 
@@ -268,71 +268,71 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
+		$this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
-		$listItem = reset( $listItems );
+		$listItem = reset($listItems);
 
-		$this->assertEquals( 1, count( $listItems ) );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
+		$this->assertEquals(1, count($listItems));
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
 
-		$this->assertEquals( 'default', $listItem->getType() );
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+		$this->assertEquals('default', $listItem->getType());
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function create( $code )
+	protected function create($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$item = $manager->createItem();
-		$item->setCode( $code );
+		$item->setCode($code);
 
-		$manager->insertItem( $item );
+		$manager->insertItem($item);
 
 		return $item;
 	}
 
 
-	protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
+	protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
-		$listManager = $manager->getSubManager( 'lists' );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
+		$listManager = $manager->getSubManager('lists');
 
-		foreach( $catItem->getListItems('product') as $listItem ) {
-			$listManager->deleteItem( $listItem->getId() );
+		foreach ($catItem->getListItems('product') as $listItem) {
+			$listManager->deleteItem($listItem->getId());
 		}
 
-		$manager->deleteItem( $catItem->getId() );
+		$manager->deleteItem($catItem->getId());
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function get( $code )
+	protected function get($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
+		$search->setConditions($search->compare('==', 'catalog.code', $code));
 
-		$result = $manager->searchItems( $search, array('product') );
+		$result = $manager->searchItems($search, array('product'));
 
-		if( ( $item = reset( $result ) ) === false ) {
-			throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
+		if (($item = reset($result)) === false) {
+			throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
 		}
 
 		return $item;

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Product/Export/Sitemap/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -14,8 +14,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
+		$obj = \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -24,8 +24,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Product/Export/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -14,8 +14,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Product\Export\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
+		$obj = \Aimeos\Controller\Jobs\Product\Export\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -24,8 +24,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Factory::createController($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -321,6 +321,7 @@
		block discarded – undo
321	321
322	322	/**
323	323	* @param string $code
	324	+ * @return \Aimeos\MShop\Catalog\Item\Iface
324	325	*/
325	326	protected function get( $code )
326	327	{

		@@ -15,8 +15,8 @@ discard block
		block discarded – undo
15	15	$context = \TestHelperJobs::getContext();
16	16	$aimeos = \TestHelperJobs::getAimeos();
17	17
18		- $obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos );
19		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	18	+ $obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos);
	19	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
20	20	}
21	21
22	22
		@@ -25,8 +25,8 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
29		- \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	28	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	29	+ \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Wrong$$$Name');
30	30	}
31	31
32	32
		@@ -35,8 +35,8 @@ discard block
		block discarded – undo
35	35	$context = \TestHelperJobs::getContext();
36	36	$aimeos = \TestHelperJobs::getAimeos();
37	37
38		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
39		- \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'WrongClass' );
	38	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	39	+ \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'WrongClass');
40	40	}
41	41
42	42
		@@ -45,8 +45,8 @@ discard block
		block discarded – undo
45	45	$context = \TestHelperJobs::getContext();
46	46	$aimeos = \TestHelperJobs::getAimeos();
47	47
48		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
49		- \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Factory' );
	48	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	49	+ \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Factory');
50	50	}
51	51
52	52	}

		@@ -22,12 +22,12 @@ discard block
		block discarded – undo
22	22	*/
23	23	protected function setUp()
24	24	{
25		- \Aimeos\MShop\Factory::setCache( true );
	25	+ \Aimeos\MShop\Factory::setCache(true);
26	26
27	27	$this->context = \TestHelperJobs::getContext();
28	28	$this->aimeos = \TestHelperJobs::getAimeos();
29	29
30		- $this->object = new \Aimeos\Controller\Jobs\Product\Export\Sitemap\Standard( $this->context, $this->aimeos );
	30	+ $this->object = new \Aimeos\Controller\Jobs\Product\Export\Sitemap\Standard($this->context, $this->aimeos);
31	31	}
32	32
33	33
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	*/
40	40	protected function tearDown()
41	41	{
42		- \Aimeos\MShop\Factory::setCache( false );
	42	+ \Aimeos\MShop\Factory::setCache(false);
43	43	\Aimeos\MShop\Factory::clear();
44	44
45	45	$this->object = null;
		@@ -48,14 +48,14 @@ discard block
		block discarded – undo
48	48
49	49	public function testGetName()
50	50	{
51		- $this->assertEquals( 'Product site map', $this->object->getName() );
	51	+ $this->assertEquals('Product site map', $this->object->getName());
52	52	}
53	53
54	54
55	55	public function testGetDescription()
56	56	{
57	57	$text = 'Creates a product site map for search engines';
58		- $this->assertEquals( $text, $this->object->getDescription() );
	58	+ $this->assertEquals($text, $this->object->getDescription());
59	59	}
60	60
61	61
		@@ -64,22 +64,22 @@ discard block
		block discarded – undo
64	64	$this->object->run();
65	65
66	66	$ds = DIRECTORY_SEPARATOR;
67		- $this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz' );
68		- $this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-2.xml.gz' );
69		- $this->assertFileExists( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz' );
	67	+ $this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-1.xml.gz');
	68	+ $this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-2.xml.gz');
	69	+ $this->assertFileExists('tmp' . $ds . 'aimeos-sitemap-index.xml.gz');
70	70
71		- $file1 = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz', 'rb' ), 0x1000 );
72		- $file2 = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-2.xml.gz', 'rb' ), 0x1000 );
73		- $index = gzread( gzopen( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz', 'rb' ), 0x1000 );
	71	+ $file1 = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-1.xml.gz', 'rb'), 0x1000);
	72	+ $file2 = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-2.xml.gz', 'rb'), 0x1000);
	73	+ $index = gzread(gzopen('tmp' . $ds . 'aimeos-sitemap-index.xml.gz', 'rb'), 0x1000);
74	74
75		- unlink( 'tmp' . $ds . 'aimeos-sitemap-1.xml.gz' );
76		- unlink( 'tmp' . $ds . 'aimeos-sitemap-2.xml.gz' );
77		- unlink( 'tmp' . $ds . 'aimeos-sitemap-index.xml.gz' );
	75	+ unlink('tmp' . $ds . 'aimeos-sitemap-1.xml.gz');
	76	+ unlink('tmp' . $ds . 'aimeos-sitemap-2.xml.gz');
	77	+ unlink('tmp' . $ds . 'aimeos-sitemap-index.xml.gz');
78	78
79		- $this->assertContains( 'Cafe-Noire-Expresso', $file1 );
80		- $this->assertContains( 'Unittest%3A-Bundle', $file2 );
	79	+ $this->assertContains('Cafe-Noire-Expresso', $file1);
	80	+ $this->assertContains('Unittest%3A-Bundle', $file2);
81	81
82		- $this->assertContains( 'aimeos-sitemap-1.xml.gz', $index );
83		- $this->assertContains( 'aimeos-sitemap-2.xml.gz', $index );
	82	+ $this->assertContains('aimeos-sitemap-1.xml.gz', $index);
	83	+ $this->assertContains('aimeos-sitemap-2.xml.gz', $index);
84	84	}
85	85	}
86	86	\ No newline at end of file

		@@ -23,12 +23,12 @@ discard block
		block discarded – undo
23	23	*/
24	24	protected function setUp()
25	25	{
26		- \Aimeos\MShop\Factory::setCache( true );
	26	+ \Aimeos\MShop\Factory::setCache(true);
27	27
28	28	$this->context = \TestHelperJobs::getContext();
29	29	$this->aimeos = \TestHelperJobs::getAimeos();
30	30
31		- $this->object = new \Aimeos\Controller\Jobs\Product\Bought\Standard( $this->context, $this->aimeos );
	31	+ $this->object = new \Aimeos\Controller\Jobs\Product\Bought\Standard($this->context, $this->aimeos);
32	32	}
33	33
34	34
		@@ -40,7 +40,7 @@ discard block
		block discarded – undo
40	40	*/
41	41	protected function tearDown()
42	42	{
43		- \Aimeos\MShop\Factory::setCache( false );
	43	+ \Aimeos\MShop\Factory::setCache(false);
44	44	\Aimeos\MShop\Factory::clear();
45	45
46	46	$this->object = null;
		@@ -49,28 +49,28 @@ discard block
		block discarded – undo
49	49
50	50	public function testGetName()
51	51	{
52		- $this->assertEquals( 'Products bought together', $this->object->getName() );
	52	+ $this->assertEquals('Products bought together', $this->object->getName());
53	53	}
54	54
55	55
56	56	public function testGetDescription()
57	57	{
58	58	$text = 'Creates bought together product suggestions';
59		- $this->assertEquals( $text, $this->object->getDescription() );
	59	+ $this->assertEquals($text, $this->object->getDescription());
60	60	}
61	61
62	62
63	63	public function testRun()
64	64	{
65		- $stub = $this->getMockBuilder( '\\Aimeos\\MShop\\Product\\Manager\\Lists\\Standard' )
66		- ->setConstructorArgs( array( $this->context ) )
67		- ->setMethods( array( 'deleteItems', 'saveItem' ) )
	65	+ $stub = $this->getMockBuilder('\\Aimeos\\MShop\\Product\\Manager\\Lists\\Standard')
	66	+ ->setConstructorArgs(array($this->context))
	67	+ ->setMethods(array('deleteItems', 'saveItem'))
68	68	->getMock();
69	69
70		- \Aimeos\MShop\Factory::injectManager( $this->context, 'product/lists', $stub );
	70	+ \Aimeos\MShop\Factory::injectManager($this->context, 'product/lists', $stub);
71	71
72		- $stub->expects( $this->atLeastOnce() )->method( 'deleteItems' );
73		- $stub->expects( $this->atLeastOnce() )->method( 'saveItem' );
	72	+ $stub->expects($this->atLeastOnce())->method('deleteItems');
	73	+ $stub->expects($this->atLeastOnce())->method('saveItem');
74	74
75	75	$this->object->run();
76	76	}

		@@ -16,23 +16,23 @@ discard block
		block discarded – undo
16	16
17	17	public static function setUpBeforeClass()
18	18	{
19		- $manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
20		- $typeManager = $manager->getSubmanager( 'type' );
	19	+ $manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
	20	+ $typeManager = $manager->getSubmanager('type');
21	21
22	22	$typeSearch = $typeManager->createSearch();
23		- $typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
24		- $result = $typeManager->searchItems( $typeSearch );
	23	+ $typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
	24	+ $result = $typeManager->searchItems($typeSearch);
25	25
26		- if( ( $typeItem = reset( $result ) ) === false ) {
27		- throw new \RuntimeException( 'Product type "default" not found' );
	26	+ if (($typeItem = reset($result)) === false) {
	27	+ throw new \RuntimeException('Product type "default" not found');
28	28	}
29	29
30	30	$item = $manager->createItem();
31		- $item->setCode( 'job_csv_prod' );
32		- $item->setTypeId( $typeItem->getId() );
33		- $item->setStatus( 1 );
	31	+ $item->setCode('job_csv_prod');
	32	+ $item->setTypeId($typeItem->getId());
	33	+ $item->setStatus(1);
34	34
35		- $manager->saveItem( $item );
	35	+ $manager->saveItem($item);
36	36
37	37	self::$product = $item;
38	38	}
		@@ -40,23 +40,23 @@ discard block
		block discarded – undo
40	40
41	41	public static function tearDownAfterClass()
42	42	{
43		- $manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
44		- $manager->deleteItem( self::$product->getId() );
	43	+ $manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
	44	+ $manager->deleteItem(self::$product->getId());
45	45	}
46	46
47	47
48	48	protected function setUp()
49	49	{
50		- \Aimeos\MShop\Factory::setCache( true );
	50	+ \Aimeos\MShop\Factory::setCache(true);
51	51
52	52	$this->context = \TestHelperCntl::getContext();
53		- $this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, array() );
	53	+ $this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, array());
54	54	}
55	55
56	56
57	57	protected function tearDown()
58	58	{
59		- \Aimeos\MShop\Factory::setCache( false );
	59	+ \Aimeos\MShop\Factory::setCache(false);
60	60	\Aimeos\MShop\Factory::clear();
61	61	}
62	62
		@@ -77,30 +77,30 @@ discard block
		block discarded – undo
77	77	3 => 'job_csv_test',
78	78	);
79	79
80		- $this->create( 'job_csv_test' );
	80	+ $this->create('job_csv_test');
81	81
82		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
83		- $object->process( self::$product, $data );
	82	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	83	+ $object->process(self::$product, $data);
84	84
85		- $category = $this->get( 'job_csv_test' );
86		- $this->delete( $category );
	85	+ $category = $this->get('job_csv_test');
	86	+ $this->delete($category);
87	87
88	88
89	89	$pos = 0;
90	90	$listItems = $category->getListItems();
91	91	$expected = array(
92		- array( 'default', 'job_csv_prod' ),
93		- array( 'promotion', 'job_csv_prod' ),
	92	+ array('default', 'job_csv_prod'),
	93	+ array('promotion', 'job_csv_prod'),
94	94	);
95	95
96		- $this->assertEquals( 2, count( $listItems ) );
	96	+ $this->assertEquals(2, count($listItems));
97	97
98		- foreach( $listItems as $listItem )
	98	+ foreach ($listItems as $listItem)
99	99	{
100		- $this->assertEquals( 1, $listItem->getStatus() );
101		- $this->assertEquals( 'product', $listItem->getDomain() );
102		- $this->assertEquals( $expected[$pos][0], $listItem->getType() );
103		- $this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
	100	+ $this->assertEquals(1, $listItem->getStatus());
	101	+ $this->assertEquals('product', $listItem->getDomain());
	102	+ $this->assertEquals($expected[$pos][0], $listItem->getType());
	103	+ $this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
104	104	$pos++;
105	105	}
106	106	}
		@@ -122,32 +122,32 @@ discard block
		block discarded – undo
122	122	3 => "job_csv_test\njob_csv_test2",
123	123	);
124	124
125		- $this->create( 'job_csv_test' );
126		- $this->create( 'job_csv_test2' );
	125	+ $this->create('job_csv_test');
	126	+ $this->create('job_csv_test2');
127	127
128		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
129		- $object->process( self::$product, $data );
	128	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	129	+ $object->process(self::$product, $data);
130	130
131		- $category = $this->get( 'job_csv_test' );
132		- $category2 = $this->get( 'job_csv_test2' );
	131	+ $category = $this->get('job_csv_test');
	132	+ $category2 = $this->get('job_csv_test2');
133	133
134		- $this->delete( $category );
135		- $this->delete( $category2 );
	134	+ $this->delete($category);
	135	+ $this->delete($category2);
136	136
137	137
138	138	$pos = 0;
139		- $types = array( 'default', 'promotion', 'default', 'promotion' );
	139	+ $types = array('default', 'promotion', 'default', 'promotion');
140	140
141		- foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
	141	+ foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
142	142	{
143		- $this->assertEquals( 2, count( $listItems ) );
	143	+ $this->assertEquals(2, count($listItems));
144	144
145		- foreach( $listItems as $listItem )
	145	+ foreach ($listItems as $listItem)
146	146	{
147		- $this->assertEquals( 1, $listItem->getStatus() );
148		- $this->assertEquals( 'product', $listItem->getDomain() );
149		- $this->assertEquals( $types[$pos], $listItem->getType() );
150		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	147	+ $this->assertEquals(1, $listItem->getStatus());
	148	+ $this->assertEquals('product', $listItem->getDomain());
	149	+ $this->assertEquals($types[$pos], $listItem->getType());
	150	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
151	151	$pos++;
152	152	}
153	153	}
		@@ -171,23 +171,23 @@ discard block
		block discarded – undo
171	171	1 => 'job_csv_test',
172	172	);
173	173
174		- $this->create( 'job_csv_test' );
	174	+ $this->create('job_csv_test');
175	175
176		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
177		- $object->process( self::$product, $data );
178		- $object->process( self::$product, $dataUpdate );
	176	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	177	+ $object->process(self::$product, $data);
	178	+ $object->process(self::$product, $dataUpdate);
179	179
180		- $category = $this->get( 'job_csv_test' );
181		- $this->delete( $category );
	180	+ $category = $this->get('job_csv_test');
	181	+ $this->delete($category);
182	182
183	183
184	184	$listItems = $category->getListItems();
185		- $listItem = reset( $listItems );
	185	+ $listItem = reset($listItems);
186	186
187		- $this->assertEquals( 1, count( $listItems ) );
188		- $this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
	187	+ $this->assertEquals(1, count($listItems));
	188	+ $this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
189	189
190		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	190	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
191	191	}
192	192
193	193
		@@ -203,21 +203,21 @@ discard block
		block discarded – undo
203	203	1 => 'job_csv_test',
204	204	);
205	205
206		- $this->create( 'job_csv_test' );
	206	+ $this->create('job_csv_test');
207	207
208		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
209		- $object->process( self::$product, $data );
	208	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	209	+ $object->process(self::$product, $data);
210	210
211		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, array(), $this->endpoint );
212		- $object->process( self::$product, array() );
	211	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, array(), $this->endpoint);
	212	+ $object->process(self::$product, array());
213	213
214		- $category = $this->get( 'job_csv_test' );
215		- $this->delete( $category );
	214	+ $category = $this->get('job_csv_test');
	215	+ $this->delete($category);
216	216
217	217
218	218	$listItems = $category->getListItems();
219	219
220		- $this->assertEquals( 0, count( $listItems ) );
	220	+ $this->assertEquals(0, count($listItems));
221	221	}
222	222
223	223
		@@ -237,18 +237,18 @@ discard block
		block discarded – undo
237	237	3 => 'job_csv_test',
238	238	);
239	239
240		- $this->create( 'job_csv_test' );
	240	+ $this->create('job_csv_test');
241	241
242		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
243		- $object->process( self::$product, $data );
	242	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	243	+ $object->process(self::$product, $data);
244	244
245		- $category = $this->get( 'job_csv_test' );
246		- $this->delete( $category );
	245	+ $category = $this->get('job_csv_test');
	246	+ $this->delete($category);
247	247
248	248
249	249	$listItems = $category->getListItems();
250	250
251		- $this->assertEquals( 1, count( $listItems ) );
	251	+ $this->assertEquals(1, count($listItems));
252	252	}
253	253
254	254
		@@ -268,71 +268,71 @@ discard block
		block discarded – undo
268	268	3 => 'job_csv_test',
269	269	);
270	270
271		- $this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
	271	+ $this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
272	272
273		- $this->create( 'job_csv_test' );
	273	+ $this->create('job_csv_test');
274	274
275		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
276		- $object->process( self::$product, $data );
	275	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	276	+ $object->process(self::$product, $data);
277	277
278		- $category = $this->get( 'job_csv_test' );
279		- $this->delete( $category );
	278	+ $category = $this->get('job_csv_test');
	279	+ $this->delete($category);
280	280
281	281
282	282	$listItems = $category->getListItems();
283		- $listItem = reset( $listItems );
	283	+ $listItem = reset($listItems);
284	284
285		- $this->assertEquals( 1, count( $listItems ) );
286		- $this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
	285	+ $this->assertEquals(1, count($listItems));
	286	+ $this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
287	287
288		- $this->assertEquals( 'default', $listItem->getType() );
289		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	288	+ $this->assertEquals('default', $listItem->getType());
	289	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
290	290	}
291	291
292	292
293	293	/**
294	294	* @param string $code
295	295	*/
296		- protected function create( $code )
	296	+ protected function create($code)
297	297	{
298		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
	298	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
299	299
300	300	$item = $manager->createItem();
301		- $item->setCode( $code );
	301	+ $item->setCode($code);
302	302
303		- $manager->insertItem( $item );
	303	+ $manager->insertItem($item);
304	304
305	305	return $item;
306	306	}
307	307
308	308
309		- protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
	309	+ protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
310	310	{
311		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
312		- $listManager = $manager->getSubManager( 'lists' );
	311	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
	312	+ $listManager = $manager->getSubManager('lists');
313	313
314		- foreach( $catItem->getListItems('product') as $listItem ) {
315		- $listManager->deleteItem( $listItem->getId() );
	314	+ foreach ($catItem->getListItems('product') as $listItem) {
	315	+ $listManager->deleteItem($listItem->getId());
316	316	}
317	317
318		- $manager->deleteItem( $catItem->getId() );
	318	+ $manager->deleteItem($catItem->getId());
319	319	}
320	320
321	321
322	322	/**
323	323	* @param string $code
324	324	*/
325		- protected function get( $code )
	325	+ protected function get($code)
326	326	{
327		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
	327	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
328	328
329	329	$search = $manager->createSearch();
330		- $search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
	330	+ $search->setConditions($search->compare('==', 'catalog.code', $code));
331	331
332		- $result = $manager->searchItems( $search, array('product') );
	332	+ $result = $manager->searchItems($search, array('product'));
333	333
334		- if( ( $item = reset( $result ) ) === false ) {
335		- throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
	334	+ if (($item = reset($result)) === false) {
	335	+ throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
336	336	}
337	337
338	338	return $item;

		@@ -14,8 +14,8 @@ discard block
		block discarded – undo
14	14	$context = \TestHelperJobs::getContext();
15	15	$aimeos = \TestHelperJobs::getAimeos();
16	16
17		- $obj = \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos );
18		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
	17	+ $obj = \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos);
	18	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
19	19	}
20	20
21	21
		@@ -24,8 +24,8 @@ discard block
		block discarded – undo
24	24	$context = \TestHelperJobs::getContext();
25	25	$aimeos = \TestHelperJobs::getAimeos();
26	26
27		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
28		- \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	27	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	28	+ \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'Wrong$$$Name');
29	29	}
30	30
31	31
		@@ -34,8 +34,8 @@ discard block
		block discarded – undo
34	34	$context = \TestHelperJobs::getContext();
35	35	$aimeos = \TestHelperJobs::getAimeos();
36	36
37		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
38		- \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'WrongClass' );
	37	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	38	+ \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'WrongClass');
39	39	}
40	40
41	41
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	$context = \TestHelperJobs::getContext();
45	45	$aimeos = \TestHelperJobs::getAimeos();
46	46
47		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
48		- \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'Factory' );
	47	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	48	+ \Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'Factory');
49	49	}
50	50	}
51	51	\ No newline at end of file

aimeos / ai-controller-jobs

Pull Request — master (#2)

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Spacing +95 added lines, -95 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch