aimeos / ai-controller-jobs

controller/jobs/tests/Controller/Jobs/Catalog/Export/Sitemap/StandardTest.php

Spacing +19 added lines, -19 removed lines

@@ -18,18 +18,18 @@ 
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperJobs::getContext();
 		$this->aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Catalog\Export\Sitemap\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Catalog\Export\Sitemap\Standard($this->context, $this->aimeos);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 
 		$this->object = null;
@@ -38,40 +38,40 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Catalog site map', $this->object->getName() );
+		$this->assertEquals('Catalog site map', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Creates a catalog site map for search engines';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$this->context->getConfig()->set( 'controller/jobs/catalog/export/sitemap/max-items', 5 );
+		$this->context->getConfig()->set('controller/jobs/catalog/export/sitemap/max-items', 5);
 
 		$this->object->run();
 
 		$ds = DIRECTORY_SEPARATOR;
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-catalog-sitemap-1.xml.gz' );
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-catalog-sitemap-2.xml.gz' );
-		$this->assertFileExists( 'tmp' . $ds . 'aimeos-catalog-sitemap-index.xml.gz' );
+		$this->assertFileExists('tmp' . $ds . 'aimeos-catalog-sitemap-1.xml.gz');
+		$this->assertFileExists('tmp' . $ds . 'aimeos-catalog-sitemap-2.xml.gz');
+		$this->assertFileExists('tmp' . $ds . 'aimeos-catalog-sitemap-index.xml.gz');
 
-		$file1 = gzread( gzopen( 'tmp' . $ds . 'aimeos-catalog-sitemap-1.xml.gz', 'rb' ), 0x1000 );
-		$file2 = gzread( gzopen( 'tmp' . $ds . 'aimeos-catalog-sitemap-2.xml.gz', 'rb' ), 0x1000 );
-		$index = gzread( gzopen( 'tmp' . $ds . 'aimeos-catalog-sitemap-index.xml.gz', 'rb' ), 0x1000 );
+		$file1 = gzread(gzopen('tmp' . $ds . 'aimeos-catalog-sitemap-1.xml.gz', 'rb'), 0x1000);
+		$file2 = gzread(gzopen('tmp' . $ds . 'aimeos-catalog-sitemap-2.xml.gz', 'rb'), 0x1000);
+		$index = gzread(gzopen('tmp' . $ds . 'aimeos-catalog-sitemap-index.xml.gz', 'rb'), 0x1000);
 
-		unlink( 'tmp' . $ds . 'aimeos-catalog-sitemap-1.xml.gz' );
-		unlink( 'tmp' . $ds . 'aimeos-catalog-sitemap-2.xml.gz' );
-		unlink( 'tmp' . $ds . 'aimeos-catalog-sitemap-index.xml.gz' );
+		unlink('tmp' . $ds . 'aimeos-catalog-sitemap-1.xml.gz');
+		unlink('tmp' . $ds . 'aimeos-catalog-sitemap-2.xml.gz');
+		unlink('tmp' . $ds . 'aimeos-catalog-sitemap-index.xml.gz');
 
-		$this->assertContains( 'Kaffee', $file2 );
-		$this->assertContains( 'Tee', $file2 );
+		$this->assertContains('Kaffee', $file2);
+		$this->assertContains('Tee', $file2);
 
-		$this->assertContains( 'aimeos-catalog-sitemap-1.xml.gz', $index );
-		$this->assertContains( 'aimeos-catalog-sitemap-2.xml.gz', $index );
+		$this->assertContains('aimeos-catalog-sitemap-1.xml.gz', $index);
+		$this->assertContains('aimeos-catalog-sitemap-2.xml.gz', $index);
 	}
 }
\ No newline at end of file

controller/jobs/tests/Controller/Jobs/Catalog/Export/Sitemap/FactoryTest.php

Spacing +8 added lines, -8 removed lines

@@ -16,8 +16,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Catalog\Export\Sitemap\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
+		$obj = \Aimeos\Controller\Jobs\Catalog\Export\Sitemap\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,7 +46,7 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Export\Sitemap\Factory::createController($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

controller/jobs/tests/config/controller.php

Spacing +3 added lines, -3 removed lines

@@ -4,11 +4,11 @@ 
 	'jobs' => array(
 		'product' => array(
 			'export' => array(
-				'location' => dirname( __DIR__ ) . DIRECTORY_SEPARATOR . 'tmp',
+				'location' => dirname(__DIR__) . DIRECTORY_SEPARATOR . 'tmp',
 				'max-items' => 15,
 				'max-query' => 5,
 				'sitemap' => array(
-					'location' => dirname( __DIR__ ) . DIRECTORY_SEPARATOR . 'tmp',
+					'location' => dirname(__DIR__) . DIRECTORY_SEPARATOR . 'tmp',
 					'max-items' => 15,
 					'max-query' => 5,
 				),
@@ -17,7 +17,7 @@ 
 		'catalog' => array(
 			'export' => array(
 				'sitemap' => array(
-					'location' => dirname( __DIR__ ) . DIRECTORY_SEPARATOR . 'tmp',
+					'location' => dirname(__DIR__) . DIRECTORY_SEPARATOR . 'tmp',
 					'max-items' => 10,
 					'max-query' => 3,
 				),

controller/jobs/src/Controller/Jobs/Catalog/Export/Sitemap/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -29,7 +29,7 @@ 
 	 * @param string|null $name Name of the controller or "Standard" if null
 	 * @return \Aimeos\Controller\Jobs\Iface New controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\Bootstrap $aimeos, $name = null)
 	{
 		/** controller/jobs/catalog/export/sitemap/name
 		 * Class name of the used catalog sitemap export scheduler controller implementation
@@ -64,19 +64,19 @@ 
 		 * @since 2018.11
 		 * @category Developer
 		 */
-		if ( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/jobs/catalog/export/sitemap/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/jobs/catalog/export/sitemap/name', 'Standard');
 		}
 
-		if ( ctype_alnum( $name ) === false ) {
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Jobs\\Catalog\\Export\\Sitemap\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Jobs\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+		if (ctype_alnum($name) === false) {
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Jobs\\Catalog\\Export\\Sitemap\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Jobs\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Jobs\\Iface';
 		$classname = '\\Aimeos\\Controller\\Jobs\\Catalog\\Export\\Sitemap\\' . $name;
 
-		$controller = self::createControllerBase( $context, $aimeos, $classname, $iface );
+		$controller = self::createControllerBase($context, $aimeos, $classname, $iface);
 
 		/** controller/jobs/catalog/export/sitemap/decorators/excludes
 		 * Excludes decorators added by the "common" option from the catalog export sitemap job controller
@@ -153,6 +153,6 @@ 
 		 * @see controller/jobs/catalog/export/sitemap/export/sitemap/decorators/excludes
 		 * @see controller/jobs/catalog/export/sitemap/export/sitemap/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $aimeos, $controller, 'catalog/export/sitemap' );
+		return self::addControllerDecorators($context, $aimeos, $controller, 'catalog/export/sitemap');
 	}
 }
\ No newline at end of file

controller/jobs/src/Controller/Jobs/Catalog/Export/Sitemap/Standard.php

Spacing +46 added lines, -46 removed lines

@@ -28,7 +28,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Catalog site map' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Catalog site map');
 	}
 
 
@@ -39,7 +39,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Creates a catalog site map for search engines' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Creates a catalog site map for search engines');
 	}
 
 
@@ -52,8 +52,8 @@ 
 	{
 		$container = $this->createContainer();
 
-		$files = $this->export( $container );
-		$this->createSitemapIndex( $container, $files );
+		$files = $this->export($container);
+		$this->createSitemapIndex($container, $files);
 
 		$container->close();
 	}
@@ -65,7 +65,7 @@ 
 	 * @param \Aimeos\MW\Container\Content\Iface $content File content object
 	 * @param \Aimeos\MShop\Catalog\Item\Iface[] $items List of catalog items
 	 */
-	protected function addItems( \Aimeos\MW\Container\Content\Iface $content, array $items )
+	protected function addItems(\Aimeos\MW\Container\Content\Iface $content, array $items)
 	{
 		$config = $this->getContext()->getConfig();
 
@@ -96,7 +96,7 @@ 
 		 * @see controller/jobs/catalog/export/sitemap/max-items
 		 * @see controller/jobs/catalog/export/sitemap/max-query
 		 */
-		$changefreq = $config->get( 'controller/jobs/catalog/export/sitemap/changefreq', 'daily' );
+		$changefreq = $config->get('controller/jobs/catalog/export/sitemap/changefreq', 'daily');
 
 		/** controller/jobs/catalog/export/sitemap/standard/template-items
 		 * Relative path to the XML items template of the catalog site map job controller.
@@ -129,7 +129,7 @@ 
 		$view->siteItems = $items;
 		$view->siteFreq = $changefreq;
 
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
 	}
 
 
@@ -175,7 +175,7 @@ 
 		 * @see controller/jobs/catalog/export/sitemap/max-query
 		 * @see controller/jobs/catalog/export/sitemap/changefreq
 		 */
-		$location = $config->get( 'controller/jobs/catalog/export/sitemap/location' );
+		$location = $config->get('controller/jobs/catalog/export/sitemap/location');
 
 		/** controller/jobs/catalog/export/sitemap/container/options
 		 * List of file container options for the site map files
@@ -197,14 +197,14 @@ 
 		 * @see controller/jobs/catalog/export/sitemap/changefreq
 		 */
 		$default = array('gzip-mode' => 'wb');
-		$options = $config->get( 'controller/jobs/catalog/export/sitemap/container/options', $default );
+		$options = $config->get('controller/jobs/catalog/export/sitemap/container/options', $default);
 
-		if ( $location === null ) {
-			$msg = sprintf( 'Required configuration for "%1$s" is missing', 'controller/jobs/catalog/export/sitemap/location' );
-			throw new \Aimeos\Controller\Jobs\Exception( $msg );
+		if ($location === null) {
+			$msg = sprintf('Required configuration for "%1$s" is missing', 'controller/jobs/catalog/export/sitemap/location');
+			throw new \Aimeos\Controller\Jobs\Exception($msg);
 		}
 
-		return \Aimeos\MW\Container\Factory::getContainer( $location, 'Directory', 'Gzip', $options );
+		return \Aimeos\MW\Container\Factory::getContainer($location, 'Directory', 'Gzip', $options);
 	}
 
 
@@ -215,7 +215,7 @@ 
 	 * @param integer $filenum New file number
 	 * @return \Aimeos\MW\Container\Content\Iface New content object
 	 */
-	protected function createContent( \Aimeos\MW\Container\Iface $container, $filenum )
+	protected function createContent(\Aimeos\MW\Container\Iface $container, $filenum)
 	{
 		/** controller/jobs/catalog/export/sitemap/standard/template-header
 		 * Relative path to the XML site map header template of the catalog site map job controller.
@@ -245,9 +245,9 @@ 
 		$context = $this->getContext();
 		$view = $context->getView();
 
-		$content = $container->create( $this->getFilename( $filenum ) );
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
-		$container->add( $content );
+		$content = $container->create($this->getFilename($filenum));
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
+		$container->add($content);
 
 		return $content;
 	}
@@ -258,7 +258,7 @@ 
 	 *
 	 * @param \Aimeos\MW\Container\Content\Iface $content
 	 */
-	protected function closeContent( \Aimeos\MW\Container\Content\Iface $content )
+	protected function closeContent(\Aimeos\MW\Container\Content\Iface $content)
 	{
 		/** controller/jobs/catalog/export/sitemap/standard/template-footer
 		 * Relative path to the XML site map footer template of the catalog site map job controller.
@@ -288,7 +288,7 @@ 
 		$context = $this->getContext();
 		$view = $context->getView();
 
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
 	}
 
 
@@ -298,7 +298,7 @@ 
 	 * @param \Aimeos\MW\Container\Iface $container File container object
 	 * @param array $files List of generated site map file names
 	 */
-	protected function createSitemapIndex( \Aimeos\MW\Container\Iface $container, array $files )
+	protected function createSitemapIndex(\Aimeos\MW\Container\Iface $container, array $files)
 	{
 		/** controller/jobs/catalog/export/sitemap/standard/template-index
 		 * Relative path to the XML site map index template of the catalog site map job controller.
@@ -330,9 +330,9 @@ 
 
 		$view->siteFiles = $files;
 
-		$content = $container->create( 'aimeos-catalog-sitemap-index.xml' );
-		$content->add( $view->render( $context->getConfig()->get( $tplconf, $default ) ) );
-		$container->add( $content );
+		$content = $container->create('aimeos-catalog-sitemap-index.xml');
+		$content->add($view->render($context->getConfig()->get($tplconf, $default)));
+		$container->add($content);
 	}
 
 
@@ -343,41 +343,41 @@ 
 	 * @param boolean $default True to filter exported catalogs by default criteria
 	 * @return array List of content (file) names
 	 */
-	protected function export( \Aimeos\MW\Container\Iface $container, $default = true )
+	protected function export(\Aimeos\MW\Container\Iface $container, $default = true)
 	{
-		$domains = $this->getConfig( 'domains', [] );
-		$maxItems = $this->getConfig( 'max-items', 10000 );
-		$maxQuery = $this->getConfig( 'max-query', 1000 );
+		$domains = $this->getConfig('domains', []);
+		$maxItems = $this->getConfig('max-items', 10000);
+		$maxQuery = $this->getConfig('max-query', 1000);
 
 		$start = 0;
 		$filenum = 1;
 		$names = [];
 
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'catalog' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'catalog');
 
-		$search = $manager->createSearch( $default );
-		$search->setSortations( array($search->sort( '+', 'catalog.id' )) );
-		$search->setSlice( 0, $maxQuery );
+		$search = $manager->createSearch($default);
+		$search->setSortations(array($search->sort('+', 'catalog.id')));
+		$search->setSlice(0, $maxQuery);
 
-		$content = $this->createContent( $container, $filenum );
+		$content = $this->createContent($container, $filenum);
 		$names[] = $content->getResource();
 
 		do {
-			$items = $manager->searchItems( $search, $domains );
-			$this->addItems( $content, $items );
+			$items = $manager->searchItems($search, $domains);
+			$this->addItems($content, $items);
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
-			$search->setSlice( $start, $maxQuery );
+			$search->setSlice($start, $maxQuery);
 
-			if ( $start + $maxQuery > $maxItems * $filenum ) {
-				$this->closeContent( $content );
-				$content = $this->createContent( $container, ++$filenum );
+			if ($start + $maxQuery > $maxItems * $filenum) {
+				$this->closeContent($content);
+				$content = $this->createContent($container, ++$filenum);
 				$names[] = $content->getResource();
 			}
 		} while ($count >= $search->getSliceSize());
 
-		$this->closeContent( $content );
+		$this->closeContent($content);
 
 		return $names;
 	}
@@ -390,7 +390,7 @@ 
 	 * @param mixed $default Default value if name is unknown
 	 * @return mixed Configuration value
 	 */
-	protected function getConfig( $name, $default = null )
+	protected function getConfig($name, $default = null)
 	{
 		$config = $this->getContext()->getConfig();
 
@@ -414,7 +414,7 @@ 
 				 * @see controller/jobs/catalog/export/sitemap/max-query
 				 * @see controller/jobs/catalog/export/sitemap/changefreq
 				 */
-				return $config->get( 'controller/jobs/catalog/export/sitemap/domains', $default );
+				return $config->get('controller/jobs/catalog/export/sitemap/domains', $default);
 
 			case 'max-items':
 				/** controller/jobs/catalog/export/sitemap/max-items
@@ -439,7 +439,7 @@ 
 				 * @see controller/jobs/catalog/export/sitemap/changefreq
 				 * @see controller/jobs/catalog/export/sitemap/domains
 				 */
-				return $config->get( 'controller/jobs/catalog/export/sitemap/max-items', 50000 );
+				return $config->get('controller/jobs/catalog/export/sitemap/max-items', 50000);
 
 			case 'max-query':
 				/** controller/jobs/catalog/export/sitemap/max-query
@@ -460,7 +460,7 @@ 
 				 * @see controller/jobs/catalog/export/sitemap/changefreq
 				 * @see controller/jobs/catalog/export/sitemap/domains
 				 */
-				return $config->get( 'controller/jobs/catalog/export/sitemap/max-query', 1000 );
+				return $config->get('controller/jobs/catalog/export/sitemap/max-query', 1000);
 		}
 
 		return $default;
@@ -473,8 +473,8 @@ 
 	 * @param integer $number Current file number
 	 * @return string New file name
 	 */
-	protected function getFilename( $number )
+	protected function getFilename($number)
 	{
-		return sprintf( 'aimeos-catalog-sitemap-%d.xml', $number );
+		return sprintf('aimeos-catalog-sitemap-%d.xml', $number);
 	}
 }