aimeos / ai-controller-jobs

controller/jobs/tests/Perf/Product/Import/Csv/StandardTest.php

Spacing +76 added lines, -76 removed lines

@@ -17,31 +17,31 @@ 
 		$this->context = \TestHelperJobs::getContext('unitperf');
 
 		$config = $this->context->getConfig();
-		$config->set( 'controller/jobs/product/import/csv/location', 'tmp/product-import.zip' );
-		$config->set( 'controller/jobs/product/import/csv/container/type', 'Zip' );
-		$config->set( 'controller/jobs/product/import/csv/container/content', 'CSV' );
-		$config->set( 'controller/jobs/product/import/csv/mapping', $this->getMapping() );
+		$config->set('controller/jobs/product/import/csv/location', 'tmp/product-import.zip');
+		$config->set('controller/jobs/product/import/csv/container/type', 'Zip');
+		$config->set('controller/jobs/product/import/csv/container/content', 'CSV');
+		$config->set('controller/jobs/product/import/csv/mapping', $this->getMapping());
 
-		$container = \Aimeos\MW\Container\Factory::getContainer( 'tmp/product-import.zip', 'Zip', 'CSV', [] );
+		$container = \Aimeos\MW\Container\Factory::getContainer('tmp/product-import.zip', 'Zip', 'CSV', []);
 
-		$content = $container->create( 'product.csv' );
+		$content = $container->create('product.csv');
 
-		for( $i = 0; $i < 1000; $i++ )
+		for ($i = 0; $i < 1000; $i++)
 		{
 			$data = [];
 
-			$data = $this->addProduct( $data, $i );
-			$data = $this->addText( $data, $i );
-			$data = $this->addMedia( $data, $i );
-			$data = $this->addPrice( $data, $i );
-			$data = $this->addAttribute( $data, $i );
-			$data = $this->addProductRef( $data, $i );
-			$data = $this->addProperty( $data, $i );
+			$data = $this->addProduct($data, $i);
+			$data = $this->addText($data, $i);
+			$data = $this->addMedia($data, $i);
+			$data = $this->addPrice($data, $i);
+			$data = $this->addAttribute($data, $i);
+			$data = $this->addProductRef($data, $i);
+			$data = $this->addProperty($data, $i);
 
-			$content->add( $data );
+			$content->add($data);
 		}
 
-		$container->add( $content );
+		$container->add($content);
 
 		$container->close();
 	}
@@ -55,25 +55,25 @@ 
 		$this->cleanupPrice();
 		$this->cleanupProduct();
 
-		unlink( 'tmp/product-import.zip' );
+		unlink('tmp/product-import.zip');
 	}
 
 
 	public function testImport()
 	{
 		$aimeos = \TestHelperJobs::getAimeos();
-		$cntl = \Aimeos\Controller\Jobs\Product\Import\Csv\Factory::createController( $this->context, $aimeos, 'Standard' );
+		$cntl = \Aimeos\Controller\Jobs\Product\Import\Csv\Factory::createController($this->context, $aimeos, 'Standard');
 
-		$start = microtime( true );
+		$start = microtime(true);
 
 		$cntl->run();
 
-		$stop = microtime( true );
-		echo "\n    product import CSV: " . ( ( $stop - $start ) ) . " sec\n";
+		$stop = microtime(true);
+		echo "\n    product import CSV: " . (($stop - $start)) . " sec\n";
 	}
 
 
-	protected function addAttribute( array $data, $cnt )
+	protected function addAttribute(array $data, $cnt)
 	{
 		$data[] = 'length'; // type
 		$data[] = 'import-' . ($cnt % 30); // code
@@ -86,7 +86,7 @@ 
 	}
 
 
-	protected function addMedia( array $data, $cnt )
+	protected function addMedia(array $data, $cnt)
 	{
 		$data[] = "/path/to/image-$cnt.jpg"; // url
 
@@ -94,7 +94,7 @@ 
 	}
 
 
-	protected function addPrice( array $data, $cnt )
+	protected function addPrice(array $data, $cnt)
 	{
 		$data[] = 1; // quantity
 		$data[] = 'import-' . $cnt; // label
@@ -105,7 +105,7 @@ 
 	}
 
 
-	protected function addProduct( array $data, $cnt )
+	protected function addProduct(array $data, $cnt)
 	{
 		$data[] = 'import-' . $cnt; // code
 		$data[] = 'import-' . $cnt; // label
@@ -116,7 +116,7 @@ 
 	}
 
 
-	protected function addProductRef( array $data, $cnt )
+	protected function addProductRef(array $data, $cnt)
 	{
 		$data[] = 'import-' . ($cnt % 100); // code
 		$data[] = 'suggestion'; // type
@@ -125,7 +125,7 @@ 
 	}
 
 
-	protected function addProperty( array $data, $cnt )
+	protected function addProperty(array $data, $cnt)
 	{
 		$data[] = 'package-weight'; // type
 		$data[] = '0.5'; // value
@@ -134,7 +134,7 @@ 
 	}
 
 
-	protected function addText( array $data, $cnt )
+	protected function addText(array $data, $cnt)
 	{
 		$data[] = 'name'; // type
 		$data[] = 'import-name-' . $cnt; //content
@@ -149,132 +149,132 @@ 
 
 	protected function cleanupAttribute()
 	{
-		$manager = \Aimeos\MShop\Attribute\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Attribute\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'attribute.domain', 'product' ),
-			$search->compare( '==', 'attribute.label', 'import-%' ),
+			$search->compare('==', 'attribute.domain', 'product'),
+			$search->compare('==', 'attribute.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'attribute.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'attribute.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupMedia()
 	{
-		$manager = \Aimeos\MShop\Media\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Media\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'media.domain', 'product' ),
-			$search->compare( '==', 'media.label', 'import-%' ),
+			$search->compare('==', 'media.domain', 'product'),
+			$search->compare('==', 'media.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'media.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'media.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupPrice()
 	{
-		$manager = \Aimeos\MShop\Price\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Price\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-				$search->compare( '==', 'price.domain', 'product' ),
-				$search->compare( '==', 'price.label', 'import-%' ),
+				$search->compare('==', 'price.domain', 'product'),
+				$search->compare('==', 'price.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'price.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'price.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupProduct()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'product.code', 'import-%' ) );
-		$search->setSortations( array( $search->sort( '+', 'product.id' ) ) );
+		$search->setConditions($search->compare('==', 'product.code', 'import-%'));
+		$search->setSortations(array($search->sort('+', 'product.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 
 	protected function cleanupText()
 	{
-		$manager = \Aimeos\MShop\Text\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Text\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'text.domain', 'product' ),
-			$search->compare( '==', 'text.label', 'import-%' ),
+			$search->compare('==', 'text.domain', 'product'),
+			$search->compare('==', 'text.label', 'import-%'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( array( $search->sort( '+', 'text.id' ) ) );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations(array($search->sort('+', 'text.id')));
 
 		$start = 0;
 
 		do
 		{
-			$result = $manager->searchItems( $search );
-			$manager->deleteItems( array_keys( $result ) );
+			$result = $manager->searchItems($search);
+			$manager->deleteItems(array_keys($result));
 
-			$count = count( $result );
+			$count = count($result);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count == $search->getSliceSize() );
+		while ($count == $search->getSliceSize());
 	}
 
 

controller/jobs/tests/Controller/Jobs/Admin/Log/StandardTest.php

Spacing +20 added lines, -20 removed lines

@@ -25,7 +25,7 @@ 
 		$this->context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard( $this->context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Admin\Log\Standard($this->context, $aimeos);
 	}
 
 
@@ -44,14 +44,14 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Log cleanup', $this->object->getName() );
+		$this->assertEquals('Log cleanup', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Removes the old log entries from the database and archives them (optional)';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -59,38 +59,38 @@ 
 	{
 		$config = $this->context->getConfig();
 
-		$mock = $this->getMockBuilder( '\\Aimeos\\MAdmin\\Log\\Manager\\Standard' )
-			->setMethods( array( 'deleteItems' ) )
-			->setConstructorArgs( array( $this->context ) )
+		$mock = $this->getMockBuilder('\\Aimeos\\MAdmin\\Log\\Manager\\Standard')
+			->setMethods(array('deleteItems'))
+			->setConstructorArgs(array($this->context))
 			->getMock();
 
-		$mock->expects( $this->atLeastOnce() )->method( 'deleteItems' );
+		$mock->expects($this->atLeastOnce())->method('deleteItems');
 
-		$tmppath = dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) . DIRECTORY_SEPARATOR . 'tmp';
+		$tmppath = dirname(dirname(dirname(dirname(__DIR__)))) . DIRECTORY_SEPARATOR . 'tmp';
 		$name = 'ControllerJobsAdminLogDefaultRun';
-		$config->set( 'madmin/log/manager/name', $name );
-		$config->set( 'controller/jobs/admin/log/standard/limit-days', 0 );
-		$config->set( 'controller/jobs/admin/log/standard/path', $tmppath );
+		$config->set('madmin/log/manager/name', $name);
+		$config->set('controller/jobs/admin/log/standard/limit-days', 0);
+		$config->set('controller/jobs/admin/log/standard/path', $tmppath);
 
-		\Aimeos\MAdmin\Log\Manager\Factory::injectManager( '\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock );
+		\Aimeos\MAdmin\Log\Manager\Factory::injectManager('\\Aimeos\\MAdmin\\Log\\Manager\\' . $name, $mock);
 
-		if( !is_dir( $tmppath ) && mkdir( $tmppath ) === false ) {
-			throw new \RuntimeException( sprintf( 'Unable to create temporary path "%1$s"', $tmppath ) );
+		if (!is_dir($tmppath) && mkdir($tmppath) === false) {
+			throw new \RuntimeException(sprintf('Unable to create temporary path "%1$s"', $tmppath));
 		}
 
 		$this->object->run();
 
-		foreach( new \DirectoryIterator( $tmppath ) as $file )
+		foreach (new \DirectoryIterator($tmppath) as $file)
 		{
-			if( $file->isFile() && $file->getExtension() === 'zip' )
+			if ($file->isFile() && $file->getExtension() === 'zip')
 			{
-				$container = \Aimeos\MW\Container\Factory::getContainer( $file->getPathName(), 'Zip', 'CSV', [] );
-				$container->get( 'unittest facility.csv' );
-				unlink( $file->getPathName() );
+				$container = \Aimeos\MW\Container\Factory::getContainer($file->getPathName(), 'Zip', 'CSV', []);
+				$container->get('unittest facility.csv');
+				unlink($file->getPathName());
 				return;
 			}
 		}
 
-		$this->fail( 'Log archive file not found' );
+		$this->fail('Log archive file not found');
 	}
 }

controller/jobs/tests/Controller/Jobs/Order/Service/Payment/StandardTest.php

Spacing +67 added lines, -67 removed lines

@@ -24,7 +24,7 @@ 
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@ 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Capture authorized payments', $this->object->getName() );
+		$this->assertEquals('Capture authorized payments', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Authorized payments of orders will be captured after dispatching or after a configurable amount of time';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 
@@ -60,49 +60,49 @@ 
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 		$orderItem = $orderManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
-			->setMethods( array( 'isImplemented', 'capture' ) )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
+			->setMethods(array('isImplemented', 'capture'))
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), []));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
-			->will( $this->returnValue( true ) );
+		$serviceProviderStub->expects($this->once())->method('isImplemented')
+			->will($this->returnValue(true));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'capture' );
+		$serviceProviderStub->expects($this->once())->method('capture');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -114,52 +114,52 @@ 
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 		$orderItem = $orderManagerStub->createItem();
 
-		$serviceProviderStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay' )
-			->setMethods( array( 'isImplemented', 'capture' ) )
-			->setConstructorArgs( array( $context, $serviceItem ) )
+		$serviceProviderStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Payment\\PrePay')
+			->setMethods(array('isImplemented', 'capture'))
+			->setConstructorArgs(array($context, $serviceItem))
 			->getMock();
 
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $serviceProviderStub ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($serviceProviderStub));
 
-		$orderManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $orderItem ), [] ) );
+		$orderManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($orderItem), []));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'isImplemented' )
-			->will( $this->returnValue( true ) );
+		$serviceProviderStub->expects($this->once())->method('isImplemented')
+			->will($this->returnValue(true));
 
-		$serviceProviderStub->expects( $this->once() )->method( 'capture' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test oder service payment: capture' ) ) );
+		$serviceProviderStub->expects($this->once())->method('capture')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception('test oder service payment: capture')));
 
-		$orderManagerStub->expects( $this->never() )->method( 'saveItem' );
+		$orderManagerStub->expects($this->never())->method('saveItem');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 
@@ -171,36 +171,36 @@ 
 
 
 		$name = 'ControllerJobsServicePaymentProcessDefaultRun';
-		$context->getConfig()->set( 'mshop/service/manager/name', $name );
-		$context->getConfig()->set( 'mshop/order/manager/name', $name );
+		$context->getConfig()->set('mshop/service/manager/name', $name);
+		$context->getConfig()->set('mshop/order/manager/name', $name);
 
 
-		$orderManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setMethods( array( 'saveItem', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$orderManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setMethods(array('saveItem', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		$serviceManagerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
-			->setMethods( array( 'getProvider', 'searchItems' ) )
-			->setConstructorArgs( array( $context ) )
+		$serviceManagerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
+			->setMethods(array('getProvider', 'searchItems'))
+			->setConstructorArgs(array($context))
 			->getMock();
 
-		\Aimeos\MShop\Service\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub );
-		\Aimeos\MShop\Order\Manager\Factory::injectManager( '\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub );
+		\Aimeos\MShop\Service\Manager\Factory::injectManager('\\Aimeos\\MShop\\Service\\Manager\\' . $name, $serviceManagerStub);
+		\Aimeos\MShop\Order\Manager\Factory::injectManager('\\Aimeos\\MShop\\Order\\Manager\\' . $name, $orderManagerStub);
 
 
 		$serviceItem = $serviceManagerStub->createItem();
 
-		$serviceManagerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->onConsecutiveCalls( array( $serviceItem ), [] ) );
+		$serviceManagerStub->expects($this->once())->method('searchItems')
+			->will($this->onConsecutiveCalls(array($serviceItem), []));
 
-		$serviceManagerStub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->throwException( new \Aimeos\MShop\Service\Exception( 'test service delivery process: getProvider' ) ) );
+		$serviceManagerStub->expects($this->once())->method('getProvider')
+			->will($this->throwException(new \Aimeos\MShop\Service\Exception('test service delivery process: getProvider')));
 
-		$orderManagerStub->expects( $this->never() )->method( 'searchItems' );
+		$orderManagerStub->expects($this->never())->method('searchItems');
 
 
-		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard( $context, $aimeos );
+		$object = new \Aimeos\Controller\Jobs\Order\Service\Payment\Standard($context, $aimeos);
 		$object->run();
 	}
 }

controller/jobs/src/Controller/Jobs/Admin/Log/Standard.php

Spacing +26 added lines, -26 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Log cleanup' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Log cleanup');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Removes the old log entries from the database and archives them (optional)' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Removes the old log entries from the database and archives them (optional)');
 	}
 
 
@@ -71,8 +71,8 @@ 
 		 * @see controller/jobs/admin/log/standard/container/format
 		 * @see controller/jobs/admin/log/standard/container/options
 		 */
-		$limit = $config->get( 'controller/jobs/admin/log/standard/limit-days', 30 );
-		$limitDate = date( 'Y-m-d H:i:s', time() - $limit * 86400 );
+		$limit = $config->get('controller/jobs/admin/log/standard/limit-days', 30);
+		$limitDate = date('Y-m-d H:i:s', time() - $limit * 86400);
 
 		/** controller/jobs/admin/log/standard/path
 		 * Path to a writable directory where the log archive files should be stored
@@ -101,7 +101,7 @@ 
 		 * @see controller/jobs/admin/log/standard/container/options
 		 * @see controller/jobs/admin/log/standard/limit-days
 		 */
-		if( ( $path = $config->get( 'controller/jobs/admin/log/standard/path', null ) ) !== null )
+		if (($path = $config->get('controller/jobs/admin/log/standard/path', null)) !== null)
 		{
 			/** controller/jobs/admin/log/standard/container/type
 			 * Container file type storing all coupon code files to import
@@ -175,19 +175,19 @@ 
 			 * @see controller/jobs/admin/log/standard/limit-days
 			 */
 
-			$type = $config->get( 'controller/jobs/admin/log/standard/container/type', 'Zip' );
-			$format = $config->get( 'controller/jobs/admin/log/standard/container/format', 'CSV' );
-			$options = $config->get( 'controller/jobs/admin/log/standard/container/options', [] );
+			$type = $config->get('controller/jobs/admin/log/standard/container/type', 'Zip');
+			$format = $config->get('controller/jobs/admin/log/standard/container/format', 'CSV');
+			$options = $config->get('controller/jobs/admin/log/standard/container/options', []);
 
-			$path .= DIRECTORY_SEPARATOR . str_replace( ' ', '_', $limitDate );
-			$container = \Aimeos\MW\Container\Factory::getContainer( $path, $type, $format, $options );
+			$path .= DIRECTORY_SEPARATOR . str_replace(' ', '_', $limitDate);
+			$container = \Aimeos\MW\Container\Factory::getContainer($path, $type, $format, $options);
 		}
 
-		$manager = \Aimeos\MAdmin\Factory::createManager( $context, 'log' );
+		$manager = \Aimeos\MAdmin\Factory::createManager($context, 'log');
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '<=', 'log.timestamp', $limitDate ) );
-		$search->setSortations( array( $search->sort( '+', 'log.timestamp' ) ) );
+		$search->setConditions($search->compare('<=', 'log.timestamp', $limitDate));
+		$search->setSortations(array($search->sort('+', 'log.timestamp')));
 
 		$start = 0;
 		$contents = [];
@@ -195,37 +195,37 @@ 
 		do
 		{
 			$ids = [];
-			$items = $manager->searchItems( $search );
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $id => $item )
+			foreach ($items as $id => $item)
 			{
-				if( $container !== null )
+				if ($container !== null)
 				{
 					$facility = $item->getFacility();
 
-					if( !isset( $contents[$facility] ) ) {
-						$contents[$facility] = $container->create( $facility );
+					if (!isset($contents[$facility])) {
+						$contents[$facility] = $container->create($facility);
 					}
 
-					$contents[$facility]->add( $item->toArray() );
+					$contents[$facility]->add($item->toArray());
 				}
 
 				$ids[] = $id;
 			}
 
-			$manager->deleteItems( $ids );
+			$manager->deleteItems($ids);
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count >= $search->getSliceSize() );
+		while ($count >= $search->getSliceSize());
 
 
-		if( $container !== null && !empty( $contents ) )
+		if ($container !== null && !empty($contents))
 		{
-			foreach( $contents as $content ) {
-				$container->add( $content );
+			foreach ($contents as $content) {
+				$container->add($content);
 			}
 
 			$container->close();

controller/jobs/src/Controller/Jobs/Order/Cleanup/Unpaid/Standard.php

Spacing +17 added lines, -17 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Removes unpaid orders' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Removes unpaid orders');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Deletes unpaid orders to keep the database clean' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Deletes unpaid orders to keep the database clean');
 	}
 
 
@@ -52,9 +52,9 @@ 
 	public function run()
 	{
 		$context = $this->getContext();
-		$controller = \Aimeos\Controller\Common\Order\Factory::createController( $context );
-		$baseManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$controller = \Aimeos\Controller\Common\Order\Factory::createController($context);
+		$baseManager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order');
 
 		/** controller/jobs/order/cleanup/unpaid/keep-days
 		 * Removes all orders from the database that are unpaid
@@ -71,35 +71,35 @@ 
 		 * @since 2014.07
 		 * @category User
 		 */
-		$days = $context->getConfig()->get( 'controller/jobs/order/cleanup/unpaid/keep-days', 3 );
-		$limit = date( 'Y-m-d H:i:s', time() - 86400 * $days );
+		$days = $context->getConfig()->get('controller/jobs/order/cleanup/unpaid/keep-days', 3);
+		$limit = date('Y-m-d H:i:s', time() - 86400 * $days);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '<', 'order.mtime', $limit ),
-			$search->compare( '<', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_REFUND ),
+			$search->compare('<', 'order.mtime', $limit),
+			$search->compare('<', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_REFUND),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
 		$start = 0;
 
 		do
 		{
 			$baseIds = [];
-			$items = $manager->searchItems( $search );
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $item )
+			foreach ($items as $item)
 			{
-				$controller->unblock( $item );
+				$controller->unblock($item);
 				$baseIds[] = $item->getBaseId();
 			}
 
-			$baseManager->deleteItems( $baseIds );
+			$baseManager->deleteItems($baseIds);
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count >= $search->getSliceSize() );
+		while ($count >= $search->getSliceSize());
 	}
 }

controller/jobs/src/Controller/Jobs/Order/Cleanup/Unfinished/Standard.php

Spacing +17 added lines, -17 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Removes unfinished orders' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Removes unfinished orders');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Deletes unfinished orders an makes their products and coupon codes available again' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Deletes unfinished orders an makes their products and coupon codes available again');
 	}
 
 
@@ -52,9 +52,9 @@ 
 	public function run()
 	{
 		$context = $this->getContext();
-		$controller = \Aimeos\Controller\Common\Order\Factory::createController( $context );
-		$baseManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$controller = \Aimeos\Controller\Common\Order\Factory::createController($context);
+		$baseManager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order');
 
 		/** controller/jobs/order/cleanup/unfinished/keep-hours
 		 * Release the ordered products after the configured time if no payment was confirmed
@@ -74,35 +74,35 @@ 
 		 * @since 2014.07
 		 * @category User
 		 */
-		$hours = $context->getConfig()->get( 'controller/jobs/order/cleanup/unfinished/keep-hours', 24 );
-		$limit = date( 'Y-m-d H:i:s', time() - 3600 * $hours );
+		$hours = $context->getConfig()->get('controller/jobs/order/cleanup/unfinished/keep-hours', 24);
+		$limit = date('Y-m-d H:i:s', time() - 3600 * $hours);
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '<', 'order.mtime', $limit ),
-			$search->compare( '==', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_UNFINISHED ),
+			$search->compare('<', 'order.mtime', $limit),
+			$search->compare('==', 'order.statuspayment', \Aimeos\MShop\Order\Item\Base::PAY_UNFINISHED),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
 		$start = 0;
 
 		do
 		{
 			$baseIds = [];
-			$items = $manager->searchItems( $search );
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $item )
+			foreach ($items as $item)
 			{
-				$controller->unblock( $item );
+				$controller->unblock($item);
 				$baseIds[] = $item->getBaseId();
 			}
 
-			$baseManager->deleteItems( $baseIds );
+			$baseManager->deleteItems($baseIds);
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count >= $search->getSliceSize() );
+		while ($count >= $search->getSliceSize());
 	}
 }

controller/common/src/Controller/Common/Product/Import/Csv/Cache/Attribute/Standard.php

Spacing +17 added lines, -17 removed lines

@@ -40,15 +40,15 @@ 
 	 *
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object
 	 */
-	public function __construct( \Aimeos\MShop\Context\Item\Iface $context )
+	public function __construct(\Aimeos\MShop\Context\Item\Iface $context)
 	{
-		parent::__construct( $context );
+		parent::__construct($context);
 
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'attribute' );
-		$result = $manager->searchItems( $manager->createSearch() );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'attribute');
+		$result = $manager->searchItems($manager->createSearch());
 
-		foreach( $result as $id => $item ) {
-			$this->attributes[ $item->getCode() ][ $item->getType() ] = $item;
+		foreach ($result as $id => $item) {
+			$this->attributes[$item->getCode()][$item->getType()] = $item;
 		}
 	}
 
@@ -60,24 +60,24 @@ 
 	 * @param string|null $type Attribute type
 	 * @return \Aimeos\MShop\Attribute\Item\Iface|null Attribute object or null if not found
 	 */
-	public function get( $code, $type = null )
+	public function get($code, $type = null)
 	{
-		if( isset( $this->attributes[$code] ) && isset( $this->attributes[$code][$type] ) ) {
+		if (isset($this->attributes[$code]) && isset($this->attributes[$code][$type])) {
 			return $this->attributes[$code][$type];
 		}
 
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'attribute' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'attribute');
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'attribute.code', $code ),
-			$search->compare( '==', 'attribute.type.code', $type ),
+			$search->compare('==', 'attribute.code', $code),
+			$search->compare('==', 'attribute.type.code', $type),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
-		$result = $manager->searchItems( $search );
+		$result = $manager->searchItems($search);
 
-		if( ( $item = reset( $result ) ) !== false )
+		if (($item = reset($result)) !== false)
 		{
 			$this->attributes[$code][$type] = $item;
 			return $item;
@@ -90,14 +90,14 @@ 
 	 *
 	 * @param \Aimeos\MShop\Common\Item\Iface $item Attribute object
 	 */
-	public function set( \Aimeos\MShop\Common\Item\Iface $item )
+	public function set(\Aimeos\MShop\Common\Item\Iface $item)
 	{
 		$code = $item->getCode();
 
-		if( !isset( $this->attributes[$code] ) || !is_array( $this->attributes[$code] ) ) {
+		if (!isset($this->attributes[$code]) || !is_array($this->attributes[$code])) {
 			$this->attributes[$code] = [];
 		}
 
-		$this->attributes[$code][ $item->getType() ] = $item;
+		$this->attributes[$code][$item->getType()] = $item;
 	}
 }
\ No newline at end of file

controller/jobs/src/Controller/Jobs/Product/Bought/Standard.php

Spacing +64 added lines, -64 removed lines

@@ -29,7 +29,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Products bought together' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Products bought together');
 	}
 
 
@@ -40,7 +40,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Creates bought together product suggestions' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Creates bought together product suggestions');
 	}
 
 
@@ -72,7 +72,7 @@ 
 		 * @see controller/jobs/product/bought/min-confidence
 		 * @see controller/jobs/product/bought/limit-days
 		 */
-		$maxItems = $config->get( 'controller/jobs/product/bought/max-items', 5 );
+		$maxItems = $config->get('controller/jobs/product/bought/max-items', 5);
 
 		/** controller/jobs/product/bought/min-support
 		 * Minimum support value to sort out all irrelevant combinations
@@ -101,7 +101,7 @@ 
 		 * @see controller/jobs/product/bought/min-confidence
 		 * @see controller/jobs/product/bought/limit-days
 		 */
-		$minSupport = $config->get( 'controller/jobs/product/bought/min-support', 0.02 );
+		$minSupport = $config->get('controller/jobs/product/bought/min-support', 0.02);
 
 		/** controller/jobs/product/bought/min-confidence
 		 * Minimum confidence value for high quality suggestions
@@ -126,7 +126,7 @@ 
 		 * @see controller/jobs/product/bought/min-support
 		 * @see controller/jobs/product/bought/limit-days
 		 */
-		$minConfidence = $config->get( 'controller/jobs/product/bought/min-confidence', 0.66 );
+		$minConfidence = $config->get('controller/jobs/product/bought/min-confidence', 0.66);
 
 		/** controller/jobs/product/bought/limit-days
 		 * Only use orders placed in the past within the configured number of days for calculating bought together products
@@ -150,45 +150,45 @@ 
 		 * @see controller/jobs/product/bought/min-support
 		 * @see controller/jobs/product/bought/min-confidence
 		 */
-		$days = $config->get( 'controller/jobs/product/bought/limit-days', 180 );
-		$date = date( 'Y-m-d H:i:s', time() - $days * 86400 );
+		$days = $config->get('controller/jobs/product/bought/limit-days', 180);
+		$date = date('Y-m-d H:i:s', time() - $days * 86400);
 
 
-		$typeItem = $this->getTypeItem( 'product/lists/type', 'product', 'bought-together' );
+		$typeItem = $this->getTypeItem('product/lists/type', 'product', 'bought-together');
 
-		$baseManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
+		$baseManager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
 		$search = $baseManager->createSearch();
-		$search->setConditions( $search->compare( '>', 'order.base.ctime', $date ) );
-		$search->setSlice( 0, 0 );
+		$search->setConditions($search->compare('>', 'order.base.ctime', $date));
+		$search->setSlice(0, 0);
 		$totalOrders = 0;
-		$baseManager->searchItems( $search, [], $totalOrders );
+		$baseManager->searchItems($search, [], $totalOrders);
 
-		$baseProductManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base/product' );
+		$baseProductManager = \Aimeos\MShop\Factory::createManager($context, 'order/base/product');
 		$search = $baseProductManager->createSearch();
-		$search->setConditions( $search->compare( '>', 'order.base.product.ctime', $date ) );
+		$search->setConditions($search->compare('>', 'order.base.product.ctime', $date));
 		$start = 0;
 
 		do
 		{
-			$totalCounts = $baseProductManager->aggregate( $search, 'order.base.product.productid' );
-			$prodIds = array_keys( $totalCounts );
+			$totalCounts = $baseProductManager->aggregate($search, 'order.base.product.productid');
+			$prodIds = array_keys($totalCounts);
 
-			foreach( $totalCounts as $id => $count )
+			foreach ($totalCounts as $id => $count)
 			{
-				$this->removeListItems( $id, $typeItem->getId() );
+				$this->removeListItems($id, $typeItem->getId());
 
-				if( $count / $totalOrders > $minSupport )
+				if ($count / $totalOrders > $minSupport)
 				{
-					$productIds = $this->getSuggestions( $id, $prodIds, $count, $totalOrders, $maxItems, $minSupport, $minConfidence, $date );
-					$this->addListItems( $id, $typeItem->getId(), $productIds );
+					$productIds = $this->getSuggestions($id, $prodIds, $count, $totalOrders, $maxItems, $minSupport, $minConfidence, $date);
+					$this->addListItems($id, $typeItem->getId(), $productIds);
 				}
 			}
 
-			$count = count( $totalCounts );
+			$count = count($totalCounts);
 			$start += $count;
-			$search->setSlice( $start );
+			$search->setSlice($start);
 		}
-		while( $count >= $search->getSliceSize() );
+		while ($count >= $search->getSliceSize());
 	}
 
 
@@ -205,59 +205,59 @@ 
 	 * @param string $date Date in YYYY-MM-DD HH:mm:ss format after which orders should be used for calculations
 	 * @return array List of suggested product IDs as key and their confidence as value
 	 */
-	protected function getSuggestions( $id, $prodIds, $count, $total, $maxItems, $minSupport, $minConfidence, $date )
+	protected function getSuggestions($id, $prodIds, $count, $total, $maxItems, $minSupport, $minConfidence, $date)
 	{
 		$refIds = [];
 		$context = $this->getContext();
 
-		$catalogListManager = \Aimeos\MShop\Factory::createManager( $context, 'catalog/lists' );
-		$baseProductManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base/product' );
+		$catalogListManager = \Aimeos\MShop\Factory::createManager($context, 'catalog/lists');
+		$baseProductManager = \Aimeos\MShop\Factory::createManager($context, 'order/base/product');
 
 
 		$search = $baseProductManager->createSearch();
-		$func = $search->createFunction( 'order.base.product.count', array( (string) $id ) );
+		$func = $search->createFunction('order.base.product.count', array((string) $id));
 		$expr = array(
-			$search->compare( '==', 'order.base.product.productid', $prodIds ),
-			$search->compare( '>', 'order.base.product.ctime', $date ),
-			$search->compare( '==', $func, 1 ),
+			$search->compare('==', 'order.base.product.productid', $prodIds),
+			$search->compare('>', 'order.base.product.ctime', $date),
+			$search->compare('==', $func, 1),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
-		$relativeCounts = $baseProductManager->aggregate( $search, 'order.base.product.productid' );
+		$relativeCounts = $baseProductManager->aggregate($search, 'order.base.product.productid');
 
 
 		$search = $catalogListManager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'catalog.lists.refid', array_keys( $relativeCounts ) ),
-			$search->compare( '==', 'catalog.lists.domain', 'product' ),
+			$search->compare('==', 'catalog.lists.refid', array_keys($relativeCounts)),
+			$search->compare('==', 'catalog.lists.domain', 'product'),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
-		foreach( $catalogListManager->searchItems( $search ) as $listItem ) {
+		foreach ($catalogListManager->searchItems($search) as $listItem) {
 			$refIds[$listItem->getRefId()] = true;
 		}
 
 
-		unset( $relativeCounts[$id] );
+		unset($relativeCounts[$id]);
 		$supportA = $count / $total;
 		$products = [];
 
-		foreach( $relativeCounts as $prodId => $relCnt )
+		foreach ($relativeCounts as $prodId => $relCnt)
 		{
-			if( !isset( $refIds[$prodId] ) ) {
+			if (!isset($refIds[$prodId])) {
 				continue;
 			}
 
 			$supportAB = $relCnt / $total;
 
-			if( $supportAB > $minSupport && ( $conf = ( $supportAB / $supportA ) ) > $minConfidence ) {
+			if ($supportAB > $minSupport && ($conf = ($supportAB / $supportA)) > $minConfidence) {
 				$products[$prodId] = $conf;
 			}
 		}
 
-		arsort( $products );
+		arsort($products);
 
-		return array_keys( array_slice( $products, 0, $maxItems, true ) );
+		return array_keys(array_slice($products, 0, $maxItems, true));
 	}
 
 
@@ -268,26 +268,26 @@ 
 	 * @param integer $typeId Unique ID of the list type used for the referenced products
 	 * @param array $productIds List of position as key and product ID as value
 	 */
-	protected function addListItems( $productId, $typeId, array $productIds )
+	protected function addListItems($productId, $typeId, array $productIds)
 	{
-		if( empty( $productIds ) ) {
+		if (empty($productIds)) {
 			return;
 		}
 
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'product/lists' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'product/lists');
 		$item = $manager->createItem();
 
-		foreach( $productIds as $pos => $refid )
+		foreach ($productIds as $pos => $refid)
 		{
-			$item->setId( null );
-			$item->setParentId( $productId );
-			$item->setDomain( 'product' );
-			$item->setTypeId( $typeId );
-			$item->setPosition( $pos );
-			$item->setRefId( $refid );
-			$item->setStatus( 1 );
-
-			$manager->saveItem( $item, false );
+			$item->setId(null);
+			$item->setParentId($productId);
+			$item->setDomain('product');
+			$item->setTypeId($typeId);
+			$item->setPosition($pos);
+			$item->setRefId($refid);
+			$item->setStatus(1);
+
+			$manager->saveItem($item, false);
 		}
 	}
 
@@ -298,20 +298,20 @@ 
 	 * @param string $productId Unique ID of the product the references should be removed from
 	 * @param integer $typeId Unique ID of the list type the referenced products should be removed from
 	 */
-	protected function removeListItems( $productId, $typeId )
+	protected function removeListItems($productId, $typeId)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'product/lists' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'product/lists');
 
 		$search = $manager->createSearch();
 		$expr = array(
-			$search->compare( '==', 'product.lists.parentid', $productId ),
-			$search->compare( '==', 'product.lists.domain', 'product' ),
-			$search->compare( '==', 'product.lists.typeid', $typeId ),
+			$search->compare('==', 'product.lists.parentid', $productId),
+			$search->compare('==', 'product.lists.domain', 'product'),
+			$search->compare('==', 'product.lists.typeid', $typeId),
 		);
-		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setConditions($search->combine('&&', $expr));
 
-		$listItems = $manager->searchItems( $search );
+		$listItems = $manager->searchItems($search);
 
-		$manager->deleteItems( array_keys( $listItems ) );
+		$manager->deleteItems(array_keys($listItems));
 	}
 }

controller/common/tests/Controller/Common/Product/Import/Csv/Processor/Catalog/StandardTest.php

Spacing +95 added lines, -95 removed lines

@@ -16,45 +16,45 @@ 
 
 	public static function setUpBeforeClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
-		$typeManager = $manager->getSubmanager( 'type' );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
+		$typeManager = $manager->getSubmanager('type');
 
 		$typeSearch = $typeManager->createSearch();
-		$typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
-		$result = $typeManager->searchItems( $typeSearch );
+		$typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
+		$result = $typeManager->searchItems($typeSearch);
 
-		if( ( $typeItem = reset( $result ) ) === false ) {
-			throw new \RuntimeException( 'Product type "default" not found' );
+		if (($typeItem = reset($result)) === false) {
+			throw new \RuntimeException('Product type "default" not found');
 		}
 
 		$item = $manager->createItem();
-		$item->setCode( 'job_csv_prod' );
-		$item->setTypeId( $typeItem->getId() );
-		$item->setStatus( 1 );
+		$item->setCode('job_csv_prod');
+		$item->setTypeId($typeItem->getId());
+		$item->setStatus(1);
 
-		self::$product = $manager->saveItem( $item );
+		self::$product = $manager->saveItem($item);
 	}
 
 
 	public static function tearDownAfterClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
-		$manager->deleteItem( self::$product->getId() );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
+		$manager->deleteItem(self::$product->getId());
 	}
 
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperCntl::getContext();
-		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
+		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 	}
 
@@ -75,30 +75,30 @@ 
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$pos = 0;
 		$listItems = $category->getListItems();
 		$expected = array(
-			array( 'default', 'job_csv_prod' ),
-			array( 'promotion', 'job_csv_prod' ),
+			array('default', 'job_csv_prod'),
+			array('promotion', 'job_csv_prod'),
 		);
 
-		$this->assertEquals( 2, count( $listItems ) );
+		$this->assertEquals(2, count($listItems));
 
-		foreach( $listItems as $listItem )
+		foreach ($listItems as $listItem)
 		{
-			$this->assertEquals( 1, $listItem->getStatus() );
-			$this->assertEquals( 'product', $listItem->getDomain() );
-			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
-			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
+			$this->assertEquals(1, $listItem->getStatus());
+			$this->assertEquals('product', $listItem->getDomain());
+			$this->assertEquals($expected[$pos][0], $listItem->getType());
+			$this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
 			$pos++;
 		}
 	}
@@ -120,32 +120,32 @@ 
 			3 => "job_csv_test\njob_csv_test2",
 		);
 
-		$this->create( 'job_csv_test' );
-		$this->create( 'job_csv_test2' );
+		$this->create('job_csv_test');
+		$this->create('job_csv_test2');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$category2 = $this->get( 'job_csv_test2' );
+		$category = $this->get('job_csv_test');
+		$category2 = $this->get('job_csv_test2');
 
-		$this->delete( $category );
-		$this->delete( $category2 );
+		$this->delete($category);
+		$this->delete($category2);
 
 
 		$pos = 0;
-		$types = array( 'default', 'promotion', 'default', 'promotion' );
+		$types = array('default', 'promotion', 'default', 'promotion');
 
-		foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
+		foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
 		{
-			$this->assertEquals( 2, count( $listItems ) );
+			$this->assertEquals(2, count($listItems));
 
-			foreach( $listItems as $listItem )
+			foreach ($listItems as $listItem)
 			{
-				$this->assertEquals( 1, $listItem->getStatus() );
-				$this->assertEquals( 'product', $listItem->getDomain() );
-				$this->assertEquals( $types[$pos], $listItem->getType() );
-				$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+				$this->assertEquals(1, $listItem->getStatus());
+				$this->assertEquals('product', $listItem->getDomain());
+				$this->assertEquals($types[$pos], $listItem->getType());
+				$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 				$pos++;
 			}
 		}
@@ -169,23 +169,23 @@ 
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
-		$object->process( self::$product, $dataUpdate );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
+		$object->process(self::$product, $dataUpdate);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
-		$listItem = reset( $listItems );
+		$listItem = reset($listItems);
 
-		$this->assertEquals( 1, count( $listItems ) );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
+		$this->assertEquals(1, count($listItems));
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
 
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 	}
 
 
@@ -201,21 +201,21 @@ 
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, [], $this->endpoint );
-		$object->process( self::$product, [] );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, [], $this->endpoint);
+		$object->process(self::$product, []);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 0, count( $listItems ) );
+		$this->assertEquals(0, count($listItems));
 	}
 
 
@@ -235,18 +235,18 @@ 
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 1, count( $listItems ) );
+		$this->assertEquals(1, count($listItems));
 	}
 
 
@@ -266,71 +266,71 @@ 
 			3 => 'job_csv_test',
 		);
 
-		$this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
+		$this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
-		$listItem = reset( $listItems );
+		$listItem = reset($listItems);
 
-		$this->assertEquals( 1, count( $listItems ) );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
+		$this->assertEquals(1, count($listItems));
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
 
-		$this->assertEquals( 'default', $listItem->getType() );
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+		$this->assertEquals('default', $listItem->getType());
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function create( $code )
+	protected function create($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$item = $manager->createItem();
-		$item->setCode( $code );
+		$item->setCode($code);
 
-		$manager->insertItem( $item );
+		$manager->insertItem($item);
 
 		return $item;
 	}
 
 
-	protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
+	protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
-		$listManager = $manager->getSubManager( 'lists' );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
+		$listManager = $manager->getSubManager('lists');
 
-		foreach( $catItem->getListItems('product') as $listItem ) {
-			$listManager->deleteItem( $listItem->getId() );
+		foreach ($catItem->getListItems('product') as $listItem) {
+			$listManager->deleteItem($listItem->getId());
 		}
 
-		$manager->deleteItem( $catItem->getId() );
+		$manager->deleteItem($catItem->getId());
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function get( $code )
+	protected function get($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
+		$search->setConditions($search->compare('==', 'catalog.code', $code));
 
-		$result = $manager->searchItems( $search, array('product') );
+		$result = $manager->searchItems($search, array('product'));
 
-		if( ( $item = reset( $result ) ) === false ) {
-			throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
+		if (($item = reset($result)) === false) {
+			throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
 		}
 
 		return $item;