Inspection of "Adapt to changes of createItem() in core" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 475749...c0b163 )

by Aimeos

created 2018-12-21 16:14 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Service/Delivery/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Cache/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Cache/StandardTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Cache cleanup', $this->object->getName() );
+		$this->assertEquals('Cache cleanup', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Removes the expired entries from the cache';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Log/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Index/Optimize/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Index/Rebuild/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Product/Bought/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

Controller/Common/Product/Import/Csv/Processor/Catalog/StandardTest.php 2 patches

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -321,6 +321,7 @@
 block discarded – undo
 
 	/**
 	 * @param string $code
+	 * @return \Aimeos\MShop\Catalog\Item\Iface
 	 */
 	protected function get( $code )
 	{

Please login to merge, or discard this patch.

Spacing +84 added lines, -84 removed lines patch added patch discarded remove patch

@@ -18,36 +18,36 @@  discard block
 block discarded – undo
 
 	public static function setUpBeforeClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
 
 		$item = $manager->createItem();
-		$item->setCode( 'job_csv_prod' );
-		$item->setType( 'default' );
-		$item->setStatus( 1 );
+		$item->setCode('job_csv_prod');
+		$item->setType('default');
+		$item->setStatus(1);
 
-		self::$product = $manager->saveItem( $item );
+		self::$product = $manager->saveItem($item);
 	}
 
 
 	public static function tearDownAfterClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
-		$manager->deleteItem( self::$product->getId() );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
+		$manager->deleteItem(self::$product->getId());
 	}
 
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperCntl::getContext();
-		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
+		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 	}
 
@@ -68,30 +68,30 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$pos = 0;
 		$listItems = $category->getListItems();
 		$expected = array(
-			array( 'default', 'job_csv_prod' ),
-			array( 'promotion', 'job_csv_prod' ),
+			array('default', 'job_csv_prod'),
+			array('promotion', 'job_csv_prod'),
 		);
 
-		$this->assertEquals( 2, count( $listItems ) );
+		$this->assertEquals(2, count($listItems));
 
-		foreach( $listItems as $listItem )
+		foreach ($listItems as $listItem)
 		{
-			$this->assertEquals( 1, $listItem->getStatus() );
-			$this->assertEquals( 'product', $listItem->getDomain() );
-			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
-			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
+			$this->assertEquals(1, $listItem->getStatus());
+			$this->assertEquals('product', $listItem->getDomain());
+			$this->assertEquals($expected[$pos][0], $listItem->getType());
+			$this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
 			$pos++;
 		}
 	}
@@ -113,32 +113,32 @@  discard block
 block discarded – undo
 			3 => "job_csv_test\njob_csv_test2",
 		);
 
-		$this->create( 'job_csv_test' );
-		$this->create( 'job_csv_test2' );
+		$this->create('job_csv_test');
+		$this->create('job_csv_test2');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$category2 = $this->get( 'job_csv_test2' );
+		$category = $this->get('job_csv_test');
+		$category2 = $this->get('job_csv_test2');
 
-		$this->delete( $category );
-		$this->delete( $category2 );
+		$this->delete($category);
+		$this->delete($category2);
 
 
 		$pos = 0;
-		$types = array( 'default', 'promotion', 'default', 'promotion' );
+		$types = array('default', 'promotion', 'default', 'promotion');
 
-		foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
+		foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
 		{
-			$this->assertEquals( 2, count( $listItems ) );
+			$this->assertEquals(2, count($listItems));
 
-			foreach( $listItems as $listItem )
+			foreach ($listItems as $listItem)
 			{
-				$this->assertEquals( 1, $listItem->getStatus() );
-				$this->assertEquals( 'product', $listItem->getDomain() );
-				$this->assertEquals( $types[$pos], $listItem->getType() );
-				$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+				$this->assertEquals(1, $listItem->getStatus());
+				$this->assertEquals('product', $listItem->getDomain());
+				$this->assertEquals($types[$pos], $listItem->getType());
+				$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 				$pos++;
 			}
 		}
@@ -162,23 +162,23 @@  discard block
 block discarded – undo
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
-		$object->process( self::$product, $dataUpdate );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
+		$object->process(self::$product, $dataUpdate);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
-		$listItem = reset( $listItems );
+		$listItem = reset($listItems);
 
-		$this->assertEquals( 1, count( $listItems ) );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
+		$this->assertEquals(1, count($listItems));
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
 
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 	}
 
 
@@ -194,21 +194,21 @@  discard block
 block discarded – undo
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, [], $this->endpoint );
-		$object->process( self::$product, [] );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, [], $this->endpoint);
+		$object->process(self::$product, []);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 0, count( $listItems ) );
+		$this->assertEquals(0, count($listItems));
 	}
 
 
@@ -228,18 +228,18 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 1, count( $listItems ) );
+		$this->assertEquals(1, count($listItems));
 	}
 
 
@@ -259,60 +259,60 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
+		$this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
 
-		$this->setExpectedException( '\Aimeos\Controller\Common\Exception' );
-		$object->process( self::$product, $data );
+		$this->setExpectedException('\Aimeos\Controller\Common\Exception');
+		$object->process(self::$product, $data);
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function create( $code )
+	protected function create($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$item = $manager->createItem();
-		$item->setCode( $code );
+		$item->setCode($code);
 
-		$manager->insertItem( $item );
+		$manager->insertItem($item);
 
 		return $item;
 	}
 
 
-	protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
+	protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
-		$listManager = $manager->getSubManager( 'lists' );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
+		$listManager = $manager->getSubManager('lists');
 
-		foreach( $catItem->getListItems('product') as $listItem ) {
-			$listManager->deleteItem( $listItem->getId() );
+		foreach ($catItem->getListItems('product') as $listItem) {
+			$listManager->deleteItem($listItem->getId());
 		}
 
-		$manager->deleteItem( $catItem->getId() );
+		$manager->deleteItem($catItem->getId());
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function get( $code )
+	protected function get($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
+		$search->setConditions($search->compare('==', 'catalog.code', $code));
 
-		$result = $manager->searchItems( $search, array('product') );
+		$result = $manager->searchItems($search, array('product'));
 
-		if( ( $item = reset( $result ) ) === false ) {
-			throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
+		if (($item = reset($result)) === false) {
+			throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
 		}
 
 		return $item;

Please login to merge, or discard this patch.

		@@ -321,6 +321,7 @@
		block discarded – undo
321	321
322	322	/**
323	323	* @param string $code
	324	+ * @return \Aimeos\MShop\Catalog\Item\Iface
324	325	*/
325	326	protected function get( $code )
326	327	{

		@@ -15,8 +15,8 @@ discard block
		block discarded – undo
15	15	$context = \TestHelperJobs::getContext();
16	16	$aimeos = \TestHelperJobs::getAimeos();
17	17
18		- $obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos );
19		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	18	+ $obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos);
	19	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
20	20	}
21	21
22	22
		@@ -25,8 +25,8 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
29		- \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	28	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	29	+ \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Wrong$$$Name');
30	30	}
31	31
32	32
		@@ -35,8 +35,8 @@ discard block
		block discarded – undo
35	35	$context = \TestHelperJobs::getContext();
36	36	$aimeos = \TestHelperJobs::getAimeos();
37	37
38		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
39		- \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'WrongClass' );
	38	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	39	+ \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'WrongClass');
40	40	}
41	41
42	42
		@@ -45,8 +45,8 @@ discard block
		block discarded – undo
45	45	$context = \TestHelperJobs::getContext();
46	46	$aimeos = \TestHelperJobs::getAimeos();
47	47
48		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
49		- \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Factory' );
	48	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	49	+ \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Factory');
50	50	}
51	51
52	52	}

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	$context = \TestHelperJobs::getContext();
25	25	$aimeos = \TestHelperJobs::getAimeos();
26	26
27		- $this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard( $context, $aimeos );
	27	+ $this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard($context, $aimeos);
28	28	}
29	29
30	30
		@@ -42,14 +42,14 @@ discard block
		block discarded – undo
42	42
43	43	public function testGetName()
44	44	{
45		- $this->assertEquals( 'Cache cleanup', $this->object->getName() );
	45	+ $this->assertEquals('Cache cleanup', $this->object->getName());
46	46	}
47	47
48	48
49	49	public function testGetDescription()
50	50	{
51	51	$text = 'Removes the expired entries from the cache';
52		- $this->assertEquals( $text, $this->object->getDescription() );
	52	+ $this->assertEquals($text, $this->object->getDescription());
53	53	}
54	54
55	55

		@@ -18,36 +18,36 @@ discard block
		block discarded – undo
18	18
19	19	public static function setUpBeforeClass()
20	20	{
21		- $manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
	21	+ $manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
22	22
23	23	$item = $manager->createItem();
24		- $item->setCode( 'job_csv_prod' );
25		- $item->setType( 'default' );
26		- $item->setStatus( 1 );
	24	+ $item->setCode('job_csv_prod');
	25	+ $item->setType('default');
	26	+ $item->setStatus(1);
27	27
28		- self::$product = $manager->saveItem( $item );
	28	+ self::$product = $manager->saveItem($item);
29	29	}
30	30
31	31
32	32	public static function tearDownAfterClass()
33	33	{
34		- $manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
35		- $manager->deleteItem( self::$product->getId() );
	34	+ $manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
	35	+ $manager->deleteItem(self::$product->getId());
36	36	}
37	37
38	38
39	39	protected function setUp()
40	40	{
41		- \Aimeos\MShop\Factory::setCache( true );
	41	+ \Aimeos\MShop\Factory::setCache(true);
42	42
43	43	$this->context = \TestHelperCntl::getContext();
44		- $this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
	44	+ $this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
45	45	}
46	46
47	47
48	48	protected function tearDown()
49	49	{
50		- \Aimeos\MShop\Factory::setCache( false );
	50	+ \Aimeos\MShop\Factory::setCache(false);
51	51	\Aimeos\MShop\Factory::clear();
52	52	}
53	53
		@@ -68,30 +68,30 @@ discard block
		block discarded – undo
68	68	3 => 'job_csv_test',
69	69	);
70	70
71		- $this->create( 'job_csv_test' );
	71	+ $this->create('job_csv_test');
72	72
73		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
74		- $object->process( self::$product, $data );
	73	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	74	+ $object->process(self::$product, $data);
75	75
76		- $category = $this->get( 'job_csv_test' );
77		- $this->delete( $category );
	76	+ $category = $this->get('job_csv_test');
	77	+ $this->delete($category);
78	78
79	79
80	80	$pos = 0;
81	81	$listItems = $category->getListItems();
82	82	$expected = array(
83		- array( 'default', 'job_csv_prod' ),
84		- array( 'promotion', 'job_csv_prod' ),
	83	+ array('default', 'job_csv_prod'),
	84	+ array('promotion', 'job_csv_prod'),
85	85	);
86	86
87		- $this->assertEquals( 2, count( $listItems ) );
	87	+ $this->assertEquals(2, count($listItems));
88	88
89		- foreach( $listItems as $listItem )
	89	+ foreach ($listItems as $listItem)
90	90	{
91		- $this->assertEquals( 1, $listItem->getStatus() );
92		- $this->assertEquals( 'product', $listItem->getDomain() );
93		- $this->assertEquals( $expected[$pos][0], $listItem->getType() );
94		- $this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
	91	+ $this->assertEquals(1, $listItem->getStatus());
	92	+ $this->assertEquals('product', $listItem->getDomain());
	93	+ $this->assertEquals($expected[$pos][0], $listItem->getType());
	94	+ $this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
95	95	$pos++;
96	96	}
97	97	}
		@@ -113,32 +113,32 @@ discard block
		block discarded – undo
113	113	3 => "job_csv_test\njob_csv_test2",
114	114	);
115	115
116		- $this->create( 'job_csv_test' );
117		- $this->create( 'job_csv_test2' );
	116	+ $this->create('job_csv_test');
	117	+ $this->create('job_csv_test2');
118	118
119		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
120		- $object->process( self::$product, $data );
	119	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	120	+ $object->process(self::$product, $data);
121	121
122		- $category = $this->get( 'job_csv_test' );
123		- $category2 = $this->get( 'job_csv_test2' );
	122	+ $category = $this->get('job_csv_test');
	123	+ $category2 = $this->get('job_csv_test2');
124	124
125		- $this->delete( $category );
126		- $this->delete( $category2 );
	125	+ $this->delete($category);
	126	+ $this->delete($category2);
127	127
128	128
129	129	$pos = 0;
130		- $types = array( 'default', 'promotion', 'default', 'promotion' );
	130	+ $types = array('default', 'promotion', 'default', 'promotion');
131	131
132		- foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
	132	+ foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
133	133	{
134		- $this->assertEquals( 2, count( $listItems ) );
	134	+ $this->assertEquals(2, count($listItems));
135	135
136		- foreach( $listItems as $listItem )
	136	+ foreach ($listItems as $listItem)
137	137	{
138		- $this->assertEquals( 1, $listItem->getStatus() );
139		- $this->assertEquals( 'product', $listItem->getDomain() );
140		- $this->assertEquals( $types[$pos], $listItem->getType() );
141		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	138	+ $this->assertEquals(1, $listItem->getStatus());
	139	+ $this->assertEquals('product', $listItem->getDomain());
	140	+ $this->assertEquals($types[$pos], $listItem->getType());
	141	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
142	142	$pos++;
143	143	}
144	144	}
		@@ -162,23 +162,23 @@ discard block
		block discarded – undo
162	162	1 => 'job_csv_test',
163	163	);
164	164
165		- $this->create( 'job_csv_test' );
	165	+ $this->create('job_csv_test');
166	166
167		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
168		- $object->process( self::$product, $data );
169		- $object->process( self::$product, $dataUpdate );
	167	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	168	+ $object->process(self::$product, $data);
	169	+ $object->process(self::$product, $dataUpdate);
170	170
171		- $category = $this->get( 'job_csv_test' );
172		- $this->delete( $category );
	171	+ $category = $this->get('job_csv_test');
	172	+ $this->delete($category);
173	173
174	174
175	175	$listItems = $category->getListItems();
176		- $listItem = reset( $listItems );
	176	+ $listItem = reset($listItems);
177	177
178		- $this->assertEquals( 1, count( $listItems ) );
179		- $this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
	178	+ $this->assertEquals(1, count($listItems));
	179	+ $this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
180	180
181		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	181	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
182	182	}
183	183
184	184
		@@ -194,21 +194,21 @@ discard block
		block discarded – undo
194	194	1 => 'job_csv_test',
195	195	);
196	196
197		- $this->create( 'job_csv_test' );
	197	+ $this->create('job_csv_test');
198	198
199		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
200		- $object->process( self::$product, $data );
	199	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	200	+ $object->process(self::$product, $data);
201	201
202		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, [], $this->endpoint );
203		- $object->process( self::$product, [] );
	202	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, [], $this->endpoint);
	203	+ $object->process(self::$product, []);
204	204
205		- $category = $this->get( 'job_csv_test' );
206		- $this->delete( $category );
	205	+ $category = $this->get('job_csv_test');
	206	+ $this->delete($category);
207	207
208	208
209	209	$listItems = $category->getListItems();
210	210
211		- $this->assertEquals( 0, count( $listItems ) );
	211	+ $this->assertEquals(0, count($listItems));
212	212	}
213	213
214	214
		@@ -228,18 +228,18 @@ discard block
		block discarded – undo
228	228	3 => 'job_csv_test',
229	229	);
230	230
231		- $this->create( 'job_csv_test' );
	231	+ $this->create('job_csv_test');
232	232
233		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
234		- $object->process( self::$product, $data );
	233	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	234	+ $object->process(self::$product, $data);
235	235
236		- $category = $this->get( 'job_csv_test' );
237		- $this->delete( $category );
	236	+ $category = $this->get('job_csv_test');
	237	+ $this->delete($category);
238	238
239	239
240	240	$listItems = $category->getListItems();
241	241
242		- $this->assertEquals( 1, count( $listItems ) );
	242	+ $this->assertEquals(1, count($listItems));
243	243	}
244	244
245	245
		@@ -259,60 +259,60 @@ discard block
		block discarded – undo
259	259	3 => 'job_csv_test',
260	260	);
261	261
262		- $this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
	262	+ $this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
263	263
264		- $this->create( 'job_csv_test' );
	264	+ $this->create('job_csv_test');
265	265
266		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
	266	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
267	267
268		- $this->setExpectedException( '\Aimeos\Controller\Common\Exception' );
269		- $object->process( self::$product, $data );
	268	+ $this->setExpectedException('\Aimeos\Controller\Common\Exception');
	269	+ $object->process(self::$product, $data);
270	270	}
271	271
272	272
273	273	/**
274	274	* @param string $code
275	275	*/
276		- protected function create( $code )
	276	+ protected function create($code)
277	277	{
278		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
	278	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
279	279
280	280	$item = $manager->createItem();
281		- $item->setCode( $code );
	281	+ $item->setCode($code);
282	282
283		- $manager->insertItem( $item );
	283	+ $manager->insertItem($item);
284	284
285	285	return $item;
286	286	}
287	287
288	288
289		- protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
	289	+ protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
290	290	{
291		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
292		- $listManager = $manager->getSubManager( 'lists' );
	291	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
	292	+ $listManager = $manager->getSubManager('lists');
293	293
294		- foreach( $catItem->getListItems('product') as $listItem ) {
295		- $listManager->deleteItem( $listItem->getId() );
	294	+ foreach ($catItem->getListItems('product') as $listItem) {
	295	+ $listManager->deleteItem($listItem->getId());
296	296	}
297	297
298		- $manager->deleteItem( $catItem->getId() );
	298	+ $manager->deleteItem($catItem->getId());
299	299	}
300	300
301	301
302	302	/**
303	303	* @param string $code
304	304	*/
305		- protected function get( $code )
	305	+ protected function get($code)
306	306	{
307		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
	307	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
308	308
309	309	$search = $manager->createSearch();
310		- $search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
	310	+ $search->setConditions($search->compare('==', 'catalog.code', $code));
311	311
312		- $result = $manager->searchItems( $search, array('product') );
	312	+ $result = $manager->searchItems($search, array('product'));
313	313
314		- if( ( $item = reset( $result ) ) === false ) {
315		- throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
	314	+ if (($item = reset($result)) === false) {
	315	+ throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
316	316	}
317	317
318	318	return $item;

aimeos / ai-controller-jobs

Push — master ( 475749...c0b163 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Spacing +84 added lines, -84 removed lines patch added patch discarded remove patch