Inspection of "Renamed createController() to create() and createC..." - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0b1729...545b8f )

by Aimeos

created 2018-12-29 12:58 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -27,8 +27,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Coupon/Import/Csv/Code/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
+		$obj = \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Catalog/Import/Csv/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
+		$obj = \Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Catalog\Import\Csv\Factory::create($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Media/Scale/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -16,8 +16,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Media\Scale\Factory::create( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Media\Scale\Factory::create($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::create($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::create( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::create($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Media\Scale\Factory::create( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Media\Scale\Factory::create($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Index/Optimize/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::create( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::create($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -27,8 +27,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::create($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::create( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::create($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::create( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::create($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Index/Rebuild/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::create( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::create($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -27,8 +27,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::create($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::create( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::create($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::create( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::create($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

		@@ -17,8 +17,8 @@ discard block
		block discarded – undo
17	17	$context = \TestHelperJobs::getContext();
18	18	$aimeos = \TestHelperJobs::getAimeos();
19	19
20		- $obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos );
21		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	20	+ $obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos);
	21	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
22	22	}
23	23
24	24
		@@ -27,8 +27,8 @@ discard block
		block discarded – undo
27	27	$context = \TestHelperJobs::getContext();
28	28	$aimeos = \TestHelperJobs::getAimeos();
29	29
30		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
31		- \Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
	30	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	31	+ \Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos, 'Wrong$$$Name');
32	32	}
33	33
34	34
		@@ -37,8 +37,8 @@ discard block
		block discarded – undo
37	37	$context = \TestHelperJobs::getContext();
38	38	$aimeos = \TestHelperJobs::getAimeos();
39	39
40		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
41		- \Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos, 'WrongClass' );
	40	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	41	+ \Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos, 'WrongClass');
42	42	}
43	43
44	44
		@@ -47,8 +47,8 @@ discard block
		block discarded – undo
47	47	$context = \TestHelperJobs::getContext();
48	48	$aimeos = \TestHelperJobs::getAimeos();
49	49
50		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
51		- \Aimeos\Controller\Jobs\Admin\Log\Factory::create( $context, $aimeos, 'Factory' );
	50	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	51	+ \Aimeos\Controller\Jobs\Admin\Log\Factory::create($context, $aimeos, 'Factory');
52	52	}
53	53
54	54	}

		@@ -16,8 +16,8 @@ discard block
		block discarded – undo
16	16	$context = \TestHelperJobs::getContext();
17	17	$aimeos = \TestHelperJobs::getAimeos();
18	18
19		- $obj = \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos );
20		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
	19	+ $obj = \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos);
	20	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
21	21	}
22	22
23	23
		@@ -26,8 +26,8 @@ discard block
		block discarded – undo
26	26	$context = \TestHelperJobs::getContext();
27	27	$aimeos = \TestHelperJobs::getAimeos();
28	28
29		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
30		- \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos, 'Wrong$$$Name' );
	29	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	30	+ \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos, 'Wrong$$$Name');
31	31	}
32	32
33	33
		@@ -36,8 +36,8 @@ discard block
		block discarded – undo
36	36	$context = \TestHelperJobs::getContext();
37	37	$aimeos = \TestHelperJobs::getAimeos();
38	38
39		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
40		- \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos, 'WrongClass' );
	39	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	40	+ \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos, 'WrongClass');
41	41	}
42	42
43	43
		@@ -46,7 +46,7 @@ discard block
		block discarded – undo
46	46	$context = \TestHelperJobs::getContext();
47	47	$aimeos = \TestHelperJobs::getAimeos();
48	48
49		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
50		- \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos, 'Factory' );
	49	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	50	+ \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create($context, $aimeos, 'Factory');
51	51	}
52	52	}
53	53	\ No newline at end of file

aimeos / ai-controller-jobs

Push — master ( 0b1729...545b8f )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch