Inspection of "Adapt to core change" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b85694...d1869e )

by Aimeos

created 2018-11-27 17:31 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Order/Service/Delivery/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Order\Service\Delivery\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Cache/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Cache\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Cache/StandardTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard( $context, $aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard($context, $aimeos);
 	}
 
 
@@ -42,14 +42,14 @@  discard block
 block discarded – undo
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Cache cleanup', $this->object->getName() );
+		$this->assertEquals('Cache cleanup', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
 		$text = 'Removes the expired entries from the cache';
-		$this->assertEquals( $text, $this->object->getDescription() );
+		$this->assertEquals($text, $this->object->getDescription());
 	}
 
 

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Admin/Log/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Admin\Log\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Index/Optimize/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Optimize\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Index/Rebuild/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Index\Rebuild\Factory::createController($context, $aimeos, 'Factory');
 	}
 
 }

Please login to merge, or discard this patch.

controller/jobs/tests/Controller/Jobs/Product/Bought/FactoryTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$obj = \Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
+		$obj = \Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos);
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
 	}
 
 
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'Wrong$$$Name');
 	}
 
 
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'WrongClass' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'WrongClass');
 	}
 
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 		$context = \TestHelperJobs::getContext();
 		$aimeos = \TestHelperJobs::getAimeos();
 
-		$this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
-		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController( $context, $aimeos, 'Factory' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
+		\Aimeos\Controller\Jobs\Product\Bought\Factory::createController($context, $aimeos, 'Factory');
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

Controller/Common/Product/Import/Csv/Processor/Catalog/StandardTest.php 2 patches

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -321,6 +321,7 @@
 block discarded – undo
 
 	/**
 	 * @param string $code
+	 * @return \Aimeos\MShop\Catalog\Item\Iface
 	 */
 	protected function get( $code )
 	{

Please login to merge, or discard this patch.

Spacing +95 added lines, -95 removed lines patch added patch discarded remove patch

@@ -16,45 +16,45 @@  discard block
 block discarded – undo
 
 	public static function setUpBeforeClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
-		$typeManager = $manager->getSubmanager( 'type' );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
+		$typeManager = $manager->getSubmanager('type');
 
 		$typeSearch = $typeManager->createSearch();
-		$typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
-		$result = $typeManager->searchItems( $typeSearch );
+		$typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
+		$result = $typeManager->searchItems($typeSearch);
 
-		if( ( $typeItem = reset( $result ) ) === false ) {
-			throw new \RuntimeException( 'Product type "default" not found' );
+		if (($typeItem = reset($result)) === false) {
+			throw new \RuntimeException('Product type "default" not found');
 		}
 
 		$item = $manager->createItem();
-		$item->setCode( 'job_csv_prod' );
-		$item->setTypeId( $typeItem->getId() );
-		$item->setStatus( 1 );
+		$item->setCode('job_csv_prod');
+		$item->setTypeId($typeItem->getId());
+		$item->setStatus(1);
 
-		self::$product = $manager->saveItem( $item );
+		self::$product = $manager->saveItem($item);
 	}
 
 
 	public static function tearDownAfterClass()
 	{
-		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
-		$manager->deleteItem( self::$product->getId() );
+		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
+		$manager->deleteItem(self::$product->getId());
 	}
 
 
 	protected function setUp()
 	{
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 
 		$this->context = \TestHelperCntl::getContext();
-		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
+		$this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 	}
 
@@ -75,30 +75,30 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$pos = 0;
 		$listItems = $category->getListItems();
 		$expected = array(
-			array( 'default', 'job_csv_prod' ),
-			array( 'promotion', 'job_csv_prod' ),
+			array('default', 'job_csv_prod'),
+			array('promotion', 'job_csv_prod'),
 		);
 
-		$this->assertEquals( 2, count( $listItems ) );
+		$this->assertEquals(2, count($listItems));
 
-		foreach( $listItems as $listItem )
+		foreach ($listItems as $listItem)
 		{
-			$this->assertEquals( 1, $listItem->getStatus() );
-			$this->assertEquals( 'product', $listItem->getDomain() );
-			$this->assertEquals( $expected[$pos][0], $listItem->getType() );
-			$this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
+			$this->assertEquals(1, $listItem->getStatus());
+			$this->assertEquals('product', $listItem->getDomain());
+			$this->assertEquals($expected[$pos][0], $listItem->getType());
+			$this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
 			$pos++;
 		}
 	}
@@ -120,32 +120,32 @@  discard block
 block discarded – undo
 			3 => "job_csv_test\njob_csv_test2",
 		);
 
-		$this->create( 'job_csv_test' );
-		$this->create( 'job_csv_test2' );
+		$this->create('job_csv_test');
+		$this->create('job_csv_test2');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$category2 = $this->get( 'job_csv_test2' );
+		$category = $this->get('job_csv_test');
+		$category2 = $this->get('job_csv_test2');
 
-		$this->delete( $category );
-		$this->delete( $category2 );
+		$this->delete($category);
+		$this->delete($category2);
 
 
 		$pos = 0;
-		$types = array( 'default', 'promotion', 'default', 'promotion' );
+		$types = array('default', 'promotion', 'default', 'promotion');
 
-		foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
+		foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
 		{
-			$this->assertEquals( 2, count( $listItems ) );
+			$this->assertEquals(2, count($listItems));
 
-			foreach( $listItems as $listItem )
+			foreach ($listItems as $listItem)
 			{
-				$this->assertEquals( 1, $listItem->getStatus() );
-				$this->assertEquals( 'product', $listItem->getDomain() );
-				$this->assertEquals( $types[$pos], $listItem->getType() );
-				$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+				$this->assertEquals(1, $listItem->getStatus());
+				$this->assertEquals('product', $listItem->getDomain());
+				$this->assertEquals($types[$pos], $listItem->getType());
+				$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 				$pos++;
 			}
 		}
@@ -169,23 +169,23 @@  discard block
 block discarded – undo
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
-		$object->process( self::$product, $dataUpdate );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
+		$object->process(self::$product, $dataUpdate);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
-		$listItem = reset( $listItems );
+		$listItem = reset($listItems);
 
-		$this->assertEquals( 1, count( $listItems ) );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
+		$this->assertEquals(1, count($listItems));
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
 
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 	}
 
 
@@ -201,21 +201,21 @@  discard block
 block discarded – undo
 			1 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, [], $this->endpoint );
-		$object->process( self::$product, [] );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, [], $this->endpoint);
+		$object->process(self::$product, []);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 0, count( $listItems ) );
+		$this->assertEquals(0, count($listItems));
 	}
 
 
@@ -235,18 +235,18 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
 
-		$this->assertEquals( 1, count( $listItems ) );
+		$this->assertEquals(1, count($listItems));
 	}
 
 
@@ -266,71 +266,71 @@  discard block
 block discarded – undo
 			3 => 'job_csv_test',
 		);
 
-		$this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
+		$this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
 
-		$this->create( 'job_csv_test' );
+		$this->create('job_csv_test');
 
-		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
-		$object->process( self::$product, $data );
+		$object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
+		$object->process(self::$product, $data);
 
-		$category = $this->get( 'job_csv_test' );
-		$this->delete( $category );
+		$category = $this->get('job_csv_test');
+		$this->delete($category);
 
 
 		$listItems = $category->getListItems();
-		$listItem = reset( $listItems );
+		$listItem = reset($listItems);
 
-		$this->assertEquals( 1, count( $listItems ) );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
+		$this->assertEquals(1, count($listItems));
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
 
-		$this->assertEquals( 'default', $listItem->getType() );
-		$this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
+		$this->assertEquals('default', $listItem->getType());
+		$this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function create( $code )
+	protected function create($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$item = $manager->createItem();
-		$item->setCode( $code );
+		$item->setCode($code);
 
-		$manager->insertItem( $item );
+		$manager->insertItem($item);
 
 		return $item;
 	}
 
 
-	protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
+	protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
-		$listManager = $manager->getSubManager( 'lists' );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
+		$listManager = $manager->getSubManager('lists');
 
-		foreach( $catItem->getListItems('product') as $listItem ) {
-			$listManager->deleteItem( $listItem->getId() );
+		foreach ($catItem->getListItems('product') as $listItem) {
+			$listManager->deleteItem($listItem->getId());
 		}
 
-		$manager->deleteItem( $catItem->getId() );
+		$manager->deleteItem($catItem->getId());
 	}
 
 
 	/**
 	 * @param string $code
 	 */
-	protected function get( $code )
+	protected function get($code)
 	{
-		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
+		$manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
+		$search->setConditions($search->compare('==', 'catalog.code', $code));
 
-		$result = $manager->searchItems( $search, array('product') );
+		$result = $manager->searchItems($search, array('product'));
 
-		if( ( $item = reset( $result ) ) === false ) {
-			throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
+		if (($item = reset($result)) === false) {
+			throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
 		}
 
 		return $item;

Please login to merge, or discard this patch.

		@@ -321,6 +321,7 @@
		block discarded – undo
321	321
322	322	/**
323	323	* @param string $code
	324	+ * @return \Aimeos\MShop\Catalog\Item\Iface
324	325	*/
325	326	protected function get( $code )
326	327	{

		@@ -15,8 +15,8 @@ discard block
		block discarded – undo
15	15	$context = \TestHelperJobs::getContext();
16	16	$aimeos = \TestHelperJobs::getAimeos();
17	17
18		- $obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos );
19		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
	18	+ $obj = \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos);
	19	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Jobs\\Iface', $obj);
20	20	}
21	21
22	22
		@@ -25,8 +25,8 @@ discard block
		block discarded – undo
25	25	$context = \TestHelperJobs::getContext();
26	26	$aimeos = \TestHelperJobs::getAimeos();
27	27
28		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
29		- \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Wrong$$$Name' );
	28	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	29	+ \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Wrong$$$Name');
30	30	}
31	31
32	32
		@@ -35,8 +35,8 @@ discard block
		block discarded – undo
35	35	$context = \TestHelperJobs::getContext();
36	36	$aimeos = \TestHelperJobs::getAimeos();
37	37
38		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
39		- \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'WrongClass' );
	38	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	39	+ \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'WrongClass');
40	40	}
41	41
42	42
		@@ -45,8 +45,8 @@ discard block
		block discarded – undo
45	45	$context = \TestHelperJobs::getContext();
46	46	$aimeos = \TestHelperJobs::getAimeos();
47	47
48		- $this->setExpectedException( '\\Aimeos\\Controller\\Jobs\\Exception' );
49		- \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController( $context, $aimeos, 'Factory' );
	48	+ $this->setExpectedException('\\Aimeos\\Controller\\Jobs\\Exception');
	49	+ \Aimeos\Controller\Jobs\Order\Service\Payment\Factory::createController($context, $aimeos, 'Factory');
50	50	}
51	51
52	52	}

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	$context = \TestHelperJobs::getContext();
25	25	$aimeos = \TestHelperJobs::getAimeos();
26	26
27		- $this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard( $context, $aimeos );
	27	+ $this->object = new \Aimeos\Controller\Jobs\Admin\Cache\Standard($context, $aimeos);
28	28	}
29	29
30	30
		@@ -42,14 +42,14 @@ discard block
		block discarded – undo
42	42
43	43	public function testGetName()
44	44	{
45		- $this->assertEquals( 'Cache cleanup', $this->object->getName() );
	45	+ $this->assertEquals('Cache cleanup', $this->object->getName());
46	46	}
47	47
48	48
49	49	public function testGetDescription()
50	50	{
51	51	$text = 'Removes the expired entries from the cache';
52		- $this->assertEquals( $text, $this->object->getDescription() );
	52	+ $this->assertEquals($text, $this->object->getDescription());
53	53	}
54	54
55	55

		@@ -16,45 +16,45 @@ discard block
		block discarded – undo
16	16
17	17	public static function setUpBeforeClass()
18	18	{
19		- $manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
20		- $typeManager = $manager->getSubmanager( 'type' );
	19	+ $manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
	20	+ $typeManager = $manager->getSubmanager('type');
21	21
22	22	$typeSearch = $typeManager->createSearch();
23		- $typeSearch->setConditions( $typeSearch->compare( '==', 'product.type.code', 'default' ) );
24		- $result = $typeManager->searchItems( $typeSearch );
	23	+ $typeSearch->setConditions($typeSearch->compare('==', 'product.type.code', 'default'));
	24	+ $result = $typeManager->searchItems($typeSearch);
25	25
26		- if( ( $typeItem = reset( $result ) ) === false ) {
27		- throw new \RuntimeException( 'Product type "default" not found' );
	26	+ if (($typeItem = reset($result)) === false) {
	27	+ throw new \RuntimeException('Product type "default" not found');
28	28	}
29	29
30	30	$item = $manager->createItem();
31		- $item->setCode( 'job_csv_prod' );
32		- $item->setTypeId( $typeItem->getId() );
33		- $item->setStatus( 1 );
	31	+ $item->setCode('job_csv_prod');
	32	+ $item->setTypeId($typeItem->getId());
	33	+ $item->setStatus(1);
34	34
35		- self::$product = $manager->saveItem( $item );
	35	+ self::$product = $manager->saveItem($item);
36	36	}
37	37
38	38
39	39	public static function tearDownAfterClass()
40	40	{
41		- $manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperCntl::getContext() );
42		- $manager->deleteItem( self::$product->getId() );
	41	+ $manager = \Aimeos\MShop\Product\Manager\Factory::createManager(\TestHelperCntl::getContext());
	42	+ $manager->deleteItem(self::$product->getId());
43	43	}
44	44
45	45
46	46	protected function setUp()
47	47	{
48		- \Aimeos\MShop\Factory::setCache( true );
	48	+ \Aimeos\MShop\Factory::setCache(true);
49	49
50	50	$this->context = \TestHelperCntl::getContext();
51		- $this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done( $this->context, [] );
	51	+ $this->endpoint = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Done($this->context, []);
52	52	}
53	53
54	54
55	55	protected function tearDown()
56	56	{
57		- \Aimeos\MShop\Factory::setCache( false );
	57	+ \Aimeos\MShop\Factory::setCache(false);
58	58	\Aimeos\MShop\Factory::clear();
59	59	}
60	60
		@@ -75,30 +75,30 @@ discard block
		block discarded – undo
75	75	3 => 'job_csv_test',
76	76	);
77	77
78		- $this->create( 'job_csv_test' );
	78	+ $this->create('job_csv_test');
79	79
80		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
81		- $object->process( self::$product, $data );
	80	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	81	+ $object->process(self::$product, $data);
82	82
83		- $category = $this->get( 'job_csv_test' );
84		- $this->delete( $category );
	83	+ $category = $this->get('job_csv_test');
	84	+ $this->delete($category);
85	85
86	86
87	87	$pos = 0;
88	88	$listItems = $category->getListItems();
89	89	$expected = array(
90		- array( 'default', 'job_csv_prod' ),
91		- array( 'promotion', 'job_csv_prod' ),
	90	+ array('default', 'job_csv_prod'),
	91	+ array('promotion', 'job_csv_prod'),
92	92	);
93	93
94		- $this->assertEquals( 2, count( $listItems ) );
	94	+ $this->assertEquals(2, count($listItems));
95	95
96		- foreach( $listItems as $listItem )
	96	+ foreach ($listItems as $listItem)
97	97	{
98		- $this->assertEquals( 1, $listItem->getStatus() );
99		- $this->assertEquals( 'product', $listItem->getDomain() );
100		- $this->assertEquals( $expected[$pos][0], $listItem->getType() );
101		- $this->assertEquals( $expected[$pos][1], $listItem->getRefItem()->getCode() );
	98	+ $this->assertEquals(1, $listItem->getStatus());
	99	+ $this->assertEquals('product', $listItem->getDomain());
	100	+ $this->assertEquals($expected[$pos][0], $listItem->getType());
	101	+ $this->assertEquals($expected[$pos][1], $listItem->getRefItem()->getCode());
102	102	$pos++;
103	103	}
104	104	}
		@@ -120,32 +120,32 @@ discard block
		block discarded – undo
120	120	3 => "job_csv_test\njob_csv_test2",
121	121	);
122	122
123		- $this->create( 'job_csv_test' );
124		- $this->create( 'job_csv_test2' );
	123	+ $this->create('job_csv_test');
	124	+ $this->create('job_csv_test2');
125	125
126		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
127		- $object->process( self::$product, $data );
	126	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	127	+ $object->process(self::$product, $data);
128	128
129		- $category = $this->get( 'job_csv_test' );
130		- $category2 = $this->get( 'job_csv_test2' );
	129	+ $category = $this->get('job_csv_test');
	130	+ $category2 = $this->get('job_csv_test2');
131	131
132		- $this->delete( $category );
133		- $this->delete( $category2 );
	132	+ $this->delete($category);
	133	+ $this->delete($category2);
134	134
135	135
136	136	$pos = 0;
137		- $types = array( 'default', 'promotion', 'default', 'promotion' );
	137	+ $types = array('default', 'promotion', 'default', 'promotion');
138	138
139		- foreach( array( $category->getListItems(), $category2->getListItems() ) as $listItems )
	139	+ foreach (array($category->getListItems(), $category2->getListItems()) as $listItems)
140	140	{
141		- $this->assertEquals( 2, count( $listItems ) );
	141	+ $this->assertEquals(2, count($listItems));
142	142
143		- foreach( $listItems as $listItem )
	143	+ foreach ($listItems as $listItem)
144	144	{
145		- $this->assertEquals( 1, $listItem->getStatus() );
146		- $this->assertEquals( 'product', $listItem->getDomain() );
147		- $this->assertEquals( $types[$pos], $listItem->getType() );
148		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	145	+ $this->assertEquals(1, $listItem->getStatus());
	146	+ $this->assertEquals('product', $listItem->getDomain());
	147	+ $this->assertEquals($types[$pos], $listItem->getType());
	148	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
149	149	$pos++;
150	150	}
151	151	}
		@@ -169,23 +169,23 @@ discard block
		block discarded – undo
169	169	1 => 'job_csv_test',
170	170	);
171	171
172		- $this->create( 'job_csv_test' );
	172	+ $this->create('job_csv_test');
173	173
174		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
175		- $object->process( self::$product, $data );
176		- $object->process( self::$product, $dataUpdate );
	174	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	175	+ $object->process(self::$product, $data);
	176	+ $object->process(self::$product, $dataUpdate);
177	177
178		- $category = $this->get( 'job_csv_test' );
179		- $this->delete( $category );
	178	+ $category = $this->get('job_csv_test');
	179	+ $this->delete($category);
180	180
181	181
182	182	$listItems = $category->getListItems();
183		- $listItem = reset( $listItems );
	183	+ $listItem = reset($listItems);
184	184
185		- $this->assertEquals( 1, count( $listItems ) );
186		- $this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
	185	+ $this->assertEquals(1, count($listItems));
	186	+ $this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
187	187
188		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	188	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
189	189	}
190	190
191	191
		@@ -201,21 +201,21 @@ discard block
		block discarded – undo
201	201	1 => 'job_csv_test',
202	202	);
203	203
204		- $this->create( 'job_csv_test' );
	204	+ $this->create('job_csv_test');
205	205
206		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
207		- $object->process( self::$product, $data );
	206	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	207	+ $object->process(self::$product, $data);
208	208
209		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, [], $this->endpoint );
210		- $object->process( self::$product, [] );
	209	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, [], $this->endpoint);
	210	+ $object->process(self::$product, []);
211	211
212		- $category = $this->get( 'job_csv_test' );
213		- $this->delete( $category );
	212	+ $category = $this->get('job_csv_test');
	213	+ $this->delete($category);
214	214
215	215
216	216	$listItems = $category->getListItems();
217	217
218		- $this->assertEquals( 0, count( $listItems ) );
	218	+ $this->assertEquals(0, count($listItems));
219	219	}
220	220
221	221
		@@ -235,18 +235,18 @@ discard block
		block discarded – undo
235	235	3 => 'job_csv_test',
236	236	);
237	237
238		- $this->create( 'job_csv_test' );
	238	+ $this->create('job_csv_test');
239	239
240		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
241		- $object->process( self::$product, $data );
	240	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	241	+ $object->process(self::$product, $data);
242	242
243		- $category = $this->get( 'job_csv_test' );
244		- $this->delete( $category );
	243	+ $category = $this->get('job_csv_test');
	244	+ $this->delete($category);
245	245
246	246
247	247	$listItems = $category->getListItems();
248	248
249		- $this->assertEquals( 1, count( $listItems ) );
	249	+ $this->assertEquals(1, count($listItems));
250	250	}
251	251
252	252
		@@ -266,71 +266,71 @@ discard block
		block discarded – undo
266	266	3 => 'job_csv_test',
267	267	);
268	268
269		- $this->context->getConfig()->set( 'controller/common/product/import/csv/processor/catalog/listtypes', array( 'default' ) );
	269	+ $this->context->getConfig()->set('controller/common/product/import/csv/processor/catalog/listtypes', array('default'));
270	270
271		- $this->create( 'job_csv_test' );
	271	+ $this->create('job_csv_test');
272	272
273		- $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard( $this->context, $mapping, $this->endpoint );
274		- $object->process( self::$product, $data );
	273	+ $object = new \Aimeos\Controller\Common\Product\Import\Csv\Processor\Catalog\Standard($this->context, $mapping, $this->endpoint);
	274	+ $object->process(self::$product, $data);
275	275
276		- $category = $this->get( 'job_csv_test' );
277		- $this->delete( $category );
	276	+ $category = $this->get('job_csv_test');
	277	+ $this->delete($category);
278	278
279	279
280	280	$listItems = $category->getListItems();
281		- $listItem = reset( $listItems );
	281	+ $listItem = reset($listItems);
282	282
283		- $this->assertEquals( 1, count( $listItems ) );
284		- $this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem );
	283	+ $this->assertEquals(1, count($listItems));
	284	+ $this->assertInstanceOf('\\Aimeos\\MShop\\Common\\Item\\Lists\\Iface', $listItem);
285	285
286		- $this->assertEquals( 'default', $listItem->getType() );
287		- $this->assertEquals( 'job_csv_prod', $listItem->getRefItem()->getCode() );
	286	+ $this->assertEquals('default', $listItem->getType());
	287	+ $this->assertEquals('job_csv_prod', $listItem->getRefItem()->getCode());
288	288	}
289	289
290	290
291	291	/**
292	292	* @param string $code
293	293	*/
294		- protected function create( $code )
	294	+ protected function create($code)
295	295	{
296		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
	296	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
297	297
298	298	$item = $manager->createItem();
299		- $item->setCode( $code );
	299	+ $item->setCode($code);
300	300
301		- $manager->insertItem( $item );
	301	+ $manager->insertItem($item);
302	302
303	303	return $item;
304	304	}
305	305
306	306
307		- protected function delete( \Aimeos\MShop\Catalog\Item\Iface $catItem )
	307	+ protected function delete(\Aimeos\MShop\Catalog\Item\Iface $catItem)
308	308	{
309		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
310		- $listManager = $manager->getSubManager( 'lists' );
	309	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
	310	+ $listManager = $manager->getSubManager('lists');
311	311
312		- foreach( $catItem->getListItems('product') as $listItem ) {
313		- $listManager->deleteItem( $listItem->getId() );
	312	+ foreach ($catItem->getListItems('product') as $listItem) {
	313	+ $listManager->deleteItem($listItem->getId());
314	314	}
315	315
316		- $manager->deleteItem( $catItem->getId() );
	316	+ $manager->deleteItem($catItem->getId());
317	317	}
318	318
319	319
320	320	/**
321	321	* @param string $code
322	322	*/
323		- protected function get( $code )
	323	+ protected function get($code)
324	324	{
325		- $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager( $this->context );
	325	+ $manager = \Aimeos\MShop\Catalog\Manager\Factory::createManager($this->context);
326	326
327	327	$search = $manager->createSearch();
328		- $search->setConditions( $search->compare( '==', 'catalog.code', $code ) );
	328	+ $search->setConditions($search->compare('==', 'catalog.code', $code));
329	329
330		- $result = $manager->searchItems( $search, array('product') );
	330	+ $result = $manager->searchItems($search, array('product'));
331	331
332		- if( ( $item = reset( $result ) ) === false ) {
333		- throw new \RuntimeException( sprintf( 'No catalog item for code "%1$s"', $code ) );
	332	+ if (($item = reset($result)) === false) {
	333	+ throw new \RuntimeException(sprintf('No catalog item for code "%1$s"', $code));
334	334	}
335	335
336	336	return $item;

aimeos / ai-controller-jobs

Push — master ( b85694...d1869e )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Spacing +95 added lines, -95 removed lines patch added patch discarded remove patch